diff options
author | Guenter Roeck <linux@roeck-us.net> | 2015-05-28 12:08:09 -0400 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2015-05-29 20:47:33 -0400 |
commit | 1b63bf617206ff35b93c57c67bbe067ac735a85a (patch) | |
tree | 8efcde73220d2a574d861468c6088f17d5c4d0b4 | |
parent | 9aecac04d8d89e730ae362a748113b19c06a9d39 (diff) |
hwmon: (nct6775) Add missing sysfs attribute initialization
The following error message is seen when loading the nct6775 driver
with DEBUG_LOCK_ALLOC enabled.
BUG: key ffff88040b2f0030 not in .data!
------------[ cut here ]------------
WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
lockdep_init_map+0x469/0x630()
DEBUG_LOCKS_WARN_ON(1)
Caused by a missing call to sysfs_attr_init() when initializing
sysfs attributes.
Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org # v3.12+
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r-- | drivers/hwmon/nct6775.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 4fcb48103299..bd1c99deac71 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c | |||
@@ -995,6 +995,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg, | |||
995 | (*t)->dev_attr.attr.name, tg->base + i); | 995 | (*t)->dev_attr.attr.name, tg->base + i); |
996 | if ((*t)->s2) { | 996 | if ((*t)->s2) { |
997 | a2 = &su->u.a2; | 997 | a2 = &su->u.a2; |
998 | sysfs_attr_init(&a2->dev_attr.attr); | ||
998 | a2->dev_attr.attr.name = su->name; | 999 | a2->dev_attr.attr.name = su->name; |
999 | a2->nr = (*t)->u.s.nr + i; | 1000 | a2->nr = (*t)->u.s.nr + i; |
1000 | a2->index = (*t)->u.s.index; | 1001 | a2->index = (*t)->u.s.index; |
@@ -1005,6 +1006,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg, | |||
1005 | *attrs = &a2->dev_attr.attr; | 1006 | *attrs = &a2->dev_attr.attr; |
1006 | } else { | 1007 | } else { |
1007 | a = &su->u.a1; | 1008 | a = &su->u.a1; |
1009 | sysfs_attr_init(&a->dev_attr.attr); | ||
1008 | a->dev_attr.attr.name = su->name; | 1010 | a->dev_attr.attr.name = su->name; |
1009 | a->index = (*t)->u.index + i; | 1011 | a->index = (*t)->u.index + i; |
1010 | a->dev_attr.attr.mode = | 1012 | a->dev_attr.attr.mode = |