diff options
author | David S. Miller <davem@davemloft.net> | 2014-07-21 00:30:28 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-07-21 00:30:28 -0400 |
commit | 1b31a1bf851b55ce3180b0e40998ee32a2cc61e0 (patch) | |
tree | 3e1f9170e5c2be9e637f3aa9696fff0a15403790 | |
parent | fa4eff44a65c91c9ad09e5695ba171a107e5c327 (diff) | |
parent | b684106a53c42f1cd089c09809d236036e2af5ad (diff) |
Merge branch 'break_after_return'
Fabian Frederick says:
====================
drivers/net: remove unnecessary break after return
Second patchset after "remove unnecessary break after goto" addressing break redundancy on drivers/net branch
(suggested by Joe Perches)
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
37 files changed, 0 insertions, 71 deletions
diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c index 29e272cc7a98..64c016a99af8 100644 --- a/drivers/net/cris/eth_v10.c +++ b/drivers/net/cris/eth_v10.c | |||
@@ -1496,7 +1496,6 @@ e100_set_config(struct net_device *dev, struct ifmap *map) | |||
1496 | case IF_PORT_AUI: | 1496 | case IF_PORT_AUI: |
1497 | spin_unlock(&np->lock); | 1497 | spin_unlock(&np->lock); |
1498 | return -EOPNOTSUPP; | 1498 | return -EOPNOTSUPP; |
1499 | break; | ||
1500 | default: | 1499 | default: |
1501 | printk(KERN_ERR "%s: Invalid media selected", dev->name); | 1500 | printk(KERN_ERR "%s: Invalid media selected", dev->name); |
1502 | spin_unlock(&np->lock); | 1501 | spin_unlock(&np->lock); |
diff --git a/drivers/net/ethernet/8390/mac8390.c b/drivers/net/ethernet/8390/mac8390.c index 90e825e8abfe..65cf60f6718c 100644 --- a/drivers/net/ethernet/8390/mac8390.c +++ b/drivers/net/ethernet/8390/mac8390.c | |||
@@ -178,10 +178,8 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev) | |||
178 | case NUBUS_DRHW_APPLE_SONIC_LC: | 178 | case NUBUS_DRHW_APPLE_SONIC_LC: |
179 | case NUBUS_DRHW_SONNET: | 179 | case NUBUS_DRHW_SONNET: |
180 | return MAC8390_NONE; | 180 | return MAC8390_NONE; |
181 | break; | ||
182 | default: | 181 | default: |
183 | return MAC8390_APPLE; | 182 | return MAC8390_APPLE; |
184 | break; | ||
185 | } | 183 | } |
186 | break; | 184 | break; |
187 | 185 | ||
@@ -189,13 +187,10 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev) | |||
189 | switch (dev->dr_hw) { | 187 | switch (dev->dr_hw) { |
190 | case NUBUS_DRHW_ASANTE_LC: | 188 | case NUBUS_DRHW_ASANTE_LC: |
191 | return MAC8390_NONE; | 189 | return MAC8390_NONE; |
192 | break; | ||
193 | case NUBUS_DRHW_CABLETRON: | 190 | case NUBUS_DRHW_CABLETRON: |
194 | return MAC8390_CABLETRON; | 191 | return MAC8390_CABLETRON; |
195 | break; | ||
196 | default: | 192 | default: |
197 | return MAC8390_APPLE; | 193 | return MAC8390_APPLE; |
198 | break; | ||
199 | } | 194 | } |
200 | break; | 195 | break; |
201 | 196 | ||
@@ -220,10 +215,8 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev) | |||
220 | switch (dev->dr_hw) { | 215 | switch (dev->dr_hw) { |
221 | case NUBUS_DRHW_INTERLAN: | 216 | case NUBUS_DRHW_INTERLAN: |
222 | return MAC8390_INTERLAN; | 217 | return MAC8390_INTERLAN; |
223 | break; | ||
224 | default: | 218 | default: |
225 | return MAC8390_KINETICS; | 219 | return MAC8390_KINETICS; |
226 | break; | ||
227 | } | 220 | } |
228 | break; | 221 | break; |
229 | 222 | ||
@@ -563,7 +556,6 @@ static int __init mac8390_initdev(struct net_device *dev, | |||
563 | case ACCESS_UNKNOWN: | 556 | case ACCESS_UNKNOWN: |
564 | pr_err("Don't know how to access card memory!\n"); | 557 | pr_err("Don't know how to access card memory!\n"); |
565 | return -ENODEV; | 558 | return -ENODEV; |
566 | break; | ||
567 | 559 | ||
568 | case ACCESS_16: | 560 | case ACCESS_16: |
569 | /* 16 bit card, register map is reversed */ | 561 | /* 16 bit card, register map is reversed */ |
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c index 1cda49a28f7f..52fdfe225978 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | |||
@@ -639,7 +639,6 @@ int atl1c_phy_init(struct atl1c_hw *hw) | |||
639 | dev_err(&pdev->dev, "Wrong Media type %d\n", | 639 | dev_err(&pdev->dev, "Wrong Media type %d\n", |
640 | hw->media_type); | 640 | hw->media_type); |
641 | return -1; | 641 | return -1; |
642 | break; | ||
643 | } | 642 | } |
644 | 643 | ||
645 | ret_val = atl1c_write_phy_reg(hw, MII_BMCR, mii_bmcr_data); | 644 | ret_val = atl1c_write_phy_reg(hw, MII_BMCR, mii_bmcr_data); |
@@ -682,7 +681,6 @@ int atl1c_get_speed_and_duplex(struct atl1c_hw *hw, u16 *speed, u16 *duplex) | |||
682 | break; | 681 | break; |
683 | default: | 682 | default: |
684 | return -1; | 683 | return -1; |
685 | break; | ||
686 | } | 684 | } |
687 | 685 | ||
688 | if (phy_data & GIGA_PSSR_DPLX) | 686 | if (phy_data & GIGA_PSSR_DPLX) |
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c b/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c index 923063d2e5bb..113565da155f 100644 --- a/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c +++ b/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c | |||
@@ -618,7 +618,6 @@ int atl1e_get_speed_and_duplex(struct atl1e_hw *hw, u16 *speed, u16 *duplex) | |||
618 | break; | 618 | break; |
619 | default: | 619 | default: |
620 | return AT_ERR_PHY_SPEED; | 620 | return AT_ERR_PHY_SPEED; |
621 | break; | ||
622 | } | 621 | } |
623 | 622 | ||
624 | if (phy_data & MII_AT001_PSSR_DPLX) | 623 | if (phy_data & MII_AT001_PSSR_DPLX) |
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index b460db7919a2..1546d550ac97 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c | |||
@@ -910,7 +910,6 @@ static s32 atl1_get_speed_and_duplex(struct atl1_hw *hw, u16 *speed, u16 *duplex | |||
910 | if (netif_msg_hw(adapter)) | 910 | if (netif_msg_hw(adapter)) |
911 | dev_dbg(&pdev->dev, "error getting speed\n"); | 911 | dev_dbg(&pdev->dev, "error getting speed\n"); |
912 | return ATLX_ERR_PHY_SPEED; | 912 | return ATLX_ERR_PHY_SPEED; |
913 | break; | ||
914 | } | 913 | } |
915 | if (phy_data & MII_ATLX_PSSR_DPLX) | 914 | if (phy_data & MII_ATLX_PSSR_DPLX) |
916 | *duplex = FULL_DUPLEX; | 915 | *duplex = FULL_DUPLEX; |
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index 6746bd717146..c194bc687c30 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c | |||
@@ -2493,7 +2493,6 @@ static s32 atl2_get_speed_and_duplex(struct atl2_hw *hw, u16 *speed, | |||
2493 | break; | 2493 | break; |
2494 | default: | 2494 | default: |
2495 | return ATLX_ERR_PHY_SPEED; | 2495 | return ATLX_ERR_PHY_SPEED; |
2496 | break; | ||
2497 | } | 2496 | } |
2498 | 2497 | ||
2499 | if (phy_data & MII_ATLX_PSSR_DPLX) | 2498 | if (phy_data & MII_ATLX_PSSR_DPLX) |
@@ -2933,11 +2932,9 @@ static int atl2_validate_option(int *value, struct atl2_option *opt) | |||
2933 | case OPTION_ENABLED: | 2932 | case OPTION_ENABLED: |
2934 | printk(KERN_INFO "%s Enabled\n", opt->name); | 2933 | printk(KERN_INFO "%s Enabled\n", opt->name); |
2935 | return 0; | 2934 | return 0; |
2936 | break; | ||
2937 | case OPTION_DISABLED: | 2935 | case OPTION_DISABLED: |
2938 | printk(KERN_INFO "%s Disabled\n", opt->name); | 2936 | printk(KERN_INFO "%s Disabled\n", opt->name); |
2939 | return 0; | 2937 | return 0; |
2940 | break; | ||
2941 | } | 2938 | } |
2942 | break; | 2939 | break; |
2943 | case range_option: | 2940 | case range_option: |
diff --git a/drivers/net/ethernet/brocade/bna/cna_fwimg.c b/drivers/net/ethernet/brocade/bna/cna_fwimg.c index 6a68e8d93309..6f72771caea6 100644 --- a/drivers/net/ethernet/brocade/bna/cna_fwimg.c +++ b/drivers/net/ethernet/brocade/bna/cna_fwimg.c | |||
@@ -68,10 +68,8 @@ bfa_cb_image_get_chunk(enum bfi_asic_gen asic_gen, u32 off) | |||
68 | switch (asic_gen) { | 68 | switch (asic_gen) { |
69 | case BFI_ASIC_GEN_CT: | 69 | case BFI_ASIC_GEN_CT: |
70 | return (bfi_image_ct_cna + off); | 70 | return (bfi_image_ct_cna + off); |
71 | break; | ||
72 | case BFI_ASIC_GEN_CT2: | 71 | case BFI_ASIC_GEN_CT2: |
73 | return (bfi_image_ct2_cna + off); | 72 | return (bfi_image_ct2_cna + off); |
74 | break; | ||
75 | default: | 73 | default: |
76 | return NULL; | 74 | return NULL; |
77 | } | 75 | } |
@@ -83,10 +81,8 @@ bfa_cb_image_get_size(enum bfi_asic_gen asic_gen) | |||
83 | switch (asic_gen) { | 81 | switch (asic_gen) { |
84 | case BFI_ASIC_GEN_CT: | 82 | case BFI_ASIC_GEN_CT: |
85 | return bfi_image_ct_cna_size; | 83 | return bfi_image_ct_cna_size; |
86 | break; | ||
87 | case BFI_ASIC_GEN_CT2: | 84 | case BFI_ASIC_GEN_CT2: |
88 | return bfi_image_ct2_cna_size; | 85 | return bfi_image_ct2_cna_size; |
89 | break; | ||
90 | default: | 86 | default: |
91 | return 0; | 87 | return 0; |
92 | } | 88 | } |
diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index c05b66dfcc30..7091fa6ed096 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c | |||
@@ -3250,7 +3250,6 @@ srom_map_media(struct net_device *dev) | |||
3250 | printk("%s: Bad media code [%d] detected in SROM!\n", dev->name, | 3250 | printk("%s: Bad media code [%d] detected in SROM!\n", dev->name, |
3251 | lp->infoblock_media); | 3251 | lp->infoblock_media); |
3252 | return -1; | 3252 | return -1; |
3253 | break; | ||
3254 | } | 3253 | } |
3255 | 3254 | ||
3256 | return 0; | 3255 | return 0; |
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 36fc429298e3..8ceaf7a2660c 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c | |||
@@ -2396,7 +2396,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth) | |||
2396 | if (netif_msg_ifup(ugeth)) | 2396 | if (netif_msg_ifup(ugeth)) |
2397 | pr_err("Bad number of Rx threads value\n"); | 2397 | pr_err("Bad number of Rx threads value\n"); |
2398 | return -EINVAL; | 2398 | return -EINVAL; |
2399 | break; | ||
2400 | } | 2399 | } |
2401 | 2400 | ||
2402 | switch (ug_info->numThreadsTx) { | 2401 | switch (ug_info->numThreadsTx) { |
@@ -2419,7 +2418,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth) | |||
2419 | if (netif_msg_ifup(ugeth)) | 2418 | if (netif_msg_ifup(ugeth)) |
2420 | pr_err("Bad number of Tx threads value\n"); | 2419 | pr_err("Bad number of Tx threads value\n"); |
2421 | return -EINVAL; | 2420 | return -EINVAL; |
2422 | break; | ||
2423 | } | 2421 | } |
2424 | 2422 | ||
2425 | /* Calculate rx_extended_features */ | 2423 | /* Calculate rx_extended_features */ |
diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c index d50f78afb56d..cca5bca44e73 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c +++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c | |||
@@ -1316,7 +1316,6 @@ static int e1000_set_phy_loopback(struct e1000_adapter *adapter) | |||
1316 | case e1000_82547: | 1316 | case e1000_82547: |
1317 | case e1000_82547_rev_2: | 1317 | case e1000_82547_rev_2: |
1318 | return e1000_integrated_phy_loopback(adapter); | 1318 | return e1000_integrated_phy_loopback(adapter); |
1319 | break; | ||
1320 | default: | 1319 | default: |
1321 | /* Default PHY loopback work is to read the MII | 1320 | /* Default PHY loopback work is to read the MII |
1322 | * control register and assert bit 14 (loopback mode). | 1321 | * control register and assert bit 14 (loopback mode). |
@@ -1325,7 +1324,6 @@ static int e1000_set_phy_loopback(struct e1000_adapter *adapter) | |||
1325 | phy_reg |= MII_CR_LOOPBACK; | 1324 | phy_reg |= MII_CR_LOOPBACK; |
1326 | e1000_write_phy_reg(hw, PHY_CTRL, phy_reg); | 1325 | e1000_write_phy_reg(hw, PHY_CTRL, phy_reg); |
1327 | return 0; | 1326 | return 0; |
1328 | break; | ||
1329 | } | 1327 | } |
1330 | 1328 | ||
1331 | return 8; | 1329 | return 8; |
@@ -1344,7 +1342,6 @@ static int e1000_setup_loopback_test(struct e1000_adapter *adapter) | |||
1344 | case e1000_82545_rev_3: | 1342 | case e1000_82545_rev_3: |
1345 | case e1000_82546_rev_3: | 1343 | case e1000_82546_rev_3: |
1346 | return e1000_set_phy_loopback(adapter); | 1344 | return e1000_set_phy_loopback(adapter); |
1347 | break; | ||
1348 | default: | 1345 | default: |
1349 | rctl = er32(RCTL); | 1346 | rctl = er32(RCTL); |
1350 | rctl |= E1000_RCTL_LBM_TCVR; | 1347 | rctl |= E1000_RCTL_LBM_TCVR; |
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c index e9b07ccc0eba..1acf5034db10 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_hw.c +++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c | |||
@@ -902,7 +902,6 @@ static s32 e1000_setup_fiber_serdes_link(struct e1000_hw *hw) | |||
902 | default: | 902 | default: |
903 | e_dbg("Flow control param set incorrectly\n"); | 903 | e_dbg("Flow control param set incorrectly\n"); |
904 | return -E1000_ERR_CONFIG; | 904 | return -E1000_ERR_CONFIG; |
905 | break; | ||
906 | } | 905 | } |
907 | 906 | ||
908 | /* Since auto-negotiation is enabled, take the link out of reset (the | 907 | /* Since auto-negotiation is enabled, take the link out of reset (the |
@@ -5041,7 +5040,6 @@ static s32 e1000_get_cable_length(struct e1000_hw *hw, u16 *min_length, | |||
5041 | break; | 5040 | break; |
5042 | default: | 5041 | default: |
5043 | return -E1000_ERR_PHY; | 5042 | return -E1000_ERR_PHY; |
5044 | break; | ||
5045 | } | 5043 | } |
5046 | } else if (hw->phy_type == e1000_phy_igp) { /* For IGP PHY */ | 5044 | } else if (hw->phy_type == e1000_phy_igp) { /* For IGP PHY */ |
5047 | u16 cur_agc_value; | 5045 | u16 cur_agc_value; |
diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c index 218481e509f9..dc79ed85030b 100644 --- a/drivers/net/ethernet/intel/e1000e/82571.c +++ b/drivers/net/ethernet/intel/e1000e/82571.c | |||
@@ -95,7 +95,6 @@ static s32 e1000_init_phy_params_82571(struct e1000_hw *hw) | |||
95 | break; | 95 | break; |
96 | default: | 96 | default: |
97 | return -E1000_ERR_PHY; | 97 | return -E1000_ERR_PHY; |
98 | break; | ||
99 | } | 98 | } |
100 | 99 | ||
101 | /* This can only be done after all function pointers are setup. */ | 100 | /* This can only be done after all function pointers are setup. */ |
@@ -422,7 +421,6 @@ static s32 e1000_get_phy_id_82571(struct e1000_hw *hw) | |||
422 | break; | 421 | break; |
423 | case e1000_82573: | 422 | case e1000_82573: |
424 | return e1000e_get_phy_id(hw); | 423 | return e1000e_get_phy_id(hw); |
425 | break; | ||
426 | case e1000_82574: | 424 | case e1000_82574: |
427 | case e1000_82583: | 425 | case e1000_82583: |
428 | ret_val = e1e_rphy(hw, MII_PHYSID1, &phy_id); | 426 | ret_val = e1e_rphy(hw, MII_PHYSID1, &phy_id); |
@@ -440,7 +438,6 @@ static s32 e1000_get_phy_id_82571(struct e1000_hw *hw) | |||
440 | break; | 438 | break; |
441 | default: | 439 | default: |
442 | return -E1000_ERR_PHY; | 440 | return -E1000_ERR_PHY; |
443 | break; | ||
444 | } | 441 | } |
445 | 442 | ||
446 | return 0; | 443 | return 0; |
@@ -1458,7 +1455,6 @@ static s32 e1000_setup_copper_link_82571(struct e1000_hw *hw) | |||
1458 | break; | 1455 | break; |
1459 | default: | 1456 | default: |
1460 | return -E1000_ERR_PHY; | 1457 | return -E1000_ERR_PHY; |
1461 | break; | ||
1462 | } | 1458 | } |
1463 | 1459 | ||
1464 | if (ret_val) | 1460 | if (ret_val) |
diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 815e26c6d34b..865ce45f9ec3 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c | |||
@@ -1521,11 +1521,9 @@ static int e1000_setup_loopback_test(struct e1000_adapter *adapter) | |||
1521 | switch (hw->mac.type) { | 1521 | switch (hw->mac.type) { |
1522 | case e1000_80003es2lan: | 1522 | case e1000_80003es2lan: |
1523 | return e1000_set_es2lan_mac_loopback(adapter); | 1523 | return e1000_set_es2lan_mac_loopback(adapter); |
1524 | break; | ||
1525 | case e1000_82571: | 1524 | case e1000_82571: |
1526 | case e1000_82572: | 1525 | case e1000_82572: |
1527 | return e1000_set_82571_fiber_loopback(adapter); | 1526 | return e1000_set_82571_fiber_loopback(adapter); |
1528 | break; | ||
1529 | default: | 1527 | default: |
1530 | rctl = er32(RCTL); | 1528 | rctl = er32(RCTL); |
1531 | rctl |= E1000_RCTL_LBM_TCVR; | 1529 | rctl |= E1000_RCTL_LBM_TCVR; |
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index 8894ab8ed6bd..f236861c2a31 100644 --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c | |||
@@ -572,7 +572,6 @@ static s32 e1000_init_phy_params_ich8lan(struct e1000_hw *hw) | |||
572 | break; | 572 | break; |
573 | default: | 573 | default: |
574 | return -E1000_ERR_PHY; | 574 | return -E1000_ERR_PHY; |
575 | break; | ||
576 | } | 575 | } |
577 | 576 | ||
578 | return 0; | 577 | return 0; |
diff --git a/drivers/net/ethernet/intel/e1000e/mac.c b/drivers/net/ethernet/intel/e1000e/mac.c index 8c386f3a15eb..30b74d590bee 100644 --- a/drivers/net/ethernet/intel/e1000e/mac.c +++ b/drivers/net/ethernet/intel/e1000e/mac.c | |||
@@ -787,7 +787,6 @@ static s32 e1000_commit_fc_settings_generic(struct e1000_hw *hw) | |||
787 | default: | 787 | default: |
788 | e_dbg("Flow control param set incorrectly\n"); | 788 | e_dbg("Flow control param set incorrectly\n"); |
789 | return -E1000_ERR_CONFIG; | 789 | return -E1000_ERR_CONFIG; |
790 | break; | ||
791 | } | 790 | } |
792 | 791 | ||
793 | ew32(TXCW, txcw); | 792 | ew32(TXCW, txcw); |
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c index 72b454ce05ac..236a6183a865 100644 --- a/drivers/net/ethernet/intel/igb/e1000_82575.c +++ b/drivers/net/ethernet/intel/igb/e1000_82575.c | |||
@@ -579,7 +579,6 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw) | |||
579 | break; | 579 | break; |
580 | default: | 580 | default: |
581 | return -E1000_ERR_MAC_INIT; | 581 | return -E1000_ERR_MAC_INIT; |
582 | break; | ||
583 | } | 582 | } |
584 | 583 | ||
585 | /* Set media type */ | 584 | /* Set media type */ |
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c index ea1c1ab926e2..75bcb2e08491 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | |||
@@ -460,7 +460,6 @@ static int ixgbe_dcbnl_getnumtcs(struct net_device *netdev, int tcid, u8 *num) | |||
460 | break; | 460 | break; |
461 | default: | 461 | default: |
462 | return -EINVAL; | 462 | return -EINVAL; |
463 | break; | ||
464 | } | 463 | } |
465 | } else { | 464 | } else { |
466 | return -EINVAL; | 465 | return -EINVAL; |
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c index a452730a3278..94a1c07efeb0 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | |||
@@ -1408,7 +1408,6 @@ static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data) | |||
1408 | default: | 1408 | default: |
1409 | *data = 1; | 1409 | *data = 1; |
1410 | return 1; | 1410 | return 1; |
1411 | break; | ||
1412 | } | 1411 | } |
1413 | 1412 | ||
1414 | /* | 1413 | /* |
@@ -2866,7 +2865,6 @@ static int ixgbe_get_ts_info(struct net_device *dev, | |||
2866 | break; | 2865 | break; |
2867 | default: | 2866 | default: |
2868 | return ethtool_op_get_ts_info(dev, info); | 2867 | return ethtool_op_get_ts_info(dev, info); |
2869 | break; | ||
2870 | } | 2868 | } |
2871 | return 0; | 2869 | return 0; |
2872 | } | 2870 | } |
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index 6072f093e6b4..7bea17c41dc9 100644 --- a/drivers/net/ethernet/sis/sis900.c +++ b/drivers/net/ethernet/sis/sis900.c | |||
@@ -2258,7 +2258,6 @@ static int sis900_set_config(struct net_device *dev, struct ifmap *map) | |||
2258 | case IF_PORT_100BASEFX: /* 100BaseFx */ | 2258 | case IF_PORT_100BASEFX: /* 100BaseFx */ |
2259 | /* These Modes are not supported (are they?)*/ | 2259 | /* These Modes are not supported (are they?)*/ |
2260 | return -EOPNOTSUPP; | 2260 | return -EOPNOTSUPP; |
2261 | break; | ||
2262 | 2261 | ||
2263 | default: | 2262 | default: |
2264 | return -EINVAL; | 2263 | return -EINVAL; |
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 79606f47a08e..db8ffde491b5 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c | |||
@@ -2584,7 +2584,6 @@ static int niu_determine_phy_disposition(struct niu *np) | |||
2584 | break; | 2584 | break; |
2585 | default: | 2585 | default: |
2586 | return -EINVAL; | 2586 | return -EINVAL; |
2587 | break; | ||
2588 | } | 2587 | } |
2589 | phy_addr_off = niu_atca_port_num[np->port]; | 2588 | phy_addr_off = niu_atca_port_num[np->port]; |
2590 | break; | 2589 | break; |
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index 2553ed5d2ece..0a7f2e77557f 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | |||
@@ -1828,25 +1828,18 @@ static const char *wpasecstr(enum gelic_eurus_wpa_security sec) | |||
1828 | switch (sec) { | 1828 | switch (sec) { |
1829 | case GELIC_EURUS_WPA_SEC_NONE: | 1829 | case GELIC_EURUS_WPA_SEC_NONE: |
1830 | return "NONE"; | 1830 | return "NONE"; |
1831 | break; | ||
1832 | case GELIC_EURUS_WPA_SEC_WPA_TKIP_TKIP: | 1831 | case GELIC_EURUS_WPA_SEC_WPA_TKIP_TKIP: |
1833 | return "WPA_TKIP_TKIP"; | 1832 | return "WPA_TKIP_TKIP"; |
1834 | break; | ||
1835 | case GELIC_EURUS_WPA_SEC_WPA_TKIP_AES: | 1833 | case GELIC_EURUS_WPA_SEC_WPA_TKIP_AES: |
1836 | return "WPA_TKIP_AES"; | 1834 | return "WPA_TKIP_AES"; |
1837 | break; | ||
1838 | case GELIC_EURUS_WPA_SEC_WPA_AES_AES: | 1835 | case GELIC_EURUS_WPA_SEC_WPA_AES_AES: |
1839 | return "WPA_AES_AES"; | 1836 | return "WPA_AES_AES"; |
1840 | break; | ||
1841 | case GELIC_EURUS_WPA_SEC_WPA2_TKIP_TKIP: | 1837 | case GELIC_EURUS_WPA_SEC_WPA2_TKIP_TKIP: |
1842 | return "WPA2_TKIP_TKIP"; | 1838 | return "WPA2_TKIP_TKIP"; |
1843 | break; | ||
1844 | case GELIC_EURUS_WPA_SEC_WPA2_TKIP_AES: | 1839 | case GELIC_EURUS_WPA_SEC_WPA2_TKIP_AES: |
1845 | return "WPA2_TKIP_AES"; | 1840 | return "WPA2_TKIP_AES"; |
1846 | break; | ||
1847 | case GELIC_EURUS_WPA_SEC_WPA2_AES_AES: | 1841 | case GELIC_EURUS_WPA_SEC_WPA2_AES_AES: |
1848 | return "WPA2_AES_AES"; | 1842 | return "WPA2_AES_AES"; |
1849 | break; | ||
1850 | } | 1843 | } |
1851 | return ""; | 1844 | return ""; |
1852 | }; | 1845 | }; |
diff --git a/drivers/net/wan/dlci.c b/drivers/net/wan/dlci.c index a463613a0719..43c9960dce1c 100644 --- a/drivers/net/wan/dlci.c +++ b/drivers/net/wan/dlci.c | |||
@@ -255,7 +255,6 @@ static int dlci_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) | |||
255 | return -EINVAL; | 255 | return -EINVAL; |
256 | 256 | ||
257 | return dlci_config(dev, ifr->ifr_data, cmd == DLCI_GET_CONF); | 257 | return dlci_config(dev, ifr->ifr_data, cmd == DLCI_GET_CONF); |
258 | break; | ||
259 | 258 | ||
260 | default: | 259 | default: |
261 | return -EOPNOTSUPP; | 260 | return -EOPNOTSUPP; |
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index 29d88739454b..b39807579a8a 100644 --- a/drivers/net/wireless/airo.c +++ b/drivers/net/wireless/airo.c | |||
@@ -7818,7 +7818,6 @@ static int readrids(struct net_device *dev, aironet_ioctl *comp) { | |||
7818 | case AIRORRID: ridcode = comp->ridnum; break; | 7818 | case AIRORRID: ridcode = comp->ridnum; break; |
7819 | default: | 7819 | default: |
7820 | return -EINVAL; | 7820 | return -EINVAL; |
7821 | break; | ||
7822 | } | 7821 | } |
7823 | 7822 | ||
7824 | if ((iobuf = kmalloc(RIDSIZE, GFP_KERNEL)) == NULL) | 7823 | if ((iobuf = kmalloc(RIDSIZE, GFP_KERNEL)) == NULL) |
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index d5ef211f261c..8ee7097f0b25 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers/net/wireless/ath/ath6kl/init.c | |||
@@ -1187,7 +1187,6 @@ static int ath6kl_upload_board_file(struct ath6kl *ar) | |||
1187 | default: | 1187 | default: |
1188 | WARN_ON(1); | 1188 | WARN_ON(1); |
1189 | return -EINVAL; | 1189 | return -EINVAL; |
1190 | break; | ||
1191 | } | 1190 | } |
1192 | 1191 | ||
1193 | if (board_ext_address && | 1192 | if (board_ext_address && |
diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index ab4ee7d39ad3..b80b2138ce3c 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c | |||
@@ -1139,7 +1139,6 @@ static int carl9170_set_freq_cal_data(struct ar9170 *ar, | |||
1139 | 1139 | ||
1140 | default: | 1140 | default: |
1141 | return -EINVAL; | 1141 | return -EINVAL; |
1142 | break; | ||
1143 | } | 1142 | } |
1144 | 1143 | ||
1145 | for (; i >= 0; i--) { | 1144 | for (; i >= 0; i--) { |
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c index 588fdbdb3255..057b982ea8b3 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c | |||
@@ -2364,7 +2364,6 @@ int brcmf_p2p_del_vif(struct wiphy *wiphy, struct wireless_dev *wdev) | |||
2364 | return 0; | 2364 | return 0; |
2365 | default: | 2365 | default: |
2366 | return -ENOTSUPP; | 2366 | return -ENOTSUPP; |
2367 | break; | ||
2368 | } | 2367 | } |
2369 | 2368 | ||
2370 | clear_bit(BRCMF_P2P_STATUS_GO_NEG_PHASE, &p2p->status); | 2369 | clear_bit(BRCMF_P2P_STATUS_GO_NEG_PHASE, &p2p->status); |
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c index 3e9f5b25be63..93869e89aa3d 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_n.c | |||
@@ -22916,7 +22916,6 @@ static void wlc_phy_rssi_cal_nphy_rev2(struct brcms_phy *pi, u8 rssi_type) | |||
22916 | break; | 22916 | break; |
22917 | default: | 22917 | default: |
22918 | return; | 22918 | return; |
22919 | break; | ||
22920 | } | 22919 | } |
22921 | 22920 | ||
22922 | classif_state = wlc_phy_classifier_nphy(pi, 0, 0); | 22921 | classif_state = wlc_phy_classifier_nphy(pi, 0, 0); |
diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c index e23d67e0bfe6..6f1b9aace8b3 100644 --- a/drivers/net/wireless/cw1200/fwio.c +++ b/drivers/net/wireless/cw1200/fwio.c | |||
@@ -290,7 +290,6 @@ static int config_reg_write(struct cw1200_common *priv, u32 val) | |||
290 | case HIF_8601_SILICON: | 290 | case HIF_8601_SILICON: |
291 | default: | 291 | default: |
292 | return cw1200_reg_write_32(priv, ST90TDS_CONFIG_REG_ID, val); | 292 | return cw1200_reg_write_32(priv, ST90TDS_CONFIG_REG_ID, val); |
293 | break; | ||
294 | } | 293 | } |
295 | return 0; | 294 | return 0; |
296 | } | 295 | } |
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c index 3c0a0a86ba12..9a3d4d6724f7 100644 --- a/drivers/net/wireless/mwl8k.c +++ b/drivers/net/wireless/mwl8k.c | |||
@@ -1633,22 +1633,17 @@ static int mwl8k_tid_queue_mapping(u8 tid) | |||
1633 | case 0: | 1633 | case 0: |
1634 | case 3: | 1634 | case 3: |
1635 | return IEEE80211_AC_BE; | 1635 | return IEEE80211_AC_BE; |
1636 | break; | ||
1637 | case 1: | 1636 | case 1: |
1638 | case 2: | 1637 | case 2: |
1639 | return IEEE80211_AC_BK; | 1638 | return IEEE80211_AC_BK; |
1640 | break; | ||
1641 | case 4: | 1639 | case 4: |
1642 | case 5: | 1640 | case 5: |
1643 | return IEEE80211_AC_VI; | 1641 | return IEEE80211_AC_VI; |
1644 | break; | ||
1645 | case 6: | 1642 | case 6: |
1646 | case 7: | 1643 | case 7: |
1647 | return IEEE80211_AC_VO; | 1644 | return IEEE80211_AC_VO; |
1648 | break; | ||
1649 | default: | 1645 | default: |
1650 | return -1; | 1646 | return -1; |
1651 | break; | ||
1652 | } | 1647 | } |
1653 | } | 1648 | } |
1654 | 1649 | ||
diff --git a/drivers/net/wireless/prism54/oid_mgt.c b/drivers/net/wireless/prism54/oid_mgt.c index 47b34bfe890a..3a8d2dbcfecd 100644 --- a/drivers/net/wireless/prism54/oid_mgt.c +++ b/drivers/net/wireless/prism54/oid_mgt.c | |||
@@ -793,7 +793,6 @@ mgt_response_to_str(enum oid_num_t n, union oid_res_t *r, char *str) | |||
793 | switch (isl_oid[n].flags & OID_FLAG_TYPE) { | 793 | switch (isl_oid[n].flags & OID_FLAG_TYPE) { |
794 | case OID_TYPE_U32: | 794 | case OID_TYPE_U32: |
795 | return snprintf(str, PRIV_STR_SIZE, "%u\n", r->u); | 795 | return snprintf(str, PRIV_STR_SIZE, "%u\n", r->u); |
796 | break; | ||
797 | case OID_TYPE_BUFFER:{ | 796 | case OID_TYPE_BUFFER:{ |
798 | struct obj_buffer *buff = r->ptr; | 797 | struct obj_buffer *buff = r->ptr; |
799 | return snprintf(str, PRIV_STR_SIZE, | 798 | return snprintf(str, PRIV_STR_SIZE, |
diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c index b1ed6d0796f6..56e218e0469c 100644 --- a/drivers/net/wireless/rtlwifi/core.c +++ b/drivers/net/wireless/rtlwifi/core.c | |||
@@ -1064,7 +1064,6 @@ static int rtl_op_ampdu_action(struct ieee80211_hw *hw, | |||
1064 | RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE, | 1064 | RT_TRACE(rtlpriv, COMP_MAC80211, DBG_TRACE, |
1065 | "IEEE80211_AMPDU_TX_START: TID:%d\n", tid); | 1065 | "IEEE80211_AMPDU_TX_START: TID:%d\n", tid); |
1066 | return rtl_tx_agg_start(hw, sta, tid, ssn); | 1066 | return rtl_tx_agg_start(hw, sta, tid, ssn); |
1067 | break; | ||
1068 | case IEEE80211_AMPDU_TX_STOP_CONT: | 1067 | case IEEE80211_AMPDU_TX_STOP_CONT: |
1069 | case IEEE80211_AMPDU_TX_STOP_FLUSH: | 1068 | case IEEE80211_AMPDU_TX_STOP_FLUSH: |
1070 | case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT: | 1069 | case IEEE80211_AMPDU_TX_STOP_FLUSH_CONT: |
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c b/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c index a9cfa13be3a8..0f9314205526 100644 --- a/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/pwrseqcmd.c | |||
@@ -125,7 +125,6 @@ bool rtl88_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version, | |||
125 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, | 125 | RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, |
126 | "rtl88_hal_pwrseqcmdparsing(): PWR_CMD_END\n"); | 126 | "rtl88_hal_pwrseqcmdparsing(): PWR_CMD_END\n"); |
127 | return true; | 127 | return true; |
128 | break; | ||
129 | default: | 128 | default: |
130 | RT_ASSERT(false, | 129 | RT_ASSERT(false, |
131 | "rtl88_hal_pwrseqcmdparsing(): Unknown CMD!!\n"); | 130 | "rtl88_hal_pwrseqcmdparsing(): Unknown CMD!!\n"); |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c index e2736929b5d0..df98a5e4729a 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | |||
@@ -1200,7 +1200,6 @@ static int _rtl92ce_set_media_status(struct ieee80211_hw *hw, | |||
1200 | RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, | 1200 | RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, |
1201 | "Network type %d not supported!\n", type); | 1201 | "Network type %d not supported!\n", type); |
1202 | return 1; | 1202 | return 1; |
1203 | break; | ||
1204 | 1203 | ||
1205 | } | 1204 | } |
1206 | 1205 | ||
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/fw.c b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c index 73fa4a1de4df..331b1584a1a2 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/fw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/fw.c | |||
@@ -112,13 +112,10 @@ static u8 _rtl92s_firmware_header_map_rftype(struct ieee80211_hw *hw) | |||
112 | switch (rtlphy->rf_type) { | 112 | switch (rtlphy->rf_type) { |
113 | case RF_1T1R: | 113 | case RF_1T1R: |
114 | return 0x11; | 114 | return 0x11; |
115 | break; | ||
116 | case RF_1T2R: | 115 | case RF_1T2R: |
117 | return 0x12; | 116 | return 0x12; |
118 | break; | ||
119 | case RF_2T2R: | 117 | case RF_2T2R: |
120 | return 0x22; | 118 | return 0x22; |
121 | break; | ||
122 | default: | 119 | default: |
123 | RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unknown RF type(%x)\n", | 120 | RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unknown RF type(%x)\n", |
124 | rtlphy->rf_type); | 121 | rtlphy->rf_type); |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/hw.c b/drivers/net/wireless/rtlwifi/rtl8192se/hw.c index 1c7101bcd790..00e067044c08 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/hw.c | |||
@@ -1198,7 +1198,6 @@ static int _rtl92se_set_media_status(struct ieee80211_hw *hw, | |||
1198 | RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, | 1198 | RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, |
1199 | "Network type %d not supported!\n", type); | 1199 | "Network type %d not supported!\n", type); |
1200 | return 1; | 1200 | return 1; |
1201 | break; | ||
1202 | 1201 | ||
1203 | } | 1202 | } |
1204 | 1203 | ||
diff --git a/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c index 539e53987372..662a079f76f3 100644 --- a/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8723ae/hw.c | |||
@@ -1103,7 +1103,6 @@ static int _rtl8723ae_set_media_status(struct ieee80211_hw *hw, | |||
1103 | "Network type %d not supported!\n", | 1103 | "Network type %d not supported!\n", |
1104 | type); | 1104 | type); |
1105 | return 1; | 1105 | return 1; |
1106 | break; | ||
1107 | 1106 | ||
1108 | } | 1107 | } |
1109 | 1108 | ||
diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c b/drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c index e4a507a756fb..4573310c707f 100644 --- a/drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c +++ b/drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c | |||
@@ -124,7 +124,6 @@ bool rtlbe_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, u8 cut_version, | |||
124 | "rtlbe_hal_pwrseqcmdparsing(): " | 124 | "rtlbe_hal_pwrseqcmdparsing(): " |
125 | "PWR_CMD_END\n"); | 125 | "PWR_CMD_END\n"); |
126 | return true; | 126 | return true; |
127 | break; | ||
128 | default: | 127 | default: |
129 | RT_ASSERT(false, | 128 | RT_ASSERT(false, |
130 | "rtlbe_hal_pwrseqcmdparsing(): " | 129 | "rtlbe_hal_pwrseqcmdparsing(): " |