diff options
author | H. Peter Anvin <hpa@linux.intel.com> | 2013-04-27 19:10:11 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2013-06-25 19:25:32 -0400 |
commit | 1adfa76a95fe4444124a502f7cc858a39d5b8e01 (patch) | |
tree | 9c2d630bfde374e46063e549bc1c53833e42ce86 | |
parent | 2fc016c5bd8aad2e201cdf71b9fb4573f94775bd (diff) |
x86, flags: Rename X86_EFLAGS_BIT1 to X86_EFLAGS_FIXED
Bit 1 in the x86 EFLAGS is always set. Name the macro something that
actually tries to explain what it is all about, rather than being a
tautology.
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Gleb Natapov <gleb@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Link: http://lkml.kernel.org/n/tip-f10rx5vjjm6tfnt8o1wseb3v@git.kernel.org
-rw-r--r-- | arch/x86/include/uapi/asm/processor-flags.h | 2 | ||||
-rw-r--r-- | arch/x86/kernel/entry_64.S | 2 | ||||
-rw-r--r-- | arch/x86/kernel/process_32.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/process_64.c | 2 | ||||
-rw-r--r-- | arch/x86/kvm/vmx.c | 2 | ||||
-rw-r--r-- | drivers/lguest/x86/core.c | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/arch/x86/include/uapi/asm/processor-flags.h b/arch/x86/include/uapi/asm/processor-flags.h index 54991a746043..b16e6d28f149 100644 --- a/arch/x86/include/uapi/asm/processor-flags.h +++ b/arch/x86/include/uapi/asm/processor-flags.h | |||
@@ -6,7 +6,7 @@ | |||
6 | * EFLAGS bits | 6 | * EFLAGS bits |
7 | */ | 7 | */ |
8 | #define X86_EFLAGS_CF 0x00000001 /* Carry Flag */ | 8 | #define X86_EFLAGS_CF 0x00000001 /* Carry Flag */ |
9 | #define X86_EFLAGS_BIT1 0x00000002 /* Bit 1 - always on */ | 9 | #define X86_EFLAGS_FIXED 0x00000002 /* Bit 1 - always on */ |
10 | #define X86_EFLAGS_PF 0x00000004 /* Parity Flag */ | 10 | #define X86_EFLAGS_PF 0x00000004 /* Parity Flag */ |
11 | #define X86_EFLAGS_AF 0x00000010 /* Auxiliary carry Flag */ | 11 | #define X86_EFLAGS_AF 0x00000010 /* Auxiliary carry Flag */ |
12 | #define X86_EFLAGS_ZF 0x00000040 /* Zero Flag */ | 12 | #define X86_EFLAGS_ZF 0x00000040 /* Zero Flag */ |
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index 727208941030..5fe1fb2d1490 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86/kernel/entry_64.S | |||
@@ -365,7 +365,7 @@ ENDPROC(native_usergs_sysret64) | |||
365 | /*CFI_REL_OFFSET ss,0*/ | 365 | /*CFI_REL_OFFSET ss,0*/ |
366 | pushq_cfi %rax /* rsp */ | 366 | pushq_cfi %rax /* rsp */ |
367 | CFI_REL_OFFSET rsp,0 | 367 | CFI_REL_OFFSET rsp,0 |
368 | pushq_cfi $(X86_EFLAGS_IF|X86_EFLAGS_BIT1) /* eflags - interrupts on */ | 368 | pushq_cfi $(X86_EFLAGS_IF|X86_EFLAGS_FIXED) /* eflags - interrupts on */ |
369 | /*CFI_REL_OFFSET rflags,0*/ | 369 | /*CFI_REL_OFFSET rflags,0*/ |
370 | pushq_cfi $__KERNEL_CS /* cs */ | 370 | pushq_cfi $__KERNEL_CS /* cs */ |
371 | /*CFI_REL_OFFSET cs,0*/ | 371 | /*CFI_REL_OFFSET cs,0*/ |
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index 7305f7dfc7ab..0339f5c14bf9 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c | |||
@@ -147,7 +147,7 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, | |||
147 | childregs->bp = arg; | 147 | childregs->bp = arg; |
148 | childregs->orig_ax = -1; | 148 | childregs->orig_ax = -1; |
149 | childregs->cs = __KERNEL_CS | get_kernel_rpl(); | 149 | childregs->cs = __KERNEL_CS | get_kernel_rpl(); |
150 | childregs->flags = X86_EFLAGS_IF | X86_EFLAGS_BIT1; | 150 | childregs->flags = X86_EFLAGS_IF | X86_EFLAGS_FIXED; |
151 | p->fpu_counter = 0; | 151 | p->fpu_counter = 0; |
152 | p->thread.io_bitmap_ptr = NULL; | 152 | p->thread.io_bitmap_ptr = NULL; |
153 | memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps)); | 153 | memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps)); |
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 355ae06dbf94..f99a242730e9 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c | |||
@@ -176,7 +176,7 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, | |||
176 | childregs->bp = arg; | 176 | childregs->bp = arg; |
177 | childregs->orig_ax = -1; | 177 | childregs->orig_ax = -1; |
178 | childregs->cs = __KERNEL_CS | get_kernel_rpl(); | 178 | childregs->cs = __KERNEL_CS | get_kernel_rpl(); |
179 | childregs->flags = X86_EFLAGS_IF | X86_EFLAGS_BIT1; | 179 | childregs->flags = X86_EFLAGS_IF | X86_EFLAGS_FIXED; |
180 | return 0; | 180 | return 0; |
181 | } | 181 | } |
182 | *childregs = *current_pt_regs(); | 182 | *childregs = *current_pt_regs(); |
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 260a91939555..b30f5a54a2ab 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c | |||
@@ -7942,7 +7942,7 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu, | |||
7942 | 7942 | ||
7943 | kvm_register_write(vcpu, VCPU_REGS_RSP, vmcs12->host_rsp); | 7943 | kvm_register_write(vcpu, VCPU_REGS_RSP, vmcs12->host_rsp); |
7944 | kvm_register_write(vcpu, VCPU_REGS_RIP, vmcs12->host_rip); | 7944 | kvm_register_write(vcpu, VCPU_REGS_RIP, vmcs12->host_rip); |
7945 | vmx_set_rflags(vcpu, X86_EFLAGS_BIT1); | 7945 | vmx_set_rflags(vcpu, X86_EFLAGS_FIXED); |
7946 | /* | 7946 | /* |
7947 | * Note that calling vmx_set_cr0 is important, even if cr0 hasn't | 7947 | * Note that calling vmx_set_cr0 is important, even if cr0 hasn't |
7948 | * actually changed, because it depends on the current state of | 7948 | * actually changed, because it depends on the current state of |
diff --git a/drivers/lguest/x86/core.c b/drivers/lguest/x86/core.c index f0a3347b6441..516923926335 100644 --- a/drivers/lguest/x86/core.c +++ b/drivers/lguest/x86/core.c | |||
@@ -700,7 +700,7 @@ void lguest_arch_setup_regs(struct lg_cpu *cpu, unsigned long start) | |||
700 | * interrupts are enabled. We always leave interrupts enabled while | 700 | * interrupts are enabled. We always leave interrupts enabled while |
701 | * running the Guest. | 701 | * running the Guest. |
702 | */ | 702 | */ |
703 | regs->eflags = X86_EFLAGS_IF | X86_EFLAGS_BIT1; | 703 | regs->eflags = X86_EFLAGS_IF | X86_EFLAGS_FIXED; |
704 | 704 | ||
705 | /* | 705 | /* |
706 | * The "Extended Instruction Pointer" register says where the Guest is | 706 | * The "Extended Instruction Pointer" register says where the Guest is |