gpu: ipu-v3: Add Image Converter unit

Adds the Image Converter (IC) unit.

Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>

Condensed the three CSC setup functions into a single one that
uses static tables to set up the CSC task parameters.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

5 files changed, 848 insertions, 2 deletions

diff --git a/drivers/gpu/ipu-v3/Makefile b/drivers/gpu/ipu-v3/Makefile
index d22bd06caa6d..107ec236a4a6 100644
--- a/drivers/gpu/ipu-v3/Makefile
+++ b/drivers/gpu/ipu-v3/Makefile
@@ -1,4 +1,4 @@
 obj-$(CONFIG_IMX_IPUV3_CORE) += imx-ipu-v3.o
 
 imx-ipu-v3-objs := ipu-common.o ipu-cpmem.o ipu-csi.o ipu-dc.o ipu-di.o \
-                ipu-dp.o ipu-dmfc.o ipu-smfc.o
+                ipu-dp.o ipu-dmfc.o ipu-ic.o ipu-smfc.o
diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
index 511c364231a2..312eef6ffcad 100644
--- a/drivers/gpu/ipu-v3/ipu-common.c
+++ b/drivers/gpu/ipu-v3/ipu-common.c
@@ -429,6 +429,7 @@ struct ipu_devtype {
         unsigned long tpm_ofs;
         unsigned long csi0_ofs;
         unsigned long csi1_ofs;
+        unsigned long ic_ofs;
         unsigned long disp0_ofs;
         unsigned long disp1_ofs;
         unsigned long dc_tmpl_ofs;
@@ -444,6 +445,7 @@ static struct ipu_devtype ipu_type_imx51 = {
         .tpm_ofs = 0x1f060000,
         .csi0_ofs = 0x1f030000,
         .csi1_ofs = 0x1f038000,
+        .ic_ofs = 0x1f020000,
         .disp0_ofs = 0x1e040000,
         .disp1_ofs = 0x1e048000,
         .dc_tmpl_ofs = 0x1f080000,
@@ -459,6 +461,7 @@ static struct ipu_devtype ipu_type_imx53 = {
         .tpm_ofs = 0x07060000,
         .csi0_ofs = 0x07030000,
         .csi1_ofs = 0x07038000,
+        .ic_ofs = 0x07020000,
         .disp0_ofs = 0x06040000,
         .disp1_ofs = 0x06048000,
         .dc_tmpl_ofs = 0x07080000,
@@ -474,6 +477,7 @@ static struct ipu_devtype ipu_type_imx6q = {
         .tpm_ofs = 0x00360000,
         .csi0_ofs = 0x00230000,
         .csi1_ofs = 0x00238000,
+        .ic_ofs = 0x00220000,
         .disp0_ofs = 0x00240000,
         .disp1_ofs = 0x00248000,
         .dc_tmpl_ofs = 0x00380000,
@@ -518,8 +522,16 @@ static int ipu_submodules_init(struct ipu_soc *ipu,
                 goto err_csi_1;
         }
 
+        ret = ipu_ic_init(ipu, dev,
+                          ipu_base + devtype->ic_ofs,
+                          ipu_base + devtype->tpm_ofs);
+        if (ret) {
+                unit = "ic";
+                goto err_ic;
+        }
+
         ret = ipu_di_init(ipu, dev, 0, ipu_base + devtype->disp0_ofs,
-                        IPU_CONF_DI0_EN, ipu_clk);
+                          IPU_CONF_DI0_EN, ipu_clk);
         if (ret) {
                 unit = "di0";
                 goto err_di_0;
@@ -572,6 +584,8 @@ err_dc:
 err_di_1:
         ipu_di_exit(ipu, 0);
 err_di_0:
+        ipu_ic_exit(ipu);
+err_ic:
         ipu_csi_exit(ipu, 1);
 err_csi_1:
         ipu_csi_exit(ipu, 0);
@@ -654,6 +668,7 @@ static void ipu_submodules_exit(struct ipu_soc *ipu)
         ipu_dc_exit(ipu);
         ipu_di_exit(ipu, 1);
         ipu_di_exit(ipu, 0);
+        ipu_ic_exit(ipu);
         ipu_csi_exit(ipu, 1);
         ipu_csi_exit(ipu, 0);
         ipu_cpmem_exit(ipu);
@@ -879,6 +894,8 @@ static int ipu_probe(struct platform_device *pdev)
                         ipu_base + devtype->csi0_ofs);
         dev_dbg(&pdev->dev, "csi1:    0x%08lx\n",
                         ipu_base + devtype->csi1_ofs);
+        dev_dbg(&pdev->dev, "ic:      0x%08lx\n",
+                        ipu_base + devtype->ic_ofs);
         dev_dbg(&pdev->dev, "disp0:    0x%08lx\n",
                         ipu_base + devtype->disp0_ofs);
         dev_dbg(&pdev->dev, "disp1:    0x%08lx\n",
diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3/ipu-ic.c
new file mode 100644
index 000000000000..ad75588e1629
--- /dev/null
+++ b/drivers/gpu/ipu-v3/ipu-ic.c
@@ -0,0 +1,778 @@
+/*
+ * Copyright (C) 2012-2014 Mentor Graphics Inc.
+ * Copyright 2005-2012 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include <linux/types.h>
+#include <linux/init.h>
+#include <linux/errno.h>
+#include <linux/spinlock.h>
+#include <linux/bitrev.h>
+#include <linux/io.h>
+#include <linux/err.h>
+#include "ipu-prv.h"
+
+/* IC Register Offsets */
+#define IC_CONF                 0x0000
+#define IC_PRP_ENC_RSC          0x0004
+#define IC_PRP_VF_RSC           0x0008
+#define IC_PP_RSC               0x000C
+#define IC_CMBP_1               0x0010
+#define IC_CMBP_2               0x0014
+#define IC_IDMAC_1              0x0018
+#define IC_IDMAC_2              0x001C
+#define IC_IDMAC_3              0x0020
+#define IC_IDMAC_4              0x0024
+
+/* IC Register Fields */
+#define IC_CONF_PRPENC_EN       (1 << 0)
+#define IC_CONF_PRPENC_CSC1     (1 << 1)
+#define IC_CONF_PRPENC_ROT_EN   (1 << 2)
+#define IC_CONF_PRPVF_EN        (1 << 8)
+#define IC_CONF_PRPVF_CSC1      (1 << 9)
+#define IC_CONF_PRPVF_CSC2      (1 << 10)
+#define IC_CONF_PRPVF_CMB       (1 << 11)
+#define IC_CONF_PRPVF_ROT_EN    (1 << 12)
+#define IC_CONF_PP_EN           (1 << 16)
+#define IC_CONF_PP_CSC1         (1 << 17)
+#define IC_CONF_PP_CSC2         (1 << 18)
+#define IC_CONF_PP_CMB          (1 << 19)
+#define IC_CONF_PP_ROT_EN       (1 << 20)
+#define IC_CONF_IC_GLB_LOC_A    (1 << 28)
+#define IC_CONF_KEY_COLOR_EN    (1 << 29)
+#define IC_CONF_RWS_EN          (1 << 30)
+#define IC_CONF_CSI_MEM_WR_EN   (1 << 31)
+
+#define IC_IDMAC_1_CB0_BURST_16         (1 << 0)
+#define IC_IDMAC_1_CB1_BURST_16         (1 << 1)
+#define IC_IDMAC_1_CB2_BURST_16         (1 << 2)
+#define IC_IDMAC_1_CB3_BURST_16         (1 << 3)
+#define IC_IDMAC_1_CB4_BURST_16         (1 << 4)
+#define IC_IDMAC_1_CB5_BURST_16         (1 << 5)
+#define IC_IDMAC_1_CB6_BURST_16         (1 << 6)
+#define IC_IDMAC_1_CB7_BURST_16         (1 << 7)
+#define IC_IDMAC_1_PRPENC_ROT_MASK      (0x7 << 11)
+#define IC_IDMAC_1_PRPENC_ROT_OFFSET    11
+#define IC_IDMAC_1_PRPVF_ROT_MASK       (0x7 << 14)
+#define IC_IDMAC_1_PRPVF_ROT_OFFSET     14
+#define IC_IDMAC_1_PP_ROT_MASK          (0x7 << 17)
+#define IC_IDMAC_1_PP_ROT_OFFSET        17
+#define IC_IDMAC_1_PP_FLIP_RS           (1 << 22)
+#define IC_IDMAC_1_PRPVF_FLIP_RS        (1 << 21)
+#define IC_IDMAC_1_PRPENC_FLIP_RS       (1 << 20)
+
+#define IC_IDMAC_2_PRPENC_HEIGHT_MASK   (0x3ff << 0)
+#define IC_IDMAC_2_PRPENC_HEIGHT_OFFSET 0
+#define IC_IDMAC_2_PRPVF_HEIGHT_MASK    (0x3ff << 10)
+#define IC_IDMAC_2_PRPVF_HEIGHT_OFFSET  10
+#define IC_IDMAC_2_PP_HEIGHT_MASK       (0x3ff << 20)
+#define IC_IDMAC_2_PP_HEIGHT_OFFSET     20
+
+#define IC_IDMAC_3_PRPENC_WIDTH_MASK    (0x3ff << 0)
+#define IC_IDMAC_3_PRPENC_WIDTH_OFFSET  0
+#define IC_IDMAC_3_PRPVF_WIDTH_MASK     (0x3ff << 10)
+#define IC_IDMAC_3_PRPVF_WIDTH_OFFSET   10
+#define IC_IDMAC_3_PP_WIDTH_MASK        (0x3ff << 20)
+#define IC_IDMAC_3_PP_WIDTH_OFFSET      20
+
+struct ic_task_regoffs {
+        u32 rsc;
+        u32 tpmem_csc[2];
+};
+
+struct ic_task_bitfields {
+        u32 ic_conf_en;
+        u32 ic_conf_rot_en;
+        u32 ic_conf_cmb_en;
+        u32 ic_conf_csc1_en;
+        u32 ic_conf_csc2_en;
+        u32 ic_cmb_galpha_bit;
+};
+
+static const struct ic_task_regoffs ic_task_reg[IC_NUM_TASKS] = {
+        [IC_TASK_ENCODER] = {
+                .rsc = IC_PRP_ENC_RSC,
+                .tpmem_csc = {0x2008, 0},
+        },
+        [IC_TASK_VIEWFINDER] = {
+                .rsc = IC_PRP_VF_RSC,
+                .tpmem_csc = {0x4028, 0x4040},
+        },
+        [IC_TASK_POST_PROCESSOR] = {
+                .rsc = IC_PP_RSC,
+                .tpmem_csc = {0x6060, 0x6078},
+        },
+};
+
+static const struct ic_task_bitfields ic_task_bit[IC_NUM_TASKS] = {
+        [IC_TASK_ENCODER] = {
+                .ic_conf_en = IC_CONF_PRPENC_EN,
+                .ic_conf_rot_en = IC_CONF_PRPENC_ROT_EN,
+                .ic_conf_cmb_en = 0,    /* NA */
+                .ic_conf_csc1_en = IC_CONF_PRPENC_CSC1,
+                .ic_conf_csc2_en = 0,   /* NA */
+                .ic_cmb_galpha_bit = 0, /* NA */
+        },
+        [IC_TASK_VIEWFINDER] = {
+                .ic_conf_en = IC_CONF_PRPVF_EN,
+                .ic_conf_rot_en = IC_CONF_PRPVF_ROT_EN,
+                .ic_conf_cmb_en = IC_CONF_PRPVF_CMB,
+                .ic_conf_csc1_en = IC_CONF_PRPVF_CSC1,
+                .ic_conf_csc2_en = IC_CONF_PRPVF_CSC2,
+                .ic_cmb_galpha_bit = 0,
+        },
+        [IC_TASK_POST_PROCESSOR] = {
+                .ic_conf_en = IC_CONF_PP_EN,
+                .ic_conf_rot_en = IC_CONF_PP_ROT_EN,
+                .ic_conf_cmb_en = IC_CONF_PP_CMB,
+                .ic_conf_csc1_en = IC_CONF_PP_CSC1,
+                .ic_conf_csc2_en = IC_CONF_PP_CSC2,
+                .ic_cmb_galpha_bit = 8,
+        },
+};
+
+struct ipu_ic_priv;
+
+struct ipu_ic {
+        enum ipu_ic_task task;
+        const struct ic_task_regoffs *reg;
+        const struct ic_task_bitfields *bit;
+
+        enum ipu_color_space in_cs, g_in_cs;
+        enum ipu_color_space out_cs;
+        bool graphics;
+        bool rotation;
+        bool in_use;
+
+        struct ipu_ic_priv *priv;
+};
+
+struct ipu_ic_priv {
+        void __iomem *base;
+        void __iomem *tpmem_base;
+        spinlock_t lock;
+        struct ipu_soc *ipu;
+        int use_count;
+        struct ipu_ic task[IC_NUM_TASKS];
+};
+
+static inline u32 ipu_ic_read(struct ipu_ic *ic, unsigned offset)
+{
+        return readl(ic->priv->base + offset);
+}
+
+static inline void ipu_ic_write(struct ipu_ic *ic, u32 value, unsigned offset)
+{
+        writel(value, ic->priv->base + offset);
+}
+
+struct ic_csc_params {
+        s16 coeff[3][3];        /* signed 9-bit integer coefficients */
+        s16 offset[3];          /* signed 11+2-bit fixed point offset */
+        u8 scale:2;             /* scale coefficients * 2^(scale-1) */
+        bool sat:1;             /* saturate to (16, 235(Y) / 240(U, V)) */
+};
+
+/*
+ * Y = R *  .299 + G *  .587 + B *  .114;
+ * U = R * -.169 + G * -.332 + B *  .500 + 128.;
+ * V = R *  .500 + G * -.419 + B * -.0813 + 128.;
+ */
+static const struct ic_csc_params ic_csc_rgb2ycbcr = {
+        .coeff = {
+                { 77, 150, 29 },
+                { 469, 427, 128 },
+                { 128, 405, 491 },
+        },
+        .offset = { 0, 512, 512 },
+        .scale = 1,
+};
+
+/* transparent RGB->RGB matrix for graphics combining */
+static const struct ic_csc_params ic_csc_rgb2rgb = {
+        .coeff = {
+                { 128, 0, 0 },
+                { 0, 128, 0 },
+                { 0, 0, 128 },
+        },
+        .scale = 2,
+};
+
+/*
+ * R = (1.164 * (Y - 16)) + (1.596 * (Cr - 128));
+ * G = (1.164 * (Y - 16)) - (0.392 * (Cb - 128)) - (0.813 * (Cr - 128));
+ * B = (1.164 * (Y - 16)) + (2.017 * (Cb - 128);
+ */
+static const struct ic_csc_params ic_csc_ycbcr2rgb = {
+        .coeff = {
+                { 149, 0, 204 },
+                { 149, 462, 408 },
+                { 149, 255, 0 },
+        },
+        .offset = { -446, 266, -554 },
+        .scale = 2,
+};
+
+static int init_csc(struct ipu_ic *ic,
+                    enum ipu_color_space inf,
+                    enum ipu_color_space outf,
+                    int csc_index)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        const struct ic_csc_params *params;
+        u32 __iomem *base;
+        const u16 (*c)[3];
+        const u16 *a;
+        u32 param;
+
+        base = (u32 __iomem *)
+                (priv->tpmem_base + ic->reg->tpmem_csc[csc_index]);
+
+        if (inf == IPUV3_COLORSPACE_YUV && outf == IPUV3_COLORSPACE_RGB)
+                params = &ic_csc_ycbcr2rgb;
+        else if (inf == IPUV3_COLORSPACE_RGB && outf == IPUV3_COLORSPACE_YUV)
+                params = &ic_csc_rgb2ycbcr;
+        else if (inf == IPUV3_COLORSPACE_RGB && outf == IPUV3_COLORSPACE_RGB)
+                params = &ic_csc_rgb2rgb;
+        else {
+                dev_err(priv->ipu->dev, "Unsupported color space conversion\n");
+                return -EINVAL;
+        }
+
+        /* Cast to unsigned */
+        c = (const u16 (*)[3])params->coeff;
+        a = (const u16 *)params->offset;
+
+        param = ((a[0] & 0x1f) << 27) | ((c[0][0] & 0x1ff) << 18) |
+                ((c[1][1] & 0x1ff) << 9) | (c[2][2] & 0x1ff);
+        writel(param, base++);
+
+        param = ((a[0] & 0x1fe0) >> 5) | (params->scale << 8) |
+                (params->sat << 9);
+        writel(param, base++);
+
+        param = ((a[1] & 0x1f) << 27) | ((c[0][1] & 0x1ff) << 18) |
+                ((c[1][0] & 0x1ff) << 9) | (c[2][0] & 0x1ff);
+        writel(param, base++);
+
+        param = ((a[1] & 0x1fe0) >> 5);
+        writel(param, base++);
+
+        param = ((a[2] & 0x1f) << 27) | ((c[0][2] & 0x1ff) << 18) |
+                ((c[1][2] & 0x1ff) << 9) | (c[2][1] & 0x1ff);
+        writel(param, base++);
+
+        param = ((a[2] & 0x1fe0) >> 5);
+        writel(param, base++);
+
+        return 0;
+}
+
+static int calc_resize_coeffs(struct ipu_ic *ic,
+                              u32 in_size, u32 out_size,
+                              u32 *resize_coeff,
+                              u32 *downsize_coeff)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        struct ipu_soc *ipu = priv->ipu;
+        u32 temp_size, temp_downsize;
+
+        /*
+         * Input size cannot be more than 4096, and output size cannot
+         * be more than 1024
+         */
+        if (in_size > 4096) {
+                dev_err(ipu->dev, "Unsupported resize (in_size > 4096)\n");
+                return -EINVAL;
+        }
+        if (out_size > 1024) {
+                dev_err(ipu->dev, "Unsupported resize (out_size > 1024)\n");
+                return -EINVAL;
+        }
+
+        /* Cannot downsize more than 8:1 */
+        if ((out_size << 3) < in_size) {
+                dev_err(ipu->dev, "Unsupported downsize\n");
+                return -EINVAL;
+        }
+
+        /* Compute downsizing coefficient */
+        temp_downsize = 0;
+        temp_size = in_size;
+        while (((temp_size > 1024) || (temp_size >= out_size * 2)) &&
+               (temp_downsize < 2)) {
+                temp_size >>= 1;
+                temp_downsize++;
+        }
+        *downsize_coeff = temp_downsize;
+
+        /*
+         * compute resizing coefficient using the following equation:
+         * resize_coeff = M * (SI - 1) / (SO - 1)
+         * where M = 2^13, SI = input size, SO = output size
+         */
+        *resize_coeff = (8192L * (temp_size - 1)) / (out_size - 1);
+        if (*resize_coeff >= 16384L) {
+                dev_err(ipu->dev, "Warning! Overflow on resize coeff.\n");
+                *resize_coeff = 0x3FFF;
+        }
+
+        return 0;
+}
+
+void ipu_ic_task_enable(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+        u32 ic_conf;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        ic_conf = ipu_ic_read(ic, IC_CONF);
+
+        ic_conf |= ic->bit->ic_conf_en;
+
+        if (ic->rotation)
+                ic_conf |= ic->bit->ic_conf_rot_en;
+
+        if (ic->in_cs != ic->out_cs)
+                ic_conf |= ic->bit->ic_conf_csc1_en;
+
+        if (ic->graphics) {
+                ic_conf |= ic->bit->ic_conf_cmb_en;
+                ic_conf |= ic->bit->ic_conf_csc1_en;
+
+                if (ic->g_in_cs != ic->out_cs)
+                        ic_conf |= ic->bit->ic_conf_csc2_en;
+        }
+
+        ipu_ic_write(ic, ic_conf, IC_CONF);
+
+        spin_unlock_irqrestore(&priv->lock, flags);
+}
+EXPORT_SYMBOL_GPL(ipu_ic_task_enable);
+
+void ipu_ic_task_disable(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+        u32 ic_conf;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        ic_conf = ipu_ic_read(ic, IC_CONF);
+
+        ic_conf &= ~(ic->bit->ic_conf_en |
+                     ic->bit->ic_conf_csc1_en |
+                     ic->bit->ic_conf_rot_en);
+        if (ic->bit->ic_conf_csc2_en)
+                ic_conf &= ~ic->bit->ic_conf_csc2_en;
+        if (ic->bit->ic_conf_cmb_en)
+                ic_conf &= ~ic->bit->ic_conf_cmb_en;
+
+        ipu_ic_write(ic, ic_conf, IC_CONF);
+
+        ic->rotation = ic->graphics = false;
+
+        spin_unlock_irqrestore(&priv->lock, flags);
+}
+EXPORT_SYMBOL_GPL(ipu_ic_task_disable);
+
+int ipu_ic_task_graphics_init(struct ipu_ic *ic,
+                              enum ipu_color_space in_g_cs,
+                              bool galpha_en, u32 galpha,
+                              bool colorkey_en, u32 colorkey)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+        u32 reg, ic_conf;
+        int ret = 0;
+
+        if (ic->task == IC_TASK_ENCODER)
+                return -EINVAL;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        ic_conf = ipu_ic_read(ic, IC_CONF);
+
+        if (!(ic_conf & ic->bit->ic_conf_csc1_en)) {
+                /* need transparent CSC1 conversion */
+                ret = init_csc(ic, IPUV3_COLORSPACE_RGB,
+                               IPUV3_COLORSPACE_RGB, 0);
+                if (ret)
+                        goto unlock;
+        }
+
+        ic->g_in_cs = in_g_cs;
+
+        if (ic->g_in_cs != ic->out_cs) {
+                ret = init_csc(ic, ic->g_in_cs, ic->out_cs, 1);
+                if (ret)
+                        goto unlock;
+        }
+
+        if (galpha_en) {
+                ic_conf |= IC_CONF_IC_GLB_LOC_A;
+                reg = ipu_ic_read(ic, IC_CMBP_1);
+                reg &= ~(0xff << ic->bit->ic_cmb_galpha_bit);
+                reg |= (galpha << ic->bit->ic_cmb_galpha_bit);
+                ipu_ic_write(ic, reg, IC_CMBP_1);
+        } else
+                ic_conf &= ~IC_CONF_IC_GLB_LOC_A;
+
+        if (colorkey_en) {
+                ic_conf |= IC_CONF_KEY_COLOR_EN;
+                ipu_ic_write(ic, colorkey, IC_CMBP_2);
+        } else
+                ic_conf &= ~IC_CONF_KEY_COLOR_EN;
+
+        ipu_ic_write(ic, ic_conf, IC_CONF);
+
+        ic->graphics = true;
+unlock:
+        spin_unlock_irqrestore(&priv->lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_task_graphics_init);
+
+int ipu_ic_task_init(struct ipu_ic *ic,
+                     int in_width, int in_height,
+                     int out_width, int out_height,
+                     enum ipu_color_space in_cs,
+                     enum ipu_color_space out_cs)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        u32 reg, downsize_coeff, resize_coeff;
+        unsigned long flags;
+        int ret = 0;
+
+        /* Setup vertical resizing */
+        ret = calc_resize_coeffs(ic, in_height, out_height,
+                                 &resize_coeff, &downsize_coeff);
+        if (ret)
+                return ret;
+
+        reg = (downsize_coeff << 30) | (resize_coeff << 16);
+
+        /* Setup horizontal resizing */
+        ret = calc_resize_coeffs(ic, in_width, out_width,
+                                 &resize_coeff, &downsize_coeff);
+        if (ret)
+                return ret;
+
+        reg |= (downsize_coeff << 14) | resize_coeff;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        ipu_ic_write(ic, reg, ic->reg->rsc);
+
+        /* Setup color space conversion */
+        ic->in_cs = in_cs;
+        ic->out_cs = out_cs;
+
+        if (ic->in_cs != ic->out_cs) {
+                ret = init_csc(ic, ic->in_cs, ic->out_cs, 0);
+                if (ret)
+                        goto unlock;
+        }
+
+unlock:
+        spin_unlock_irqrestore(&priv->lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_task_init);
+
+int ipu_ic_task_idma_init(struct ipu_ic *ic, struct ipuv3_channel *channel,
+                          u32 width, u32 height, int burst_size,
+                          enum ipu_rotate_mode rot)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        struct ipu_soc *ipu = priv->ipu;
+        u32 ic_idmac_1, ic_idmac_2, ic_idmac_3;
+        u32 temp_rot = bitrev8(rot) >> 5;
+        bool need_hor_flip = false;
+        unsigned long flags;
+        int ret = 0;
+
+        if ((burst_size != 8) && (burst_size != 16)) {
+                dev_err(ipu->dev, "Illegal burst length for IC\n");
+                return -EINVAL;
+        }
+
+        width--;
+        height--;
+
+        if (temp_rot & 0x2)     /* Need horizontal flip */
+                need_hor_flip = true;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        ic_idmac_1 = ipu_ic_read(ic, IC_IDMAC_1);
+        ic_idmac_2 = ipu_ic_read(ic, IC_IDMAC_2);
+        ic_idmac_3 = ipu_ic_read(ic, IC_IDMAC_3);
+
+        switch (channel->num) {
+        case IPUV3_CHANNEL_IC_PP_MEM:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB2_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB2_BURST_16;
+
+                if (need_hor_flip)
+                        ic_idmac_1 |= IC_IDMAC_1_PP_FLIP_RS;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_PP_FLIP_RS;
+
+                ic_idmac_2 &= ~IC_IDMAC_2_PP_HEIGHT_MASK;
+                ic_idmac_2 |= height << IC_IDMAC_2_PP_HEIGHT_OFFSET;
+
+                ic_idmac_3 &= ~IC_IDMAC_3_PP_WIDTH_MASK;
+                ic_idmac_3 |= width << IC_IDMAC_3_PP_WIDTH_OFFSET;
+                break;
+        case IPUV3_CHANNEL_MEM_IC_PP:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB5_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB5_BURST_16;
+                break;
+        case IPUV3_CHANNEL_MEM_ROT_PP:
+                ic_idmac_1 &= ~IC_IDMAC_1_PP_ROT_MASK;
+                ic_idmac_1 |= temp_rot << IC_IDMAC_1_PP_ROT_OFFSET;
+                break;
+        case IPUV3_CHANNEL_MEM_IC_PRP_VF:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB6_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB6_BURST_16;
+                break;
+        case IPUV3_CHANNEL_IC_PRP_ENC_MEM:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB0_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB0_BURST_16;
+
+                if (need_hor_flip)
+                        ic_idmac_1 |= IC_IDMAC_1_PRPENC_FLIP_RS;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_PRPENC_FLIP_RS;
+
+                ic_idmac_2 &= ~IC_IDMAC_2_PRPENC_HEIGHT_MASK;
+                ic_idmac_2 |= height << IC_IDMAC_2_PRPENC_HEIGHT_OFFSET;
+
+                ic_idmac_3 &= ~IC_IDMAC_3_PRPENC_WIDTH_MASK;
+                ic_idmac_3 |= width << IC_IDMAC_3_PRPENC_WIDTH_OFFSET;
+                break;
+        case IPUV3_CHANNEL_MEM_ROT_ENC:
+                ic_idmac_1 &= ~IC_IDMAC_1_PRPENC_ROT_MASK;
+                ic_idmac_1 |= temp_rot << IC_IDMAC_1_PRPENC_ROT_OFFSET;
+                break;
+        case IPUV3_CHANNEL_IC_PRP_VF_MEM:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB1_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB1_BURST_16;
+
+                if (need_hor_flip)
+                        ic_idmac_1 |= IC_IDMAC_1_PRPVF_FLIP_RS;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_PRPVF_FLIP_RS;
+
+                ic_idmac_2 &= ~IC_IDMAC_2_PRPVF_HEIGHT_MASK;
+                ic_idmac_2 |= height << IC_IDMAC_2_PRPVF_HEIGHT_OFFSET;
+
+                ic_idmac_3 &= ~IC_IDMAC_3_PRPVF_WIDTH_MASK;
+                ic_idmac_3 |= width << IC_IDMAC_3_PRPVF_WIDTH_OFFSET;
+                break;
+        case IPUV3_CHANNEL_MEM_ROT_VF:
+                ic_idmac_1 &= ~IC_IDMAC_1_PRPVF_ROT_MASK;
+                ic_idmac_1 |= temp_rot << IC_IDMAC_1_PRPVF_ROT_OFFSET;
+                break;
+        case IPUV3_CHANNEL_G_MEM_IC_PRP_VF:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB3_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB3_BURST_16;
+                break;
+        case IPUV3_CHANNEL_G_MEM_IC_PP:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB4_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB4_BURST_16;
+                break;
+        case IPUV3_CHANNEL_VDI_MEM_IC_VF:
+                if (burst_size == 16)
+                        ic_idmac_1 |= IC_IDMAC_1_CB7_BURST_16;
+                else
+                        ic_idmac_1 &= ~IC_IDMAC_1_CB7_BURST_16;
+                break;
+        default:
+                goto unlock;
+        }
+
+        ipu_ic_write(ic, ic_idmac_1, IC_IDMAC_1);
+        ipu_ic_write(ic, ic_idmac_2, IC_IDMAC_2);
+        ipu_ic_write(ic, ic_idmac_3, IC_IDMAC_3);
+
+        if (rot >= IPU_ROTATE_90_RIGHT)
+                ic->rotation = true;
+
+unlock:
+        spin_unlock_irqrestore(&priv->lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_task_idma_init);
+
+int ipu_ic_enable(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+        u32 module = IPU_CONF_IC_EN;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        if (ic->rotation)
+                module |= IPU_CONF_ROT_EN;
+
+        if (!priv->use_count)
+                ipu_module_enable(priv->ipu, module);
+
+        priv->use_count++;
+
+        spin_unlock_irqrestore(&priv->lock, flags);
+
+        return 0;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_enable);
+
+int ipu_ic_disable(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+        u32 module = IPU_CONF_IC_EN | IPU_CONF_ROT_EN;
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        priv->use_count--;
+
+        if (!priv->use_count)
+                ipu_module_disable(priv->ipu, module);
+
+        if (priv->use_count < 0)
+                priv->use_count = 0;
+
+        spin_unlock_irqrestore(&priv->lock, flags);
+
+        return 0;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_disable);
+
+struct ipu_ic *ipu_ic_get(struct ipu_soc *ipu, enum ipu_ic_task task)
+{
+        struct ipu_ic_priv *priv = ipu->ic_priv;
+        unsigned long flags;
+        struct ipu_ic *ic, *ret;
+
+        if (task >= IC_NUM_TASKS)
+                return ERR_PTR(-EINVAL);
+
+        ic = &priv->task[task];
+
+        spin_lock_irqsave(&priv->lock, flags);
+
+        if (ic->in_use) {
+                ret = ERR_PTR(-EBUSY);
+                goto unlock;
+        }
+
+        ic->in_use = true;
+        ret = ic;
+
+unlock:
+        spin_unlock_irqrestore(&priv->lock, flags);
+        return ret;
+}
+EXPORT_SYMBOL_GPL(ipu_ic_get);
+
+void ipu_ic_put(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        unsigned long flags;
+
+        spin_lock_irqsave(&priv->lock, flags);
+        ic->in_use = false;
+        spin_unlock_irqrestore(&priv->lock, flags);
+}
+EXPORT_SYMBOL_GPL(ipu_ic_put);
+
+int ipu_ic_init(struct ipu_soc *ipu, struct device *dev,
+                unsigned long base, unsigned long tpmem_base)
+{
+        struct ipu_ic_priv *priv;
+        int i;
+
+        priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+        if (!priv)
+                return -ENOMEM;
+
+        ipu->ic_priv = priv;
+
+        spin_lock_init(&priv->lock);
+        priv->base = devm_ioremap(dev, base, PAGE_SIZE);
+        if (!priv->base)
+                return -ENOMEM;
+        priv->tpmem_base = devm_ioremap(dev, tpmem_base, SZ_64K);
+        if (!priv->tpmem_base)
+                return -ENOMEM;
+
+        dev_dbg(dev, "IC base: 0x%08lx remapped to %p\n", base, priv->base);
+
+        priv->ipu = ipu;
+
+        for (i = 0; i < IC_NUM_TASKS; i++) {
+                priv->task[i].task = i;
+                priv->task[i].priv = priv;
+                priv->task[i].reg = &ic_task_reg[i];
+                priv->task[i].bit = &ic_task_bit[i];
+        }
+
+        return 0;
+}
+
+void ipu_ic_exit(struct ipu_soc *ipu)
+{
+}
+
+void ipu_ic_dump(struct ipu_ic *ic)
+{
+        struct ipu_ic_priv *priv = ic->priv;
+        struct ipu_soc *ipu = priv->ipu;
+
+        dev_dbg(ipu->dev, "IC_CONF = \t0x%08X\n",
+                ipu_ic_read(ic, IC_CONF));
+        dev_dbg(ipu->dev, "IC_PRP_ENC_RSC = \t0x%08X\n",
+                ipu_ic_read(ic, IC_PRP_ENC_RSC));
+        dev_dbg(ipu->dev, "IC_PRP_VF_RSC = \t0x%08X\n",
+                ipu_ic_read(ic, IC_PRP_VF_RSC));
+        dev_dbg(ipu->dev, "IC_PP_RSC = \t0x%08X\n",
+                ipu_ic_read(ic, IC_PP_RSC));
+        dev_dbg(ipu->dev, "IC_CMBP_1 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_CMBP_1));
+        dev_dbg(ipu->dev, "IC_CMBP_2 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_CMBP_2));
+        dev_dbg(ipu->dev, "IC_IDMAC_1 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_IDMAC_1));
+        dev_dbg(ipu->dev, "IC_IDMAC_2 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_IDMAC_2));
+        dev_dbg(ipu->dev, "IC_IDMAC_3 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_IDMAC_3));
+        dev_dbg(ipu->dev, "IC_IDMAC_4 = \t0x%08X\n",
+                ipu_ic_read(ic, IC_IDMAC_4));
+}
+EXPORT_SYMBOL_GPL(ipu_ic_dump);
diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h
index 9b274f1259e1..1596a4f52faf 100644
--- a/drivers/gpu/ipu-v3/ipu-prv.h
+++ b/drivers/gpu/ipu-v3/ipu-prv.h
@@ -161,6 +161,7 @@ struct ipu_csi;
 struct ipu_dc_priv;
 struct ipu_dmfc_priv;
 struct ipu_di;
+struct ipu_ic_priv;
 struct ipu_smfc_priv;
 
 struct ipu_devtype;
@@ -191,6 +192,7 @@ struct ipu_soc {
         struct ipu_dmfc_priv    *dmfc_priv;
         struct ipu_di           *di_priv[2];
         struct ipu_csi          *csi_priv[2];
+        struct ipu_ic_priv      *ic_priv;
         struct ipu_smfc_priv    *smfc_priv;
 };
 
@@ -217,6 +219,10 @@ int ipu_csi_init(struct ipu_soc *ipu, struct device *dev, int id,
                  unsigned long base, u32 module, struct clk *clk_ipu);
 void ipu_csi_exit(struct ipu_soc *ipu, int id);
 
+int ipu_ic_init(struct ipu_soc *ipu, struct device *dev,
+                unsigned long base, unsigned long tpmem_base);
+void ipu_ic_exit(struct ipu_soc *ipu);
+
 int ipu_di_init(struct ipu_soc *ipu, struct device *dev, int id,
                 unsigned long base, u32 module, struct clk *ipu_clk);
 void ipu_di_exit(struct ipu_soc *ipu, int id);
diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
index 6d254275192b..a477814a03af 100644
--- a/include/video/imx-ipu-v3.h
+++ b/include/video/imx-ipu-v3.h
@@ -71,6 +71,20 @@ enum ipu_csi_dest {
         IPU_CSI_DEST_VDIC,  /* to VDIC */
 };
 
+/*
+ * Enumeration of IPU rotation modes
+ */
+enum ipu_rotate_mode {
+        IPU_ROTATE_NONE = 0,
+        IPU_ROTATE_VERT_FLIP,
+        IPU_ROTATE_HORIZ_FLIP,
+        IPU_ROTATE_180,
+        IPU_ROTATE_90_RIGHT,
+        IPU_ROTATE_90_RIGHT_VFLIP,
+        IPU_ROTATE_90_RIGHT_HFLIP,
+        IPU_ROTATE_90_LEFT,
+};
+
 enum ipu_color_space {
         IPUV3_COLORSPACE_RGB,
         IPUV3_COLORSPACE_YUV,
@@ -243,6 +257,37 @@ void ipu_csi_put(struct ipu_csi *csi);
 void ipu_csi_dump(struct ipu_csi *csi);
 
 /*
+ * IPU Image Converter (ic) functions
+ */
+enum ipu_ic_task {
+        IC_TASK_ENCODER,
+        IC_TASK_VIEWFINDER,
+        IC_TASK_POST_PROCESSOR,
+        IC_NUM_TASKS,
+};
+
+struct ipu_ic;
+int ipu_ic_task_init(struct ipu_ic *ic,
+                     int in_width, int in_height,
+                     int out_width, int out_height,
+                     enum ipu_color_space in_cs,
+                     enum ipu_color_space out_cs);
+int ipu_ic_task_graphics_init(struct ipu_ic *ic,
+                              enum ipu_color_space in_g_cs,
+                              bool galpha_en, u32 galpha,
+                              bool colorkey_en, u32 colorkey);
+void ipu_ic_task_enable(struct ipu_ic *ic);
+void ipu_ic_task_disable(struct ipu_ic *ic);
+int ipu_ic_task_idma_init(struct ipu_ic *ic, struct ipuv3_channel *channel,
+                          u32 width, u32 height, int burst_size,
+                          enum ipu_rotate_mode rot);
+int ipu_ic_enable(struct ipu_ic *ic);
+int ipu_ic_disable(struct ipu_ic *ic);
+struct ipu_ic *ipu_ic_get(struct ipu_soc *ipu, enum ipu_ic_task task);
+void ipu_ic_put(struct ipu_ic *ic);
+void ipu_ic_dump(struct ipu_ic *ic);
+
+/*
  * IPU Sensor Multiple FIFO Controller (SMFC) functions
  */
 int ipu_smfc_enable(struct ipu_soc *ipu);