diff options
| author | Brian King <brking@us.ibm.com> | 2005-12-12 14:05:08 -0500 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.(none)> | 2005-12-12 15:27:05 -0500 |
| commit | 1a68de5c08be8c77c4ad208306187bd95107c7cd (patch) | |
| tree | 27069553f2a991578355a26bddff2528014dc6fd | |
| parent | a8c730e85e80734412f4f73ab28496a0e8b04a7b (diff) | |
[SCSI] fix double free of scsi request queue
Current scsi scanning code appears to have a use after free
bug is a LLDD's slave_alloc fails. Remove the redundant
scsi_free_queue.
Signed-off-by: Brian King <brking@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 374853df9cca..be276ea8f033 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c | |||
| @@ -279,7 +279,6 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget, | |||
| 279 | 279 | ||
| 280 | out_device_destroy: | 280 | out_device_destroy: |
| 281 | transport_destroy_device(&sdev->sdev_gendev); | 281 | transport_destroy_device(&sdev->sdev_gendev); |
| 282 | scsi_free_queue(sdev->request_queue); | ||
| 283 | put_device(&sdev->sdev_gendev); | 282 | put_device(&sdev->sdev_gendev); |
| 284 | out: | 283 | out: |
| 285 | if (display_failure_msg) | 284 | if (display_failure_msg) |