diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2013-04-11 19:51:01 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2013-05-28 03:40:25 -0400 |
commit | 1a55af2e45cce0ff13bc33c8ee99da84e188b615 (patch) | |
tree | 1320457064ff621d4dc50fe4febf4ac624c682dc | |
parent | 1ad4ec0dc740c4183acd6d6e367ca52b28e4fa94 (diff) |
sched: Update rq clock earlier in unthrottle_cfs_rq
In this function we are making use of rq->clock right before the
update of the rq clock, let's just call update_rq_clock() just
before that to avoid using a stale rq clock value.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Turner <pjt@google.com>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1365724262-20142-5-git-send-email-fweisbec@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | kernel/sched/fair.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index f76ca21711bb..1c8762a5370c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c | |||
@@ -2319,12 +2319,14 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq) | |||
2319 | se = cfs_rq->tg->se[cpu_of(rq_of(cfs_rq))]; | 2319 | se = cfs_rq->tg->se[cpu_of(rq_of(cfs_rq))]; |
2320 | 2320 | ||
2321 | cfs_rq->throttled = 0; | 2321 | cfs_rq->throttled = 0; |
2322 | |||
2323 | update_rq_clock(rq); | ||
2324 | |||
2322 | raw_spin_lock(&cfs_b->lock); | 2325 | raw_spin_lock(&cfs_b->lock); |
2323 | cfs_b->throttled_time += rq->clock - cfs_rq->throttled_clock; | 2326 | cfs_b->throttled_time += rq->clock - cfs_rq->throttled_clock; |
2324 | list_del_rcu(&cfs_rq->throttled_list); | 2327 | list_del_rcu(&cfs_rq->throttled_list); |
2325 | raw_spin_unlock(&cfs_b->lock); | 2328 | raw_spin_unlock(&cfs_b->lock); |
2326 | 2329 | ||
2327 | update_rq_clock(rq); | ||
2328 | /* update hierarchical throttle state */ | 2330 | /* update hierarchical throttle state */ |
2329 | walk_tg_tree_from(cfs_rq->tg, tg_nop, tg_unthrottle_up, (void *)rq); | 2331 | walk_tg_tree_from(cfs_rq->tg, tg_nop, tg_unthrottle_up, (void *)rq); |
2330 | 2332 | ||