aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Pargmann <mpa@pengutronix.de>2014-09-08 02:43:37 -0400
committerMark Brown <broonie@kernel.org>2014-09-29 13:22:26 -0400
commit18c0301f9898feaac38135b2cea476bb606830e3 (patch)
tree16de5ad4b420033e9ff1a761881fedb4a30e0f0f
parent2c98e0c1cc6b8e86f1978286c3d4e0769ee9d733 (diff)
regmap: Fix debugfs-file 'registers' mode
The macro "REGMAP_ALLOW_WRITE_DEBUGFS" can be used to enable write support on the registers file in the debugfs. The mode of the file is fixed to 0400 so it is not possible to write the file ever. This patch fixes the mode by setting it to the correct value depending on the macro. Signed-off-by: Markus Pargmann <mpa@pengutronix.de> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/base/regmap/regmap-debugfs.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index bdd88708e4d6..a88cbd42edf0 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -516,7 +516,14 @@ void regmap_debugfs_init(struct regmap *map, const char *name)
516 map, &regmap_reg_ranges_fops); 516 map, &regmap_reg_ranges_fops);
517 517
518 if (map->max_register || regmap_readable(map, 0)) { 518 if (map->max_register || regmap_readable(map, 0)) {
519 debugfs_create_file("registers", 0400, map->debugfs, 519 umode_t registers_mode;
520
521 if (IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS))
522 registers_mode = 0600;
523 else
524 registers_mode = 0400;
525
526 debugfs_create_file("registers", registers_mode, map->debugfs,
520 map, &regmap_map_fops); 527 map, &regmap_map_fops);
521 debugfs_create_file("access", 0400, map->debugfs, 528 debugfs_create_file("access", 0400, map->debugfs,
522 map, &regmap_access_fops); 529 map, &regmap_access_fops);