diff options
author | AKASHI Takahiro <takahiro.akashi@linaro.org> | 2014-01-13 16:33:09 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-02-13 16:48:00 -0500 |
commit | 186b643ae0c6db1816c93b9b98daf583ef62c372 (patch) | |
tree | 1f7d95ba4a17cc7aa98b1666a5d401e76cef2bff | |
parent | 34210beebddf8a2bd655086b61dbe3b72e7bc7c5 (diff) |
audit: correct a type mismatch in audit_syscall_exit()
commit 06bdadd7634551cfe8ce071fe44d0311b3033d9e upstream.
audit_syscall_exit() saves a result of regs_return_value() in intermediate
"int" variable and passes it to __audit_syscall_exit(), which expects its
second argument as a "long" value. This will result in truncating the
value returned by a system call and making a wrong audit record.
I don't know why gcc compiler doesn't complain about this, but anyway it
causes a problem at runtime on arm64 (and probably most 64-bit archs).
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | include/linux/audit.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/audit.h b/include/linux/audit.h index 729a4d165bcc..4fb28b23a4a4 100644 --- a/include/linux/audit.h +++ b/include/linux/audit.h | |||
@@ -135,7 +135,7 @@ static inline void audit_syscall_exit(void *pt_regs) | |||
135 | { | 135 | { |
136 | if (unlikely(current->audit_context)) { | 136 | if (unlikely(current->audit_context)) { |
137 | int success = is_syscall_success(pt_regs); | 137 | int success = is_syscall_success(pt_regs); |
138 | int return_code = regs_return_value(pt_regs); | 138 | long return_code = regs_return_value(pt_regs); |
139 | 139 | ||
140 | __audit_syscall_exit(success, return_code); | 140 | __audit_syscall_exit(success, return_code); |
141 | } | 141 | } |