diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-01-22 10:55:32 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-02-18 07:34:46 -0500 |
commit | 17f22a3fbc9d81c1d8f9f853dd23d0e5e8f4c994 (patch) | |
tree | 226b8434c03d887a5b5a45385221927b310cd88b | |
parent | e985a6c675950af10131fdce4d46481d655c6b60 (diff) |
perf report: Use al->cpumode where applicable
We don't need to recalculate cpumode from the perf_event->header field,
as this is already available in the struct addr_location->cpumode field.
Remove the function signature of functions that receive both perf_event
and addr_location parameters but use perf_event just to extract the
cpumode.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-tmct07y7mka54allj82trlnx@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-report.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 3c53ec268fbc..8f9d6edb4674 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -76,12 +76,10 @@ static int report__config(const char *var, const char *value, void *cb) | |||
76 | } | 76 | } |
77 | 77 | ||
78 | static int report__add_mem_hist_entry(struct perf_tool *tool, struct addr_location *al, | 78 | static int report__add_mem_hist_entry(struct perf_tool *tool, struct addr_location *al, |
79 | struct perf_sample *sample, struct perf_evsel *evsel, | 79 | struct perf_sample *sample, struct perf_evsel *evsel) |
80 | union perf_event *event) | ||
81 | { | 80 | { |
82 | struct report *rep = container_of(tool, struct report, tool); | 81 | struct report *rep = container_of(tool, struct report, tool); |
83 | struct symbol *parent = NULL; | 82 | struct symbol *parent = NULL; |
84 | u8 cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK; | ||
85 | struct hist_entry *he; | 83 | struct hist_entry *he; |
86 | struct mem_info *mi, *mx; | 84 | struct mem_info *mi, *mx; |
87 | uint64_t cost; | 85 | uint64_t cost; |
@@ -90,7 +88,7 @@ static int report__add_mem_hist_entry(struct perf_tool *tool, struct addr_locati | |||
90 | if (err) | 88 | if (err) |
91 | return err; | 89 | return err; |
92 | 90 | ||
93 | mi = machine__resolve_mem(al->machine, al->thread, sample, cpumode); | 91 | mi = machine__resolve_mem(al->machine, al->thread, sample, al->cpumode); |
94 | if (!mi) | 92 | if (!mi) |
95 | return -ENOMEM; | 93 | return -ENOMEM; |
96 | 94 | ||
@@ -240,7 +238,7 @@ static int process_sample_event(struct perf_tool *tool, | |||
240 | if (ret < 0) | 238 | if (ret < 0) |
241 | pr_debug("problem adding lbr entry, skipping event\n"); | 239 | pr_debug("problem adding lbr entry, skipping event\n"); |
242 | } else if (rep->mem_mode == 1) { | 240 | } else if (rep->mem_mode == 1) { |
243 | ret = report__add_mem_hist_entry(tool, &al, sample, evsel, event); | 241 | ret = report__add_mem_hist_entry(tool, &al, sample, evsel); |
244 | if (ret < 0) | 242 | if (ret < 0) |
245 | pr_debug("problem adding mem entry, skipping event\n"); | 243 | pr_debug("problem adding mem entry, skipping event\n"); |
246 | } else { | 244 | } else { |