aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2012-08-21 16:18:24 -0400
committerTejun Heo <tj@kernel.org>2012-08-21 16:18:24 -0400
commit136b5721d75a62a8f02c601c89122e32c1a85a84 (patch)
tree871be0290b244d7e171ee615faecd6b804c55f8e
parent57b30ae77bf00d2318df711ef9a4d2a9be0a3a2a (diff)
workqueue: deprecate __cancel_delayed_work()
Now that cancel_delayed_work() can be safely called from IRQ handlers, there's no reason to use __cancel_delayed_work(). Use cancel_delayed_work() instead of __cancel_delayed_work() and mark the latter deprecated. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Jens Axboe <axboe@kernel.dk> Cc: Jiri Kosina <jkosina@suse.cz> Cc: Roland Dreier <roland@kernel.org> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r--block/blk-core.c2
-rw-r--r--drivers/block/floppy.c2
-rw-r--r--drivers/infiniband/core/mad.c2
-rw-r--r--drivers/video/omap2/dss/dsi.c2
-rw-r--r--include/linux/workqueue.h2
5 files changed, 5 insertions, 5 deletions
diff --git a/block/blk-core.c b/block/blk-core.c
index 4b8b606dbb01..dc04a9013027 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -262,7 +262,7 @@ EXPORT_SYMBOL(blk_start_queue);
262 **/ 262 **/
263void blk_stop_queue(struct request_queue *q) 263void blk_stop_queue(struct request_queue *q)
264{ 264{
265 __cancel_delayed_work(&q->delay_work); 265 cancel_delayed_work(&q->delay_work);
266 queue_flag_set(QUEUE_FLAG_STOPPED, q); 266 queue_flag_set(QUEUE_FLAG_STOPPED, q);
267} 267}
268EXPORT_SYMBOL(blk_stop_queue); 268EXPORT_SYMBOL(blk_stop_queue);
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 55a5bc002c06..17c675c52295 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -890,7 +890,7 @@ static void unlock_fdc(void)
890 890
891 raw_cmd = NULL; 891 raw_cmd = NULL;
892 command_status = FD_COMMAND_NONE; 892 command_status = FD_COMMAND_NONE;
893 __cancel_delayed_work(&fd_timeout); 893 cancel_delayed_work(&fd_timeout);
894 do_floppy = NULL; 894 do_floppy = NULL;
895 cont = NULL; 895 cont = NULL;
896 clear_bit(0, &fdc_busy); 896 clear_bit(0, &fdc_busy);
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index b5938147fc89..dc3fd1e8af07 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -2004,7 +2004,7 @@ static void adjust_timeout(struct ib_mad_agent_private *mad_agent_priv)
2004 unsigned long delay; 2004 unsigned long delay;
2005 2005
2006 if (list_empty(&mad_agent_priv->wait_list)) { 2006 if (list_empty(&mad_agent_priv->wait_list)) {
2007 __cancel_delayed_work(&mad_agent_priv->timed_work); 2007 cancel_delayed_work(&mad_agent_priv->timed_work);
2008 } else { 2008 } else {
2009 mad_send_wr = list_entry(mad_agent_priv->wait_list.next, 2009 mad_send_wr = list_entry(mad_agent_priv->wait_list.next,
2010 struct ib_mad_send_wr_private, 2010 struct ib_mad_send_wr_private,
diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
index fd40f2625051..05ee04667af1 100644
--- a/drivers/video/omap2/dss/dsi.c
+++ b/drivers/video/omap2/dss/dsi.c
@@ -4306,7 +4306,7 @@ static void dsi_framedone_irq_callback(void *data, u32 mask)
4306 * and is sending the data. 4306 * and is sending the data.
4307 */ 4307 */
4308 4308
4309 __cancel_delayed_work(&dsi->framedone_timeout_work); 4309 cancel_delayed_work(&dsi->framedone_timeout_work);
4310 4310
4311 dsi_handle_framedone(dsidev, 0); 4311 dsi_handle_framedone(dsidev, 0);
4312} 4312}
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 4898289564ab..2b58905d3504 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -434,7 +434,7 @@ extern unsigned int work_busy(struct work_struct *work);
434 * if it returns 0 the timer function may be running and the queueing is in 434 * if it returns 0 the timer function may be running and the queueing is in
435 * progress. 435 * progress.
436 */ 436 */
437static inline bool __cancel_delayed_work(struct delayed_work *work) 437static inline bool __deprecated __cancel_delayed_work(struct delayed_work *work)
438{ 438{
439 bool ret; 439 bool ret;
440 440