aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2013-11-28 13:01:40 -0500
committerIngo Molnar <mingo@kernel.org>2014-01-13 09:13:17 -0500
commit10b033d434c25a6c9e0f4f4dc2418af1b8236c63 (patch)
tree6d152d9953a9d8106978dbc84217c1f695df9ffe
parent6577e42a3e1633afe762f47da9e00061ee4b9a5e (diff)
sched/clock, x86: Avoid a runtime condition in native_sched_clock()
Use a static_key to avoid touching tsc_disabled and a runtime condition in native_sched_clock() -- less cachelines touched is always better. MAINLINE PRE POST sched_clock_stable: 1 1 1 (cold) sched_clock: 329841 215295 213039 (cold) local_clock: 301773 220773 216084 (warm) sched_clock: 38375 25659 25231 (warm) local_clock: 100371 27242 27601 (warm) rdtsc: 27340 24208 24203 sched_clock_stable: 0 0 0 (cold) sched_clock: 382634 237019 240055 (cold) local_clock: 396890 294819 299942 (warm) sched_clock: 38194 25609 25276 (warm) local_clock: 143452 71232 73232 (warm) rdtsc: 27345 24243 24244 Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Andrew Morton <akpm@linux-foundation.org> Link: http://lkml.kernel.org/n/tip-hrz87bo37qke25bty6pnfy4b@git.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/kernel/tsc.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 53c123537245..6377fb28b958 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -11,6 +11,7 @@
11#include <linux/clocksource.h> 11#include <linux/clocksource.h>
12#include <linux/percpu.h> 12#include <linux/percpu.h>
13#include <linux/timex.h> 13#include <linux/timex.h>
14#include <linux/static_key.h>
14 15
15#include <asm/hpet.h> 16#include <asm/hpet.h>
16#include <asm/timer.h> 17#include <asm/timer.h>
@@ -37,6 +38,8 @@ static int __read_mostly tsc_unstable;
37 erroneous rdtsc usage on !cpu_has_tsc processors */ 38 erroneous rdtsc usage on !cpu_has_tsc processors */
38static int __read_mostly tsc_disabled = -1; 39static int __read_mostly tsc_disabled = -1;
39 40
41static struct static_key __use_tsc = STATIC_KEY_INIT;
42
40int tsc_clocksource_reliable; 43int tsc_clocksource_reliable;
41 44
42/* 45/*
@@ -282,7 +285,7 @@ u64 native_sched_clock(void)
282 * very important for it to be as fast as the platform 285 * very important for it to be as fast as the platform
283 * can achieve it. ) 286 * can achieve it. )
284 */ 287 */
285 if (unlikely(tsc_disabled)) { 288 if (!static_key_false(&__use_tsc)) {
286 /* No locking but a rare wrong value is not a big deal: */ 289 /* No locking but a rare wrong value is not a big deal: */
287 return (jiffies_64 - INITIAL_JIFFIES) * (1000000000 / HZ); 290 return (jiffies_64 - INITIAL_JIFFIES) * (1000000000 / HZ);
288 } 291 }
@@ -1193,7 +1196,9 @@ void __init tsc_init(void)
1193 return; 1196 return;
1194 1197
1195 /* now allow native_sched_clock() to use rdtsc */ 1198 /* now allow native_sched_clock() to use rdtsc */
1199
1196 tsc_disabled = 0; 1200 tsc_disabled = 0;
1201 static_key_slow_inc(&__use_tsc);
1197 1202
1198 if (!no_sched_irq_time) 1203 if (!no_sched_irq_time)
1199 enable_sched_clock_irqtime(); 1204 enable_sched_clock_irqtime();