aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDenys Vlasenko <dvlasenk@redhat.com>2015-04-07 16:43:39 -0400
committerIngo Molnar <mingo@kernel.org>2015-04-09 04:31:24 -0400
commit0f90fb979d7b53d80a6d5cb6e127b4b4b249907e (patch)
tree94a4a3f1fc3634487ad80a503940bfe4cf28a51a
parent05f1752d195c145d02ae40881d0985c2cfbee473 (diff)
x86/asm/entry: Zero EXTRA_REGS for stub32_execve() too
The change which affected how execve clears EXTRA_REGS missed 32-bit execve syscalls. Fix this by using 64-bit execve stub epilogue for them too. Run-tested. Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> Cc: Alexei Starovoitov <ast@plumgrid.com> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Kees Cook <keescook@chromium.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Drewry <wad@chromium.org> Link: http://lkml.kernel.org/r/1428439424-7258-3-git-send-email-dvlasenk@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/ia32/ia32entry.S2
-rw-r--r--arch/x86/kernel/entry_64.S15
2 files changed, 15 insertions, 2 deletions
diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index 5d8f987a340d..a821b1cd4fa7 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -571,8 +571,6 @@ GLOBAL(\label)
571 571
572 PTREGSCALL stub32_rt_sigreturn, sys32_rt_sigreturn 572 PTREGSCALL stub32_rt_sigreturn, sys32_rt_sigreturn
573 PTREGSCALL stub32_sigreturn, sys32_sigreturn 573 PTREGSCALL stub32_sigreturn, sys32_sigreturn
574 PTREGSCALL stub32_execve, compat_sys_execve
575 PTREGSCALL stub32_execveat, compat_sys_execveat
576 PTREGSCALL stub32_fork, sys_fork 574 PTREGSCALL stub32_fork, sys_fork
577 PTREGSCALL stub32_vfork, sys_vfork 575 PTREGSCALL stub32_vfork, sys_vfork
578 576
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index f7d9ba6f73a3..5380b3a8f3e5 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -538,6 +538,21 @@ ENTRY(stub_x32_execveat)
538END(stub_x32_execveat) 538END(stub_x32_execveat)
539#endif 539#endif
540 540
541#ifdef CONFIG_IA32_EMULATION
542ENTRY(stub32_execve)
543 CFI_STARTPROC
544 call compat_sys_execve
545 jmp return_from_execve
546 CFI_ENDPROC
547END(stub32_execve)
548ENTRY(stub32_execveat)
549 CFI_STARTPROC
550 call compat_sys_execveat
551 jmp return_from_execve
552 CFI_ENDPROC
553END(stub32_execveat)
554#endif
555
541/* 556/*
542 * sigreturn is special because it needs to restore all registers on return. 557 * sigreturn is special because it needs to restore all registers on return.
543 * This cannot be done with SYSRET, so use the IRET return path instead. 558 * This cannot be done with SYSRET, so use the IRET return path instead.