aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBruce Allan <bruce.w.allan@intel.com>2012-01-31 01:37:11 -0500
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2012-02-07 07:18:09 -0500
commit0e15df490eef6f5080b84533dcd3068a78122768 (patch)
treec523faf2387b310ce3a1c35a91f7d6344fde23b1
parente885d762b7f73e811432f67608a6f0affa861029 (diff)
e1000e: minor whitespace and indentation cleanup
Cleanup of some whitespace and indentation of a single code block. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r--drivers/net/ethernet/intel/e1000e/ich8lan.c4
-rw-r--r--drivers/net/ethernet/intel/e1000e/netdev.c76
2 files changed, 43 insertions, 37 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 0e64cc438494..5061d4ded6e2 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -280,8 +280,8 @@ static inline void __ew32flash(struct e1000_hw *hw, unsigned long reg, u32 val)
280 280
281#define er16flash(reg) __er16flash(hw, (reg)) 281#define er16flash(reg) __er16flash(hw, (reg))
282#define er32flash(reg) __er32flash(hw, (reg)) 282#define er32flash(reg) __er32flash(hw, (reg))
283#define ew16flash(reg,val) __ew16flash(hw, (reg), (val)) 283#define ew16flash(reg, val) __ew16flash(hw, (reg), (val))
284#define ew32flash(reg,val) __ew32flash(hw, (reg), (val)) 284#define ew32flash(reg, val) __ew32flash(hw, (reg), (val))
285 285
286static void e1000_toggle_lanphypc_value_ich8lan(struct e1000_hw *hw) 286static void e1000_toggle_lanphypc_value_ich8lan(struct e1000_hw *hw)
287{ 287{
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 2ac1164d04e5..293a7606e0f4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -1267,43 +1267,49 @@ static bool e1000_clean_rx_irq_ps(struct e1000_ring *rx_ring, int *work_done,
1267 skb_put(skb, length); 1267 skb_put(skb, length);
1268 1268
1269 { 1269 {
1270 /* 1270 /*
1271 * this looks ugly, but it seems compiler issues make it 1271 * this looks ugly, but it seems compiler issues make
1272 * more efficient than reusing j 1272 * it more efficient than reusing j
1273 */ 1273 */
1274 int l1 = le16_to_cpu(rx_desc->wb.upper.length[0]); 1274 int l1 = le16_to_cpu(rx_desc->wb.upper.length[0]);
1275
1276 /*
1277 * page alloc/put takes too long and effects small packet
1278 * throughput, so unsplit small packets and save the alloc/put
1279 * only valid in softirq (napi) context to call kmap_*
1280 */
1281 if (l1 && (l1 <= copybreak) &&
1282 ((length + l1) <= adapter->rx_ps_bsize0)) {
1283 u8 *vaddr;
1284
1285 ps_page = &buffer_info->ps_pages[0];
1286 1275
1287 /* 1276 /*
1288 * there is no documentation about how to call 1277 * page alloc/put takes too long and effects small
1289 * kmap_atomic, so we can't hold the mapping 1278 * packet throughput, so unsplit small packets and
1290 * very long 1279 * save the alloc/put only valid in softirq (napi)
1280 * context to call kmap_*
1291 */ 1281 */
1292 dma_sync_single_for_cpu(&pdev->dev, ps_page->dma, 1282 if (l1 && (l1 <= copybreak) &&
1293 PAGE_SIZE, DMA_FROM_DEVICE); 1283 ((length + l1) <= adapter->rx_ps_bsize0)) {
1294 vaddr = kmap_atomic(ps_page->page, KM_SKB_DATA_SOFTIRQ); 1284 u8 *vaddr;
1295 memcpy(skb_tail_pointer(skb), vaddr, l1); 1285
1296 kunmap_atomic(vaddr, KM_SKB_DATA_SOFTIRQ); 1286 ps_page = &buffer_info->ps_pages[0];
1297 dma_sync_single_for_device(&pdev->dev, ps_page->dma, 1287
1298 PAGE_SIZE, DMA_FROM_DEVICE); 1288 /*
1299 1289 * there is no documentation about how to call
1300 /* remove the CRC */ 1290 * kmap_atomic, so we can't hold the mapping
1301 if (!(adapter->flags2 & FLAG2_CRC_STRIPPING)) 1291 * very long
1302 l1 -= 4; 1292 */
1303 1293 dma_sync_single_for_cpu(&pdev->dev,
1304 skb_put(skb, l1); 1294 ps_page->dma,
1305 goto copydone; 1295 PAGE_SIZE,
1306 } /* if */ 1296 DMA_FROM_DEVICE);
1297 vaddr = kmap_atomic(ps_page->page,
1298 KM_SKB_DATA_SOFTIRQ);
1299 memcpy(skb_tail_pointer(skb), vaddr, l1);
1300 kunmap_atomic(vaddr, KM_SKB_DATA_SOFTIRQ);
1301 dma_sync_single_for_device(&pdev->dev,
1302 ps_page->dma,
1303 PAGE_SIZE,
1304 DMA_FROM_DEVICE);
1305
1306 /* remove the CRC */
1307 if (!(adapter->flags2 & FLAG2_CRC_STRIPPING))
1308 l1 -= 4;
1309
1310 skb_put(skb, l1);
1311 goto copydone;
1312 } /* if */
1307 } 1313 }
1308 1314
1309 for (j = 0; j < PS_PAGE_BUFFERS; j++) { 1315 for (j = 0; j < PS_PAGE_BUFFERS; j++) {
@@ -4969,7 +4975,7 @@ static int e1000_maybe_stop_tx(struct e1000_ring *tx_ring, int size)
4969 return __e1000_maybe_stop_tx(tx_ring, size); 4975 return __e1000_maybe_stop_tx(tx_ring, size);
4970} 4976}
4971 4977
4972#define TXD_USE_COUNT(S, X) (((S) >> (X)) + 1 ) 4978#define TXD_USE_COUNT(S, X) (((S) >> (X)) + 1)
4973static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb, 4979static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb,
4974 struct net_device *netdev) 4980 struct net_device *netdev)
4975{ 4981{