aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-13 20:18:19 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-09-13 20:18:19 -0400
commit0e00609d857962ebecfba7deab834a52087b2454 (patch)
treea0be93353fa5f755024e924f8d9bcf4a2f4a0343
parentd44d9ab79212d56eea6b26f1e4925284861c347e (diff)
USB: serial: option.c: remove dbg() usage
dbg() was a very old USB-serial-specific macro. This patch removes it from being used in the driver and uses dev_dbg() instead. CC: Matthias Urlichs <smurf@smurf.noris.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/serial/option.c15
1 files changed, 8 insertions, 7 deletions
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index cc40f47ecea1..3891c0f60dea 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1367,18 +1367,19 @@ static void option_instat_callback(struct urb *urb)
1367{ 1367{
1368 int err; 1368 int err;
1369 int status = urb->status; 1369 int status = urb->status;
1370 struct usb_serial_port *port = urb->context; 1370 struct usb_serial_port *port = urb->context;
1371 struct device *dev = &port->dev;
1371 struct usb_wwan_port_private *portdata = 1372 struct usb_wwan_port_private *portdata =
1372 usb_get_serial_port_data(port); 1373 usb_get_serial_port_data(port);
1373 1374
1374 dbg("%s: urb %p port %p has data %p", __func__, urb, port, portdata); 1375 dev_dbg(dev, "%s: urb %p port %p has data %p\n", __func__, urb, port, portdata);
1375 1376
1376 if (status == 0) { 1377 if (status == 0) {
1377 struct usb_ctrlrequest *req_pkt = 1378 struct usb_ctrlrequest *req_pkt =
1378 (struct usb_ctrlrequest *)urb->transfer_buffer; 1379 (struct usb_ctrlrequest *)urb->transfer_buffer;
1379 1380
1380 if (!req_pkt) { 1381 if (!req_pkt) {
1381 dbg("%s: NULL req_pkt", __func__); 1382 dev_dbg(dev, "%s: NULL req_pkt\n", __func__);
1382 return; 1383 return;
1383 } 1384 }
1384 if ((req_pkt->bRequestType == 0xA1) && 1385 if ((req_pkt->bRequestType == 0xA1) &&
@@ -1388,7 +1389,7 @@ static void option_instat_callback(struct urb *urb)
1388 urb->transfer_buffer + 1389 urb->transfer_buffer +
1389 sizeof(struct usb_ctrlrequest)); 1390 sizeof(struct usb_ctrlrequest));
1390 1391
1391 dbg("%s: signal x%x", __func__, signals); 1392 dev_dbg(dev, "%s: signal x%x\n", __func__, signals);
1392 1393
1393 old_dcd_state = portdata->dcd_state; 1394 old_dcd_state = portdata->dcd_state;
1394 portdata->cts_state = 1; 1395 portdata->cts_state = 1;
@@ -1404,17 +1405,17 @@ static void option_instat_callback(struct urb *urb)
1404 tty_kref_put(tty); 1405 tty_kref_put(tty);
1405 } 1406 }
1406 } else { 1407 } else {
1407 dbg("%s: type %x req %x", __func__, 1408 dev_dbg(dev, "%s: type %x req %x\n", __func__,
1408 req_pkt->bRequestType, req_pkt->bRequest); 1409 req_pkt->bRequestType, req_pkt->bRequest);
1409 } 1410 }
1410 } else 1411 } else
1411 dev_err(&port->dev, "%s: error %d\n", __func__, status); 1412 dev_err(dev, "%s: error %d\n", __func__, status);
1412 1413
1413 /* Resubmit urb so we continue receiving IRQ data */ 1414 /* Resubmit urb so we continue receiving IRQ data */
1414 if (status != -ESHUTDOWN && status != -ENOENT) { 1415 if (status != -ESHUTDOWN && status != -ENOENT) {
1415 err = usb_submit_urb(urb, GFP_ATOMIC); 1416 err = usb_submit_urb(urb, GFP_ATOMIC);
1416 if (err) 1417 if (err)
1417 dbg("%s: resubmit intr urb failed. (%d)", 1418 dev_dbg(dev, "%s: resubmit intr urb failed. (%d)\n",
1418 __func__, err); 1419 __func__, err);
1419 } 1420 }
1420} 1421}