diff options
author | Julia Lawall <julia@diku.dk> | 2010-08-28 12:48:56 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-22 13:21:26 -0400 |
commit | 0cf7a6338808d702c256778188516a16805e6145 (patch) | |
tree | a7b5a40fc5c141fc7f6f60484592a7aacd1d7a0c | |
parent | 5ea081785dde6041eb2f4acc2369abbb9099a981 (diff) |
USB: gadget: amd5536udc.c: Remove double test
The same expression is tested twice and the result is the same each time.
Instead test for use_dma_ppb as in the test above.
The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@expression@
expression E;
@@
(
* E
|| ... || E
|
* E
&& ... && E
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/usb/gadget/amd5536udc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index fadebfd53b47..2b361500af1e 100644 --- a/drivers/usb/gadget/amd5536udc.c +++ b/drivers/usb/gadget/amd5536udc.c | |||
@@ -203,7 +203,7 @@ static void print_regs(struct udc *dev) | |||
203 | DBG(dev, "DMA mode = PPBNDU (packet per buffer " | 203 | DBG(dev, "DMA mode = PPBNDU (packet per buffer " |
204 | "WITHOUT desc. update)\n"); | 204 | "WITHOUT desc. update)\n"); |
205 | dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU"); | 205 | dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU"); |
206 | } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) { | 206 | } else if (use_dma && use_dma_ppb && use_dma_ppb_du) { |
207 | DBG(dev, "DMA mode = PPBDU (packet per buffer " | 207 | DBG(dev, "DMA mode = PPBDU (packet per buffer " |
208 | "WITH desc. update)\n"); | 208 | "WITH desc. update)\n"); |
209 | dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU"); | 209 | dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU"); |