diff options
author | Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> | 2014-05-20 17:37:32 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2014-05-23 06:47:31 -0400 |
commit | 0c641bff31af7326b51cd39739cfc3a2c060f456 (patch) | |
tree | 4e62855538bea5115c07fcad71b08d762d43835d | |
parent | d9a5f87c8fb49010d4fc1e41e263072b7e9916b1 (diff) |
video: fbdev: s3fb.c: Fix for possible null pointer dereference
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r-- | drivers/video/fbdev/s3fb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 9a3f8f1c6aab..c43b969e1e23 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c | |||
@@ -1401,9 +1401,10 @@ err_enable_device: | |||
1401 | static void s3_pci_remove(struct pci_dev *dev) | 1401 | static void s3_pci_remove(struct pci_dev *dev) |
1402 | { | 1402 | { |
1403 | struct fb_info *info = pci_get_drvdata(dev); | 1403 | struct fb_info *info = pci_get_drvdata(dev); |
1404 | struct s3fb_info __maybe_unused *par = info->par; | 1404 | struct s3fb_info __maybe_unused *par; |
1405 | 1405 | ||
1406 | if (info) { | 1406 | if (info) { |
1407 | par = info->par; | ||
1407 | 1408 | ||
1408 | #ifdef CONFIG_MTRR | 1409 | #ifdef CONFIG_MTRR |
1409 | if (par->mtrr_reg >= 0) { | 1410 | if (par->mtrr_reg >= 0) { |