diff options
author | Dave Airlie <airlied@redhat.com> | 2014-06-03 23:29:13 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2014-06-03 23:29:13 -0400 |
commit | 0a4ae727d6aa459247b027387edb6ff99f657792 (patch) | |
tree | c4b8df20065905271be593123e6cc9dd97c6d7da | |
parent | ba6f582606655754d9dfbfc9dffe75dcf806f1dd (diff) | |
parent | 91b0275c0ecd1870c5f8bfb73e2da2d6c29414b3 (diff) |
Merge branch 'drm-fixes-3.15' of git://people.freedesktop.org/~deathsimple/linux into drm-fixes
The first one is a one liner fixing a stupid typo in the VM handling code and is only relevant if play with one of the VM defines.
The other two switches CIK to use the CPDMA instead of the SDMA for buffer moves, as it turned out the SDMA is still sometimes not 100% reliable.
* 'drm-fixes-3.15' of git://people.freedesktop.org/~deathsimple/linux:
drm/radeon: use the CP DMA on CIK
drm/radeon: sync page table updates
drm/radeon: fix vm buffer size estimation
-rw-r--r-- | drivers/gpu/drm/radeon/radeon_asic.c | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/radeon/radeon_vm.c | 11 |
2 files changed, 10 insertions, 5 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_asic.c b/drivers/gpu/drm/radeon/radeon_asic.c index be20e62dac83..e5f0177bea1e 100644 --- a/drivers/gpu/drm/radeon/radeon_asic.c +++ b/drivers/gpu/drm/radeon/radeon_asic.c | |||
@@ -2049,8 +2049,8 @@ static struct radeon_asic ci_asic = { | |||
2049 | .blit_ring_index = RADEON_RING_TYPE_GFX_INDEX, | 2049 | .blit_ring_index = RADEON_RING_TYPE_GFX_INDEX, |
2050 | .dma = &cik_copy_dma, | 2050 | .dma = &cik_copy_dma, |
2051 | .dma_ring_index = R600_RING_TYPE_DMA_INDEX, | 2051 | .dma_ring_index = R600_RING_TYPE_DMA_INDEX, |
2052 | .copy = &cik_copy_dma, | 2052 | .copy = &cik_copy_cpdma, |
2053 | .copy_ring_index = R600_RING_TYPE_DMA_INDEX, | 2053 | .copy_ring_index = RADEON_RING_TYPE_GFX_INDEX, |
2054 | }, | 2054 | }, |
2055 | .surface = { | 2055 | .surface = { |
2056 | .set_reg = r600_set_surface_reg, | 2056 | .set_reg = r600_set_surface_reg, |
diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index 1f426696de36..c11b71d249e3 100644 --- a/drivers/gpu/drm/radeon/radeon_vm.c +++ b/drivers/gpu/drm/radeon/radeon_vm.c | |||
@@ -132,7 +132,7 @@ struct radeon_cs_reloc *radeon_vm_get_bos(struct radeon_device *rdev, | |||
132 | struct radeon_cs_reloc *list; | 132 | struct radeon_cs_reloc *list; |
133 | unsigned i, idx; | 133 | unsigned i, idx; |
134 | 134 | ||
135 | list = kmalloc_array(vm->max_pde_used + 1, | 135 | list = kmalloc_array(vm->max_pde_used + 2, |
136 | sizeof(struct radeon_cs_reloc), GFP_KERNEL); | 136 | sizeof(struct radeon_cs_reloc), GFP_KERNEL); |
137 | if (!list) | 137 | if (!list) |
138 | return NULL; | 138 | return NULL; |
@@ -585,7 +585,8 @@ int radeon_vm_update_page_directory(struct radeon_device *rdev, | |||
585 | { | 585 | { |
586 | static const uint32_t incr = RADEON_VM_PTE_COUNT * 8; | 586 | static const uint32_t incr = RADEON_VM_PTE_COUNT * 8; |
587 | 587 | ||
588 | uint64_t pd_addr = radeon_bo_gpu_offset(vm->page_directory); | 588 | struct radeon_bo *pd = vm->page_directory; |
589 | uint64_t pd_addr = radeon_bo_gpu_offset(pd); | ||
589 | uint64_t last_pde = ~0, last_pt = ~0; | 590 | uint64_t last_pde = ~0, last_pt = ~0; |
590 | unsigned count = 0, pt_idx, ndw; | 591 | unsigned count = 0, pt_idx, ndw; |
591 | struct radeon_ib ib; | 592 | struct radeon_ib ib; |
@@ -642,6 +643,7 @@ int radeon_vm_update_page_directory(struct radeon_device *rdev, | |||
642 | incr, R600_PTE_VALID); | 643 | incr, R600_PTE_VALID); |
643 | 644 | ||
644 | if (ib.length_dw != 0) { | 645 | if (ib.length_dw != 0) { |
646 | radeon_semaphore_sync_to(ib.semaphore, pd->tbo.sync_obj); | ||
645 | radeon_semaphore_sync_to(ib.semaphore, vm->last_id_use); | 647 | radeon_semaphore_sync_to(ib.semaphore, vm->last_id_use); |
646 | r = radeon_ib_schedule(rdev, &ib, NULL); | 648 | r = radeon_ib_schedule(rdev, &ib, NULL); |
647 | if (r) { | 649 | if (r) { |
@@ -689,15 +691,18 @@ static void radeon_vm_update_ptes(struct radeon_device *rdev, | |||
689 | /* walk over the address space and update the page tables */ | 691 | /* walk over the address space and update the page tables */ |
690 | for (addr = start; addr < end; ) { | 692 | for (addr = start; addr < end; ) { |
691 | uint64_t pt_idx = addr >> RADEON_VM_BLOCK_SIZE; | 693 | uint64_t pt_idx = addr >> RADEON_VM_BLOCK_SIZE; |
694 | struct radeon_bo *pt = vm->page_tables[pt_idx].bo; | ||
692 | unsigned nptes; | 695 | unsigned nptes; |
693 | uint64_t pte; | 696 | uint64_t pte; |
694 | 697 | ||
698 | radeon_semaphore_sync_to(ib->semaphore, pt->tbo.sync_obj); | ||
699 | |||
695 | if ((addr & ~mask) == (end & ~mask)) | 700 | if ((addr & ~mask) == (end & ~mask)) |
696 | nptes = end - addr; | 701 | nptes = end - addr; |
697 | else | 702 | else |
698 | nptes = RADEON_VM_PTE_COUNT - (addr & mask); | 703 | nptes = RADEON_VM_PTE_COUNT - (addr & mask); |
699 | 704 | ||
700 | pte = radeon_bo_gpu_offset(vm->page_tables[pt_idx].bo); | 705 | pte = radeon_bo_gpu_offset(pt); |
701 | pte += (addr & mask) * 8; | 706 | pte += (addr & mask) * 8; |
702 | 707 | ||
703 | if ((last_pte + 8 * count) != pte) { | 708 | if ((last_pte + 8 * count) != pte) { |