aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2011-01-11 14:42:29 -0500
committerTheodore Ts'o <tytso@mit.edu>2011-01-11 14:42:29 -0500
commit0a2179b169089f871e071c74316371ed43e6c8eb (patch)
treecfddd008d054c0ec6b047130d7f4e11667516770
parentd002ebf1d8daa5a317645b1c4a3a0b7ea2abc9ac (diff)
ext4: revert buggy trim overflow patch
This reverts commit 4f531501e44: ext4: fix possible overflow in ext4_trim_fs() Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r--fs/ext4/mballoc.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index cd5214f75397..cc1297e15f1b 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -4804,7 +4804,6 @@ ext4_grpblk_t ext4_trim_all_free(struct super_block *sb, struct ext4_buddy *e4b,
4804int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range) 4804int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
4805{ 4805{
4806 struct ext4_buddy e4b; 4806 struct ext4_buddy e4b;
4807 ext4_fsblk_t blocks_count = ext4_blocks_count(EXT4_SB(sb)->s_es);
4808 ext4_group_t first_group, last_group; 4807 ext4_group_t first_group, last_group;
4809 ext4_group_t group, ngroups = ext4_get_groups_count(sb); 4808 ext4_group_t group, ngroups = ext4_get_groups_count(sb);
4810 ext4_grpblk_t cnt = 0, first_block, last_block; 4809 ext4_grpblk_t cnt = 0, first_block, last_block;
@@ -4816,11 +4815,6 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
4816 minlen = range->minlen >> sb->s_blocksize_bits; 4815 minlen = range->minlen >> sb->s_blocksize_bits;
4817 trimmed = 0; 4816 trimmed = 0;
4818 4817
4819 if (start >= blocks_count)
4820 return -EINVAL;
4821 if (start + len > blocks_count)
4822 len = blocks_count - start;
4823
4824 if (unlikely(minlen > EXT4_BLOCKS_PER_GROUP(sb))) 4818 if (unlikely(minlen > EXT4_BLOCKS_PER_GROUP(sb)))
4825 return -EINVAL; 4819 return -EINVAL;
4826 4820