aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@sandeen.net>2013-10-11 21:59:05 -0400
committerBen Myers <bpm@sgi.com>2013-10-17 14:30:29 -0400
commit08e96e1a3c5fd823f846df813b0b8be8e734c6c2 (patch)
treee775cee59304c8fa614c6a1a966b80c8fe9f3125
parent2c6e24ce1aa6b3b147c75d488c2797ee258eb22b (diff)
xfs: remove newlines from strings passed to __xfs_printk
__xfs_printk adds its own "\n". Having it in the original string leads to unintentional blank lines from these messages. Most format strings have no newline, but a few do, leading to i.e.: [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119911] [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119919] Fix them all. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r--fs/xfs/xfs_bmap.c2
-rw-r--r--fs/xfs/xfs_buf.c6
-rw-r--r--fs/xfs/xfs_dir2_node.c2
-rw-r--r--fs/xfs/xfs_error.c2
-rw-r--r--fs/xfs/xfs_iomap.c2
-rw-r--r--fs/xfs/xfs_log.c2
-rw-r--r--fs/xfs/xfs_log_recover.c6
-rw-r--r--fs/xfs/xfs_qm_syscalls.c12
-rw-r--r--fs/xfs/xfs_sb.c4
-rw-r--r--fs/xfs/xfs_super.c2
10 files changed, 20 insertions, 20 deletions
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
index f47e65c30be6..e6b42026f9d4 100644
--- a/fs/xfs/xfs_bmap.c
+++ b/fs/xfs/xfs_bmap.c
@@ -1482,7 +1482,7 @@ xfs_bmap_search_extents(
1482 xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO, 1482 xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
1483 "Access to block zero in inode %llu " 1483 "Access to block zero in inode %llu "
1484 "start_block: %llx start_off: %llx " 1484 "start_block: %llx start_off: %llx "
1485 "blkcnt: %llx extent-state: %x lastx: %x\n", 1485 "blkcnt: %llx extent-state: %x lastx: %x",
1486 (unsigned long long)ip->i_ino, 1486 (unsigned long long)ip->i_ino,
1487 (unsigned long long)gotp->br_startblock, 1487 (unsigned long long)gotp->br_startblock,
1488 (unsigned long long)gotp->br_startoff, 1488 (unsigned long long)gotp->br_startoff,
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 263470075ea2..75e4ea7b109a 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -590,7 +590,7 @@ found:
590 error = _xfs_buf_map_pages(bp, flags); 590 error = _xfs_buf_map_pages(bp, flags);
591 if (unlikely(error)) { 591 if (unlikely(error)) {
592 xfs_warn(target->bt_mount, 592 xfs_warn(target->bt_mount,
593 "%s: failed to map pages\n", __func__); 593 "%s: failed to map pagesn", __func__);
594 xfs_buf_relse(bp); 594 xfs_buf_relse(bp);
595 return NULL; 595 return NULL;
596 } 596 }
@@ -809,7 +809,7 @@ xfs_buf_get_uncached(
809 error = _xfs_buf_map_pages(bp, 0); 809 error = _xfs_buf_map_pages(bp, 0);
810 if (unlikely(error)) { 810 if (unlikely(error)) {
811 xfs_warn(target->bt_mount, 811 xfs_warn(target->bt_mount,
812 "%s: failed to map pages\n", __func__); 812 "%s: failed to map pages", __func__);
813 goto fail_free_mem; 813 goto fail_free_mem;
814 } 814 }
815 815
@@ -1618,7 +1618,7 @@ xfs_setsize_buftarg_flags(
1618 bdevname(btp->bt_bdev, name); 1618 bdevname(btp->bt_bdev, name);
1619 1619
1620 xfs_warn(btp->bt_mount, 1620 xfs_warn(btp->bt_mount,
1621 "Cannot set_blocksize to %u on device %s\n", 1621 "Cannot set_blocksize to %u on device %s",
1622 sectorsize, name); 1622 sectorsize, name);
1623 return EINVAL; 1623 return EINVAL;
1624 } 1624 }
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c
index 4c3dba7ffb74..34df052683eb 100644
--- a/fs/xfs/xfs_dir2_node.c
+++ b/fs/xfs/xfs_dir2_node.c
@@ -1101,7 +1101,7 @@ xfs_dir2_leafn_rebalance(
1101 state->inleaf = 1; 1101 state->inleaf = 1;
1102 blk2->index = 0; 1102 blk2->index = 0;
1103 xfs_alert(args->dp->i_mount, 1103 xfs_alert(args->dp->i_mount,
1104 "%s: picked the wrong leaf? reverting original leaf: blk1->index %d\n", 1104 "%s: picked the wrong leaf? reverting original leaf: blk1->index %d",
1105 __func__, blk1->index); 1105 __func__, blk1->index);
1106 } 1106 }
1107} 1107}
diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 1123d93ff795..40f2985a27bc 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -159,7 +159,7 @@ xfs_error_report(
159{ 159{
160 if (level <= xfs_error_level) { 160 if (level <= xfs_error_level) {
161 xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT, 161 xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
162 "Internal error %s at line %d of file %s. Caller 0x%p\n", 162 "Internal error %s at line %d of file %s. Caller 0x%p",
163 tag, linenum, filename, ra); 163 tag, linenum, filename, ra);
164 164
165 xfs_stack_trace(); 165 xfs_stack_trace();
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 521fdf2ac6da..338b33263c56 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -110,7 +110,7 @@ xfs_alert_fsblock_zero(
110 xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO, 110 xfs_alert_tag(ip->i_mount, XFS_PTAG_FSBLOCK_ZERO,
111 "Access to block zero in inode %llu " 111 "Access to block zero in inode %llu "
112 "start_block: %llx start_off: %llx " 112 "start_block: %llx start_off: %llx "
113 "blkcnt: %llx extent-state: %x\n", 113 "blkcnt: %llx extent-state: %x",
114 (unsigned long long)ip->i_ino, 114 (unsigned long long)ip->i_ino,
115 (unsigned long long)imap->br_startblock, 115 (unsigned long long)imap->br_startblock,
116 (unsigned long long)imap->br_startoff, 116 (unsigned long long)imap->br_startoff,
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 613ed9414e70..0461f0872244 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1989,7 +1989,7 @@ xlog_print_tic_res(
1989 1989
1990 for (i = 0; i < ticket->t_res_num; i++) { 1990 for (i = 0; i < ticket->t_res_num; i++) {
1991 uint r_type = ticket->t_res_arr[i].r_type; 1991 uint r_type = ticket->t_res_arr[i].r_type;
1992 xfs_warn(mp, "region[%u]: %s - %u bytes\n", i, 1992 xfs_warn(mp, "region[%u]: %s - %u bytes", i,
1993 ((r_type <= 0 || r_type > XLOG_REG_TYPE_MAX) ? 1993 ((r_type <= 0 || r_type > XLOG_REG_TYPE_MAX) ?
1994 "bad-rtype" : res_type_str[r_type-1]), 1994 "bad-rtype" : res_type_str[r_type-1]),
1995 ticket->t_res_arr[i].r_len); 1995 ticket->t_res_arr[i].r_len);
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 39797490a1f1..e7ca48e8f515 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -305,9 +305,9 @@ xlog_header_check_dump(
305 xfs_mount_t *mp, 305 xfs_mount_t *mp,
306 xlog_rec_header_t *head) 306 xlog_rec_header_t *head)
307{ 307{
308 xfs_debug(mp, "%s: SB : uuid = %pU, fmt = %d\n", 308 xfs_debug(mp, "%s: SB : uuid = %pU, fmt = %d",
309 __func__, &mp->m_sb.sb_uuid, XLOG_FMT); 309 __func__, &mp->m_sb.sb_uuid, XLOG_FMT);
310 xfs_debug(mp, " log : uuid = %pU, fmt = %d\n", 310 xfs_debug(mp, " log : uuid = %pU, fmt = %d",
311 &head->h_fs_uuid, be32_to_cpu(head->h_fmt)); 311 &head->h_fs_uuid, be32_to_cpu(head->h_fmt));
312} 312}
313#else 313#else
@@ -4077,7 +4077,7 @@ xlog_unpack_data_crc(
4077 if (crc != rhead->h_crc) { 4077 if (crc != rhead->h_crc) {
4078 if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) { 4078 if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
4079 xfs_alert(log->l_mp, 4079 xfs_alert(log->l_mp,
4080 "log record CRC mismatch: found 0x%x, expected 0x%x.\n", 4080 "log record CRC mismatch: found 0x%x, expected 0x%x.",
4081 le32_to_cpu(rhead->h_crc), 4081 le32_to_cpu(rhead->h_crc),
4082 le32_to_cpu(crc)); 4082 le32_to_cpu(crc));
4083 xfs_hex_dump(dp, 32); 4083 xfs_hex_dump(dp, 32);
diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
index 8174aad0b388..fb6709191811 100644
--- a/fs/xfs/xfs_qm_syscalls.c
+++ b/fs/xfs/xfs_qm_syscalls.c
@@ -287,7 +287,7 @@ xfs_qm_scall_trunc_qfiles(
287 int error = 0, error2 = 0; 287 int error = 0, error2 = 0;
288 288
289 if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0) { 289 if (!xfs_sb_version_hasquota(&mp->m_sb) || flags == 0) {
290 xfs_debug(mp, "%s: flags=%x m_qflags=%x\n", 290 xfs_debug(mp, "%s: flags=%x m_qflags=%x",
291 __func__, flags, mp->m_qflags); 291 __func__, flags, mp->m_qflags);
292 return XFS_ERROR(EINVAL); 292 return XFS_ERROR(EINVAL);
293 } 293 }
@@ -325,7 +325,7 @@ xfs_qm_scall_quotaon(
325 sbflags = 0; 325 sbflags = 0;
326 326
327 if (flags == 0) { 327 if (flags == 0) {
328 xfs_debug(mp, "%s: zero flags, m_qflags=%x\n", 328 xfs_debug(mp, "%s: zero flags, m_qflags=%x",
329 __func__, mp->m_qflags); 329 __func__, mp->m_qflags);
330 return XFS_ERROR(EINVAL); 330 return XFS_ERROR(EINVAL);
331 } 331 }
@@ -348,7 +348,7 @@ xfs_qm_scall_quotaon(
348 (mp->m_sb.sb_qflags & XFS_PQUOTA_ACCT) == 0 && 348 (mp->m_sb.sb_qflags & XFS_PQUOTA_ACCT) == 0 &&
349 (flags & XFS_PQUOTA_ENFD))) { 349 (flags & XFS_PQUOTA_ENFD))) {
350 xfs_debug(mp, 350 xfs_debug(mp,
351 "%s: Can't enforce without acct, flags=%x sbflags=%x\n", 351 "%s: Can't enforce without acct, flags=%x sbflags=%x",
352 __func__, flags, mp->m_sb.sb_qflags); 352 __func__, flags, mp->m_sb.sb_qflags);
353 return XFS_ERROR(EINVAL); 353 return XFS_ERROR(EINVAL);
354 } 354 }
@@ -648,7 +648,7 @@ xfs_qm_scall_setqlim(
648 q->qi_bsoftlimit = soft; 648 q->qi_bsoftlimit = soft;
649 } 649 }
650 } else { 650 } else {
651 xfs_debug(mp, "blkhard %Ld < blksoft %Ld\n", hard, soft); 651 xfs_debug(mp, "blkhard %Ld < blksoft %Ld", hard, soft);
652 } 652 }
653 hard = (newlim->d_fieldmask & FS_DQ_RTBHARD) ? 653 hard = (newlim->d_fieldmask & FS_DQ_RTBHARD) ?
654 (xfs_qcnt_t) XFS_BB_TO_FSB(mp, newlim->d_rtb_hardlimit) : 654 (xfs_qcnt_t) XFS_BB_TO_FSB(mp, newlim->d_rtb_hardlimit) :
@@ -664,7 +664,7 @@ xfs_qm_scall_setqlim(
664 q->qi_rtbsoftlimit = soft; 664 q->qi_rtbsoftlimit = soft;
665 } 665 }
666 } else { 666 } else {
667 xfs_debug(mp, "rtbhard %Ld < rtbsoft %Ld\n", hard, soft); 667 xfs_debug(mp, "rtbhard %Ld < rtbsoft %Ld", hard, soft);
668 } 668 }
669 669
670 hard = (newlim->d_fieldmask & FS_DQ_IHARD) ? 670 hard = (newlim->d_fieldmask & FS_DQ_IHARD) ?
@@ -681,7 +681,7 @@ xfs_qm_scall_setqlim(
681 q->qi_isoftlimit = soft; 681 q->qi_isoftlimit = soft;
682 } 682 }
683 } else { 683 } else {
684 xfs_debug(mp, "ihard %Ld < isoft %Ld\n", hard, soft); 684 xfs_debug(mp, "ihard %Ld < isoft %Ld", hard, soft);
685 } 685 }
686 686
687 /* 687 /*
diff --git a/fs/xfs/xfs_sb.c b/fs/xfs/xfs_sb.c
index a5b59d92eb70..a89d0bcc7959 100644
--- a/fs/xfs/xfs_sb.c
+++ b/fs/xfs/xfs_sb.c
@@ -249,13 +249,13 @@ xfs_mount_validate_sb(
249 if (xfs_sb_version_has_pquotino(sbp)) { 249 if (xfs_sb_version_has_pquotino(sbp)) {
250 if (sbp->sb_qflags & (XFS_OQUOTA_ENFD | XFS_OQUOTA_CHKD)) { 250 if (sbp->sb_qflags & (XFS_OQUOTA_ENFD | XFS_OQUOTA_CHKD)) {
251 xfs_notice(mp, 251 xfs_notice(mp,
252 "Version 5 of Super block has XFS_OQUOTA bits.\n"); 252 "Version 5 of Super block has XFS_OQUOTA bits.");
253 return XFS_ERROR(EFSCORRUPTED); 253 return XFS_ERROR(EFSCORRUPTED);
254 } 254 }
255 } else if (sbp->sb_qflags & (XFS_PQUOTA_ENFD | XFS_GQUOTA_ENFD | 255 } else if (sbp->sb_qflags & (XFS_PQUOTA_ENFD | XFS_GQUOTA_ENFD |
256 XFS_PQUOTA_CHKD | XFS_GQUOTA_CHKD)) { 256 XFS_PQUOTA_CHKD | XFS_GQUOTA_CHKD)) {
257 xfs_notice(mp, 257 xfs_notice(mp,
258"Superblock earlier than Version 5 has XFS_[PQ]UOTA_{ENFD|CHKD} bits.\n"); 258"Superblock earlier than Version 5 has XFS_[PQ]UOTA_{ENFD|CHKD} bits.");
259 return XFS_ERROR(EFSCORRUPTED); 259 return XFS_ERROR(EFSCORRUPTED);
260 } 260 }
261 261
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 938e50fe6c61..c2e3e9535b26 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1241,7 +1241,7 @@ xfs_fs_remount(
1241 */ 1241 */
1242#if 0 1242#if 0
1243 xfs_info(mp, 1243 xfs_info(mp,
1244 "mount option \"%s\" not supported for remount\n", p); 1244 "mount option \"%s\" not supported for remount", p);
1245 return -EINVAL; 1245 return -EINVAL;
1246#else 1246#else
1247 break; 1247 break;