diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:31 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-25 17:48:31 -0400 |
commit | 08813d35d2ac6f304a53eb3a9ee59283fa7cc67f (patch) | |
tree | d3b3887302b24ea14848e0f1cac9db5281960e59 | |
parent | 2385f3c3c757b6ffb766c320df4a7f7a45593f24 (diff) |
USB: yealink.c: remove err() usage
err() was a very old USB-specific macro that I thought had
gone away. This patch removes it from being used in the
driver and uses dev_err() instead.
CC: Henk Vergonet <Henk.Vergonet@gmail.com>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/input/misc/yealink.c | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c index f4776e7f8c15..4984823b3681 100644 --- a/drivers/input/misc/yealink.c +++ b/drivers/input/misc/yealink.c | |||
@@ -428,7 +428,8 @@ static void urb_irq_callback(struct urb *urb) | |||
428 | int ret, status = urb->status; | 428 | int ret, status = urb->status; |
429 | 429 | ||
430 | if (status) | 430 | if (status) |
431 | err("%s - urb status %d", __func__, status); | 431 | dev_err(&yld->udev->dev, "%s - urb status %d\n", |
432 | __func__, status); | ||
432 | 433 | ||
433 | switch (yld->irq_data->cmd) { | 434 | switch (yld->irq_data->cmd) { |
434 | case CMD_KEYPRESS: | 435 | case CMD_KEYPRESS: |
@@ -443,7 +444,8 @@ static void urb_irq_callback(struct urb *urb) | |||
443 | break; | 444 | break; |
444 | 445 | ||
445 | default: | 446 | default: |
446 | err("unexpected response %x", yld->irq_data->cmd); | 447 | dev_err(&yld->udev->dev, "unexpected response %x\n", |
448 | yld->irq_data->cmd); | ||
447 | } | 449 | } |
448 | 450 | ||
449 | yealink_do_idle_tasks(yld); | 451 | yealink_do_idle_tasks(yld); |
@@ -451,7 +453,9 @@ static void urb_irq_callback(struct urb *urb) | |||
451 | if (!yld->shutdown) { | 453 | if (!yld->shutdown) { |
452 | ret = usb_submit_urb(yld->urb_ctl, GFP_ATOMIC); | 454 | ret = usb_submit_urb(yld->urb_ctl, GFP_ATOMIC); |
453 | if (ret && ret != -EPERM) | 455 | if (ret && ret != -EPERM) |
454 | err("%s - usb_submit_urb failed %d", __func__, ret); | 456 | dev_err(&yld->udev->dev, |
457 | "%s - usb_submit_urb failed %d\n", | ||
458 | __func__, ret); | ||
455 | } | 459 | } |
456 | } | 460 | } |
457 | 461 | ||
@@ -461,7 +465,8 @@ static void urb_ctl_callback(struct urb *urb) | |||
461 | int ret = 0, status = urb->status; | 465 | int ret = 0, status = urb->status; |
462 | 466 | ||
463 | if (status) | 467 | if (status) |
464 | err("%s - urb status %d", __func__, status); | 468 | dev_err(&yld->udev->dev, "%s - urb status %d\n", |
469 | __func__, status); | ||
465 | 470 | ||
466 | switch (yld->ctl_data->cmd) { | 471 | switch (yld->ctl_data->cmd) { |
467 | case CMD_KEYPRESS: | 472 | case CMD_KEYPRESS: |
@@ -479,7 +484,8 @@ static void urb_ctl_callback(struct urb *urb) | |||
479 | } | 484 | } |
480 | 485 | ||
481 | if (ret && ret != -EPERM) | 486 | if (ret && ret != -EPERM) |
482 | err("%s - usb_submit_urb failed %d", __func__, ret); | 487 | dev_err(&yld->udev->dev, "%s - usb_submit_urb failed %d\n", |
488 | __func__, ret); | ||
483 | } | 489 | } |
484 | 490 | ||
485 | /******************************************************************************* | 491 | /******************************************************************************* |
@@ -909,7 +915,8 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) | |||
909 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); | 915 | pipe = usb_rcvintpipe(udev, endpoint->bEndpointAddress); |
910 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); | 916 | ret = usb_maxpacket(udev, pipe, usb_pipeout(pipe)); |
911 | if (ret != USB_PKT_LEN) | 917 | if (ret != USB_PKT_LEN) |
912 | err("invalid payload size %d, expected %zd", ret, USB_PKT_LEN); | 918 | dev_err(&intf->dev, "invalid payload size %d, expected %zd\n", |
919 | ret, USB_PKT_LEN); | ||
913 | 920 | ||
914 | /* initialise irq urb */ | 921 | /* initialise irq urb */ |
915 | usb_fill_int_urb(yld->urb_irq, udev, pipe, yld->irq_data, | 922 | usb_fill_int_urb(yld->urb_irq, udev, pipe, yld->irq_data, |