diff options
author | Axel Lin <axel.lin@gmail.com> | 2012-06-07 22:29:21 -0400 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2012-06-17 16:04:45 -0400 |
commit | 07b9e329f99397d01e4789d64aa2f581a7c94b03 (patch) | |
tree | e8fd36f96c52a0e9e4ccbfb5c31c44f693555f34 | |
parent | 7142e2138b088da429d94859df0ed05b1b82607c (diff) |
regulator: ab8500: Remove min_uV and max_uV from struct ab8500_regulator_info
The min_uV and max_uV are not really used in the code and misleading because
the min_uV and max_uV settings does not match the value in the voltage table.
For example, we have
static const unsigned int ldo_vaux3_voltages[] = {
1200000,
1500000,
1800000,
2100000,
2500000,
2750000,
2790000,
2910000,
};
With below min_uV/max_uV settings for AB8500_LDO_AUX3.
.min_uV = 1100000,
.max_uV = 3300000,
The min_uV/max_uV for AB8500_LDO_AUX3 seems copy-paste from AB8500_LDO_AUX2
and is wrong.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r-- | drivers/regulator/ab8500.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c index c931c7c0ad1b..13d424fc1c14 100644 --- a/drivers/regulator/ab8500.c +++ b/drivers/regulator/ab8500.c | |||
@@ -30,8 +30,6 @@ | |||
30 | * @dev: device pointer | 30 | * @dev: device pointer |
31 | * @desc: regulator description | 31 | * @desc: regulator description |
32 | * @regulator_dev: regulator device | 32 | * @regulator_dev: regulator device |
33 | * @max_uV: maximum voltage (for variable voltage supplies) | ||
34 | * @min_uV: minimum voltage (for variable voltage supplies) | ||
35 | * @update_bank: bank to control on/off | 33 | * @update_bank: bank to control on/off |
36 | * @update_reg: register to control on/off | 34 | * @update_reg: register to control on/off |
37 | * @update_mask: mask to enable/disable regulator | 35 | * @update_mask: mask to enable/disable regulator |
@@ -45,8 +43,6 @@ struct ab8500_regulator_info { | |||
45 | struct device *dev; | 43 | struct device *dev; |
46 | struct regulator_desc desc; | 44 | struct regulator_desc desc; |
47 | struct regulator_dev *regulator; | 45 | struct regulator_dev *regulator; |
48 | int max_uV; | ||
49 | int min_uV; | ||
50 | u8 update_bank; | 46 | u8 update_bank; |
51 | u8 update_reg; | 47 | u8 update_reg; |
52 | u8 update_mask; | 48 | u8 update_mask; |
@@ -301,8 +297,6 @@ static struct ab8500_regulator_info | |||
301 | .n_voltages = ARRAY_SIZE(ldo_vauxn_voltages), | 297 | .n_voltages = ARRAY_SIZE(ldo_vauxn_voltages), |
302 | .volt_table = ldo_vauxn_voltages, | 298 | .volt_table = ldo_vauxn_voltages, |
303 | }, | 299 | }, |
304 | .min_uV = 1100000, | ||
305 | .max_uV = 3300000, | ||
306 | .update_bank = 0x04, | 300 | .update_bank = 0x04, |
307 | .update_reg = 0x09, | 301 | .update_reg = 0x09, |
308 | .update_mask = 0x03, | 302 | .update_mask = 0x03, |
@@ -321,8 +315,6 @@ static struct ab8500_regulator_info | |||
321 | .n_voltages = ARRAY_SIZE(ldo_vauxn_voltages), | 315 | .n_voltages = ARRAY_SIZE(ldo_vauxn_voltages), |
322 | .volt_table = ldo_vauxn_voltages, | 316 | .volt_table = ldo_vauxn_voltages, |
323 | }, | 317 | }, |
324 | .min_uV = 1100000, | ||
325 | .max_uV = 3300000, | ||
326 | .update_bank = 0x04, | 318 | .update_bank = 0x04, |
327 | .update_reg = 0x09, | 319 | .update_reg = 0x09, |
328 | .update_mask = 0x0c, | 320 | .update_mask = 0x0c, |
@@ -341,8 +333,6 @@ static struct ab8500_regulator_info | |||
341 | .n_voltages = ARRAY_SIZE(ldo_vaux3_voltages), | 333 | .n_voltages = ARRAY_SIZE(ldo_vaux3_voltages), |
342 | .volt_table = ldo_vaux3_voltages, | 334 | .volt_table = ldo_vaux3_voltages, |
343 | }, | 335 | }, |
344 | .min_uV = 1100000, | ||
345 | .max_uV = 3300000, | ||
346 | .update_bank = 0x04, | 336 | .update_bank = 0x04, |
347 | .update_reg = 0x0a, | 337 | .update_reg = 0x0a, |
348 | .update_mask = 0x03, | 338 | .update_mask = 0x03, |
@@ -361,8 +351,6 @@ static struct ab8500_regulator_info | |||
361 | .n_voltages = ARRAY_SIZE(ldo_vintcore_voltages), | 351 | .n_voltages = ARRAY_SIZE(ldo_vintcore_voltages), |
362 | .volt_table = ldo_vintcore_voltages, | 352 | .volt_table = ldo_vintcore_voltages, |
363 | }, | 353 | }, |
364 | .min_uV = 1100000, | ||
365 | .max_uV = 3300000, | ||
366 | .update_bank = 0x03, | 354 | .update_bank = 0x03, |
367 | .update_reg = 0x80, | 355 | .update_reg = 0x80, |
368 | .update_mask = 0x44, | 356 | .update_mask = 0x44, |