diff options
author | Jiri Olsa <jolsa@kernel.org> | 2014-11-21 04:31:08 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-12-01 18:00:30 -0500 |
commit | 060c4f9c8cc871a96dfacdc9306101e8b9195805 (patch) | |
tree | d3b830fbe4aa3368222caf6bcabb9cc0bca1d899 | |
parent | 1d9e446b91e182055d874fbb30150aad479a4981 (diff) |
perf stat: Use perf_evsel__read_cb in read_counter
Replacing __perf_evsel__read_on_cpu function with perf_evsel__read_cb
function. The read_cb callback will be used later for global aggregation
counter values as well.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1416562275-12404-5-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-stat.c | 27 |
1 files changed, 21 insertions, 6 deletions
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 055ce9232c9e..9cc0db1d7f06 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c | |||
@@ -388,6 +388,26 @@ static void update_shadow_stats(struct perf_evsel *counter, u64 *count) | |||
388 | update_stats(&runtime_itlb_cache_stats[0], count[0]); | 388 | update_stats(&runtime_itlb_cache_stats[0], count[0]); |
389 | } | 389 | } |
390 | 390 | ||
391 | static int read_cb(struct perf_evsel *evsel, int cpu, int thread __maybe_unused, | ||
392 | struct perf_counts_values *count) | ||
393 | { | ||
394 | switch (aggr_mode) { | ||
395 | case AGGR_CORE: | ||
396 | case AGGR_SOCKET: | ||
397 | case AGGR_NONE: | ||
398 | perf_evsel__compute_deltas(evsel, cpu, count); | ||
399 | perf_counts_values__scale(count, scale, NULL); | ||
400 | evsel->counts->cpu[cpu] = *count; | ||
401 | update_shadow_stats(evsel, count->values); | ||
402 | break; | ||
403 | case AGGR_GLOBAL: | ||
404 | default: | ||
405 | break; | ||
406 | } | ||
407 | |||
408 | return 0; | ||
409 | } | ||
410 | |||
391 | /* | 411 | /* |
392 | * Read out the results of a single counter: | 412 | * Read out the results of a single counter: |
393 | * aggregate counts across CPUs in system-wide mode | 413 | * aggregate counts across CPUs in system-wide mode |
@@ -424,16 +444,11 @@ static int read_counter_aggr(struct perf_evsel *counter) | |||
424 | */ | 444 | */ |
425 | static int read_counter(struct perf_evsel *counter) | 445 | static int read_counter(struct perf_evsel *counter) |
426 | { | 446 | { |
427 | u64 *count; | ||
428 | int cpu; | 447 | int cpu; |
429 | 448 | ||
430 | for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { | 449 | for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { |
431 | if (__perf_evsel__read_on_cpu(counter, cpu, 0, scale) < 0) | 450 | if (perf_evsel__read_cb(counter, cpu, 0, read_cb)) |
432 | return -1; | 451 | return -1; |
433 | |||
434 | count = counter->counts->cpu[cpu].values; | ||
435 | |||
436 | update_shadow_stats(counter, count); | ||
437 | } | 452 | } |
438 | 453 | ||
439 | return 0; | 454 | return 0; |