diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-03-15 21:28:30 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-03-15 21:28:30 -0400 |
| commit | 0586bed3e8563c2eb89bc7256e30ce633ae06cfb (patch) | |
| tree | 7a59610f45f7222f25b3212c53fa28636bb4427c | |
| parent | b80cd62b7d4406bbe8c573fe4381dcc71a2850fd (diff) | |
| parent | dbebbfbb1605f0179e7c0d900d941cc9c45de569 (diff) | |
Merge branch 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip
* 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
rtmutex: tester: Remove the remaining BKL leftovers
lockdep/timers: Explain in detail the locking problems del_timer_sync() may cause
rtmutex: Simplify PI algorithm and make highest prio task get lock
rwsem: Remove redundant asmregparm annotation
rwsem: Move duplicate function prototypes to linux/rwsem.h
rwsem: Unify the duplicate rwsem_is_locked() inlines
rwsem: Move duplicate init macros and functions to linux/rwsem.h
rwsem: Move duplicate struct rwsem declaration to linux/rwsem.h
x86: Cleanup rwsem_count_t typedef
rwsem: Cleanup includes
locking: Remove deprecated lock initializers
cred: Replace deprecated spinlock initialization
kthread: Replace deprecated spinlock initialization
xtensa: Replace deprecated spinlock initialization
um: Replace deprecated spinlock initialization
sparc: Replace deprecated spinlock initialization
mips: Replace deprecated spinlock initialization
cris: Replace deprecated spinlock initialization
alpha: Replace deprecated spinlock initialization
rtmutex-tester: Remove BKL tests
40 files changed, 228 insertions, 816 deletions
diff --git a/Documentation/spinlocks.txt b/Documentation/spinlocks.txt index 178c831b907d..2e3c64b1a6a5 100644 --- a/Documentation/spinlocks.txt +++ b/Documentation/spinlocks.txt | |||
| @@ -86,7 +86,7 @@ to change the variables it has to get an exclusive write lock. | |||
| 86 | 86 | ||
| 87 | The routines look the same as above: | 87 | The routines look the same as above: |
| 88 | 88 | ||
| 89 | rwlock_t xxx_lock = RW_LOCK_UNLOCKED; | 89 | rwlock_t xxx_lock = __RW_LOCK_UNLOCKED(xxx_lock); |
| 90 | 90 | ||
| 91 | unsigned long flags; | 91 | unsigned long flags; |
| 92 | 92 | ||
| @@ -196,25 +196,3 @@ appropriate: | |||
| 196 | 196 | ||
| 197 | For static initialization, use DEFINE_SPINLOCK() / DEFINE_RWLOCK() or | 197 | For static initialization, use DEFINE_SPINLOCK() / DEFINE_RWLOCK() or |
| 198 | __SPIN_LOCK_UNLOCKED() / __RW_LOCK_UNLOCKED() as appropriate. | 198 | __SPIN_LOCK_UNLOCKED() / __RW_LOCK_UNLOCKED() as appropriate. |
| 199 | |||
| 200 | SPIN_LOCK_UNLOCKED and RW_LOCK_UNLOCKED are deprecated. These interfere | ||
| 201 | with lockdep state tracking. | ||
| 202 | |||
| 203 | Most of the time, you can simply turn: | ||
| 204 | static spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED; | ||
| 205 | into: | ||
| 206 | static DEFINE_SPINLOCK(xxx_lock); | ||
| 207 | |||
| 208 | Static structure member variables go from: | ||
| 209 | |||
| 210 | struct foo bar { | ||
| 211 | .lock = SPIN_LOCK_UNLOCKED; | ||
| 212 | }; | ||
| 213 | |||
| 214 | to: | ||
| 215 | |||
| 216 | struct foo bar { | ||
| 217 | .lock = __SPIN_LOCK_UNLOCKED(bar.lock); | ||
| 218 | }; | ||
| 219 | |||
| 220 | Declaration of static rw_locks undergo a similar transformation. | ||
diff --git a/arch/alpha/include/asm/rwsem.h b/arch/alpha/include/asm/rwsem.h index 1570c0b54336..a83bbea62c67 100644 --- a/arch/alpha/include/asm/rwsem.h +++ b/arch/alpha/include/asm/rwsem.h | |||
| @@ -13,44 +13,13 @@ | |||
| 13 | #ifdef __KERNEL__ | 13 | #ifdef __KERNEL__ |
| 14 | 14 | ||
| 15 | #include <linux/compiler.h> | 15 | #include <linux/compiler.h> |
| 16 | #include <linux/list.h> | ||
| 17 | #include <linux/spinlock.h> | ||
| 18 | 16 | ||
| 19 | struct rwsem_waiter; | ||
| 20 | |||
| 21 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 22 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 23 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *); | ||
| 24 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 25 | |||
| 26 | /* | ||
| 27 | * the semaphore definition | ||
| 28 | */ | ||
| 29 | struct rw_semaphore { | ||
| 30 | long count; | ||
| 31 | #define RWSEM_UNLOCKED_VALUE 0x0000000000000000L | 17 | #define RWSEM_UNLOCKED_VALUE 0x0000000000000000L |
| 32 | #define RWSEM_ACTIVE_BIAS 0x0000000000000001L | 18 | #define RWSEM_ACTIVE_BIAS 0x0000000000000001L |
| 33 | #define RWSEM_ACTIVE_MASK 0x00000000ffffffffL | 19 | #define RWSEM_ACTIVE_MASK 0x00000000ffffffffL |
| 34 | #define RWSEM_WAITING_BIAS (-0x0000000100000000L) | 20 | #define RWSEM_WAITING_BIAS (-0x0000000100000000L) |
| 35 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 21 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 36 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 22 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 37 | spinlock_t wait_lock; | ||
| 38 | struct list_head wait_list; | ||
| 39 | }; | ||
| 40 | |||
| 41 | #define __RWSEM_INITIALIZER(name) \ | ||
| 42 | { RWSEM_UNLOCKED_VALUE, SPIN_LOCK_UNLOCKED, \ | ||
| 43 | LIST_HEAD_INIT((name).wait_list) } | ||
| 44 | |||
| 45 | #define DECLARE_RWSEM(name) \ | ||
| 46 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 47 | |||
| 48 | static inline void init_rwsem(struct rw_semaphore *sem) | ||
| 49 | { | ||
| 50 | sem->count = RWSEM_UNLOCKED_VALUE; | ||
| 51 | spin_lock_init(&sem->wait_lock); | ||
| 52 | INIT_LIST_HEAD(&sem->wait_list); | ||
| 53 | } | ||
| 54 | 23 | ||
| 55 | static inline void __down_read(struct rw_semaphore *sem) | 24 | static inline void __down_read(struct rw_semaphore *sem) |
| 56 | { | 25 | { |
| @@ -250,10 +219,5 @@ static inline long rwsem_atomic_update(long val, struct rw_semaphore *sem) | |||
| 250 | #endif | 219 | #endif |
| 251 | } | 220 | } |
| 252 | 221 | ||
| 253 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 254 | { | ||
| 255 | return (sem->count != 0); | ||
| 256 | } | ||
| 257 | |||
| 258 | #endif /* __KERNEL__ */ | 222 | #endif /* __KERNEL__ */ |
| 259 | #endif /* _ALPHA_RWSEM_H */ | 223 | #endif /* _ALPHA_RWSEM_H */ |
diff --git a/arch/cris/arch-v32/kernel/smp.c b/arch/cris/arch-v32/kernel/smp.c index 84fed3b4b079..4c9e3e1ba5d1 100644 --- a/arch/cris/arch-v32/kernel/smp.c +++ b/arch/cris/arch-v32/kernel/smp.c | |||
| @@ -26,7 +26,9 @@ | |||
| 26 | #define FLUSH_ALL (void*)0xffffffff | 26 | #define FLUSH_ALL (void*)0xffffffff |
| 27 | 27 | ||
| 28 | /* Vector of locks used for various atomic operations */ | 28 | /* Vector of locks used for various atomic operations */ |
| 29 | spinlock_t cris_atomic_locks[] = { [0 ... LOCK_COUNT - 1] = SPIN_LOCK_UNLOCKED}; | 29 | spinlock_t cris_atomic_locks[] = { |
| 30 | [0 ... LOCK_COUNT - 1] = __SPIN_LOCK_UNLOCKED(cris_atomic_locks) | ||
| 31 | }; | ||
| 30 | 32 | ||
| 31 | /* CPU masks */ | 33 | /* CPU masks */ |
| 32 | cpumask_t phys_cpu_present_map = CPU_MASK_NONE; | 34 | cpumask_t phys_cpu_present_map = CPU_MASK_NONE; |
diff --git a/arch/ia64/include/asm/rwsem.h b/arch/ia64/include/asm/rwsem.h index 215d5454c7d3..3027e7516d85 100644 --- a/arch/ia64/include/asm/rwsem.h +++ b/arch/ia64/include/asm/rwsem.h | |||
| @@ -25,20 +25,8 @@ | |||
| 25 | #error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead." | 25 | #error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead." |
| 26 | #endif | 26 | #endif |
| 27 | 27 | ||
| 28 | #include <linux/list.h> | ||
| 29 | #include <linux/spinlock.h> | ||
| 30 | |||
| 31 | #include <asm/intrinsics.h> | 28 | #include <asm/intrinsics.h> |
| 32 | 29 | ||
| 33 | /* | ||
| 34 | * the semaphore definition | ||
| 35 | */ | ||
| 36 | struct rw_semaphore { | ||
| 37 | signed long count; | ||
| 38 | spinlock_t wait_lock; | ||
| 39 | struct list_head wait_list; | ||
| 40 | }; | ||
| 41 | |||
| 42 | #define RWSEM_UNLOCKED_VALUE __IA64_UL_CONST(0x0000000000000000) | 30 | #define RWSEM_UNLOCKED_VALUE __IA64_UL_CONST(0x0000000000000000) |
| 43 | #define RWSEM_ACTIVE_BIAS (1L) | 31 | #define RWSEM_ACTIVE_BIAS (1L) |
| 44 | #define RWSEM_ACTIVE_MASK (0xffffffffL) | 32 | #define RWSEM_ACTIVE_MASK (0xffffffffL) |
| @@ -46,26 +34,6 @@ struct rw_semaphore { | |||
| 46 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 34 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 47 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 35 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 48 | 36 | ||
| 49 | #define __RWSEM_INITIALIZER(name) \ | ||
| 50 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait_lock), \ | ||
| 51 | LIST_HEAD_INIT((name).wait_list) } | ||
| 52 | |||
| 53 | #define DECLARE_RWSEM(name) \ | ||
| 54 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 55 | |||
| 56 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 57 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 58 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem); | ||
| 59 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 60 | |||
| 61 | static inline void | ||
| 62 | init_rwsem (struct rw_semaphore *sem) | ||
| 63 | { | ||
| 64 | sem->count = RWSEM_UNLOCKED_VALUE; | ||
| 65 | spin_lock_init(&sem->wait_lock); | ||
| 66 | INIT_LIST_HEAD(&sem->wait_list); | ||
| 67 | } | ||
| 68 | |||
| 69 | /* | 37 | /* |
| 70 | * lock for reading | 38 | * lock for reading |
| 71 | */ | 39 | */ |
| @@ -174,9 +142,4 @@ __downgrade_write (struct rw_semaphore *sem) | |||
| 174 | #define rwsem_atomic_add(delta, sem) atomic64_add(delta, (atomic64_t *)(&(sem)->count)) | 142 | #define rwsem_atomic_add(delta, sem) atomic64_add(delta, (atomic64_t *)(&(sem)->count)) |
| 175 | #define rwsem_atomic_update(delta, sem) atomic64_add_return(delta, (atomic64_t *)(&(sem)->count)) | 143 | #define rwsem_atomic_update(delta, sem) atomic64_add_return(delta, (atomic64_t *)(&(sem)->count)) |
| 176 | 144 | ||
| 177 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 178 | { | ||
| 179 | return (sem->count != 0); | ||
| 180 | } | ||
| 181 | |||
| 182 | #endif /* _ASM_IA64_RWSEM_H */ | 145 | #endif /* _ASM_IA64_RWSEM_H */ |
diff --git a/arch/powerpc/include/asm/rwsem.h b/arch/powerpc/include/asm/rwsem.h index 8447d89fbe72..bb1e2cdeb9bf 100644 --- a/arch/powerpc/include/asm/rwsem.h +++ b/arch/powerpc/include/asm/rwsem.h | |||
| @@ -13,11 +13,6 @@ | |||
| 13 | * by Paul Mackerras <paulus@samba.org>. | 13 | * by Paul Mackerras <paulus@samba.org>. |
| 14 | */ | 14 | */ |
| 15 | 15 | ||
| 16 | #include <linux/list.h> | ||
| 17 | #include <linux/spinlock.h> | ||
| 18 | #include <asm/atomic.h> | ||
| 19 | #include <asm/system.h> | ||
| 20 | |||
| 21 | /* | 16 | /* |
| 22 | * the semaphore definition | 17 | * the semaphore definition |
| 23 | */ | 18 | */ |
| @@ -33,47 +28,6 @@ | |||
| 33 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 28 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 34 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 29 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 35 | 30 | ||
| 36 | struct rw_semaphore { | ||
| 37 | long count; | ||
| 38 | spinlock_t wait_lock; | ||
| 39 | struct list_head wait_list; | ||
| 40 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 41 | struct lockdep_map dep_map; | ||
| 42 | #endif | ||
| 43 | }; | ||
| 44 | |||
| 45 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 46 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 47 | #else | ||
| 48 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 49 | #endif | ||
| 50 | |||
| 51 | #define __RWSEM_INITIALIZER(name) \ | ||
| 52 | { \ | ||
| 53 | RWSEM_UNLOCKED_VALUE, \ | ||
| 54 | __SPIN_LOCK_UNLOCKED((name).wait_lock), \ | ||
| 55 | LIST_HEAD_INIT((name).wait_list) \ | ||
| 56 | __RWSEM_DEP_MAP_INIT(name) \ | ||
| 57 | } | ||
| 58 | |||
| 59 | #define DECLARE_RWSEM(name) \ | ||
| 60 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 61 | |||
| 62 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 63 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 64 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem); | ||
| 65 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 66 | |||
| 67 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 68 | struct lock_class_key *key); | ||
| 69 | |||
| 70 | #define init_rwsem(sem) \ | ||
| 71 | do { \ | ||
| 72 | static struct lock_class_key __key; \ | ||
| 73 | \ | ||
| 74 | __init_rwsem((sem), #sem, &__key); \ | ||
| 75 | } while (0) | ||
| 76 | |||
| 77 | /* | 31 | /* |
| 78 | * lock for reading | 32 | * lock for reading |
| 79 | */ | 33 | */ |
| @@ -174,10 +128,5 @@ static inline long rwsem_atomic_update(long delta, struct rw_semaphore *sem) | |||
| 174 | return atomic_long_add_return(delta, (atomic_long_t *)&sem->count); | 128 | return atomic_long_add_return(delta, (atomic_long_t *)&sem->count); |
| 175 | } | 129 | } |
| 176 | 130 | ||
| 177 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 178 | { | ||
| 179 | return sem->count != 0; | ||
| 180 | } | ||
| 181 | |||
| 182 | #endif /* __KERNEL__ */ | 131 | #endif /* __KERNEL__ */ |
| 183 | #endif /* _ASM_POWERPC_RWSEM_H */ | 132 | #endif /* _ASM_POWERPC_RWSEM_H */ |
diff --git a/arch/s390/include/asm/rwsem.h b/arch/s390/include/asm/rwsem.h index 423fdda2322d..d0eb4653cebd 100644 --- a/arch/s390/include/asm/rwsem.h +++ b/arch/s390/include/asm/rwsem.h | |||
| @@ -43,29 +43,6 @@ | |||
| 43 | 43 | ||
| 44 | #ifdef __KERNEL__ | 44 | #ifdef __KERNEL__ |
| 45 | 45 | ||
| 46 | #include <linux/list.h> | ||
| 47 | #include <linux/spinlock.h> | ||
| 48 | |||
| 49 | struct rwsem_waiter; | ||
| 50 | |||
| 51 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *); | ||
| 52 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *); | ||
| 53 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *); | ||
| 54 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *); | ||
| 55 | extern struct rw_semaphore *rwsem_downgrade_write(struct rw_semaphore *); | ||
| 56 | |||
| 57 | /* | ||
| 58 | * the semaphore definition | ||
| 59 | */ | ||
| 60 | struct rw_semaphore { | ||
| 61 | signed long count; | ||
| 62 | spinlock_t wait_lock; | ||
| 63 | struct list_head wait_list; | ||
| 64 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 65 | struct lockdep_map dep_map; | ||
| 66 | #endif | ||
| 67 | }; | ||
| 68 | |||
| 69 | #ifndef __s390x__ | 46 | #ifndef __s390x__ |
| 70 | #define RWSEM_UNLOCKED_VALUE 0x00000000 | 47 | #define RWSEM_UNLOCKED_VALUE 0x00000000 |
| 71 | #define RWSEM_ACTIVE_BIAS 0x00000001 | 48 | #define RWSEM_ACTIVE_BIAS 0x00000001 |
| @@ -81,41 +58,6 @@ struct rw_semaphore { | |||
| 81 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 58 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 82 | 59 | ||
| 83 | /* | 60 | /* |
| 84 | * initialisation | ||
| 85 | */ | ||
| 86 | |||
| 87 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 88 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 89 | #else | ||
| 90 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 91 | #endif | ||
| 92 | |||
| 93 | #define __RWSEM_INITIALIZER(name) \ | ||
| 94 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait.lock), \ | ||
| 95 | LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) } | ||
| 96 | |||
| 97 | #define DECLARE_RWSEM(name) \ | ||
| 98 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 99 | |||
| 100 | static inline void init_rwsem(struct rw_semaphore *sem) | ||
| 101 | { | ||
| 102 | sem->count = RWSEM_UNLOCKED_VALUE; | ||
| 103 | spin_lock_init(&sem->wait_lock); | ||
| 104 | INIT_LIST_HEAD(&sem->wait_list); | ||
| 105 | } | ||
| 106 | |||
| 107 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 108 | struct lock_class_key *key); | ||
| 109 | |||
| 110 | #define init_rwsem(sem) \ | ||
| 111 | do { \ | ||
| 112 | static struct lock_class_key __key; \ | ||
| 113 | \ | ||
| 114 | __init_rwsem((sem), #sem, &__key); \ | ||
| 115 | } while (0) | ||
| 116 | |||
| 117 | |||
| 118 | /* | ||
| 119 | * lock for reading | 61 | * lock for reading |
| 120 | */ | 62 | */ |
| 121 | static inline void __down_read(struct rw_semaphore *sem) | 63 | static inline void __down_read(struct rw_semaphore *sem) |
| @@ -377,10 +319,5 @@ static inline long rwsem_atomic_update(long delta, struct rw_semaphore *sem) | |||
| 377 | return new; | 319 | return new; |
| 378 | } | 320 | } |
| 379 | 321 | ||
| 380 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 381 | { | ||
| 382 | return (sem->count != 0); | ||
| 383 | } | ||
| 384 | |||
| 385 | #endif /* __KERNEL__ */ | 322 | #endif /* __KERNEL__ */ |
| 386 | #endif /* _S390_RWSEM_H */ | 323 | #endif /* _S390_RWSEM_H */ |
diff --git a/arch/sh/include/asm/rwsem.h b/arch/sh/include/asm/rwsem.h index 06e2251a5e48..edab57265293 100644 --- a/arch/sh/include/asm/rwsem.h +++ b/arch/sh/include/asm/rwsem.h | |||
| @@ -11,64 +11,13 @@ | |||
| 11 | #endif | 11 | #endif |
| 12 | 12 | ||
| 13 | #ifdef __KERNEL__ | 13 | #ifdef __KERNEL__ |
| 14 | #include <linux/list.h> | ||
| 15 | #include <linux/spinlock.h> | ||
| 16 | #include <asm/atomic.h> | ||
| 17 | #include <asm/system.h> | ||
| 18 | 14 | ||
| 19 | /* | ||
| 20 | * the semaphore definition | ||
| 21 | */ | ||
| 22 | struct rw_semaphore { | ||
| 23 | long count; | ||
| 24 | #define RWSEM_UNLOCKED_VALUE 0x00000000 | 15 | #define RWSEM_UNLOCKED_VALUE 0x00000000 |
| 25 | #define RWSEM_ACTIVE_BIAS 0x00000001 | 16 | #define RWSEM_ACTIVE_BIAS 0x00000001 |
| 26 | #define RWSEM_ACTIVE_MASK 0x0000ffff | 17 | #define RWSEM_ACTIVE_MASK 0x0000ffff |
| 27 | #define RWSEM_WAITING_BIAS (-0x00010000) | 18 | #define RWSEM_WAITING_BIAS (-0x00010000) |
| 28 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 19 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 29 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 20 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 30 | spinlock_t wait_lock; | ||
| 31 | struct list_head wait_list; | ||
| 32 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 33 | struct lockdep_map dep_map; | ||
| 34 | #endif | ||
| 35 | }; | ||
| 36 | |||
| 37 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 38 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 39 | #else | ||
| 40 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 41 | #endif | ||
| 42 | |||
| 43 | #define __RWSEM_INITIALIZER(name) \ | ||
| 44 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait_lock), \ | ||
| 45 | LIST_HEAD_INIT((name).wait_list) \ | ||
| 46 | __RWSEM_DEP_MAP_INIT(name) } | ||
| 47 | |||
| 48 | #define DECLARE_RWSEM(name) \ | ||
| 49 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 50 | |||
| 51 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 52 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 53 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem); | ||
| 54 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 55 | |||
| 56 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 57 | struct lock_class_key *key); | ||
| 58 | |||
| 59 | #define init_rwsem(sem) \ | ||
| 60 | do { \ | ||
| 61 | static struct lock_class_key __key; \ | ||
| 62 | \ | ||
| 63 | __init_rwsem((sem), #sem, &__key); \ | ||
| 64 | } while (0) | ||
| 65 | |||
| 66 | static inline void init_rwsem(struct rw_semaphore *sem) | ||
| 67 | { | ||
| 68 | sem->count = RWSEM_UNLOCKED_VALUE; | ||
| 69 | spin_lock_init(&sem->wait_lock); | ||
| 70 | INIT_LIST_HEAD(&sem->wait_list); | ||
| 71 | } | ||
| 72 | 21 | ||
| 73 | /* | 22 | /* |
| 74 | * lock for reading | 23 | * lock for reading |
| @@ -179,10 +128,5 @@ static inline int rwsem_atomic_update(int delta, struct rw_semaphore *sem) | |||
| 179 | return atomic_add_return(delta, (atomic_t *)(&sem->count)); | 128 | return atomic_add_return(delta, (atomic_t *)(&sem->count)); |
| 180 | } | 129 | } |
| 181 | 130 | ||
| 182 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 183 | { | ||
| 184 | return (sem->count != 0); | ||
| 185 | } | ||
| 186 | |||
| 187 | #endif /* __KERNEL__ */ | 131 | #endif /* __KERNEL__ */ |
| 188 | #endif /* _ASM_SH_RWSEM_H */ | 132 | #endif /* _ASM_SH_RWSEM_H */ |
diff --git a/arch/sparc/include/asm/rwsem.h b/arch/sparc/include/asm/rwsem.h index a2b4302869bc..069bf4d663a1 100644 --- a/arch/sparc/include/asm/rwsem.h +++ b/arch/sparc/include/asm/rwsem.h | |||
| @@ -13,53 +13,12 @@ | |||
| 13 | 13 | ||
| 14 | #ifdef __KERNEL__ | 14 | #ifdef __KERNEL__ |
| 15 | 15 | ||
| 16 | #include <linux/list.h> | ||
| 17 | #include <linux/spinlock.h> | ||
| 18 | |||
| 19 | struct rwsem_waiter; | ||
| 20 | |||
| 21 | struct rw_semaphore { | ||
| 22 | signed long count; | ||
| 23 | #define RWSEM_UNLOCKED_VALUE 0x00000000L | 16 | #define RWSEM_UNLOCKED_VALUE 0x00000000L |
| 24 | #define RWSEM_ACTIVE_BIAS 0x00000001L | 17 | #define RWSEM_ACTIVE_BIAS 0x00000001L |
| 25 | #define RWSEM_ACTIVE_MASK 0xffffffffL | 18 | #define RWSEM_ACTIVE_MASK 0xffffffffL |
| 26 | #define RWSEM_WAITING_BIAS (-RWSEM_ACTIVE_MASK-1) | 19 | #define RWSEM_WAITING_BIAS (-RWSEM_ACTIVE_MASK-1) |
| 27 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 20 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 28 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 21 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 29 | spinlock_t wait_lock; | ||
| 30 | struct list_head wait_list; | ||
| 31 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 32 | struct lockdep_map dep_map; | ||
| 33 | #endif | ||
| 34 | }; | ||
| 35 | |||
| 36 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 37 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 38 | #else | ||
| 39 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 40 | #endif | ||
| 41 | |||
| 42 | #define __RWSEM_INITIALIZER(name) \ | ||
| 43 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait_lock), \ | ||
| 44 | LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) } | ||
| 45 | |||
| 46 | #define DECLARE_RWSEM(name) \ | ||
| 47 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 48 | |||
| 49 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 50 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 51 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem); | ||
| 52 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 53 | |||
| 54 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 55 | struct lock_class_key *key); | ||
| 56 | |||
| 57 | #define init_rwsem(sem) \ | ||
| 58 | do { \ | ||
| 59 | static struct lock_class_key __key; \ | ||
| 60 | \ | ||
| 61 | __init_rwsem((sem), #sem, &__key); \ | ||
| 62 | } while (0) | ||
| 63 | 22 | ||
| 64 | /* | 23 | /* |
| 65 | * lock for reading | 24 | * lock for reading |
| @@ -160,11 +119,6 @@ static inline long rwsem_atomic_update(long delta, struct rw_semaphore *sem) | |||
| 160 | return atomic64_add_return(delta, (atomic64_t *)(&sem->count)); | 119 | return atomic64_add_return(delta, (atomic64_t *)(&sem->count)); |
| 161 | } | 120 | } |
| 162 | 121 | ||
| 163 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 164 | { | ||
| 165 | return (sem->count != 0); | ||
| 166 | } | ||
| 167 | |||
| 168 | #endif /* __KERNEL__ */ | 122 | #endif /* __KERNEL__ */ |
| 169 | 123 | ||
| 170 | #endif /* _SPARC64_RWSEM_H */ | 124 | #endif /* _SPARC64_RWSEM_H */ |
diff --git a/arch/sparc/lib/atomic32.c b/arch/sparc/lib/atomic32.c index cbddeb38ffda..d3c7a12ad879 100644 --- a/arch/sparc/lib/atomic32.c +++ b/arch/sparc/lib/atomic32.c | |||
| @@ -16,7 +16,7 @@ | |||
| 16 | #define ATOMIC_HASH(a) (&__atomic_hash[(((unsigned long)a)>>8) & (ATOMIC_HASH_SIZE-1)]) | 16 | #define ATOMIC_HASH(a) (&__atomic_hash[(((unsigned long)a)>>8) & (ATOMIC_HASH_SIZE-1)]) |
| 17 | 17 | ||
| 18 | spinlock_t __atomic_hash[ATOMIC_HASH_SIZE] = { | 18 | spinlock_t __atomic_hash[ATOMIC_HASH_SIZE] = { |
| 19 | [0 ... (ATOMIC_HASH_SIZE-1)] = SPIN_LOCK_UNLOCKED | 19 | [0 ... (ATOMIC_HASH_SIZE-1)] = __SPIN_LOCK_UNLOCKED(__atomic_hash) |
| 20 | }; | 20 | }; |
| 21 | 21 | ||
| 22 | #else /* SMP */ | 22 | #else /* SMP */ |
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index ba4a98ba39c0..620f5b70957d 100644 --- a/arch/um/drivers/ubd_kern.c +++ b/arch/um/drivers/ubd_kern.c | |||
| @@ -185,7 +185,7 @@ struct ubd { | |||
| 185 | .no_cow = 0, \ | 185 | .no_cow = 0, \ |
| 186 | .shared = 0, \ | 186 | .shared = 0, \ |
| 187 | .cow = DEFAULT_COW, \ | 187 | .cow = DEFAULT_COW, \ |
| 188 | .lock = SPIN_LOCK_UNLOCKED, \ | 188 | .lock = __SPIN_LOCK_UNLOCKED(ubd_devs.lock), \ |
| 189 | .request = NULL, \ | 189 | .request = NULL, \ |
| 190 | .start_sg = 0, \ | 190 | .start_sg = 0, \ |
| 191 | .end_sg = 0, \ | 191 | .end_sg = 0, \ |
diff --git a/arch/x86/include/asm/rwsem.h b/arch/x86/include/asm/rwsem.h index d1e41b0f9b60..df4cd32b4cc6 100644 --- a/arch/x86/include/asm/rwsem.h +++ b/arch/x86/include/asm/rwsem.h | |||
| @@ -37,26 +37,9 @@ | |||
| 37 | #endif | 37 | #endif |
| 38 | 38 | ||
| 39 | #ifdef __KERNEL__ | 39 | #ifdef __KERNEL__ |
| 40 | |||
| 41 | #include <linux/list.h> | ||
| 42 | #include <linux/spinlock.h> | ||
| 43 | #include <linux/lockdep.h> | ||
| 44 | #include <asm/asm.h> | 40 | #include <asm/asm.h> |
| 45 | 41 | ||
| 46 | struct rwsem_waiter; | ||
| 47 | |||
| 48 | extern asmregparm struct rw_semaphore * | ||
| 49 | rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 50 | extern asmregparm struct rw_semaphore * | ||
| 51 | rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 52 | extern asmregparm struct rw_semaphore * | ||
| 53 | rwsem_wake(struct rw_semaphore *); | ||
| 54 | extern asmregparm struct rw_semaphore * | ||
| 55 | rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 56 | |||
| 57 | /* | 42 | /* |
| 58 | * the semaphore definition | ||
| 59 | * | ||
| 60 | * The bias values and the counter type limits the number of | 43 | * The bias values and the counter type limits the number of |
| 61 | * potential readers/writers to 32767 for 32 bits and 2147483647 | 44 | * potential readers/writers to 32767 for 32 bits and 2147483647 |
| 62 | * for 64 bits. | 45 | * for 64 bits. |
| @@ -74,43 +57,6 @@ extern asmregparm struct rw_semaphore * | |||
| 74 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 57 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 75 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 58 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 76 | 59 | ||
| 77 | typedef signed long rwsem_count_t; | ||
| 78 | |||
| 79 | struct rw_semaphore { | ||
| 80 | rwsem_count_t count; | ||
| 81 | spinlock_t wait_lock; | ||
| 82 | struct list_head wait_list; | ||
| 83 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 84 | struct lockdep_map dep_map; | ||
| 85 | #endif | ||
| 86 | }; | ||
| 87 | |||
| 88 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 89 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 90 | #else | ||
| 91 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 92 | #endif | ||
| 93 | |||
| 94 | |||
| 95 | #define __RWSEM_INITIALIZER(name) \ | ||
| 96 | { \ | ||
| 97 | RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED((name).wait_lock), \ | ||
| 98 | LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) \ | ||
| 99 | } | ||
| 100 | |||
| 101 | #define DECLARE_RWSEM(name) \ | ||
| 102 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 103 | |||
| 104 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 105 | struct lock_class_key *key); | ||
| 106 | |||
| 107 | #define init_rwsem(sem) \ | ||
| 108 | do { \ | ||
| 109 | static struct lock_class_key __key; \ | ||
| 110 | \ | ||
| 111 | __init_rwsem((sem), #sem, &__key); \ | ||
| 112 | } while (0) | ||
| 113 | |||
| 114 | /* | 60 | /* |
| 115 | * lock for reading | 61 | * lock for reading |
| 116 | */ | 62 | */ |
| @@ -133,7 +79,7 @@ static inline void __down_read(struct rw_semaphore *sem) | |||
| 133 | */ | 79 | */ |
| 134 | static inline int __down_read_trylock(struct rw_semaphore *sem) | 80 | static inline int __down_read_trylock(struct rw_semaphore *sem) |
| 135 | { | 81 | { |
| 136 | rwsem_count_t result, tmp; | 82 | long result, tmp; |
| 137 | asm volatile("# beginning __down_read_trylock\n\t" | 83 | asm volatile("# beginning __down_read_trylock\n\t" |
| 138 | " mov %0,%1\n\t" | 84 | " mov %0,%1\n\t" |
| 139 | "1:\n\t" | 85 | "1:\n\t" |
| @@ -155,7 +101,7 @@ static inline int __down_read_trylock(struct rw_semaphore *sem) | |||
| 155 | */ | 101 | */ |
| 156 | static inline void __down_write_nested(struct rw_semaphore *sem, int subclass) | 102 | static inline void __down_write_nested(struct rw_semaphore *sem, int subclass) |
| 157 | { | 103 | { |
| 158 | rwsem_count_t tmp; | 104 | long tmp; |
| 159 | asm volatile("# beginning down_write\n\t" | 105 | asm volatile("# beginning down_write\n\t" |
| 160 | LOCK_PREFIX " xadd %1,(%2)\n\t" | 106 | LOCK_PREFIX " xadd %1,(%2)\n\t" |
| 161 | /* adds 0xffff0001, returns the old value */ | 107 | /* adds 0xffff0001, returns the old value */ |
| @@ -180,9 +126,8 @@ static inline void __down_write(struct rw_semaphore *sem) | |||
| 180 | */ | 126 | */ |
| 181 | static inline int __down_write_trylock(struct rw_semaphore *sem) | 127 | static inline int __down_write_trylock(struct rw_semaphore *sem) |
| 182 | { | 128 | { |
| 183 | rwsem_count_t ret = cmpxchg(&sem->count, | 129 | long ret = cmpxchg(&sem->count, RWSEM_UNLOCKED_VALUE, |
| 184 | RWSEM_UNLOCKED_VALUE, | 130 | RWSEM_ACTIVE_WRITE_BIAS); |
| 185 | RWSEM_ACTIVE_WRITE_BIAS); | ||
| 186 | if (ret == RWSEM_UNLOCKED_VALUE) | 131 | if (ret == RWSEM_UNLOCKED_VALUE) |
| 187 | return 1; | 132 | return 1; |
| 188 | return 0; | 133 | return 0; |
| @@ -193,7 +138,7 @@ static inline int __down_write_trylock(struct rw_semaphore *sem) | |||
| 193 | */ | 138 | */ |
| 194 | static inline void __up_read(struct rw_semaphore *sem) | 139 | static inline void __up_read(struct rw_semaphore *sem) |
| 195 | { | 140 | { |
| 196 | rwsem_count_t tmp; | 141 | long tmp; |
| 197 | asm volatile("# beginning __up_read\n\t" | 142 | asm volatile("# beginning __up_read\n\t" |
| 198 | LOCK_PREFIX " xadd %1,(%2)\n\t" | 143 | LOCK_PREFIX " xadd %1,(%2)\n\t" |
| 199 | /* subtracts 1, returns the old value */ | 144 | /* subtracts 1, returns the old value */ |
| @@ -211,7 +156,7 @@ static inline void __up_read(struct rw_semaphore *sem) | |||
| 211 | */ | 156 | */ |
| 212 | static inline void __up_write(struct rw_semaphore *sem) | 157 | static inline void __up_write(struct rw_semaphore *sem) |
| 213 | { | 158 | { |
| 214 | rwsem_count_t tmp; | 159 | long tmp; |
| 215 | asm volatile("# beginning __up_write\n\t" | 160 | asm volatile("# beginning __up_write\n\t" |
| 216 | LOCK_PREFIX " xadd %1,(%2)\n\t" | 161 | LOCK_PREFIX " xadd %1,(%2)\n\t" |
| 217 | /* subtracts 0xffff0001, returns the old value */ | 162 | /* subtracts 0xffff0001, returns the old value */ |
| @@ -247,8 +192,7 @@ static inline void __downgrade_write(struct rw_semaphore *sem) | |||
| 247 | /* | 192 | /* |
| 248 | * implement atomic add functionality | 193 | * implement atomic add functionality |
| 249 | */ | 194 | */ |
| 250 | static inline void rwsem_atomic_add(rwsem_count_t delta, | 195 | static inline void rwsem_atomic_add(long delta, struct rw_semaphore *sem) |
| 251 | struct rw_semaphore *sem) | ||
| 252 | { | 196 | { |
| 253 | asm volatile(LOCK_PREFIX _ASM_ADD "%1,%0" | 197 | asm volatile(LOCK_PREFIX _ASM_ADD "%1,%0" |
| 254 | : "+m" (sem->count) | 198 | : "+m" (sem->count) |
| @@ -258,10 +202,9 @@ static inline void rwsem_atomic_add(rwsem_count_t delta, | |||
| 258 | /* | 202 | /* |
| 259 | * implement exchange and add functionality | 203 | * implement exchange and add functionality |
| 260 | */ | 204 | */ |
| 261 | static inline rwsem_count_t rwsem_atomic_update(rwsem_count_t delta, | 205 | static inline long rwsem_atomic_update(long delta, struct rw_semaphore *sem) |
| 262 | struct rw_semaphore *sem) | ||
| 263 | { | 206 | { |
| 264 | rwsem_count_t tmp = delta; | 207 | long tmp = delta; |
| 265 | 208 | ||
| 266 | asm volatile(LOCK_PREFIX "xadd %0,%1" | 209 | asm volatile(LOCK_PREFIX "xadd %0,%1" |
| 267 | : "+r" (tmp), "+m" (sem->count) | 210 | : "+r" (tmp), "+m" (sem->count) |
| @@ -270,10 +213,5 @@ static inline rwsem_count_t rwsem_atomic_update(rwsem_count_t delta, | |||
| 270 | return tmp + delta; | 213 | return tmp + delta; |
| 271 | } | 214 | } |
| 272 | 215 | ||
| 273 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 274 | { | ||
| 275 | return (sem->count != 0); | ||
| 276 | } | ||
| 277 | |||
| 278 | #endif /* __KERNEL__ */ | 216 | #endif /* __KERNEL__ */ |
| 279 | #endif /* _ASM_X86_RWSEM_H */ | 217 | #endif /* _ASM_X86_RWSEM_H */ |
diff --git a/arch/xtensa/include/asm/rwsem.h b/arch/xtensa/include/asm/rwsem.h index e39edf5c86f2..249619e7e7f2 100644 --- a/arch/xtensa/include/asm/rwsem.h +++ b/arch/xtensa/include/asm/rwsem.h | |||
| @@ -17,44 +17,12 @@ | |||
| 17 | #error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead." | 17 | #error "Please don't include <asm/rwsem.h> directly, use <linux/rwsem.h> instead." |
| 18 | #endif | 18 | #endif |
| 19 | 19 | ||
| 20 | #include <linux/list.h> | ||
| 21 | #include <linux/spinlock.h> | ||
| 22 | #include <asm/atomic.h> | ||
| 23 | #include <asm/system.h> | ||
| 24 | |||
| 25 | /* | ||
| 26 | * the semaphore definition | ||
| 27 | */ | ||
| 28 | struct rw_semaphore { | ||
| 29 | signed long count; | ||
| 30 | #define RWSEM_UNLOCKED_VALUE 0x00000000 | 20 | #define RWSEM_UNLOCKED_VALUE 0x00000000 |
| 31 | #define RWSEM_ACTIVE_BIAS 0x00000001 | 21 | #define RWSEM_ACTIVE_BIAS 0x00000001 |
| 32 | #define RWSEM_ACTIVE_MASK 0x0000ffff | 22 | #define RWSEM_ACTIVE_MASK 0x0000ffff |
| 33 | #define RWSEM_WAITING_BIAS (-0x00010000) | 23 | #define RWSEM_WAITING_BIAS (-0x00010000) |
| 34 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS | 24 | #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS |
| 35 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) | 25 | #define RWSEM_ACTIVE_WRITE_BIAS (RWSEM_WAITING_BIAS + RWSEM_ACTIVE_BIAS) |
| 36 | spinlock_t wait_lock; | ||
| 37 | struct list_head wait_list; | ||
| 38 | }; | ||
| 39 | |||
| 40 | #define __RWSEM_INITIALIZER(name) \ | ||
| 41 | { RWSEM_UNLOCKED_VALUE, SPIN_LOCK_UNLOCKED, \ | ||
| 42 | LIST_HEAD_INIT((name).wait_list) } | ||
| 43 | |||
| 44 | #define DECLARE_RWSEM(name) \ | ||
| 45 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 46 | |||
| 47 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 48 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 49 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem); | ||
| 50 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 51 | |||
| 52 | static inline void init_rwsem(struct rw_semaphore *sem) | ||
| 53 | { | ||
| 54 | sem->count = RWSEM_UNLOCKED_VALUE; | ||
| 55 | spin_lock_init(&sem->wait_lock); | ||
| 56 | INIT_LIST_HEAD(&sem->wait_list); | ||
| 57 | } | ||
| 58 | 26 | ||
| 59 | /* | 27 | /* |
| 60 | * lock for reading | 28 | * lock for reading |
| @@ -160,9 +128,4 @@ static inline int rwsem_atomic_update(int delta, struct rw_semaphore *sem) | |||
| 160 | return atomic_add_return(delta, (atomic_t *)(&sem->count)); | 128 | return atomic_add_return(delta, (atomic_t *)(&sem->count)); |
| 161 | } | 129 | } |
| 162 | 130 | ||
| 163 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 164 | { | ||
| 165 | return (sem->count != 0); | ||
| 166 | } | ||
| 167 | |||
| 168 | #endif /* _XTENSA_RWSEM_H */ | 131 | #endif /* _XTENSA_RWSEM_H */ |
diff --git a/include/linux/kthread.h b/include/linux/kthread.h index ce0775aa64c3..7ff16f7d3ed4 100644 --- a/include/linux/kthread.h +++ b/include/linux/kthread.h | |||
| @@ -64,7 +64,7 @@ struct kthread_work { | |||
| 64 | }; | 64 | }; |
| 65 | 65 | ||
| 66 | #define KTHREAD_WORKER_INIT(worker) { \ | 66 | #define KTHREAD_WORKER_INIT(worker) { \ |
| 67 | .lock = SPIN_LOCK_UNLOCKED, \ | 67 | .lock = __SPIN_LOCK_UNLOCKED((worker).lock), \ |
| 68 | .work_list = LIST_HEAD_INIT((worker).work_list), \ | 68 | .work_list = LIST_HEAD_INIT((worker).work_list), \ |
| 69 | } | 69 | } |
| 70 | 70 | ||
diff --git a/include/linux/rwlock_types.h b/include/linux/rwlock_types.h index bd31808c7d8e..cc0072e93e36 100644 --- a/include/linux/rwlock_types.h +++ b/include/linux/rwlock_types.h | |||
| @@ -43,14 +43,6 @@ typedef struct { | |||
| 43 | RW_DEP_MAP_INIT(lockname) } | 43 | RW_DEP_MAP_INIT(lockname) } |
| 44 | #endif | 44 | #endif |
| 45 | 45 | ||
| 46 | /* | ||
| 47 | * RW_LOCK_UNLOCKED defeat lockdep state tracking and is hence | ||
| 48 | * deprecated. | ||
| 49 | * | ||
| 50 | * Please use DEFINE_RWLOCK() or __RW_LOCK_UNLOCKED() as appropriate. | ||
| 51 | */ | ||
| 52 | #define RW_LOCK_UNLOCKED __RW_LOCK_UNLOCKED(old_style_rw_init) | ||
| 53 | |||
| 54 | #define DEFINE_RWLOCK(x) rwlock_t x = __RW_LOCK_UNLOCKED(x) | 46 | #define DEFINE_RWLOCK(x) rwlock_t x = __RW_LOCK_UNLOCKED(x) |
| 55 | 47 | ||
| 56 | #endif /* __LINUX_RWLOCK_TYPES_H */ | 48 | #endif /* __LINUX_RWLOCK_TYPES_H */ |
diff --git a/include/linux/rwsem-spinlock.h b/include/linux/rwsem-spinlock.h index bdfcc2527970..34701241b673 100644 --- a/include/linux/rwsem-spinlock.h +++ b/include/linux/rwsem-spinlock.h | |||
| @@ -12,15 +12,7 @@ | |||
| 12 | #error "please don't include linux/rwsem-spinlock.h directly, use linux/rwsem.h instead" | 12 | #error "please don't include linux/rwsem-spinlock.h directly, use linux/rwsem.h instead" |
| 13 | #endif | 13 | #endif |
| 14 | 14 | ||
| 15 | #include <linux/spinlock.h> | ||
| 16 | #include <linux/list.h> | ||
| 17 | |||
| 18 | #ifdef __KERNEL__ | 15 | #ifdef __KERNEL__ |
| 19 | |||
| 20 | #include <linux/types.h> | ||
| 21 | |||
| 22 | struct rwsem_waiter; | ||
| 23 | |||
| 24 | /* | 16 | /* |
| 25 | * the rw-semaphore definition | 17 | * the rw-semaphore definition |
| 26 | * - if activity is 0 then there are no active readers or writers | 18 | * - if activity is 0 then there are no active readers or writers |
| @@ -37,28 +29,7 @@ struct rw_semaphore { | |||
| 37 | #endif | 29 | #endif |
| 38 | }; | 30 | }; |
| 39 | 31 | ||
| 40 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | 32 | #define RWSEM_UNLOCKED_VALUE 0x00000000 |
| 41 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 42 | #else | ||
| 43 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 44 | #endif | ||
| 45 | |||
| 46 | #define __RWSEM_INITIALIZER(name) \ | ||
| 47 | { 0, __SPIN_LOCK_UNLOCKED(name.wait_lock), LIST_HEAD_INIT((name).wait_list) \ | ||
| 48 | __RWSEM_DEP_MAP_INIT(name) } | ||
| 49 | |||
| 50 | #define DECLARE_RWSEM(name) \ | ||
| 51 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 52 | |||
| 53 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 54 | struct lock_class_key *key); | ||
| 55 | |||
| 56 | #define init_rwsem(sem) \ | ||
| 57 | do { \ | ||
| 58 | static struct lock_class_key __key; \ | ||
| 59 | \ | ||
| 60 | __init_rwsem((sem), #sem, &__key); \ | ||
| 61 | } while (0) | ||
| 62 | 33 | ||
| 63 | extern void __down_read(struct rw_semaphore *sem); | 34 | extern void __down_read(struct rw_semaphore *sem); |
| 64 | extern int __down_read_trylock(struct rw_semaphore *sem); | 35 | extern int __down_read_trylock(struct rw_semaphore *sem); |
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h index efd348fe8ca7..a8afe9cd000c 100644 --- a/include/linux/rwsem.h +++ b/include/linux/rwsem.h | |||
| @@ -11,6 +11,9 @@ | |||
| 11 | 11 | ||
| 12 | #include <linux/types.h> | 12 | #include <linux/types.h> |
| 13 | #include <linux/kernel.h> | 13 | #include <linux/kernel.h> |
| 14 | #include <linux/list.h> | ||
| 15 | #include <linux/spinlock.h> | ||
| 16 | |||
| 14 | #include <asm/system.h> | 17 | #include <asm/system.h> |
| 15 | #include <asm/atomic.h> | 18 | #include <asm/atomic.h> |
| 16 | 19 | ||
| @@ -19,9 +22,57 @@ struct rw_semaphore; | |||
| 19 | #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK | 22 | #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK |
| 20 | #include <linux/rwsem-spinlock.h> /* use a generic implementation */ | 23 | #include <linux/rwsem-spinlock.h> /* use a generic implementation */ |
| 21 | #else | 24 | #else |
| 22 | #include <asm/rwsem.h> /* use an arch-specific implementation */ | 25 | /* All arch specific implementations share the same struct */ |
| 26 | struct rw_semaphore { | ||
| 27 | long count; | ||
| 28 | spinlock_t wait_lock; | ||
| 29 | struct list_head wait_list; | ||
| 30 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 31 | struct lockdep_map dep_map; | ||
| 32 | #endif | ||
| 33 | }; | ||
| 34 | |||
| 35 | extern struct rw_semaphore *rwsem_down_read_failed(struct rw_semaphore *sem); | ||
| 36 | extern struct rw_semaphore *rwsem_down_write_failed(struct rw_semaphore *sem); | ||
| 37 | extern struct rw_semaphore *rwsem_wake(struct rw_semaphore *); | ||
| 38 | extern struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem); | ||
| 39 | |||
| 40 | /* Include the arch specific part */ | ||
| 41 | #include <asm/rwsem.h> | ||
| 42 | |||
| 43 | /* In all implementations count != 0 means locked */ | ||
| 44 | static inline int rwsem_is_locked(struct rw_semaphore *sem) | ||
| 45 | { | ||
| 46 | return sem->count != 0; | ||
| 47 | } | ||
| 48 | |||
| 49 | #endif | ||
| 50 | |||
| 51 | /* Common initializer macros and functions */ | ||
| 52 | |||
| 53 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
| 54 | # define __RWSEM_DEP_MAP_INIT(lockname) , .dep_map = { .name = #lockname } | ||
| 55 | #else | ||
| 56 | # define __RWSEM_DEP_MAP_INIT(lockname) | ||
| 23 | #endif | 57 | #endif |
| 24 | 58 | ||
| 59 | #define __RWSEM_INITIALIZER(name) \ | ||
| 60 | { RWSEM_UNLOCKED_VALUE, __SPIN_LOCK_UNLOCKED(name.wait_lock), \ | ||
| 61 | LIST_HEAD_INIT((name).wait_list) __RWSEM_DEP_MAP_INIT(name) } | ||
| 62 | |||
| 63 | #define DECLARE_RWSEM(name) \ | ||
| 64 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | ||
| 65 | |||
| 66 | extern void __init_rwsem(struct rw_semaphore *sem, const char *name, | ||
| 67 | struct lock_class_key *key); | ||
| 68 | |||
| 69 | #define init_rwsem(sem) \ | ||
| 70 | do { \ | ||
| 71 | static struct lock_class_key __key; \ | ||
| 72 | \ | ||
| 73 | __init_rwsem((sem), #sem, &__key); \ | ||
| 74 | } while (0) | ||
| 75 | |||
| 25 | /* | 76 | /* |
| 26 | * lock for reading | 77 | * lock for reading |
| 27 | */ | 78 | */ |
diff --git a/include/linux/spinlock_types.h b/include/linux/spinlock_types.h index 851b7783720d..73548eb13a5d 100644 --- a/include/linux/spinlock_types.h +++ b/include/linux/spinlock_types.h | |||
| @@ -81,14 +81,6 @@ typedef struct spinlock { | |||
| 81 | #define __SPIN_LOCK_UNLOCKED(lockname) \ | 81 | #define __SPIN_LOCK_UNLOCKED(lockname) \ |
| 82 | (spinlock_t ) __SPIN_LOCK_INITIALIZER(lockname) | 82 | (spinlock_t ) __SPIN_LOCK_INITIALIZER(lockname) |
| 83 | 83 | ||
| 84 | /* | ||
| 85 | * SPIN_LOCK_UNLOCKED defeats lockdep state tracking and is hence | ||
| 86 | * deprecated. | ||
| 87 | * Please use DEFINE_SPINLOCK() or __SPIN_LOCK_UNLOCKED() as | ||
| 88 | * appropriate. | ||
| 89 | */ | ||
| 90 | #define SPIN_LOCK_UNLOCKED __SPIN_LOCK_UNLOCKED(old_style_spin_init) | ||
| 91 | |||
| 92 | #define DEFINE_SPINLOCK(x) spinlock_t x = __SPIN_LOCK_UNLOCKED(x) | 84 | #define DEFINE_SPINLOCK(x) spinlock_t x = __SPIN_LOCK_UNLOCKED(x) |
| 93 | 85 | ||
| 94 | #include <linux/rwlock_types.h> | 86 | #include <linux/rwlock_types.h> |
diff --git a/kernel/cred.c b/kernel/cred.c index 3a9d6dd53a6c..2343c132c5a7 100644 --- a/kernel/cred.c +++ b/kernel/cred.c | |||
| @@ -35,7 +35,7 @@ static struct kmem_cache *cred_jar; | |||
| 35 | static struct thread_group_cred init_tgcred = { | 35 | static struct thread_group_cred init_tgcred = { |
| 36 | .usage = ATOMIC_INIT(2), | 36 | .usage = ATOMIC_INIT(2), |
| 37 | .tgid = 0, | 37 | .tgid = 0, |
| 38 | .lock = SPIN_LOCK_UNLOCKED, | 38 | .lock = __SPIN_LOCK_UNLOCKED(init_cred.tgcred.lock), |
| 39 | }; | 39 | }; |
| 40 | #endif | 40 | #endif |
| 41 | 41 | ||
diff --git a/kernel/futex.c b/kernel/futex.c index e9251d934f7d..bda415715382 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
| @@ -1555,10 +1555,10 @@ static int fixup_pi_state_owner(u32 __user *uaddr, struct futex_q *q, | |||
| 1555 | 1555 | ||
| 1556 | /* | 1556 | /* |
| 1557 | * We are here either because we stole the rtmutex from the | 1557 | * We are here either because we stole the rtmutex from the |
| 1558 | * pending owner or we are the pending owner which failed to | 1558 | * previous highest priority waiter or we are the highest priority |
| 1559 | * get the rtmutex. We have to replace the pending owner TID | 1559 | * waiter but failed to get the rtmutex the first time. |
| 1560 | * in the user space variable. This must be atomic as we have | 1560 | * We have to replace the newowner TID in the user space variable. |
| 1561 | * to preserve the owner died bit here. | 1561 | * This must be atomic as we have to preserve the owner died bit here. |
| 1562 | * | 1562 | * |
| 1563 | * Note: We write the user space value _before_ changing the pi_state | 1563 | * Note: We write the user space value _before_ changing the pi_state |
| 1564 | * because we can fault here. Imagine swapped out pages or a fork | 1564 | * because we can fault here. Imagine swapped out pages or a fork |
| @@ -1605,8 +1605,8 @@ retry: | |||
| 1605 | 1605 | ||
| 1606 | /* | 1606 | /* |
| 1607 | * To handle the page fault we need to drop the hash bucket | 1607 | * To handle the page fault we need to drop the hash bucket |
| 1608 | * lock here. That gives the other task (either the pending | 1608 | * lock here. That gives the other task (either the highest priority |
| 1609 | * owner itself or the task which stole the rtmutex) the | 1609 | * waiter itself or the task which stole the rtmutex) the |
| 1610 | * chance to try the fixup of the pi_state. So once we are | 1610 | * chance to try the fixup of the pi_state. So once we are |
| 1611 | * back from handling the fault we need to check the pi_state | 1611 | * back from handling the fault we need to check the pi_state |
| 1612 | * after reacquiring the hash bucket lock and before trying to | 1612 | * after reacquiring the hash bucket lock and before trying to |
| @@ -1682,18 +1682,20 @@ static int fixup_owner(u32 __user *uaddr, struct futex_q *q, int locked) | |||
| 1682 | /* | 1682 | /* |
| 1683 | * pi_state is incorrect, some other task did a lock steal and | 1683 | * pi_state is incorrect, some other task did a lock steal and |
| 1684 | * we returned due to timeout or signal without taking the | 1684 | * we returned due to timeout or signal without taking the |
| 1685 | * rt_mutex. Too late. We can access the rt_mutex_owner without | 1685 | * rt_mutex. Too late. |
| 1686 | * locking, as the other task is now blocked on the hash bucket | ||
| 1687 | * lock. Fix the state up. | ||
| 1688 | */ | 1686 | */ |
| 1687 | raw_spin_lock(&q->pi_state->pi_mutex.wait_lock); | ||
| 1689 | owner = rt_mutex_owner(&q->pi_state->pi_mutex); | 1688 | owner = rt_mutex_owner(&q->pi_state->pi_mutex); |
| 1689 | if (!owner) | ||
| 1690 | owner = rt_mutex_next_owner(&q->pi_state->pi_mutex); | ||
| 1691 | raw_spin_unlock(&q->pi_state->pi_mutex.wait_lock); | ||
| 1690 | ret = fixup_pi_state_owner(uaddr, q, owner); | 1692 | ret = fixup_pi_state_owner(uaddr, q, owner); |
| 1691 | goto out; | 1693 | goto out; |
| 1692 | } | 1694 | } |
| 1693 | 1695 | ||
| 1694 | /* | 1696 | /* |
| 1695 | * Paranoia check. If we did not take the lock, then we should not be | 1697 | * Paranoia check. If we did not take the lock, then we should not be |
| 1696 | * the owner, nor the pending owner, of the rt_mutex. | 1698 | * the owner of the rt_mutex. |
| 1697 | */ | 1699 | */ |
| 1698 | if (rt_mutex_owner(&q->pi_state->pi_mutex) == current) | 1700 | if (rt_mutex_owner(&q->pi_state->pi_mutex) == current) |
| 1699 | printk(KERN_ERR "fixup_owner: ret = %d pi-mutex: %p " | 1701 | printk(KERN_ERR "fixup_owner: ret = %d pi-mutex: %p " |
diff --git a/kernel/rtmutex-debug.c b/kernel/rtmutex-debug.c index ddabb54bb5c8..3c7cbc2c33be 100644 --- a/kernel/rtmutex-debug.c +++ b/kernel/rtmutex-debug.c | |||
| @@ -215,7 +215,6 @@ void debug_rt_mutex_free_waiter(struct rt_mutex_waiter *waiter) | |||
| 215 | put_pid(waiter->deadlock_task_pid); | 215 | put_pid(waiter->deadlock_task_pid); |
| 216 | TRACE_WARN_ON(!plist_node_empty(&waiter->list_entry)); | 216 | TRACE_WARN_ON(!plist_node_empty(&waiter->list_entry)); |
| 217 | TRACE_WARN_ON(!plist_node_empty(&waiter->pi_list_entry)); | 217 | TRACE_WARN_ON(!plist_node_empty(&waiter->pi_list_entry)); |
| 218 | TRACE_WARN_ON(waiter->task); | ||
| 219 | memset(waiter, 0x22, sizeof(*waiter)); | 218 | memset(waiter, 0x22, sizeof(*waiter)); |
| 220 | } | 219 | } |
| 221 | 220 | ||
diff --git a/kernel/rtmutex-tester.c b/kernel/rtmutex-tester.c index 66cb89bc5ef1..5c9ccd380966 100644 --- a/kernel/rtmutex-tester.c +++ b/kernel/rtmutex-tester.c | |||
| @@ -9,7 +9,6 @@ | |||
| 9 | #include <linux/kthread.h> | 9 | #include <linux/kthread.h> |
| 10 | #include <linux/module.h> | 10 | #include <linux/module.h> |
| 11 | #include <linux/sched.h> | 11 | #include <linux/sched.h> |
| 12 | #include <linux/smp_lock.h> | ||
| 13 | #include <linux/spinlock.h> | 12 | #include <linux/spinlock.h> |
| 14 | #include <linux/sysdev.h> | 13 | #include <linux/sysdev.h> |
| 15 | #include <linux/timer.h> | 14 | #include <linux/timer.h> |
| @@ -27,7 +26,6 @@ struct test_thread_data { | |||
| 27 | int opcode; | 26 | int opcode; |
| 28 | int opdata; | 27 | int opdata; |
| 29 | int mutexes[MAX_RT_TEST_MUTEXES]; | 28 | int mutexes[MAX_RT_TEST_MUTEXES]; |
| 30 | int bkl; | ||
| 31 | int event; | 29 | int event; |
| 32 | struct sys_device sysdev; | 30 | struct sys_device sysdev; |
| 33 | }; | 31 | }; |
| @@ -46,9 +44,8 @@ enum test_opcodes { | |||
| 46 | RTTEST_LOCKINTNOWAIT, /* 6 Lock interruptible no wait in wakeup, data = lockindex */ | 44 | RTTEST_LOCKINTNOWAIT, /* 6 Lock interruptible no wait in wakeup, data = lockindex */ |
| 47 | RTTEST_LOCKCONT, /* 7 Continue locking after the wakeup delay */ | 45 | RTTEST_LOCKCONT, /* 7 Continue locking after the wakeup delay */ |
| 48 | RTTEST_UNLOCK, /* 8 Unlock, data = lockindex */ | 46 | RTTEST_UNLOCK, /* 8 Unlock, data = lockindex */ |
| 49 | RTTEST_LOCKBKL, /* 9 Lock BKL */ | 47 | /* 9, 10 - reserved for BKL commemoration */ |
| 50 | RTTEST_UNLOCKBKL, /* 10 Unlock BKL */ | 48 | RTTEST_SIGNAL = 11, /* 11 Signal other test thread, data = thread id */ |
| 51 | RTTEST_SIGNAL, /* 11 Signal other test thread, data = thread id */ | ||
| 52 | RTTEST_RESETEVENT = 98, /* 98 Reset event counter */ | 49 | RTTEST_RESETEVENT = 98, /* 98 Reset event counter */ |
| 53 | RTTEST_RESET = 99, /* 99 Reset all pending operations */ | 50 | RTTEST_RESET = 99, /* 99 Reset all pending operations */ |
| 54 | }; | 51 | }; |
| @@ -74,13 +71,6 @@ static int handle_op(struct test_thread_data *td, int lockwakeup) | |||
| 74 | td->mutexes[i] = 0; | 71 | td->mutexes[i] = 0; |
| 75 | } | 72 | } |
| 76 | } | 73 | } |
| 77 | |||
| 78 | if (!lockwakeup && td->bkl == 4) { | ||
| 79 | #ifdef CONFIG_LOCK_KERNEL | ||
| 80 | unlock_kernel(); | ||
| 81 | #endif | ||
| 82 | td->bkl = 0; | ||
| 83 | } | ||
| 84 | return 0; | 74 | return 0; |
| 85 | 75 | ||
| 86 | case RTTEST_RESETEVENT: | 76 | case RTTEST_RESETEVENT: |
| @@ -131,25 +121,6 @@ static int handle_op(struct test_thread_data *td, int lockwakeup) | |||
| 131 | td->mutexes[id] = 0; | 121 | td->mutexes[id] = 0; |
| 132 | return 0; | 122 | return 0; |
| 133 | 123 | ||
| 134 | case RTTEST_LOCKBKL: | ||
| 135 | if (td->bkl) | ||
| 136 | return 0; | ||
| 137 | td->bkl = 1; | ||
| 138 | #ifdef CONFIG_LOCK_KERNEL | ||
| 139 | lock_kernel(); | ||
| 140 | #endif | ||
| 141 | td->bkl = 4; | ||
| 142 | return 0; | ||
| 143 | |||
| 144 | case RTTEST_UNLOCKBKL: | ||
| 145 | if (td->bkl != 4) | ||
| 146 | break; | ||
| 147 | #ifdef CONFIG_LOCK_KERNEL | ||
| 148 | unlock_kernel(); | ||
| 149 | #endif | ||
| 150 | td->bkl = 0; | ||
| 151 | return 0; | ||
| 152 | |||
| 153 | default: | 124 | default: |
| 154 | break; | 125 | break; |
| 155 | } | 126 | } |
| @@ -196,7 +167,6 @@ void schedule_rt_mutex_test(struct rt_mutex *mutex) | |||
| 196 | td->event = atomic_add_return(1, &rttest_event); | 167 | td->event = atomic_add_return(1, &rttest_event); |
| 197 | break; | 168 | break; |
| 198 | 169 | ||
| 199 | case RTTEST_LOCKBKL: | ||
| 200 | default: | 170 | default: |
| 201 | break; | 171 | break; |
| 202 | } | 172 | } |
| @@ -229,8 +199,6 @@ void schedule_rt_mutex_test(struct rt_mutex *mutex) | |||
| 229 | td->event = atomic_add_return(1, &rttest_event); | 199 | td->event = atomic_add_return(1, &rttest_event); |
| 230 | return; | 200 | return; |
| 231 | 201 | ||
| 232 | case RTTEST_LOCKBKL: | ||
| 233 | return; | ||
| 234 | default: | 202 | default: |
| 235 | return; | 203 | return; |
| 236 | } | 204 | } |
| @@ -380,11 +348,11 @@ static ssize_t sysfs_test_status(struct sys_device *dev, struct sysdev_attribute | |||
| 380 | spin_lock(&rttest_lock); | 348 | spin_lock(&rttest_lock); |
| 381 | 349 | ||
| 382 | curr += sprintf(curr, | 350 | curr += sprintf(curr, |
| 383 | "O: %4d, E:%8d, S: 0x%08lx, P: %4d, N: %4d, B: %p, K: %d, M:", | 351 | "O: %4d, E:%8d, S: 0x%08lx, P: %4d, N: %4d, B: %p, M:", |
| 384 | td->opcode, td->event, tsk->state, | 352 | td->opcode, td->event, tsk->state, |
| 385 | (MAX_RT_PRIO - 1) - tsk->prio, | 353 | (MAX_RT_PRIO - 1) - tsk->prio, |
| 386 | (MAX_RT_PRIO - 1) - tsk->normal_prio, | 354 | (MAX_RT_PRIO - 1) - tsk->normal_prio, |
| 387 | tsk->pi_blocked_on, td->bkl); | 355 | tsk->pi_blocked_on); |
| 388 | 356 | ||
| 389 | for (i = MAX_RT_TEST_MUTEXES - 1; i >=0 ; i--) | 357 | for (i = MAX_RT_TEST_MUTEXES - 1; i >=0 ; i--) |
| 390 | curr += sprintf(curr, "%d", td->mutexes[i]); | 358 | curr += sprintf(curr, "%d", td->mutexes[i]); |
diff --git a/kernel/rtmutex.c b/kernel/rtmutex.c index a9604815786a..ab449117aaf2 100644 --- a/kernel/rtmutex.c +++ b/kernel/rtmutex.c | |||
| @@ -20,41 +20,34 @@ | |||
| 20 | /* | 20 | /* |
| 21 | * lock->owner state tracking: | 21 | * lock->owner state tracking: |
| 22 | * | 22 | * |
| 23 | * lock->owner holds the task_struct pointer of the owner. Bit 0 and 1 | 23 | * lock->owner holds the task_struct pointer of the owner. Bit 0 |
| 24 | * are used to keep track of the "owner is pending" and "lock has | 24 | * is used to keep track of the "lock has waiters" state. |
| 25 | * waiters" state. | ||
| 26 | * | 25 | * |
| 27 | * owner bit1 bit0 | 26 | * owner bit0 |
| 28 | * NULL 0 0 lock is free (fast acquire possible) | 27 | * NULL 0 lock is free (fast acquire possible) |
| 29 | * NULL 0 1 invalid state | 28 | * NULL 1 lock is free and has waiters and the top waiter |
| 30 | * NULL 1 0 Transitional State* | 29 | * is going to take the lock* |
| 31 | * NULL 1 1 invalid state | 30 | * taskpointer 0 lock is held (fast release possible) |
| 32 | * taskpointer 0 0 lock is held (fast release possible) | 31 | * taskpointer 1 lock is held and has waiters** |
| 33 | * taskpointer 0 1 task is pending owner | ||
| 34 | * taskpointer 1 0 lock is held and has waiters | ||
| 35 | * taskpointer 1 1 task is pending owner and lock has more waiters | ||
| 36 | * | ||
| 37 | * Pending ownership is assigned to the top (highest priority) | ||
| 38 | * waiter of the lock, when the lock is released. The thread is woken | ||
| 39 | * up and can now take the lock. Until the lock is taken (bit 0 | ||
| 40 | * cleared) a competing higher priority thread can steal the lock | ||
| 41 | * which puts the woken up thread back on the waiters list. | ||
| 42 | * | 32 | * |
| 43 | * The fast atomic compare exchange based acquire and release is only | 33 | * The fast atomic compare exchange based acquire and release is only |
| 44 | * possible when bit 0 and 1 of lock->owner are 0. | 34 | * possible when bit 0 of lock->owner is 0. |
| 35 | * | ||
| 36 | * (*) It also can be a transitional state when grabbing the lock | ||
| 37 | * with ->wait_lock is held. To prevent any fast path cmpxchg to the lock, | ||
| 38 | * we need to set the bit0 before looking at the lock, and the owner may be | ||
| 39 | * NULL in this small time, hence this can be a transitional state. | ||
| 45 | * | 40 | * |
| 46 | * (*) There's a small time where the owner can be NULL and the | 41 | * (**) There is a small time when bit 0 is set but there are no |
| 47 | * "lock has waiters" bit is set. This can happen when grabbing the lock. | 42 | * waiters. This can happen when grabbing the lock in the slow path. |
| 48 | * To prevent a cmpxchg of the owner releasing the lock, we need to set this | 43 | * To prevent a cmpxchg of the owner releasing the lock, we need to |
| 49 | * bit before looking at the lock, hence the reason this is a transitional | 44 | * set this bit before looking at the lock. |
| 50 | * state. | ||
| 51 | */ | 45 | */ |
| 52 | 46 | ||
| 53 | static void | 47 | static void |
| 54 | rt_mutex_set_owner(struct rt_mutex *lock, struct task_struct *owner, | 48 | rt_mutex_set_owner(struct rt_mutex *lock, struct task_struct *owner) |
| 55 | unsigned long mask) | ||
| 56 | { | 49 | { |
| 57 | unsigned long val = (unsigned long)owner | mask; | 50 | unsigned long val = (unsigned long)owner; |
| 58 | 51 | ||
| 59 | if (rt_mutex_has_waiters(lock)) | 52 | if (rt_mutex_has_waiters(lock)) |
| 60 | val |= RT_MUTEX_HAS_WAITERS; | 53 | val |= RT_MUTEX_HAS_WAITERS; |
| @@ -203,15 +196,14 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
| 203 | * reached or the state of the chain has changed while we | 196 | * reached or the state of the chain has changed while we |
| 204 | * dropped the locks. | 197 | * dropped the locks. |
| 205 | */ | 198 | */ |
| 206 | if (!waiter || !waiter->task) | 199 | if (!waiter) |
| 207 | goto out_unlock_pi; | 200 | goto out_unlock_pi; |
| 208 | 201 | ||
| 209 | /* | 202 | /* |
| 210 | * Check the orig_waiter state. After we dropped the locks, | 203 | * Check the orig_waiter state. After we dropped the locks, |
| 211 | * the previous owner of the lock might have released the lock | 204 | * the previous owner of the lock might have released the lock. |
| 212 | * and made us the pending owner: | ||
| 213 | */ | 205 | */ |
| 214 | if (orig_waiter && !orig_waiter->task) | 206 | if (orig_waiter && !rt_mutex_owner(orig_lock)) |
| 215 | goto out_unlock_pi; | 207 | goto out_unlock_pi; |
| 216 | 208 | ||
| 217 | /* | 209 | /* |
| @@ -254,6 +246,17 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
| 254 | 246 | ||
| 255 | /* Release the task */ | 247 | /* Release the task */ |
| 256 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); | 248 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
| 249 | if (!rt_mutex_owner(lock)) { | ||
| 250 | /* | ||
| 251 | * If the requeue above changed the top waiter, then we need | ||
| 252 | * to wake the new top waiter up to try to get the lock. | ||
| 253 | */ | ||
| 254 | |||
| 255 | if (top_waiter != rt_mutex_top_waiter(lock)) | ||
| 256 | wake_up_process(rt_mutex_top_waiter(lock)->task); | ||
| 257 | raw_spin_unlock(&lock->wait_lock); | ||
| 258 | goto out_put_task; | ||
| 259 | } | ||
| 257 | put_task_struct(task); | 260 | put_task_struct(task); |
| 258 | 261 | ||
| 259 | /* Grab the next task */ | 262 | /* Grab the next task */ |
| @@ -296,78 +299,16 @@ static int rt_mutex_adjust_prio_chain(struct task_struct *task, | |||
| 296 | } | 299 | } |
| 297 | 300 | ||
| 298 | /* | 301 | /* |
| 299 | * Optimization: check if we can steal the lock from the | ||
| 300 | * assigned pending owner [which might not have taken the | ||
| 301 | * lock yet]: | ||
| 302 | */ | ||
| 303 | static inline int try_to_steal_lock(struct rt_mutex *lock, | ||
| 304 | struct task_struct *task) | ||
| 305 | { | ||
| 306 | struct task_struct *pendowner = rt_mutex_owner(lock); | ||
| 307 | struct rt_mutex_waiter *next; | ||
| 308 | unsigned long flags; | ||
| 309 | |||
| 310 | if (!rt_mutex_owner_pending(lock)) | ||
| 311 | return 0; | ||
| 312 | |||
| 313 | if (pendowner == task) | ||
| 314 | return 1; | ||
| 315 | |||
| 316 | raw_spin_lock_irqsave(&pendowner->pi_lock, flags); | ||
| 317 | if (task->prio >= pendowner->prio) { | ||
| 318 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); | ||
| 319 | return 0; | ||
| 320 | } | ||
| 321 | |||
| 322 | /* | ||
| 323 | * Check if a waiter is enqueued on the pending owners | ||
| 324 | * pi_waiters list. Remove it and readjust pending owners | ||
| 325 | * priority. | ||
| 326 | */ | ||
| 327 | if (likely(!rt_mutex_has_waiters(lock))) { | ||
| 328 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); | ||
| 329 | return 1; | ||
| 330 | } | ||
| 331 | |||
| 332 | /* No chain handling, pending owner is not blocked on anything: */ | ||
| 333 | next = rt_mutex_top_waiter(lock); | ||
| 334 | plist_del(&next->pi_list_entry, &pendowner->pi_waiters); | ||
| 335 | __rt_mutex_adjust_prio(pendowner); | ||
| 336 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); | ||
| 337 | |||
| 338 | /* | ||
| 339 | * We are going to steal the lock and a waiter was | ||
| 340 | * enqueued on the pending owners pi_waiters queue. So | ||
| 341 | * we have to enqueue this waiter into | ||
| 342 | * task->pi_waiters list. This covers the case, | ||
| 343 | * where task is boosted because it holds another | ||
| 344 | * lock and gets unboosted because the booster is | ||
| 345 | * interrupted, so we would delay a waiter with higher | ||
| 346 | * priority as task->normal_prio. | ||
| 347 | * | ||
| 348 | * Note: in the rare case of a SCHED_OTHER task changing | ||
| 349 | * its priority and thus stealing the lock, next->task | ||
| 350 | * might be task: | ||
| 351 | */ | ||
| 352 | if (likely(next->task != task)) { | ||
| 353 | raw_spin_lock_irqsave(&task->pi_lock, flags); | ||
| 354 | plist_add(&next->pi_list_entry, &task->pi_waiters); | ||
| 355 | __rt_mutex_adjust_prio(task); | ||
| 356 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); | ||
| 357 | } | ||
| 358 | return 1; | ||
| 359 | } | ||
| 360 | |||
| 361 | /* | ||
| 362 | * Try to take an rt-mutex | 302 | * Try to take an rt-mutex |
| 363 | * | 303 | * |
| 364 | * This fails | ||
| 365 | * - when the lock has a real owner | ||
| 366 | * - when a different pending owner exists and has higher priority than current | ||
| 367 | * | ||
| 368 | * Must be called with lock->wait_lock held. | 304 | * Must be called with lock->wait_lock held. |
| 305 | * | ||
| 306 | * @lock: the lock to be acquired. | ||
| 307 | * @task: the task which wants to acquire the lock | ||
| 308 | * @waiter: the waiter that is queued to the lock's wait list. (could be NULL) | ||
| 369 | */ | 309 | */ |
| 370 | static int try_to_take_rt_mutex(struct rt_mutex *lock) | 310 | static int try_to_take_rt_mutex(struct rt_mutex *lock, struct task_struct *task, |
| 311 | struct rt_mutex_waiter *waiter) | ||
| 371 | { | 312 | { |
| 372 | /* | 313 | /* |
| 373 | * We have to be careful here if the atomic speedups are | 314 | * We have to be careful here if the atomic speedups are |
| @@ -390,15 +331,52 @@ static int try_to_take_rt_mutex(struct rt_mutex *lock) | |||
| 390 | */ | 331 | */ |
| 391 | mark_rt_mutex_waiters(lock); | 332 | mark_rt_mutex_waiters(lock); |
| 392 | 333 | ||
| 393 | if (rt_mutex_owner(lock) && !try_to_steal_lock(lock, current)) | 334 | if (rt_mutex_owner(lock)) |
| 394 | return 0; | 335 | return 0; |
| 395 | 336 | ||
| 337 | /* | ||
| 338 | * It will get the lock because of one of these conditions: | ||
| 339 | * 1) there is no waiter | ||
| 340 | * 2) higher priority than waiters | ||
| 341 | * 3) it is top waiter | ||
| 342 | */ | ||
| 343 | if (rt_mutex_has_waiters(lock)) { | ||
| 344 | if (task->prio >= rt_mutex_top_waiter(lock)->list_entry.prio) { | ||
| 345 | if (!waiter || waiter != rt_mutex_top_waiter(lock)) | ||
| 346 | return 0; | ||
| 347 | } | ||
| 348 | } | ||
| 349 | |||
| 350 | if (waiter || rt_mutex_has_waiters(lock)) { | ||
| 351 | unsigned long flags; | ||
| 352 | struct rt_mutex_waiter *top; | ||
| 353 | |||
| 354 | raw_spin_lock_irqsave(&task->pi_lock, flags); | ||
| 355 | |||
| 356 | /* remove the queued waiter. */ | ||
| 357 | if (waiter) { | ||
| 358 | plist_del(&waiter->list_entry, &lock->wait_list); | ||
| 359 | task->pi_blocked_on = NULL; | ||
| 360 | } | ||
| 361 | |||
| 362 | /* | ||
| 363 | * We have to enqueue the top waiter(if it exists) into | ||
| 364 | * task->pi_waiters list. | ||
| 365 | */ | ||
| 366 | if (rt_mutex_has_waiters(lock)) { | ||
| 367 | top = rt_mutex_top_waiter(lock); | ||
| 368 | top->pi_list_entry.prio = top->list_entry.prio; | ||
| 369 | plist_add(&top->pi_list_entry, &task->pi_waiters); | ||
| 370 | } | ||
| 371 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); | ||
| 372 | } | ||
| 373 | |||
| 396 | /* We got the lock. */ | 374 | /* We got the lock. */ |
| 397 | debug_rt_mutex_lock(lock); | 375 | debug_rt_mutex_lock(lock); |
| 398 | 376 | ||
| 399 | rt_mutex_set_owner(lock, current, 0); | 377 | rt_mutex_set_owner(lock, task); |
| 400 | 378 | ||
| 401 | rt_mutex_deadlock_account_lock(lock, current); | 379 | rt_mutex_deadlock_account_lock(lock, task); |
| 402 | 380 | ||
| 403 | return 1; | 381 | return 1; |
| 404 | } | 382 | } |
| @@ -436,6 +414,9 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, | |||
| 436 | 414 | ||
| 437 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); | 415 | raw_spin_unlock_irqrestore(&task->pi_lock, flags); |
| 438 | 416 | ||
| 417 | if (!owner) | ||
| 418 | return 0; | ||
| 419 | |||
| 439 | if (waiter == rt_mutex_top_waiter(lock)) { | 420 | if (waiter == rt_mutex_top_waiter(lock)) { |
| 440 | raw_spin_lock_irqsave(&owner->pi_lock, flags); | 421 | raw_spin_lock_irqsave(&owner->pi_lock, flags); |
| 441 | plist_del(&top_waiter->pi_list_entry, &owner->pi_waiters); | 422 | plist_del(&top_waiter->pi_list_entry, &owner->pi_waiters); |
| @@ -472,21 +453,18 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock, | |||
| 472 | /* | 453 | /* |
| 473 | * Wake up the next waiter on the lock. | 454 | * Wake up the next waiter on the lock. |
| 474 | * | 455 | * |
| 475 | * Remove the top waiter from the current tasks waiter list and from | 456 | * Remove the top waiter from the current tasks waiter list and wake it up. |
| 476 | * the lock waiter list. Set it as pending owner. Then wake it up. | ||
| 477 | * | 457 | * |
| 478 | * Called with lock->wait_lock held. | 458 | * Called with lock->wait_lock held. |
| 479 | */ | 459 | */ |
| 480 | static void wakeup_next_waiter(struct rt_mutex *lock) | 460 | static void wakeup_next_waiter(struct rt_mutex *lock) |
| 481 | { | 461 | { |
| 482 | struct rt_mutex_waiter *waiter; | 462 | struct rt_mutex_waiter *waiter; |
| 483 | struct task_struct *pendowner; | ||
| 484 | unsigned long flags; | 463 | unsigned long flags; |
| 485 | 464 | ||
| 486 | raw_spin_lock_irqsave(¤t->pi_lock, flags); | 465 | raw_spin_lock_irqsave(¤t->pi_lock, flags); |
| 487 | 466 | ||
| 488 | waiter = rt_mutex_top_waiter(lock); | 467 | waiter = rt_mutex_top_waiter(lock); |
| 489 | plist_del(&waiter->list_entry, &lock->wait_list); | ||
| 490 | 468 | ||
| 491 | /* | 469 | /* |
| 492 | * Remove it from current->pi_waiters. We do not adjust a | 470 | * Remove it from current->pi_waiters. We do not adjust a |
| @@ -495,43 +473,19 @@ static void wakeup_next_waiter(struct rt_mutex *lock) | |||
| 495 | * lock->wait_lock. | 473 | * lock->wait_lock. |
| 496 | */ | 474 | */ |
| 497 | plist_del(&waiter->pi_list_entry, ¤t->pi_waiters); | 475 | plist_del(&waiter->pi_list_entry, ¤t->pi_waiters); |
| 498 | pendowner = waiter->task; | ||
| 499 | waiter->task = NULL; | ||
| 500 | 476 | ||
| 501 | rt_mutex_set_owner(lock, pendowner, RT_MUTEX_OWNER_PENDING); | 477 | rt_mutex_set_owner(lock, NULL); |
| 502 | 478 | ||
| 503 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); | 479 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); |
| 504 | 480 | ||
| 505 | /* | 481 | wake_up_process(waiter->task); |
| 506 | * Clear the pi_blocked_on variable and enqueue a possible | ||
| 507 | * waiter into the pi_waiters list of the pending owner. This | ||
| 508 | * prevents that in case the pending owner gets unboosted a | ||
| 509 | * waiter with higher priority than pending-owner->normal_prio | ||
| 510 | * is blocked on the unboosted (pending) owner. | ||
| 511 | */ | ||
| 512 | raw_spin_lock_irqsave(&pendowner->pi_lock, flags); | ||
| 513 | |||
| 514 | WARN_ON(!pendowner->pi_blocked_on); | ||
| 515 | WARN_ON(pendowner->pi_blocked_on != waiter); | ||
| 516 | WARN_ON(pendowner->pi_blocked_on->lock != lock); | ||
| 517 | |||
| 518 | pendowner->pi_blocked_on = NULL; | ||
| 519 | |||
| 520 | if (rt_mutex_has_waiters(lock)) { | ||
| 521 | struct rt_mutex_waiter *next; | ||
| 522 | |||
| 523 | next = rt_mutex_top_waiter(lock); | ||
| 524 | plist_add(&next->pi_list_entry, &pendowner->pi_waiters); | ||
| 525 | } | ||
| 526 | raw_spin_unlock_irqrestore(&pendowner->pi_lock, flags); | ||
| 527 | |||
| 528 | wake_up_process(pendowner); | ||
| 529 | } | 482 | } |
| 530 | 483 | ||
| 531 | /* | 484 | /* |
| 532 | * Remove a waiter from a lock | 485 | * Remove a waiter from a lock and give up |
| 533 | * | 486 | * |
| 534 | * Must be called with lock->wait_lock held | 487 | * Must be called with lock->wait_lock held and |
| 488 | * have just failed to try_to_take_rt_mutex(). | ||
| 535 | */ | 489 | */ |
| 536 | static void remove_waiter(struct rt_mutex *lock, | 490 | static void remove_waiter(struct rt_mutex *lock, |
| 537 | struct rt_mutex_waiter *waiter) | 491 | struct rt_mutex_waiter *waiter) |
| @@ -543,11 +497,13 @@ static void remove_waiter(struct rt_mutex *lock, | |||
| 543 | 497 | ||
| 544 | raw_spin_lock_irqsave(¤t->pi_lock, flags); | 498 | raw_spin_lock_irqsave(¤t->pi_lock, flags); |
| 545 | plist_del(&waiter->list_entry, &lock->wait_list); | 499 | plist_del(&waiter->list_entry, &lock->wait_list); |
| 546 | waiter->task = NULL; | ||
| 547 | current->pi_blocked_on = NULL; | 500 | current->pi_blocked_on = NULL; |
| 548 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); | 501 | raw_spin_unlock_irqrestore(¤t->pi_lock, flags); |
| 549 | 502 | ||
| 550 | if (first && owner != current) { | 503 | if (!owner) |
| 504 | return; | ||
| 505 | |||
| 506 | if (first) { | ||
| 551 | 507 | ||
| 552 | raw_spin_lock_irqsave(&owner->pi_lock, flags); | 508 | raw_spin_lock_irqsave(&owner->pi_lock, flags); |
| 553 | 509 | ||
| @@ -614,21 +570,19 @@ void rt_mutex_adjust_pi(struct task_struct *task) | |||
| 614 | * or TASK_UNINTERRUPTIBLE) | 570 | * or TASK_UNINTERRUPTIBLE) |
| 615 | * @timeout: the pre-initialized and started timer, or NULL for none | 571 | * @timeout: the pre-initialized and started timer, or NULL for none |
| 616 | * @waiter: the pre-initialized rt_mutex_waiter | 572 | * @waiter: the pre-initialized rt_mutex_waiter |
| 617 | * @detect_deadlock: passed to task_blocks_on_rt_mutex | ||
| 618 | * | 573 | * |
| 619 | * lock->wait_lock must be held by the caller. | 574 | * lock->wait_lock must be held by the caller. |
| 620 | */ | 575 | */ |
| 621 | static int __sched | 576 | static int __sched |
| 622 | __rt_mutex_slowlock(struct rt_mutex *lock, int state, | 577 | __rt_mutex_slowlock(struct rt_mutex *lock, int state, |
| 623 | struct hrtimer_sleeper *timeout, | 578 | struct hrtimer_sleeper *timeout, |
| 624 | struct rt_mutex_waiter *waiter, | 579 | struct rt_mutex_waiter *waiter) |
| 625 | int detect_deadlock) | ||
| 626 | { | 580 | { |
| 627 | int ret = 0; | 581 | int ret = 0; |
| 628 | 582 | ||
| 629 | for (;;) { | 583 | for (;;) { |
| 630 | /* Try to acquire the lock: */ | 584 | /* Try to acquire the lock: */ |
| 631 | if (try_to_take_rt_mutex(lock)) | 585 | if (try_to_take_rt_mutex(lock, current, waiter)) |
| 632 | break; | 586 | break; |
| 633 | 587 | ||
| 634 | /* | 588 | /* |
| @@ -645,39 +599,11 @@ __rt_mutex_slowlock(struct rt_mutex *lock, int state, | |||
| 645 | break; | 599 | break; |
| 646 | } | 600 | } |
| 647 | 601 | ||
| 648 | /* | ||
| 649 | * waiter->task is NULL the first time we come here and | ||
| 650 | * when we have been woken up by the previous owner | ||
| 651 | * but the lock got stolen by a higher prio task. | ||
| 652 | */ | ||
| 653 | if (!waiter->task) { | ||
| 654 | ret = task_blocks_on_rt_mutex(lock, waiter, current, | ||
| 655 | detect_deadlock); | ||
| 656 | /* | ||
| 657 | * If we got woken up by the owner then start loop | ||
| 658 | * all over without going into schedule to try | ||
| 659 | * to get the lock now: | ||
| 660 | */ | ||
| 661 | if (unlikely(!waiter->task)) { | ||
| 662 | /* | ||
| 663 | * Reset the return value. We might | ||
| 664 | * have returned with -EDEADLK and the | ||
| 665 | * owner released the lock while we | ||
| 666 | * were walking the pi chain. | ||
| 667 | */ | ||
| 668 | ret = 0; | ||
| 669 | continue; | ||
| 670 | } | ||
| 671 | if (unlikely(ret)) | ||
| 672 | break; | ||
| 673 | } | ||
| 674 | |||
| 675 | raw_spin_unlock(&lock->wait_lock); | 602 | raw_spin_unlock(&lock->wait_lock); |
| 676 | 603 | ||
| 677 | debug_rt_mutex_print_deadlock(waiter); | 604 | debug_rt_mutex_print_deadlock(waiter); |
| 678 | 605 | ||
| 679 | if (waiter->task) | 606 | schedule_rt_mutex(lock); |
| 680 | schedule_rt_mutex(lock); | ||
| 681 | 607 | ||
| 682 | raw_spin_lock(&lock->wait_lock); | 608 | raw_spin_lock(&lock->wait_lock); |
| 683 | set_current_state(state); | 609 | set_current_state(state); |
| @@ -698,12 +624,11 @@ rt_mutex_slowlock(struct rt_mutex *lock, int state, | |||
| 698 | int ret = 0; | 624 | int ret = 0; |
| 699 | 625 | ||
| 700 | debug_rt_mutex_init_waiter(&waiter); | 626 | debug_rt_mutex_init_waiter(&waiter); |
| 701 | waiter.task = NULL; | ||
| 702 | 627 | ||
| 703 | raw_spin_lock(&lock->wait_lock); | 628 | raw_spin_lock(&lock->wait_lock); |
| 704 | 629 | ||
| 705 | /* Try to acquire the lock again: */ | 630 | /* Try to acquire the lock again: */ |
| 706 | if (try_to_take_rt_mutex(lock)) { | 631 | if (try_to_take_rt_mutex(lock, current, NULL)) { |
| 707 | raw_spin_unlock(&lock->wait_lock); | 632 | raw_spin_unlock(&lock->wait_lock); |
| 708 | return 0; | 633 | return 0; |
| 709 | } | 634 | } |
| @@ -717,12 +642,14 @@ rt_mutex_slowlock(struct rt_mutex *lock, int state, | |||
| 717 | timeout->task = NULL; | 642 | timeout->task = NULL; |
| 718 | } | 643 | } |
| 719 | 644 | ||
| 720 | ret = __rt_mutex_slowlock(lock, state, timeout, &waiter, | 645 | ret = task_blocks_on_rt_mutex(lock, &waiter, current, detect_deadlock); |
| 721 | detect_deadlock); | 646 | |
| 647 | if (likely(!ret)) | ||
| 648 | ret = __rt_mutex_slowlock(lock, state, timeout, &waiter); | ||
| 722 | 649 | ||
| 723 | set_current_state(TASK_RUNNING); | 650 | set_current_state(TASK_RUNNING); |
| 724 | 651 | ||
| 725 | if (unlikely(waiter.task)) | 652 | if (unlikely(ret)) |
| 726 | remove_waiter(lock, &waiter); | 653 | remove_waiter(lock, &waiter); |
| 727 | 654 | ||
| 728 | /* | 655 | /* |
| @@ -737,14 +664,6 @@ rt_mutex_slowlock(struct rt_mutex *lock, int state, | |||
| 737 | if (unlikely(timeout)) | 664 | if (unlikely(timeout)) |
| 738 | hrtimer_cancel(&timeout->timer); | 665 | hrtimer_cancel(&timeout->timer); |
| 739 | 666 | ||
| 740 | /* | ||
| 741 | * Readjust priority, when we did not get the lock. We might | ||
| 742 | * have been the pending owner and boosted. Since we did not | ||
| 743 | * take the lock, the PI boost has to go. | ||
| 744 | */ | ||
| 745 | if (unlikely(ret)) | ||
| 746 | rt_mutex_adjust_prio(current); | ||
| 747 | |||
| 748 | debug_rt_mutex_free_waiter(&waiter); | 667 | debug_rt_mutex_free_waiter(&waiter); |
| 749 | 668 | ||
| 750 | return ret; | 669 | return ret; |
| @@ -762,7 +681,7 @@ rt_mutex_slowtrylock(struct rt_mutex *lock) | |||
| 762 | 681 | ||
| 763 | if (likely(rt_mutex_owner(lock) != current)) { | 682 | if (likely(rt_mutex_owner(lock) != current)) { |
| 764 | 683 | ||
| 765 | ret = try_to_take_rt_mutex(lock); | 684 | ret = try_to_take_rt_mutex(lock, current, NULL); |
| 766 | /* | 685 | /* |
| 767 | * try_to_take_rt_mutex() sets the lock waiters | 686 | * try_to_take_rt_mutex() sets the lock waiters |
| 768 | * bit unconditionally. Clean this up. | 687 | * bit unconditionally. Clean this up. |
| @@ -992,7 +911,7 @@ void rt_mutex_init_proxy_locked(struct rt_mutex *lock, | |||
| 992 | { | 911 | { |
| 993 | __rt_mutex_init(lock, NULL); | 912 | __rt_mutex_init(lock, NULL); |
| 994 | debug_rt_mutex_proxy_lock(lock, proxy_owner); | 913 | debug_rt_mutex_proxy_lock(lock, proxy_owner); |
| 995 | rt_mutex_set_owner(lock, proxy_owner, 0); | 914 | rt_mutex_set_owner(lock, proxy_owner); |
| 996 | rt_mutex_deadlock_account_lock(lock, proxy_owner); | 915 | rt_mutex_deadlock_account_lock(lock, proxy_owner); |
| 997 | } | 916 | } |
| 998 | 917 | ||
| @@ -1008,7 +927,7 @@ void rt_mutex_proxy_unlock(struct rt_mutex *lock, | |||
| 1008 | struct task_struct *proxy_owner) | 927 | struct task_struct *proxy_owner) |
| 1009 | { | 928 | { |
| 1010 | debug_rt_mutex_proxy_unlock(lock); | 929 | debug_rt_mutex_proxy_unlock(lock); |
| 1011 | rt_mutex_set_owner(lock, NULL, 0); | 930 | rt_mutex_set_owner(lock, NULL); |
| 1012 | rt_mutex_deadlock_account_unlock(proxy_owner); | 931 | rt_mutex_deadlock_account_unlock(proxy_owner); |
| 1013 | } | 932 | } |
| 1014 | 933 | ||
| @@ -1034,20 +953,14 @@ int rt_mutex_start_proxy_lock(struct rt_mutex *lock, | |||
| 1034 | 953 | ||
| 1035 | raw_spin_lock(&lock->wait_lock); | 954 | raw_spin_lock(&lock->wait_lock); |
| 1036 | 955 | ||
| 1037 | mark_rt_mutex_waiters(lock); | 956 | if (try_to_take_rt_mutex(lock, task, NULL)) { |
| 1038 | |||
| 1039 | if (!rt_mutex_owner(lock) || try_to_steal_lock(lock, task)) { | ||
| 1040 | /* We got the lock for task. */ | ||
| 1041 | debug_rt_mutex_lock(lock); | ||
| 1042 | rt_mutex_set_owner(lock, task, 0); | ||
| 1043 | raw_spin_unlock(&lock->wait_lock); | 957 | raw_spin_unlock(&lock->wait_lock); |
| 1044 | rt_mutex_deadlock_account_lock(lock, task); | ||
| 1045 | return 1; | 958 | return 1; |
| 1046 | } | 959 | } |
| 1047 | 960 | ||
| 1048 | ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock); | 961 | ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock); |
| 1049 | 962 | ||
| 1050 | if (ret && !waiter->task) { | 963 | if (ret && !rt_mutex_owner(lock)) { |
| 1051 | /* | 964 | /* |
| 1052 | * Reset the return value. We might have | 965 | * Reset the return value. We might have |
| 1053 | * returned with -EDEADLK and the owner | 966 | * returned with -EDEADLK and the owner |
| @@ -1056,6 +969,10 @@ int rt_mutex_start_proxy_lock(struct rt_mutex *lock, | |||
| 1056 | */ | 969 | */ |
| 1057 | ret = 0; | 970 | ret = 0; |
| 1058 | } | 971 | } |
| 972 | |||
| 973 | if (unlikely(ret)) | ||
| 974 | remove_waiter(lock, waiter); | ||
| 975 | |||
| 1059 | raw_spin_unlock(&lock->wait_lock); | 976 | raw_spin_unlock(&lock->wait_lock); |
| 1060 | 977 | ||
| 1061 | debug_rt_mutex_print_deadlock(waiter); | 978 | debug_rt_mutex_print_deadlock(waiter); |
| @@ -1110,12 +1027,11 @@ int rt_mutex_finish_proxy_lock(struct rt_mutex *lock, | |||
| 1110 | 1027 | ||
| 1111 | set_current_state(TASK_INTERRUPTIBLE); | 1028 | set_current_state(TASK_INTERRUPTIBLE); |
| 1112 | 1029 | ||
| 1113 | ret = __rt_mutex_slowlock(lock, TASK_INTERRUPTIBLE, to, waiter, | 1030 | ret = __rt_mutex_slowlock(lock, TASK_INTERRUPTIBLE, to, waiter); |
| 1114 | detect_deadlock); | ||
| 1115 | 1031 | ||
| 1116 | set_current_state(TASK_RUNNING); | 1032 | set_current_state(TASK_RUNNING); |
| 1117 | 1033 | ||
| 1118 | if (unlikely(waiter->task)) | 1034 | if (unlikely(ret)) |
| 1119 | remove_waiter(lock, waiter); | 1035 | remove_waiter(lock, waiter); |
| 1120 | 1036 | ||
| 1121 | /* | 1037 | /* |
| @@ -1126,13 +1042,5 @@ int rt_mutex_finish_proxy_lock(struct rt_mutex *lock, | |||
| 1126 | 1042 | ||
| 1127 | raw_spin_unlock(&lock->wait_lock); | 1043 | raw_spin_unlock(&lock->wait_lock); |
| 1128 | 1044 | ||
| 1129 | /* | ||
| 1130 | * Readjust priority, when we did not get the lock. We might have been | ||
| 1131 | * the pending owner and boosted. Since we did not take the lock, the | ||
| 1132 | * PI boost has to go. | ||
| 1133 | */ | ||
| 1134 | if (unlikely(ret)) | ||
| 1135 | rt_mutex_adjust_prio(current); | ||
| 1136 | |||
| 1137 | return ret; | 1045 | return ret; |
| 1138 | } | 1046 | } |
diff --git a/kernel/rtmutex_common.h b/kernel/rtmutex_common.h index 97a2f81866af..53a66c85261b 100644 --- a/kernel/rtmutex_common.h +++ b/kernel/rtmutex_common.h | |||
| @@ -91,9 +91,8 @@ task_top_pi_waiter(struct task_struct *p) | |||
| 91 | /* | 91 | /* |
| 92 | * lock->owner state tracking: | 92 | * lock->owner state tracking: |
| 93 | */ | 93 | */ |
| 94 | #define RT_MUTEX_OWNER_PENDING 1UL | 94 | #define RT_MUTEX_HAS_WAITERS 1UL |
| 95 | #define RT_MUTEX_HAS_WAITERS 2UL | 95 | #define RT_MUTEX_OWNER_MASKALL 1UL |
| 96 | #define RT_MUTEX_OWNER_MASKALL 3UL | ||
| 97 | 96 | ||
| 98 | static inline struct task_struct *rt_mutex_owner(struct rt_mutex *lock) | 97 | static inline struct task_struct *rt_mutex_owner(struct rt_mutex *lock) |
| 99 | { | 98 | { |
| @@ -101,17 +100,6 @@ static inline struct task_struct *rt_mutex_owner(struct rt_mutex *lock) | |||
| 101 | ((unsigned long)lock->owner & ~RT_MUTEX_OWNER_MASKALL); | 100 | ((unsigned long)lock->owner & ~RT_MUTEX_OWNER_MASKALL); |
| 102 | } | 101 | } |
| 103 | 102 | ||
| 104 | static inline struct task_struct *rt_mutex_real_owner(struct rt_mutex *lock) | ||
| 105 | { | ||
| 106 | return (struct task_struct *) | ||
| 107 | ((unsigned long)lock->owner & ~RT_MUTEX_HAS_WAITERS); | ||
| 108 | } | ||
| 109 | |||
| 110 | static inline unsigned long rt_mutex_owner_pending(struct rt_mutex *lock) | ||
| 111 | { | ||
| 112 | return (unsigned long)lock->owner & RT_MUTEX_OWNER_PENDING; | ||
| 113 | } | ||
| 114 | |||
| 115 | /* | 103 | /* |
| 116 | * PI-futex support (proxy locking functions, etc.): | 104 | * PI-futex support (proxy locking functions, etc.): |
| 117 | */ | 105 | */ |
diff --git a/kernel/timer.c b/kernel/timer.c index 33a67925d900..3503c17ac1d3 100644 --- a/kernel/timer.c +++ b/kernel/timer.c | |||
| @@ -970,6 +970,25 @@ EXPORT_SYMBOL(try_to_del_timer_sync); | |||
| 970 | * add_timer_on(). Upon exit the timer is not queued and the handler is | 970 | * add_timer_on(). Upon exit the timer is not queued and the handler is |
| 971 | * not running on any CPU. | 971 | * not running on any CPU. |
| 972 | * | 972 | * |
| 973 | * Note: You must not hold locks that are held in interrupt context | ||
| 974 | * while calling this function. Even if the lock has nothing to do | ||
| 975 | * with the timer in question. Here's why: | ||
| 976 | * | ||
| 977 | * CPU0 CPU1 | ||
| 978 | * ---- ---- | ||
| 979 | * <SOFTIRQ> | ||
| 980 | * call_timer_fn(); | ||
| 981 | * base->running_timer = mytimer; | ||
| 982 | * spin_lock_irq(somelock); | ||
| 983 | * <IRQ> | ||
| 984 | * spin_lock(somelock); | ||
| 985 | * del_timer_sync(mytimer); | ||
| 986 | * while (base->running_timer == mytimer); | ||
| 987 | * | ||
| 988 | * Now del_timer_sync() will never return and never release somelock. | ||
| 989 | * The interrupt on the other CPU is waiting to grab somelock but | ||
| 990 | * it has interrupted the softirq that CPU0 is waiting to finish. | ||
| 991 | * | ||
| 973 | * The function returns whether it has deactivated a pending timer or not. | 992 | * The function returns whether it has deactivated a pending timer or not. |
| 974 | */ | 993 | */ |
| 975 | int del_timer_sync(struct timer_list *timer) | 994 | int del_timer_sync(struct timer_list *timer) |
| @@ -977,6 +996,10 @@ int del_timer_sync(struct timer_list *timer) | |||
| 977 | #ifdef CONFIG_LOCKDEP | 996 | #ifdef CONFIG_LOCKDEP |
| 978 | unsigned long flags; | 997 | unsigned long flags; |
| 979 | 998 | ||
| 999 | /* | ||
| 1000 | * If lockdep gives a backtrace here, please reference | ||
| 1001 | * the synchronization rules above. | ||
| 1002 | */ | ||
| 980 | local_irq_save(flags); | 1003 | local_irq_save(flags); |
| 981 | lock_map_acquire(&timer->lockdep_map); | 1004 | lock_map_acquire(&timer->lockdep_map); |
| 982 | lock_map_release(&timer->lockdep_map); | 1005 | lock_map_release(&timer->lockdep_map); |
diff --git a/lib/rwsem.c b/lib/rwsem.c index f236d7cd5cf3..aa7c3052261f 100644 --- a/lib/rwsem.c +++ b/lib/rwsem.c | |||
| @@ -222,8 +222,7 @@ rwsem_down_failed_common(struct rw_semaphore *sem, | |||
| 222 | /* | 222 | /* |
| 223 | * wait for the read lock to be granted | 223 | * wait for the read lock to be granted |
| 224 | */ | 224 | */ |
| 225 | asmregparm struct rw_semaphore __sched * | 225 | struct rw_semaphore __sched *rwsem_down_read_failed(struct rw_semaphore *sem) |
| 226 | rwsem_down_read_failed(struct rw_semaphore *sem) | ||
| 227 | { | 226 | { |
| 228 | return rwsem_down_failed_common(sem, RWSEM_WAITING_FOR_READ, | 227 | return rwsem_down_failed_common(sem, RWSEM_WAITING_FOR_READ, |
| 229 | -RWSEM_ACTIVE_READ_BIAS); | 228 | -RWSEM_ACTIVE_READ_BIAS); |
| @@ -232,8 +231,7 @@ rwsem_down_read_failed(struct rw_semaphore *sem) | |||
| 232 | /* | 231 | /* |
| 233 | * wait for the write lock to be granted | 232 | * wait for the write lock to be granted |
| 234 | */ | 233 | */ |
| 235 | asmregparm struct rw_semaphore __sched * | 234 | struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem) |
| 236 | rwsem_down_write_failed(struct rw_semaphore *sem) | ||
| 237 | { | 235 | { |
| 238 | return rwsem_down_failed_common(sem, RWSEM_WAITING_FOR_WRITE, | 236 | return rwsem_down_failed_common(sem, RWSEM_WAITING_FOR_WRITE, |
| 239 | -RWSEM_ACTIVE_WRITE_BIAS); | 237 | -RWSEM_ACTIVE_WRITE_BIAS); |
| @@ -243,7 +241,7 @@ rwsem_down_write_failed(struct rw_semaphore *sem) | |||
| 243 | * handle waking up a waiter on the semaphore | 241 | * handle waking up a waiter on the semaphore |
| 244 | * - up_read/up_write has decremented the active part of count if we come here | 242 | * - up_read/up_write has decremented the active part of count if we come here |
| 245 | */ | 243 | */ |
| 246 | asmregparm struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem) | 244 | struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem) |
| 247 | { | 245 | { |
| 248 | unsigned long flags; | 246 | unsigned long flags; |
| 249 | 247 | ||
| @@ -263,7 +261,7 @@ asmregparm struct rw_semaphore *rwsem_wake(struct rw_semaphore *sem) | |||
| 263 | * - caller incremented waiting part of count and discovered it still negative | 261 | * - caller incremented waiting part of count and discovered it still negative |
| 264 | * - just wake up any readers at the front of the queue | 262 | * - just wake up any readers at the front of the queue |
| 265 | */ | 263 | */ |
| 266 | asmregparm struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem) | 264 | struct rw_semaphore *rwsem_downgrade_wake(struct rw_semaphore *sem) |
| 267 | { | 265 | { |
| 268 | unsigned long flags; | 266 | unsigned long flags; |
| 269 | 267 | ||
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4c0383da1c9a..58848e3e392c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -2654,11 +2654,6 @@ sub process { | |||
| 2654 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); | 2654 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); |
| 2655 | } | 2655 | } |
| 2656 | 2656 | ||
| 2657 | # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated | ||
| 2658 | if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { | ||
| 2659 | ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); | ||
| 2660 | } | ||
| 2661 | |||
| 2662 | # warn about #if 0 | 2657 | # warn about #if 0 |
| 2663 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { | 2658 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
| 2664 | CHK("if this code is redundant consider removing it\n" . | 2659 | CHK("if this code is redundant consider removing it\n" . |
diff --git a/scripts/rt-tester/rt-tester.py b/scripts/rt-tester/rt-tester.py index 44423b4dcb82..8c81d76959ee 100644 --- a/scripts/rt-tester/rt-tester.py +++ b/scripts/rt-tester/rt-tester.py | |||
| @@ -33,8 +33,6 @@ cmd_opcodes = { | |||
| 33 | "lockintnowait" : "6", | 33 | "lockintnowait" : "6", |
| 34 | "lockcont" : "7", | 34 | "lockcont" : "7", |
| 35 | "unlock" : "8", | 35 | "unlock" : "8", |
| 36 | "lockbkl" : "9", | ||
| 37 | "unlockbkl" : "10", | ||
| 38 | "signal" : "11", | 36 | "signal" : "11", |
| 39 | "resetevent" : "98", | 37 | "resetevent" : "98", |
| 40 | "reset" : "99", | 38 | "reset" : "99", |
diff --git a/scripts/rt-tester/t2-l1-2rt-sameprio.tst b/scripts/rt-tester/t2-l1-2rt-sameprio.tst index 8821f27cc8be..3710c8b2090d 100644 --- a/scripts/rt-tester/t2-l1-2rt-sameprio.tst +++ b/scripts/rt-tester/t2-l1-2rt-sameprio.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal 0 | 22 | # signal 0 |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t2-l1-pi.tst b/scripts/rt-tester/t2-l1-pi.tst index cde1f189a02b..b4cc95975adb 100644 --- a/scripts/rt-tester/t2-l1-pi.tst +++ b/scripts/rt-tester/t2-l1-pi.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal 0 | 22 | # signal 0 |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t2-l1-signal.tst b/scripts/rt-tester/t2-l1-signal.tst index 3ab0bfc49950..1b57376cc1f7 100644 --- a/scripts/rt-tester/t2-l1-signal.tst +++ b/scripts/rt-tester/t2-l1-signal.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal 0 | 22 | # signal 0 |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t2-l2-2rt-deadlock.tst b/scripts/rt-tester/t2-l2-2rt-deadlock.tst index f4b5d5d6215f..68b10629b6f4 100644 --- a/scripts/rt-tester/t2-l2-2rt-deadlock.tst +++ b/scripts/rt-tester/t2-l2-2rt-deadlock.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal 0 | 22 | # signal 0 |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l1-pi-1rt.tst b/scripts/rt-tester/t3-l1-pi-1rt.tst index 63440ca2cce9..8e6c8b11ae56 100644 --- a/scripts/rt-tester/t3-l1-pi-1rt.tst +++ b/scripts/rt-tester/t3-l1-pi-1rt.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l1-pi-2rt.tst b/scripts/rt-tester/t3-l1-pi-2rt.tst index e5816fe67df3..69c2212fc520 100644 --- a/scripts/rt-tester/t3-l1-pi-2rt.tst +++ b/scripts/rt-tester/t3-l1-pi-2rt.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l1-pi-3rt.tst b/scripts/rt-tester/t3-l1-pi-3rt.tst index 718b82b5d3bb..9b0f1eb26a88 100644 --- a/scripts/rt-tester/t3-l1-pi-3rt.tst +++ b/scripts/rt-tester/t3-l1-pi-3rt.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l1-pi-signal.tst b/scripts/rt-tester/t3-l1-pi-signal.tst index c6e213563498..39ec74ab06ee 100644 --- a/scripts/rt-tester/t3-l1-pi-signal.tst +++ b/scripts/rt-tester/t3-l1-pi-signal.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l1-pi-steal.tst b/scripts/rt-tester/t3-l1-pi-steal.tst index f53749d59d79..e03db7e010fa 100644 --- a/scripts/rt-tester/t3-l1-pi-steal.tst +++ b/scripts/rt-tester/t3-l1-pi-steal.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t3-l2-pi.tst b/scripts/rt-tester/t3-l2-pi.tst index cdc3e4fd7bac..7b59100d3e48 100644 --- a/scripts/rt-tester/t3-l2-pi.tst +++ b/scripts/rt-tester/t3-l2-pi.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t4-l2-pi-deboost.tst b/scripts/rt-tester/t4-l2-pi-deboost.tst index baa14137f473..2f0e049d6443 100644 --- a/scripts/rt-tester/t4-l2-pi-deboost.tst +++ b/scripts/rt-tester/t4-l2-pi-deboost.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t5-l4-pi-boost-deboost-setsched.tst b/scripts/rt-tester/t5-l4-pi-boost-deboost-setsched.tst index e6ec0c81b54d..04f4034ff895 100644 --- a/scripts/rt-tester/t5-l4-pi-boost-deboost-setsched.tst +++ b/scripts/rt-tester/t5-l4-pi-boost-deboost-setsched.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
diff --git a/scripts/rt-tester/t5-l4-pi-boost-deboost.tst b/scripts/rt-tester/t5-l4-pi-boost-deboost.tst index ca64f8bbf4bc..a48a6ee29ddc 100644 --- a/scripts/rt-tester/t5-l4-pi-boost-deboost.tst +++ b/scripts/rt-tester/t5-l4-pi-boost-deboost.tst | |||
| @@ -19,8 +19,6 @@ | |||
| 19 | # lockintnowait lock nr (0-7) | 19 | # lockintnowait lock nr (0-7) |
| 20 | # lockcont lock nr (0-7) | 20 | # lockcont lock nr (0-7) |
| 21 | # unlock lock nr (0-7) | 21 | # unlock lock nr (0-7) |
| 22 | # lockbkl lock nr (0-7) | ||
| 23 | # unlockbkl lock nr (0-7) | ||
| 24 | # signal thread to signal (0-7) | 22 | # signal thread to signal (0-7) |
| 25 | # reset 0 | 23 | # reset 0 |
| 26 | # resetevent 0 | 24 | # resetevent 0 |
| @@ -39,9 +37,6 @@ | |||
| 39 | # blocked lock nr (0-7) | 37 | # blocked lock nr (0-7) |
| 40 | # blockedwake lock nr (0-7) | 38 | # blockedwake lock nr (0-7) |
| 41 | # unlocked lock nr (0-7) | 39 | # unlocked lock nr (0-7) |
| 42 | # lockedbkl dont care | ||
| 43 | # blockedbkl dont care | ||
| 44 | # unlockedbkl dont care | ||
| 45 | # opcodeeq command opcode or number | 40 | # opcodeeq command opcode or number |
| 46 | # opcodelt number | 41 | # opcodelt number |
| 47 | # opcodegt number | 42 | # opcodegt number |
