diff options
author | Daniel Walter <dwalter@google.com> | 2014-08-08 17:23:52 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-08 18:57:27 -0400 |
commit | 056610ac140ea4775d8855989c4316017ed3bd0a (patch) | |
tree | 7f54ea2ca63713899214e99236a95c91aade9e02 | |
parent | f9213e78c42ce9f712400b699511acfff51351a5 (diff) |
arch/arm/mach-omap2: replace strict_strto* with kstrto*
Replace obsolete strict_strto call with kstrto calls.
Simplify copy_from_user/strict_strto by using kstrto_from_user
Signed-off-by: Daniel Walter <dwalter@google.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | arch/arm/mach-omap2/board-omap3touchbook.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-omap2/mux.c | 22 |
2 files changed, 7 insertions, 17 deletions
diff --git a/arch/arm/mach-omap2/board-omap3touchbook.c b/arch/arm/mach-omap2/board-omap3touchbook.c index 7da48bc42bbf..70b904c010c6 100644 --- a/arch/arm/mach-omap2/board-omap3touchbook.c +++ b/arch/arm/mach-omap2/board-omap3touchbook.c | |||
@@ -336,7 +336,7 @@ static int __init early_touchbook_revision(char *p) | |||
336 | if (!p) | 336 | if (!p) |
337 | return 0; | 337 | return 0; |
338 | 338 | ||
339 | return strict_strtoul(p, 10, &touchbook_revision); | 339 | return kstrtoul(p, 10, &touchbook_revision); |
340 | } | 340 | } |
341 | early_param("tbr", early_touchbook_revision); | 341 | early_param("tbr", early_touchbook_revision); |
342 | 342 | ||
diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c index f62f7537d899..ac8a249779f2 100644 --- a/arch/arm/mach-omap2/mux.c +++ b/arch/arm/mach-omap2/mux.c | |||
@@ -681,29 +681,19 @@ static ssize_t omap_mux_dbg_signal_write(struct file *file, | |||
681 | const char __user *user_buf, | 681 | const char __user *user_buf, |
682 | size_t count, loff_t *ppos) | 682 | size_t count, loff_t *ppos) |
683 | { | 683 | { |
684 | char buf[OMAP_MUX_MAX_ARG_CHAR]; | ||
685 | struct seq_file *seqf; | 684 | struct seq_file *seqf; |
686 | struct omap_mux *m; | 685 | struct omap_mux *m; |
687 | unsigned long val; | 686 | u16 val; |
688 | int buf_size, ret; | 687 | int ret; |
689 | struct omap_mux_partition *partition; | 688 | struct omap_mux_partition *partition; |
690 | 689 | ||
691 | if (count > OMAP_MUX_MAX_ARG_CHAR) | 690 | if (count > OMAP_MUX_MAX_ARG_CHAR) |
692 | return -EINVAL; | 691 | return -EINVAL; |
693 | 692 | ||
694 | memset(buf, 0, sizeof(buf)); | 693 | ret = kstrtou16_from_user(user_buf, count, 0x10, &val); |
695 | buf_size = min(count, sizeof(buf) - 1); | ||
696 | |||
697 | if (copy_from_user(buf, user_buf, buf_size)) | ||
698 | return -EFAULT; | ||
699 | |||
700 | ret = strict_strtoul(buf, 0x10, &val); | ||
701 | if (ret < 0) | 694 | if (ret < 0) |
702 | return ret; | 695 | return ret; |
703 | 696 | ||
704 | if (val > 0xffff) | ||
705 | return -EINVAL; | ||
706 | |||
707 | seqf = file->private_data; | 697 | seqf = file->private_data; |
708 | m = seqf->private; | 698 | m = seqf->private; |
709 | 699 | ||
@@ -711,7 +701,7 @@ static ssize_t omap_mux_dbg_signal_write(struct file *file, | |||
711 | if (!partition) | 701 | if (!partition) |
712 | return -ENODEV; | 702 | return -ENODEV; |
713 | 703 | ||
714 | omap_mux_write(partition, (u16)val, m->reg_offset); | 704 | omap_mux_write(partition, val, m->reg_offset); |
715 | *ppos += count; | 705 | *ppos += count; |
716 | 706 | ||
717 | return count; | 707 | return count; |
@@ -917,14 +907,14 @@ static void __init omap_mux_set_cmdline_signals(void) | |||
917 | 907 | ||
918 | while ((token = strsep(&next_opt, ",")) != NULL) { | 908 | while ((token = strsep(&next_opt, ",")) != NULL) { |
919 | char *keyval, *name; | 909 | char *keyval, *name; |
920 | unsigned long val; | 910 | u16 val; |
921 | 911 | ||
922 | keyval = token; | 912 | keyval = token; |
923 | name = strsep(&keyval, "="); | 913 | name = strsep(&keyval, "="); |
924 | if (name) { | 914 | if (name) { |
925 | int res; | 915 | int res; |
926 | 916 | ||
927 | res = strict_strtoul(keyval, 0x10, &val); | 917 | res = kstrtou16(keyval, 0x10, &val); |
928 | if (res < 0) | 918 | if (res < 0) |
929 | continue; | 919 | continue; |
930 | 920 | ||