aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChangli Gao <xiaosuo@gmail.com>2010-08-23 00:03:33 -0400
committerDavid S. Miller <davem@davemloft.net>2010-08-23 00:03:33 -0400
commit05532121da0728eaedac2a0a5c3cecad3a95d765 (patch)
tree1b1ff9e02b87527868c7698f0369d00d4c86a0a0
parent2436243a39de56f03d38c74139261cc61bea8456 (diff)
net: 802.1q: make vlan_hwaccel_do_receive() return void
vlan_hwaccel_do_receive() always returns 0, so make it return void. Signed-off-by: Changli Gao <xiaosuo@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/linux/if_vlan.h5
-rw-r--r--net/8021q/vlan_core.c3
-rw-r--r--net/core/dev.c4
3 files changed, 5 insertions, 7 deletions
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 3d870fda8c4f..a52320751bfc 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -119,7 +119,7 @@ extern u16 vlan_dev_vlan_id(const struct net_device *dev);
119 119
120extern int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp, 120extern int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
121 u16 vlan_tci, int polling); 121 u16 vlan_tci, int polling);
122extern int vlan_hwaccel_do_receive(struct sk_buff *skb); 122extern void vlan_hwaccel_do_receive(struct sk_buff *skb);
123extern gro_result_t 123extern gro_result_t
124vlan_gro_receive(struct napi_struct *napi, struct vlan_group *grp, 124vlan_gro_receive(struct napi_struct *napi, struct vlan_group *grp,
125 unsigned int vlan_tci, struct sk_buff *skb); 125 unsigned int vlan_tci, struct sk_buff *skb);
@@ -147,9 +147,8 @@ static inline int __vlan_hwaccel_rx(struct sk_buff *skb, struct vlan_group *grp,
147 return NET_XMIT_SUCCESS; 147 return NET_XMIT_SUCCESS;
148} 148}
149 149
150static inline int vlan_hwaccel_do_receive(struct sk_buff *skb) 150static inline void vlan_hwaccel_do_receive(struct sk_buff *skb)
151{ 151{
152 return 0;
153} 152}
154 153
155static inline gro_result_t 154static inline gro_result_t
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
index 01ddb0472f86..07eeb5b99dce 100644
--- a/net/8021q/vlan_core.c
+++ b/net/8021q/vlan_core.c
@@ -35,7 +35,7 @@ drop:
35} 35}
36EXPORT_SYMBOL(__vlan_hwaccel_rx); 36EXPORT_SYMBOL(__vlan_hwaccel_rx);
37 37
38int vlan_hwaccel_do_receive(struct sk_buff *skb) 38void vlan_hwaccel_do_receive(struct sk_buff *skb)
39{ 39{
40 struct net_device *dev = skb->dev; 40 struct net_device *dev = skb->dev;
41 struct vlan_rx_stats *rx_stats; 41 struct vlan_rx_stats *rx_stats;
@@ -69,7 +69,6 @@ int vlan_hwaccel_do_receive(struct sk_buff *skb)
69 break; 69 break;
70 } 70 }
71 u64_stats_update_end(&rx_stats->syncp); 71 u64_stats_update_end(&rx_stats->syncp);
72 return 0;
73} 72}
74 73
75struct net_device *vlan_dev_real_dev(const struct net_device *dev) 74struct net_device *vlan_dev_real_dev(const struct net_device *dev)
diff --git a/net/core/dev.c b/net/core/dev.c
index 7cd5237d9822..d569f88bcf80 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2841,8 +2841,8 @@ static int __netif_receive_skb(struct sk_buff *skb)
2841 if (!netdev_tstamp_prequeue) 2841 if (!netdev_tstamp_prequeue)
2842 net_timestamp_check(skb); 2842 net_timestamp_check(skb);
2843 2843
2844 if (vlan_tx_tag_present(skb) && vlan_hwaccel_do_receive(skb)) 2844 if (vlan_tx_tag_present(skb))
2845 return NET_RX_SUCCESS; 2845 vlan_hwaccel_do_receive(skb);
2846 2846
2847 /* if we've gotten here through NAPI, check netpoll */ 2847 /* if we've gotten here through NAPI, check netpoll */
2848 if (netpoll_receive_skb(skb)) 2848 if (netpoll_receive_skb(skb))