aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@st.com>2011-08-05 06:02:31 -0400
committerVinod Koul <vinod.koul@intel.com>2011-08-25 10:03:38 -0400
commit0532e6fced3c4f6a4eda7f078d8aa36405647c07 (patch)
treebe16a01b15211749fc027cb04aee584755d4dad3
parent5a61233073a35a7ae152af77ed80dfc465c38fc7 (diff)
dmaengine/amba-pl08x: Remove redundant comment and rewrite original
Similar comment is present over routine also pl08x_choose_master_bus(). Keeping one of them. Also rewrite that comment to convey message clearly. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
-rw-r--r--drivers/dma/amba-pl08x.c15
1 files changed, 7 insertions, 8 deletions
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 01c2f507e950..6c52959b00af 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -497,9 +497,13 @@ struct pl08x_lli_build_data {
497}; 497};
498 498
499/* 499/*
500 * Autoselect a master bus to use for the transfer this prefers the 500 * Autoselect a master bus to use for the transfer. Slave will be the chosen as
501 * destination bus if both available if fixed address on one bus the 501 * victim in case src & dest are not similarly aligned. i.e. If after aligning
502 * other will be chosen 502 * masters address with width requirements of transfer (by sending few byte by
503 * byte data), slave is still not aligned, then its width will be reduced to
504 * BYTE.
505 * - prefers the destination bus if both available
506 * - if fixed address on one bus the other will be chosen
503 */ 507 */
504static void pl08x_choose_master_bus(struct pl08x_lli_build_data *bd, 508static void pl08x_choose_master_bus(struct pl08x_lli_build_data *bd,
505 struct pl08x_bus_data **mbus, struct pl08x_bus_data **sbus, u32 cctl) 509 struct pl08x_bus_data **mbus, struct pl08x_bus_data **sbus, u32 cctl)
@@ -625,11 +629,6 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x,
625 /* We need to count this down to zero */ 629 /* We need to count this down to zero */
626 bd.remainder = txd->len; 630 bd.remainder = txd->len;
627 631
628 /*
629 * Choose bus to align to
630 * - prefers destination bus if both available
631 * - if fixed address on one bus chooses other
632 */
633 pl08x_choose_master_bus(&bd, &mbus, &sbus, cctl); 632 pl08x_choose_master_bus(&bd, &mbus, &sbus, cctl);
634 633
635 dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu llimax=%zu\n", 634 dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu llimax=%zu\n",