diff options
| author | Frans Klaver <frans.klaver@xsens.com> | 2015-01-14 03:15:40 -0500 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2015-01-20 07:58:29 -0500 |
| commit | 0428c40d4c448f5dc63b0f76de14fa0affa7aa2f (patch) | |
| tree | f13fc426f7ff140748d304e4aef374d1ddfcce3a | |
| parent | 818ca4c8c7be4910f896c702645009f09813347f (diff) | |
power: reset: ltc2952: drop empty suspend/resume functions
Documentation/SubmittingDrivers suggests these be implemented even when
they do nothing. On the other hand, the platform code calls these
functions 'legacy'. Suspend and resume operations should go into a
pm_ops structure, pointed at by the driver's pm field. This approach
would lead to a lot of boiler plate, while achieving nothing. Drop the
functions instead.
Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
| -rw-r--r-- | drivers/power/reset/ltc2952-poweroff.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c index 8c936ed555c1..d29948762ceb 100644 --- a/drivers/power/reset/ltc2952-poweroff.c +++ b/drivers/power/reset/ltc2952-poweroff.c | |||
| @@ -184,17 +184,6 @@ static void ltc2952_poweroff_kill(void) | |||
| 184 | gpiod_set_value(ltc2952_data->gpio_kill, 1); | 184 | gpiod_set_value(ltc2952_data->gpio_kill, 1); |
| 185 | } | 185 | } |
| 186 | 186 | ||
| 187 | static int ltc2952_poweroff_suspend(struct platform_device *pdev, | ||
| 188 | pm_message_t state) | ||
| 189 | { | ||
| 190 | return -ENOSYS; | ||
| 191 | } | ||
| 192 | |||
| 193 | static int ltc2952_poweroff_resume(struct platform_device *pdev) | ||
| 194 | { | ||
| 195 | return -ENOSYS; | ||
| 196 | } | ||
| 197 | |||
| 198 | static void ltc2952_poweroff_default(struct ltc2952_poweroff *data) | 187 | static void ltc2952_poweroff_default(struct ltc2952_poweroff *data) |
| 199 | { | 188 | { |
| 200 | data->wde_interval = ktime_set(0, 300L*1E6L); | 189 | data->wde_interval = ktime_set(0, 300L*1E6L); |
| @@ -322,8 +311,6 @@ static struct platform_driver ltc2952_poweroff_driver = { | |||
| 322 | .name = "ltc2952-poweroff", | 311 | .name = "ltc2952-poweroff", |
| 323 | .of_match_table = of_ltc2952_poweroff_match, | 312 | .of_match_table = of_ltc2952_poweroff_match, |
| 324 | }, | 313 | }, |
| 325 | .suspend = ltc2952_poweroff_suspend, | ||
| 326 | .resume = ltc2952_poweroff_resume, | ||
| 327 | }; | 314 | }; |
| 328 | 315 | ||
| 329 | module_platform_driver(ltc2952_poweroff_driver); | 316 | module_platform_driver(ltc2952_poweroff_driver); |
