aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2013-04-16 16:38:32 -0400
committerJoerg Roedel <joro@8bytes.org>2013-04-18 11:00:47 -0400
commit03bbcb2e7e292838bb0244f5a7816d194c911d62 (patch)
treee12aaa5de8ba8f7168e4112604e3f2afc6453154
parentbd5cdad0c8e0f0adcd6e9c582abe4c4233c19b03 (diff)
iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets
A few years back intel published a spec update: http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf For the 5520 and 5500 chipsets which contained an errata (specificially errata 53), which noted that these chipsets can't properly do interrupt remapping, and as a result the recommend that interrupt remapping be disabled in bios. While many vendors have a bios update to do exactly that, not all do, and of course not all users update their bios to a level that corrects the problem. As a result, occasionally interrupts can arrive at a cpu even after affinity for that interrupt has be moved, leading to lost or spurrious interrupts (usually characterized by the message: kernel: do_IRQ: 7.71 No irq handler for vector (irq -1) There have been several incidents recently of people seeing this error, and investigation has shown that they have system for which their BIOS level is such that this feature was not properly turned off. As such, it would be good to give them a reminder that their systems are vulnurable to this problem. For details of those that reported the problem, please see: https://bugzilla.redhat.com/show_bug.cgi?id=887006 [ Joerg: Removed CONFIG_IRQ_REMAP ifdef from early-quirks.c ] Signed-off-by: Neil Horman <nhorman@tuxdriver.com> CC: Prarit Bhargava <prarit@redhat.com> CC: Don Zickus <dzickus@redhat.com> CC: Don Dutile <ddutile@redhat.com> CC: Bjorn Helgaas <bhelgaas@google.com> CC: Asit Mallick <asit.k.mallick@intel.com> CC: David Woodhouse <dwmw2@infradead.org> CC: linux-pci@vger.kernel.org CC: Joerg Roedel <joro@8bytes.org> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Arkadiusz Miƛkiewicz <arekm@maven.pl> Signed-off-by: Joerg Roedel <joro@8bytes.org>
-rw-r--r--arch/x86/include/asm/irq_remapping.h2
-rw-r--r--arch/x86/kernel/early-quirks.c20
-rw-r--r--drivers/iommu/intel_irq_remapping.c10
-rw-r--r--drivers/iommu/irq_remapping.c6
-rw-r--r--drivers/iommu/irq_remapping.h2
5 files changed, 40 insertions, 0 deletions
diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h
index 95fd3527f632..aca6aa2088b2 100644
--- a/arch/x86/include/asm/irq_remapping.h
+++ b/arch/x86/include/asm/irq_remapping.h
@@ -28,6 +28,7 @@
28 28
29extern void setup_irq_remapping_ops(void); 29extern void setup_irq_remapping_ops(void);
30extern int irq_remapping_supported(void); 30extern int irq_remapping_supported(void);
31extern void set_irq_remapping_broken(void);
31extern int irq_remapping_prepare(void); 32extern int irq_remapping_prepare(void);
32extern int irq_remapping_enable(void); 33extern int irq_remapping_enable(void);
33extern void irq_remapping_disable(void); 34extern void irq_remapping_disable(void);
@@ -54,6 +55,7 @@ void irq_remap_modify_chip_defaults(struct irq_chip *chip);
54 55
55static inline void setup_irq_remapping_ops(void) { } 56static inline void setup_irq_remapping_ops(void) { }
56static inline int irq_remapping_supported(void) { return 0; } 57static inline int irq_remapping_supported(void) { return 0; }
58static inline void set_irq_remapping_broken(void) { }
57static inline int irq_remapping_prepare(void) { return -ENODEV; } 59static inline int irq_remapping_prepare(void) { return -ENODEV; }
58static inline int irq_remapping_enable(void) { return -ENODEV; } 60static inline int irq_remapping_enable(void) { return -ENODEV; }
59static inline void irq_remapping_disable(void) { } 61static inline void irq_remapping_disable(void) { }
diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
index 3755ef494390..94ab6b90dd3f 100644
--- a/arch/x86/kernel/early-quirks.c
+++ b/arch/x86/kernel/early-quirks.c
@@ -18,6 +18,7 @@
18#include <asm/apic.h> 18#include <asm/apic.h>
19#include <asm/iommu.h> 19#include <asm/iommu.h>
20#include <asm/gart.h> 20#include <asm/gart.h>
21#include <asm/irq_remapping.h>
21 22
22static void __init fix_hypertransport_config(int num, int slot, int func) 23static void __init fix_hypertransport_config(int num, int slot, int func)
23{ 24{
@@ -192,6 +193,21 @@ static void __init ati_bugs_contd(int num, int slot, int func)
192} 193}
193#endif 194#endif
194 195
196static void __init intel_remapping_check(int num, int slot, int func)
197{
198 u8 revision;
199
200 revision = read_pci_config_byte(num, slot, func, PCI_REVISION_ID);
201
202 /*
203 * Revision 0x13 of this chipset supports irq remapping
204 * but has an erratum that breaks its behavior, flag it as such
205 */
206 if (revision == 0x13)
207 set_irq_remapping_broken();
208
209}
210
195#define QFLAG_APPLY_ONCE 0x1 211#define QFLAG_APPLY_ONCE 0x1
196#define QFLAG_APPLIED 0x2 212#define QFLAG_APPLIED 0x2
197#define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED) 213#define QFLAG_DONE (QFLAG_APPLY_ONCE|QFLAG_APPLIED)
@@ -221,6 +237,10 @@ static struct chipset early_qrk[] __initdata = {
221 PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs }, 237 PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs },
222 { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, 238 { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS,
223 PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs_contd }, 239 PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs_contd },
240 { PCI_VENDOR_ID_INTEL, 0x3403, PCI_CLASS_BRIDGE_HOST,
241 PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
242 { PCI_VENDOR_ID_INTEL, 0x3406, PCI_CLASS_BRIDGE_HOST,
243 PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check },
224 {} 244 {}
225}; 245};
226 246
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index f3b8f23b5d8f..5b19b2d6ec2d 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -524,6 +524,16 @@ static int __init intel_irq_remapping_supported(void)
524 524
525 if (disable_irq_remap) 525 if (disable_irq_remap)
526 return 0; 526 return 0;
527 if (irq_remap_broken) {
528 WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND,
529 "This system BIOS has enabled interrupt remapping\n"
530 "on a chipset that contains an erratum making that\n"
531 "feature unstable. To maintain system stability\n"
532 "interrupt remapping is being disabled. Please\n"
533 "contact your BIOS vendor for an update\n");
534 disable_irq_remap = 1;
535 return 0;
536 }
527 537
528 if (!dmar_ir_support()) 538 if (!dmar_ir_support())
529 return 0; 539 return 0;
diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c
index d56f8c17c5fe..3c11043bdee5 100644
--- a/drivers/iommu/irq_remapping.c
+++ b/drivers/iommu/irq_remapping.c
@@ -19,6 +19,7 @@
19int irq_remapping_enabled; 19int irq_remapping_enabled;
20 20
21int disable_irq_remap; 21int disable_irq_remap;
22int irq_remap_broken;
22int disable_sourceid_checking; 23int disable_sourceid_checking;
23int no_x2apic_optout; 24int no_x2apic_optout;
24 25
@@ -211,6 +212,11 @@ void __init setup_irq_remapping_ops(void)
211#endif 212#endif
212} 213}
213 214
215void set_irq_remapping_broken(void)
216{
217 irq_remap_broken = 1;
218}
219
214int irq_remapping_supported(void) 220int irq_remapping_supported(void)
215{ 221{
216 if (disable_irq_remap) 222 if (disable_irq_remap)
diff --git a/drivers/iommu/irq_remapping.h b/drivers/iommu/irq_remapping.h
index ecb637670405..90c4dae5a46b 100644
--- a/drivers/iommu/irq_remapping.h
+++ b/drivers/iommu/irq_remapping.h
@@ -32,6 +32,7 @@ struct pci_dev;
32struct msi_msg; 32struct msi_msg;
33 33
34extern int disable_irq_remap; 34extern int disable_irq_remap;
35extern int irq_remap_broken;
35extern int disable_sourceid_checking; 36extern int disable_sourceid_checking;
36extern int no_x2apic_optout; 37extern int no_x2apic_optout;
37extern int irq_remapping_enabled; 38extern int irq_remapping_enabled;
@@ -89,6 +90,7 @@ extern struct irq_remap_ops amd_iommu_irq_ops;
89 90
90#define irq_remapping_enabled 0 91#define irq_remapping_enabled 0
91#define disable_irq_remap 1 92#define disable_irq_remap 1
93#define irq_remap_broken 0
92 94
93#endif /* CONFIG_IRQ_REMAP */ 95#endif /* CONFIG_IRQ_REMAP */
94 96