aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmir Vadai <amirv@mellanox.com>2013-10-07 07:38:13 -0400
committerDavid S. Miller <davem@davemloft.net>2013-10-08 16:09:50 -0400
commit021f1107ffdae7a82af6c53f4c52654062e365c6 (patch)
treeac5bd06eed05aec7bba4c49ba55aaaf32a8e39e9
parent70fbe0794393829d9acd686428d87c27b6f6984b (diff)
net/mlx4_en: Fix pages never dma unmapped on rx
This patch fixes a bug introduced by commit 51151a16 (mlx4: allow order-0 memory allocations in RX path). dma_unmap_page never reached because condition to detect last fragment in page is wrong. offset+frag_stride can't be greater than size, need to make sure no additional frag will fit in page => compare offset + frag_stride + next_frag_size instead. next_frag_size is the same as the current one, since page is shared only with frags of the same size. CC: Eric Dumazet <edumazet@google.com> Signed-off-by: Amir Vadai <amirv@mellanox.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/mellanox/mlx4/en_rx.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 066fc2747854..afe2efa69c86 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -135,9 +135,10 @@ static void mlx4_en_free_frag(struct mlx4_en_priv *priv,
135 int i) 135 int i)
136{ 136{
137 const struct mlx4_en_frag_info *frag_info = &priv->frag_info[i]; 137 const struct mlx4_en_frag_info *frag_info = &priv->frag_info[i];
138 u32 next_frag_end = frags[i].page_offset + 2 * frag_info->frag_stride;
138 139
139 if (frags[i].page_offset + frag_info->frag_stride > 140
140 frags[i].page_size) 141 if (next_frag_end > frags[i].page_size)
141 dma_unmap_page(priv->ddev, frags[i].dma, frags[i].page_size, 142 dma_unmap_page(priv->ddev, frags[i].dma, frags[i].page_size,
142 PCI_DMA_FROMDEVICE); 143 PCI_DMA_FROMDEVICE);
143 144