diff options
author | Parag Warudkar <parag.lkml@gmail.com> | 2008-10-18 23:28:50 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-20 11:52:42 -0400 |
commit | 01e8ef11bc1a74e65678ed55795f59266d4add01 (patch) | |
tree | 293cbe5df96191ac10afb050bd4cce54ff2c01f9 | |
parent | bb26b963d8343bb1bde842fba0b6e00cad841f31 (diff) |
x86: sysfs: kill owner field from attribute
Tejun's commit 7b595756ec1f49e0049a9e01a1298d53a7faaa15 made sysfs
attribute->owner unnecessary. But the field was left in the structure to
ease the merge. It's been over a year since that change and it is now
time to start killing attribute->owner along with its users - one arch at
a time!
This patch is attempt #1 to get rid of attribute->owner only for
CONFIG_X86_64 or CONFIG_X86_32 . We will deal with other arches later on
as and when possible - avr32 will be the next since that is something I
can test. Compile (make allyesconfig / make allmodconfig / custom config)
and boot tested.
akpm: the idea is that we put the declaration of sttribute.owner inside
`#ifndef CONFIG_X86'. But that proved to be too ambitious for now because
new usages kept on turning up in subsystem trees.
[akpm: remove the ifdef for now]
Signed-off-by: Parag Warudkar <parag.lkml@gmail.com>
Cc: Greg KH <greg@kroah.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Tejun Heo <htejun@gmail.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: David Brownell <david-b@pacbell.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/acpi/battery.c | 2 | ||||
-rw-r--r-- | drivers/acpi/sbs.c | 2 | ||||
-rw-r--r-- | drivers/acpi/system.c | 1 | ||||
-rw-r--r-- | drivers/block/aoe/aoeblk.c | 2 | ||||
-rw-r--r-- | drivers/block/nbd.c | 2 | ||||
-rw-r--r-- | drivers/firmware/iscsi_ibft.c | 1 | ||||
-rw-r--r-- | drivers/i2c/chips/at24.c | 1 | ||||
-rw-r--r-- | drivers/i2c/chips/ds1682.c | 1 | ||||
-rw-r--r-- | drivers/infiniband/core/cm.c | 2 | ||||
-rw-r--r-- | drivers/memstick/core/mspro_block.c | 1 | ||||
-rw-r--r-- | drivers/power/power_supply_sysfs.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-cmos.c | 1 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1305.c | 1 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1307.c | 1 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1511.c | 1 | ||||
-rw-r--r-- | drivers/rtc/rtc-m48t59.c | 1 | ||||
-rw-r--r-- | drivers/rtc/rtc-stk17ta8.c | 1 | ||||
-rw-r--r-- | drivers/scsi/arcmsr/arcmsr_attr.c | 3 | ||||
-rw-r--r-- | drivers/w1/slaves/w1_ds2760.c | 1 | ||||
-rw-r--r-- | include/linux/sysfs.h | 5 |
20 files changed, 9 insertions, 23 deletions
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index b1c723f9f58d..70f7f60929ca 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c | |||
@@ -431,7 +431,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, | |||
431 | } | 431 | } |
432 | 432 | ||
433 | static struct device_attribute alarm_attr = { | 433 | static struct device_attribute alarm_attr = { |
434 | .attr = {.name = "alarm", .mode = 0644, .owner = THIS_MODULE}, | 434 | .attr = {.name = "alarm", .mode = 0644}, |
435 | .show = acpi_battery_alarm_show, | 435 | .show = acpi_battery_alarm_show, |
436 | .store = acpi_battery_alarm_store, | 436 | .store = acpi_battery_alarm_store, |
437 | }; | 437 | }; |
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c index 10a36512647c..7b011e7e29fe 100644 --- a/drivers/acpi/sbs.c +++ b/drivers/acpi/sbs.c | |||
@@ -463,7 +463,7 @@ static ssize_t acpi_battery_alarm_store(struct device *dev, | |||
463 | } | 463 | } |
464 | 464 | ||
465 | static struct device_attribute alarm_attr = { | 465 | static struct device_attribute alarm_attr = { |
466 | .attr = {.name = "alarm", .mode = 0644, .owner = THIS_MODULE}, | 466 | .attr = {.name = "alarm", .mode = 0644}, |
467 | .show = acpi_battery_alarm_show, | 467 | .show = acpi_battery_alarm_show, |
468 | .store = acpi_battery_alarm_store, | 468 | .store = acpi_battery_alarm_store, |
469 | }; | 469 | }; |
diff --git a/drivers/acpi/system.c b/drivers/acpi/system.c index 91dec448b3ed..24e80fd927e2 100644 --- a/drivers/acpi/system.c +++ b/drivers/acpi/system.c | |||
@@ -115,7 +115,6 @@ static void acpi_table_attr_init(struct acpi_table_attr *table_attr, | |||
115 | table_attr->attr.read = acpi_table_show; | 115 | table_attr->attr.read = acpi_table_show; |
116 | table_attr->attr.attr.name = table_attr->name; | 116 | table_attr->attr.attr.name = table_attr->name; |
117 | table_attr->attr.attr.mode = 0444; | 117 | table_attr->attr.attr.mode = 0444; |
118 | table_attr->attr.attr.owner = THIS_MODULE; | ||
119 | 118 | ||
120 | return; | 119 | return; |
121 | } | 120 | } |
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index b82654e883a7..d876ad861237 100644 --- a/drivers/block/aoe/aoeblk.c +++ b/drivers/block/aoe/aoeblk.c | |||
@@ -90,7 +90,7 @@ static DEVICE_ATTR(state, S_IRUGO, aoedisk_show_state, NULL); | |||
90 | static DEVICE_ATTR(mac, S_IRUGO, aoedisk_show_mac, NULL); | 90 | static DEVICE_ATTR(mac, S_IRUGO, aoedisk_show_mac, NULL); |
91 | static DEVICE_ATTR(netif, S_IRUGO, aoedisk_show_netif, NULL); | 91 | static DEVICE_ATTR(netif, S_IRUGO, aoedisk_show_netif, NULL); |
92 | static struct device_attribute dev_attr_firmware_version = { | 92 | static struct device_attribute dev_attr_firmware_version = { |
93 | .attr = { .name = "firmware-version", .mode = S_IRUGO, .owner = THIS_MODULE }, | 93 | .attr = { .name = "firmware-version", .mode = S_IRUGO }, |
94 | .show = aoedisk_show_fwver, | 94 | .show = aoedisk_show_fwver, |
95 | }; | 95 | }; |
96 | 96 | ||
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 7b3351260d56..9034ca585afd 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c | |||
@@ -391,7 +391,7 @@ static ssize_t pid_show(struct device *dev, | |||
391 | } | 391 | } |
392 | 392 | ||
393 | static struct device_attribute pid_attr = { | 393 | static struct device_attribute pid_attr = { |
394 | .attr = { .name = "pid", .mode = S_IRUGO, .owner = THIS_MODULE }, | 394 | .attr = { .name = "pid", .mode = S_IRUGO}, |
395 | .show = pid_show, | 395 | .show = pid_show, |
396 | }; | 396 | }; |
397 | 397 | ||
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index deb154aa47c4..4353414a0b77 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c | |||
@@ -732,7 +732,6 @@ static int __init ibft_create_attribute(struct ibft_kobject *kobj_data, | |||
732 | 732 | ||
733 | attr->attr.name = name; | 733 | attr->attr.name = name; |
734 | attr->attr.mode = S_IRUSR; | 734 | attr->attr.mode = S_IRUSR; |
735 | attr->attr.owner = THIS_MODULE; | ||
736 | 735 | ||
737 | attr->hdr = hdr; | 736 | attr->hdr = hdr; |
738 | attr->show = show; | 737 | attr->show = show; |
diff --git a/drivers/i2c/chips/at24.c b/drivers/i2c/chips/at24.c index 2a4acb269569..d4775528abc6 100644 --- a/drivers/i2c/chips/at24.c +++ b/drivers/i2c/chips/at24.c | |||
@@ -460,7 +460,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) | |||
460 | */ | 460 | */ |
461 | at24->bin.attr.name = "eeprom"; | 461 | at24->bin.attr.name = "eeprom"; |
462 | at24->bin.attr.mode = chip.flags & AT24_FLAG_IRUGO ? S_IRUGO : S_IRUSR; | 462 | at24->bin.attr.mode = chip.flags & AT24_FLAG_IRUGO ? S_IRUGO : S_IRUSR; |
463 | at24->bin.attr.owner = THIS_MODULE; | ||
464 | at24->bin.read = at24_bin_read; | 463 | at24->bin.read = at24_bin_read; |
465 | at24->bin.size = chip.byte_len; | 464 | at24->bin.size = chip.byte_len; |
466 | 465 | ||
diff --git a/drivers/i2c/chips/ds1682.c b/drivers/i2c/chips/ds1682.c index 23be4d42cb02..f3ee4a1abb77 100644 --- a/drivers/i2c/chips/ds1682.c +++ b/drivers/i2c/chips/ds1682.c | |||
@@ -190,7 +190,6 @@ static struct bin_attribute ds1682_eeprom_attr = { | |||
190 | .attr = { | 190 | .attr = { |
191 | .name = "eeprom", | 191 | .name = "eeprom", |
192 | .mode = S_IRUGO | S_IWUSR, | 192 | .mode = S_IRUGO | S_IWUSR, |
193 | .owner = THIS_MODULE, | ||
194 | }, | 193 | }, |
195 | .size = DS1682_EEPROM_SIZE, | 194 | .size = DS1682_EEPROM_SIZE, |
196 | .read = ds1682_eeprom_read, | 195 | .read = ds1682_eeprom_read, |
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index a78d35aecee3..f1e82a92e61e 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c | |||
@@ -122,7 +122,7 @@ struct cm_counter_attribute { | |||
122 | 122 | ||
123 | #define CM_COUNTER_ATTR(_name, _index) \ | 123 | #define CM_COUNTER_ATTR(_name, _index) \ |
124 | struct cm_counter_attribute cm_##_name##_counter_attr = { \ | 124 | struct cm_counter_attribute cm_##_name##_counter_attr = { \ |
125 | .attr = { .name = __stringify(_name), .mode = 0444, .owner = THIS_MODULE }, \ | 125 | .attr = { .name = __stringify(_name), .mode = 0444 }, \ |
126 | .index = _index \ | 126 | .index = _index \ |
127 | } | 127 | } |
128 | 128 | ||
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 6e291bf8237a..5263913e0c69 100644 --- a/drivers/memstick/core/mspro_block.c +++ b/drivers/memstick/core/mspro_block.c | |||
@@ -1044,7 +1044,6 @@ static int mspro_block_read_attributes(struct memstick_dev *card) | |||
1044 | 1044 | ||
1045 | s_attr->dev_attr.attr.name = s_attr->name; | 1045 | s_attr->dev_attr.attr.name = s_attr->name; |
1046 | s_attr->dev_attr.attr.mode = S_IRUGO; | 1046 | s_attr->dev_attr.attr.mode = S_IRUGO; |
1047 | s_attr->dev_attr.attr.owner = THIS_MODULE; | ||
1048 | s_attr->dev_attr.show = mspro_block_attr_show(s_attr->id); | 1047 | s_attr->dev_attr.show = mspro_block_attr_show(s_attr->id); |
1049 | 1048 | ||
1050 | if (!rc) | 1049 | if (!rc) |
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c index fe2aeb11939b..23ae8460f5c1 100644 --- a/drivers/power/power_supply_sysfs.c +++ b/drivers/power/power_supply_sysfs.c | |||
@@ -30,7 +30,7 @@ | |||
30 | 30 | ||
31 | #define POWER_SUPPLY_ATTR(_name) \ | 31 | #define POWER_SUPPLY_ATTR(_name) \ |
32 | { \ | 32 | { \ |
33 | .attr = { .name = #_name, .mode = 0444, .owner = THIS_MODULE }, \ | 33 | .attr = { .name = #_name, .mode = 0444 }, \ |
34 | .show = power_supply_show_property, \ | 34 | .show = power_supply_show_property, \ |
35 | .store = NULL, \ | 35 | .store = NULL, \ |
36 | } | 36 | } |
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 957365e4a746..5549231179a2 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c | |||
@@ -592,7 +592,6 @@ static struct bin_attribute nvram = { | |||
592 | .attr = { | 592 | .attr = { |
593 | .name = "nvram", | 593 | .name = "nvram", |
594 | .mode = S_IRUGO | S_IWUSR, | 594 | .mode = S_IRUGO | S_IWUSR, |
595 | .owner = THIS_MODULE, | ||
596 | }, | 595 | }, |
597 | 596 | ||
598 | .read = cmos_nvram_read, | 597 | .read = cmos_nvram_read, |
diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c index 57b470f3fc0b..fc372df6534b 100644 --- a/drivers/rtc/rtc-ds1305.c +++ b/drivers/rtc/rtc-ds1305.c | |||
@@ -606,7 +606,6 @@ ds1305_nvram_write(struct kobject *kobj, struct bin_attribute *attr, | |||
606 | static struct bin_attribute nvram = { | 606 | static struct bin_attribute nvram = { |
607 | .attr.name = "nvram", | 607 | .attr.name = "nvram", |
608 | .attr.mode = S_IRUGO | S_IWUSR, | 608 | .attr.mode = S_IRUGO | S_IWUSR, |
609 | .attr.owner = THIS_MODULE, | ||
610 | .read = ds1305_nvram_read, | 609 | .read = ds1305_nvram_read, |
611 | .write = ds1305_nvram_write, | 610 | .write = ds1305_nvram_write, |
612 | .size = DS1305_NVRAM_LEN, | 611 | .size = DS1305_NVRAM_LEN, |
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index cad23bcfebd4..162330b9d1dc 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c | |||
@@ -551,7 +551,6 @@ static struct bin_attribute nvram = { | |||
551 | .attr = { | 551 | .attr = { |
552 | .name = "nvram", | 552 | .name = "nvram", |
553 | .mode = S_IRUGO | S_IWUSR, | 553 | .mode = S_IRUGO | S_IWUSR, |
554 | .owner = THIS_MODULE, | ||
555 | }, | 554 | }, |
556 | 555 | ||
557 | .read = ds1307_nvram_read, | 556 | .read = ds1307_nvram_read, |
diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index 7bb0a962ad21..25caada78398 100644 --- a/drivers/rtc/rtc-ds1511.c +++ b/drivers/rtc/rtc-ds1511.c | |||
@@ -481,7 +481,6 @@ static struct bin_attribute ds1511_nvram_attr = { | |||
481 | .attr = { | 481 | .attr = { |
482 | .name = "nvram", | 482 | .name = "nvram", |
483 | .mode = S_IRUGO | S_IWUGO, | 483 | .mode = S_IRUGO | S_IWUGO, |
484 | .owner = THIS_MODULE, | ||
485 | }, | 484 | }, |
486 | .size = DS1511_RAM_MAX, | 485 | .size = DS1511_RAM_MAX, |
487 | .read = ds1511_nvram_read, | 486 | .read = ds1511_nvram_read, |
diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index ed671e29e07d..04b63dab6932 100644 --- a/drivers/rtc/rtc-m48t59.c +++ b/drivers/rtc/rtc-m48t59.c | |||
@@ -360,7 +360,6 @@ static struct bin_attribute m48t59_nvram_attr = { | |||
360 | .attr = { | 360 | .attr = { |
361 | .name = "nvram", | 361 | .name = "nvram", |
362 | .mode = S_IRUGO | S_IWUSR, | 362 | .mode = S_IRUGO | S_IWUSR, |
363 | .owner = THIS_MODULE, | ||
364 | }, | 363 | }, |
365 | .read = m48t59_nvram_read, | 364 | .read = m48t59_nvram_read, |
366 | .write = m48t59_nvram_write, | 365 | .write = m48t59_nvram_write, |
diff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c index 0947f8c23957..f4cd46e15af9 100644 --- a/drivers/rtc/rtc-stk17ta8.c +++ b/drivers/rtc/rtc-stk17ta8.c | |||
@@ -280,7 +280,6 @@ static struct bin_attribute stk17ta8_nvram_attr = { | |||
280 | .attr = { | 280 | .attr = { |
281 | .name = "nvram", | 281 | .name = "nvram", |
282 | .mode = S_IRUGO | S_IWUSR, | 282 | .mode = S_IRUGO | S_IWUSR, |
283 | .owner = THIS_MODULE, | ||
284 | }, | 283 | }, |
285 | .size = RTC_OFFSET, | 284 | .size = RTC_OFFSET, |
286 | .read = stk17ta8_nvram_read, | 285 | .read = stk17ta8_nvram_read, |
diff --git a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c index 69f8346aa288..5877f29a6005 100644 --- a/drivers/scsi/arcmsr/arcmsr_attr.c +++ b/drivers/scsi/arcmsr/arcmsr_attr.c | |||
@@ -189,7 +189,6 @@ static struct bin_attribute arcmsr_sysfs_message_read_attr = { | |||
189 | .attr = { | 189 | .attr = { |
190 | .name = "mu_read", | 190 | .name = "mu_read", |
191 | .mode = S_IRUSR , | 191 | .mode = S_IRUSR , |
192 | .owner = THIS_MODULE, | ||
193 | }, | 192 | }, |
194 | .size = 1032, | 193 | .size = 1032, |
195 | .read = arcmsr_sysfs_iop_message_read, | 194 | .read = arcmsr_sysfs_iop_message_read, |
@@ -199,7 +198,6 @@ static struct bin_attribute arcmsr_sysfs_message_write_attr = { | |||
199 | .attr = { | 198 | .attr = { |
200 | .name = "mu_write", | 199 | .name = "mu_write", |
201 | .mode = S_IWUSR, | 200 | .mode = S_IWUSR, |
202 | .owner = THIS_MODULE, | ||
203 | }, | 201 | }, |
204 | .size = 1032, | 202 | .size = 1032, |
205 | .write = arcmsr_sysfs_iop_message_write, | 203 | .write = arcmsr_sysfs_iop_message_write, |
@@ -209,7 +207,6 @@ static struct bin_attribute arcmsr_sysfs_message_clear_attr = { | |||
209 | .attr = { | 207 | .attr = { |
210 | .name = "mu_clear", | 208 | .name = "mu_clear", |
211 | .mode = S_IWUSR, | 209 | .mode = S_IWUSR, |
212 | .owner = THIS_MODULE, | ||
213 | }, | 210 | }, |
214 | .size = 1, | 211 | .size = 1, |
215 | .write = arcmsr_sysfs_iop_message_clear, | 212 | .write = arcmsr_sysfs_iop_message_clear, |
diff --git a/drivers/w1/slaves/w1_ds2760.c b/drivers/w1/slaves/w1_ds2760.c index ed6b0576208c..1f09d4e4144c 100644 --- a/drivers/w1/slaves/w1_ds2760.c +++ b/drivers/w1/slaves/w1_ds2760.c | |||
@@ -80,7 +80,6 @@ static struct bin_attribute w1_ds2760_bin_attr = { | |||
80 | .attr = { | 80 | .attr = { |
81 | .name = "w1_slave", | 81 | .name = "w1_slave", |
82 | .mode = S_IRUGO, | 82 | .mode = S_IRUGO, |
83 | .owner = THIS_MODULE, | ||
84 | }, | 83 | }, |
85 | .size = DS2760_DATA_SIZE, | 84 | .size = DS2760_DATA_SIZE, |
86 | .read = w1_ds2760_read_bin, | 85 | .read = w1_ds2760_read_bin, |
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h index b330e289d71f..9d68fed50f11 100644 --- a/include/linux/sysfs.h +++ b/include/linux/sysfs.h | |||
@@ -21,8 +21,9 @@ struct kobject; | |||
21 | struct module; | 21 | struct module; |
22 | 22 | ||
23 | /* FIXME | 23 | /* FIXME |
24 | * The *owner field is no longer used, but leave around | 24 | * The *owner field is no longer used. |
25 | * until the tree gets cleaned up fully. | 25 | * x86 tree has been cleaned up. The owner |
26 | * attribute is still left for other arches. | ||
26 | */ | 27 | */ |
27 | struct attribute { | 28 | struct attribute { |
28 | const char *name; | 29 | const char *name; |