diff options
author | Alexandre Courbot <acourbot@nvidia.com> | 2014-10-23 04:15:18 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2014-10-23 05:39:18 -0400 |
commit | 00d647b081b5ef2193fd15910fbd103f483a5d15 (patch) | |
tree | c49c46d90c10c8084f262258c09b46ad68f26665 | |
parent | f114040e3ea6e07372334ade75d1ee0775c355e1 (diff) |
ASoC: jack: update calls to gpiod_get*()
Add the new flags argument to calls of (devm_)gpiod_get*() and
remove any direction setting code afterwards.
Currently both forms (with or without the flags argument)
are valid thanks to transitional macros in
<linux/gpio/consumer.h>. These macros will be removed once
all consumers are updated and the flags argument will become
compulsary.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/soc-jack.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index ab47fea997a3..f921d0098518 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c | |||
@@ -309,7 +309,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, | |||
309 | /* GPIO descriptor */ | 309 | /* GPIO descriptor */ |
310 | gpios[i].desc = gpiod_get_index(gpios[i].gpiod_dev, | 310 | gpios[i].desc = gpiod_get_index(gpios[i].gpiod_dev, |
311 | gpios[i].name, | 311 | gpios[i].name, |
312 | gpios[i].idx); | 312 | gpios[i].idx, GPIOD_IN); |
313 | if (IS_ERR(gpios[i].desc)) { | 313 | if (IS_ERR(gpios[i].desc)) { |
314 | ret = PTR_ERR(gpios[i].desc); | 314 | ret = PTR_ERR(gpios[i].desc); |
315 | dev_err(gpios[i].gpiod_dev, | 315 | dev_err(gpios[i].gpiod_dev, |
@@ -327,17 +327,14 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count, | |||
327 | goto undo; | 327 | goto undo; |
328 | } | 328 | } |
329 | 329 | ||
330 | ret = gpio_request(gpios[i].gpio, gpios[i].name); | 330 | ret = gpio_request_one(gpios[i].gpio, GPIOF_IN, |
331 | gpios[i].name); | ||
331 | if (ret) | 332 | if (ret) |
332 | goto undo; | 333 | goto undo; |
333 | 334 | ||
334 | gpios[i].desc = gpio_to_desc(gpios[i].gpio); | 335 | gpios[i].desc = gpio_to_desc(gpios[i].gpio); |
335 | } | 336 | } |
336 | 337 | ||
337 | ret = gpiod_direction_input(gpios[i].desc); | ||
338 | if (ret) | ||
339 | goto err; | ||
340 | |||
341 | INIT_DELAYED_WORK(&gpios[i].work, gpio_work); | 338 | INIT_DELAYED_WORK(&gpios[i].work, gpio_work); |
342 | gpios[i].jack = jack; | 339 | gpios[i].jack = jack; |
343 | 340 | ||