diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2012-12-17 02:25:01 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-01-24 14:40:10 -0500 |
commit | 000ae33fdb5ff7bc7ae985b43e6278024a4985c2 (patch) | |
tree | 258ecac95d13e80915e0c1c5a3e67973dcba73fa | |
parent | 82ce75d93335f7079afc17fb7f2a4e549d2fbecb (diff) |
perf tests: Check python path on attr and binding test
Current perf test code tries to execute python version 2 in order to
test attributes on perf_event_open syscall. However it's not default
python version anymore a system can have python v3 only or v2 with a
different name (e.g. python2). So if there's no such python interpreter
with the name 'python', the test would fail like this (yes, it's
happened on my new archlinux laptop :).
13: struct perf_event_attr setup :sh: python: command not found
FAILED!
As we can pass name of the python interpreter on make, use it for
the attr test also.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1355729101-31317-1-git-send-email-namhyung@kernel.org
[ committer note: Added the same mechanism to the python binding test ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/Makefile | 7 | ||||
-rw-r--r-- | tools/perf/tests/attr.c | 2 | ||||
-rw-r--r-- | tools/perf/tests/python-use.c | 4 |
3 files changed, 8 insertions, 5 deletions
diff --git a/tools/perf/Makefile b/tools/perf/Makefile index d0d79574403a..3158f457b6ae 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile | |||
@@ -953,11 +953,14 @@ $(OUTPUT)util/exec_cmd.o: util/exec_cmd.c $(OUTPUT)PERF-CFLAGS | |||
953 | 953 | ||
954 | $(OUTPUT)tests/attr.o: tests/attr.c $(OUTPUT)PERF-CFLAGS | 954 | $(OUTPUT)tests/attr.o: tests/attr.c $(OUTPUT)PERF-CFLAGS |
955 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \ | 955 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \ |
956 | '-DBINDIR="$(bindir_SQ)"' \ | 956 | '-DBINDIR="$(bindir_SQ)"' -DPYTHON='"$(PYTHON_WORD)"' \ |
957 | $< | 957 | $< |
958 | 958 | ||
959 | $(OUTPUT)tests/python-use.o: tests/python-use.c $(OUTPUT)PERF-CFLAGS | 959 | $(OUTPUT)tests/python-use.o: tests/python-use.c $(OUTPUT)PERF-CFLAGS |
960 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DPYTHONPATH='"$(OUTPUT)/python"' $< | 960 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \ |
961 | -DPYTHONPATH='"$(OUTPUT)/python"' \ | ||
962 | -DPYTHON='"$(PYTHON_WORD)"' \ | ||
963 | $< | ||
961 | 964 | ||
962 | $(OUTPUT)util/config.o: util/config.c $(OUTPUT)PERF-CFLAGS | 965 | $(OUTPUT)util/config.o: util/config.c $(OUTPUT)PERF-CFLAGS |
963 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DETC_PERFCONFIG='"$(ETC_PERFCONFIG_SQ)"' $< | 966 | $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) -DETC_PERFCONFIG='"$(ETC_PERFCONFIG_SQ)"' $< |
diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c index 05b5acbabe5d..f61dd3fb546b 100644 --- a/tools/perf/tests/attr.c +++ b/tools/perf/tests/attr.c | |||
@@ -144,7 +144,7 @@ static int run_dir(const char *d, const char *perf) | |||
144 | { | 144 | { |
145 | char cmd[3*PATH_MAX]; | 145 | char cmd[3*PATH_MAX]; |
146 | 146 | ||
147 | snprintf(cmd, 3*PATH_MAX, "python %s/attr.py -d %s/attr/ -p %s %s", | 147 | snprintf(cmd, 3*PATH_MAX, PYTHON " %s/attr.py -d %s/attr/ -p %s %s", |
148 | d, d, perf, verbose ? "-v" : ""); | 148 | d, d, perf, verbose ? "-v" : ""); |
149 | 149 | ||
150 | return system(cmd); | 150 | return system(cmd); |
diff --git a/tools/perf/tests/python-use.c b/tools/perf/tests/python-use.c index 15301f4ac3f1..7760277c6def 100644 --- a/tools/perf/tests/python-use.c +++ b/tools/perf/tests/python-use.c | |||
@@ -13,8 +13,8 @@ int test__python_use(void) | |||
13 | char *cmd; | 13 | char *cmd; |
14 | int ret; | 14 | int ret; |
15 | 15 | ||
16 | if (asprintf(&cmd, "echo \"import sys ; sys.path.append('%s'); import perf\" | python %s", | 16 | if (asprintf(&cmd, "echo \"import sys ; sys.path.append('%s'); import perf\" | %s %s", |
17 | PYTHONPATH, verbose ? "" : "2> /dev/null") < 0) | 17 | PYTHONPATH, PYTHON, verbose ? "" : "2> /dev/null") < 0) |
18 | return -1; | 18 | return -1; |
19 | 19 | ||
20 | ret = system(cmd) ? -1 : 0; | 20 | ret = system(cmd) ? -1 : 0; |