1 files changed, 68 insertions, 182 deletions

diff --git a/sound/soc/codecs/wm8971.c b/sound/soc/codecs/wm8971.c
index a99620f335d..ad2692afbb3 100644
--- a/sound/soc/codecs/wm8971.c
+++ b/sound/soc/codecs/wm8971.c
@@ -38,6 +38,8 @@ static struct workqueue_struct *wm8971_workq = NULL;
 
 /* codec private data */
 struct wm8971_priv {
+        enum snd_soc_control_type control_type;
+        void *control_data;
         unsigned int sysclk;
 };
 
@@ -492,8 +494,7 @@ static int wm8971_pcm_hw_params(struct snd_pcm_substream *substream,
         struct snd_soc_dai *dai)
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
-        struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_codec *codec = rtd->codec;
         struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec);
         u16 iface = snd_soc_read(codec, WM8971_IFACE) & 0x1f3;
         u16 srate = snd_soc_read(codec, WM8971_SRATE) & 0x1c0;
@@ -573,8 +574,8 @@ static struct snd_soc_dai_ops wm8971_dai_ops = {
         .set_sysclk     = wm8971_set_dai_sysclk,
 };
 
-struct snd_soc_dai wm8971_dai = {
-        .name = "WM8971",
+static struct snd_soc_dai_driver wm8971_dai = {
+        .name = "wm8971-hifi",
         .playback = {
                 .stream_name = "Playback",
                 .channels_min = 1,
@@ -589,7 +590,6 @@ struct snd_soc_dai wm8971_dai = {
                 .formats = WM8971_FORMATS,},
         .ops = &wm8971_dai_ops,
 };
-EXPORT_SYMBOL_GPL(wm8971_dai);
 
 static void wm8971_work(struct work_struct *work)
 {
@@ -598,19 +598,14 @@ static void wm8971_work(struct work_struct *work)
         wm8971_set_bias_level(codec, codec->bias_level);
 }
 
-static int wm8971_suspend(struct platform_device *pdev, pm_message_t state)
+static int wm8971_suspend(struct snd_soc_codec *codec, pm_message_t state)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
-
         wm8971_set_bias_level(codec, SND_SOC_BIAS_OFF);
         return 0;
 }
 
-static int wm8971_resume(struct platform_device *pdev)
+static int wm8971_resume(struct snd_soc_codec *codec)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
         int i;
         u8 data[2];
         u16 *cache = codec->reg_cache;
@@ -639,37 +634,27 @@ static int wm8971_resume(struct platform_device *pdev)
         return 0;
 }
 
-static int wm8971_init(struct snd_soc_device *socdev,
-                       enum snd_soc_control_type control)
+static int wm8971_probe(struct snd_soc_codec *codec)
 {
-        struct snd_soc_codec *codec = socdev->card->codec;
-        int reg, ret = 0;
-
-        codec->name = "WM8971";
-        codec->owner = THIS_MODULE;
-        codec->set_bias_level = wm8971_set_bias_level;
-        codec->dai = &wm8971_dai;
-        codec->reg_cache_size = ARRAY_SIZE(wm8971_reg);
-        codec->num_dai = 1;
-        codec->reg_cache = kmemdup(wm8971_reg, sizeof(wm8971_reg), GFP_KERNEL);
-
-        if (codec->reg_cache == NULL)
-                return -ENOMEM;
+        struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec);
+        int ret = 0;
+        u16 reg;
+
+        pr_info("WM8971 Audio Codec %s", WM8971_VERSION);
 
-        ret = snd_soc_codec_set_cache_io(codec, 7, 9, control);
+        codec->control_data = wm8971->control_data;
+        ret = snd_soc_codec_set_cache_io(codec, 7, 9, wm8971->control_type);
         if (ret < 0) {
                 printk(KERN_ERR "wm8971: failed to set cache I/O: %d\n", ret);
-                goto err;
+                return ret;
         }
 
-        wm8971_reset(codec);
+        INIT_DELAYED_WORK(&codec->delayed_work, wm8971_work);
+        wm8971_workq = create_workqueue("wm8971");
+        if (wm8971_workq == NULL)
+                return -ENOMEM;
 
-        /* register pcms */
-        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
-        if (ret < 0) {
-                printk(KERN_ERR "wm8971: failed to create pcms\n");
-                goto err;
-        }
+        wm8971_reset(codec);
 
         /* charge output caps - set vmid to 5k for quick power up */
         reg = snd_soc_read(codec, WM8971_PWR1) & 0xfe3e;
@@ -704,40 +689,55 @@ static int wm8971_init(struct snd_soc_device *socdev,
         wm8971_add_widgets(codec);
 
         return ret;
-
-err:
-        kfree(codec->reg_cache);
-        return ret;
 }
 
-/* If the i2c layer weren't so broken, we could pass this kind of data
-   around */
-static struct snd_soc_device *wm8971_socdev;
 
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
+/* power down chip */
+static int wm8971_remove(struct snd_soc_codec *codec)
+{
+        wm8971_set_bias_level(codec, SND_SOC_BIAS_OFF);
+
+        if (wm8971_workq)
+                destroy_workqueue(wm8971_workq);
+        return 0;
+}
+
+static struct snd_soc_codec_driver soc_codec_dev_wm8971 = {
+        .probe =        wm8971_probe,
+        .remove =       wm8971_remove,
+        .suspend =      wm8971_suspend,
+        .resume =       wm8971_resume,
+        .set_bias_level = wm8971_set_bias_level,
+        .reg_cache_size = ARRAY_SIZE(wm8971_reg),
+        .reg_word_size = sizeof(u16),
+        .reg_cache_default = wm8971_reg,
+};
 
-static int wm8971_i2c_probe(struct i2c_client *i2c,
-                            const struct i2c_device_id *id)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+static __devinit int wm8971_i2c_probe(struct i2c_client *i2c,
+                                      const struct i2c_device_id *id)
 {
-        struct snd_soc_device *socdev = wm8971_socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct wm8971_priv *wm8971;
         int ret;
 
-        i2c_set_clientdata(i2c, codec);
+        wm8971 = kzalloc(sizeof(struct wm8971_priv), GFP_KERNEL);
+        if (wm8971 == NULL)
+                return -ENOMEM;
 
-        codec->control_data = i2c;
+        i2c_set_clientdata(i2c, wm8971);
+        wm8971->control_data = i2c;
 
-        ret = wm8971_init(socdev, SND_SOC_I2C);
+        ret = snd_soc_register_codec(&i2c->dev,
+                        &soc_codec_dev_wm8971, &wm8971_dai, 1);
         if (ret < 0)
-                pr_err("failed to initialise WM8971\n");
-
+                kfree(wm8971);
         return ret;
 }
 
-static int wm8971_i2c_remove(struct i2c_client *client)
+static __devexit int wm8971_i2c_remove(struct i2c_client *client)
 {
-        struct snd_soc_codec *codec = i2c_get_clientdata(client);
-        kfree(codec->reg_cache);
+        snd_soc_unregister_codec(&client->dev);
+        kfree(i2c_get_clientdata(client));
         return 0;
 }
 
@@ -749,148 +749,34 @@ MODULE_DEVICE_TABLE(i2c, wm8971_i2c_id);
 
 static struct i2c_driver wm8971_i2c_driver = {
         .driver = {
-                .name = "WM8971 I2C Codec",
+                .name = "wm8971-codec",
                 .owner = THIS_MODULE,
         },
-        .probe    = wm8971_i2c_probe,
-        .remove   = wm8971_i2c_remove,
+        .probe =    wm8971_i2c_probe,
+        .remove =   __devexit_p(wm8971_i2c_remove),
         .id_table = wm8971_i2c_id,
 };
-
-static int wm8971_add_i2c_device(struct platform_device *pdev,
-                                 const struct wm8971_setup_data *setup)
-{
-        struct i2c_board_info info;
-        struct i2c_adapter *adapter;
-        struct i2c_client *client;
-        int ret;
-
-        ret = i2c_add_driver(&wm8971_i2c_driver);
-        if (ret != 0) {
-                dev_err(&pdev->dev, "can't add i2c driver\n");
-                return ret;
-        }
-
-        memset(&info, 0, sizeof(struct i2c_board_info));
-        info.addr = setup->i2c_address;
-        strlcpy(info.type, "wm8971", I2C_NAME_SIZE);
-
-        adapter = i2c_get_adapter(setup->i2c_bus);
-        if (!adapter) {
-                dev_err(&pdev->dev, "can't get i2c adapter %d\n",
-                        setup->i2c_bus);
-                goto err_driver;
-        }
-
-        client = i2c_new_device(adapter, &info);
-        i2c_put_adapter(adapter);
-        if (!client) {
-                dev_err(&pdev->dev, "can't add i2c device at 0x%x\n",
-                        (unsigned int)info.addr);
-                goto err_driver;
-        }
-
-        return 0;
-
-err_driver:
-        i2c_del_driver(&wm8971_i2c_driver);
-        return -ENODEV;
-}
-
 #endif
 
-static int wm8971_probe(struct platform_device *pdev)
+static int __init wm8971_modinit(void)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct wm8971_setup_data *setup;
-        struct snd_soc_codec *codec;
-        struct wm8971_priv *wm8971;
         int ret = 0;
-
-        pr_info("WM8971 Audio Codec %s", WM8971_VERSION);
-
-        setup = socdev->codec_data;
-        codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-        if (codec == NULL)
-                return -ENOMEM;
-
-        wm8971 = kzalloc(sizeof(struct wm8971_priv), GFP_KERNEL);
-        if (wm8971 == NULL) {
-                kfree(codec);
-                return -ENOMEM;
-        }
-
-        snd_soc_codec_set_drvdata(codec, wm8971);
-        socdev->card->codec = codec;
-        mutex_init(&codec->mutex);
-        INIT_LIST_HEAD(&codec->dapm_widgets);
-        INIT_LIST_HEAD(&codec->dapm_paths);
-        wm8971_socdev = socdev;
-
-        INIT_DELAYED_WORK(&codec->delayed_work, wm8971_work);
-        wm8971_workq = create_workqueue("wm8971");
-        if (wm8971_workq == NULL) {
-                kfree(snd_soc_codec_get_drvdata(codec));
-                kfree(codec);
-                return -ENOMEM;
-        }
-
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-        if (setup->i2c_address) {
-                ret = wm8971_add_i2c_device(pdev, setup);
-        }
-#endif
-        /* Add other interfaces here */
-
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+        ret = i2c_add_driver(&wm8971_i2c_driver);
         if (ret != 0) {
-                destroy_workqueue(wm8971_workq);
-                kfree(snd_soc_codec_get_drvdata(codec));
-                kfree(codec);
+                printk(KERN_ERR "Failed to register WM8971 I2C driver: %d\n",
+                       ret);
         }
-
-        return ret;
-}
-
-/* power down chip */
-static int wm8971_remove(struct platform_device *pdev)
-{
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
-
-        if (codec->control_data)
-                wm8971_set_bias_level(codec, SND_SOC_BIAS_OFF);
-        if (wm8971_workq)
-                destroy_workqueue(wm8971_workq);
-        snd_soc_free_pcms(socdev);
-        snd_soc_dapm_free(socdev);
-#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)
-        i2c_unregister_device(codec->control_data);
-        i2c_del_driver(&wm8971_i2c_driver);
 #endif
-        kfree(snd_soc_codec_get_drvdata(codec));
-        kfree(codec);
-
-        return 0;
-}
-
-struct snd_soc_codec_device soc_codec_dev_wm8971 = {
-        .probe =        wm8971_probe,
-        .remove =       wm8971_remove,
-        .suspend =      wm8971_suspend,
-        .resume =       wm8971_resume,
-};
-
-EXPORT_SYMBOL_GPL(soc_codec_dev_wm8971);
-
-static int __init wm8971_modinit(void)
-{
-        return snd_soc_register_dai(&wm8971_dai);
+        return ret;
 }
 module_init(wm8971_modinit);
 
 static void __exit wm8971_exit(void)
 {
-        snd_soc_unregister_dai(&wm8971_dai);
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+        i2c_del_driver(&wm8971_i2c_driver);
+#endif
 }
 module_exit(wm8971_exit);