1 files changed, 7 insertions, 16 deletions

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index bbcf921166f..d7bd9183161 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -16,7 +16,6 @@
 #include <linux/pm.h>
 #include <linux/i2c.h>
 #include <linux/clk.h>
-#include <linux/platform_device.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/consumer.h>
@@ -833,7 +832,7 @@ static int ldo_regulator_register(struct snd_soc_codec *codec,
         ldo->voltage = voltage;
 
         ldo->dev = regulator_register(&ldo->desc, codec->dev,
-                                          init_data, ldo);
+                                          init_data, ldo, NULL);
         if (IS_ERR(ldo->dev)) {
                 int ret = PTR_ERR(ldo->dev);
 
@@ -923,7 +922,7 @@ static int sgtl5000_set_bias_level(struct snd_soc_codec *codec,
                         SNDRV_PCM_FMTBIT_S24_LE |\
                         SNDRV_PCM_FMTBIT_S32_LE)
 
-static struct snd_soc_dai_ops sgtl5000_ops = {
+static const struct snd_soc_dai_ops sgtl5000_ops = {
         .hw_params = sgtl5000_pcm_hw_params,
         .digital_mute = sgtl5000_digital_mute,
         .set_fmt = sgtl5000_set_dai_fmt,
@@ -968,7 +967,7 @@ static int sgtl5000_volatile_register(struct snd_soc_codec *codec,
 }
 
 #ifdef CONFIG_SUSPEND
-static int sgtl5000_suspend(struct snd_soc_codec *codec, pm_message_t state)
+static int sgtl5000_suspend(struct snd_soc_codec *codec)
 {
         sgtl5000_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
@@ -1077,7 +1076,7 @@ static int sgtl5000_set_power_regs(struct snd_soc_codec *codec)
         /* according to datasheet, maximum voltage of supplies */
         if (vdda > 3600 || vddio > 3600 || vddd > 1980) {
                 dev_err(codec->dev,
-                        "exceed max voltage vdda %dmv vddio %dma vddd %dma\n",
+                        "exceed max voltage vdda %dmV vddio %dmV vddd %dmV\n",
                         vdda, vddio, vddd);
 
                 return -EINVAL;
@@ -1402,7 +1401,8 @@ static __devinit int sgtl5000_i2c_probe(struct i2c_client *client,
         struct sgtl5000_priv *sgtl5000;
         int ret;
 
-        sgtl5000 = kzalloc(sizeof(struct sgtl5000_priv), GFP_KERNEL);
+        sgtl5000 = devm_kzalloc(&client->dev, sizeof(struct sgtl5000_priv),
+                                                                GFP_KERNEL);
         if (!sgtl5000)
                 return -ENOMEM;
 
@@ -1410,22 +1410,13 @@ static __devinit int sgtl5000_i2c_probe(struct i2c_client *client,
 
         ret = snd_soc_register_codec(&client->dev,
                         &sgtl5000_driver, &sgtl5000_dai, 1);
-        if (ret) {
-                dev_err(&client->dev, "Failed to register codec: %d\n", ret);
-                kfree(sgtl5000);
-                return ret;
-        }
-
-        return 0;
+        return ret;
 }
 
 static __devexit int sgtl5000_i2c_remove(struct i2c_client *client)
 {
-        struct sgtl5000_priv *sgtl5000 = i2c_get_clientdata(client);
-
         snd_soc_unregister_codec(&client->dev);
 
-        kfree(sgtl5000);
         return 0;
 }