diff options
Diffstat (limited to 'scripts/coccinelle/iterators/itnull.cocci')
| -rw-r--r-- | scripts/coccinelle/iterators/itnull.cocci | 54 |
1 files changed, 9 insertions, 45 deletions
diff --git a/scripts/coccinelle/iterators/itnull.cocci b/scripts/coccinelle/iterators/itnull.cocci index 259899f6838..baa4297a4ed 100644 --- a/scripts/coccinelle/iterators/itnull.cocci +++ b/scripts/coccinelle/iterators/itnull.cocci | |||
| @@ -1,24 +1,20 @@ | |||
| 1 | /// Many iterators have the property that the first argument is always bound | 1 | /// Many iterators have the property that the first argument is always bound |
| 2 | /// to a real list element, never NULL. | 2 | /// to a real list element, never NULL. False positives arise for some |
| 3 | //# False positives arise for some iterators that do not have this property, | 3 | /// iterators that do not have this property, or in cases when the loop |
| 4 | //# or in cases when the loop cursor is reassigned. The latter should only | 4 | /// cursor is reassigned. The latter should only happen when the matched |
| 5 | //# happen when the matched code is on the way to a loop exit (break, goto, | 5 | /// code is on the way to a loop exit (break, goto, or return). |
| 6 | //# or return). | ||
| 7 | /// | 6 | /// |
| 8 | // Confidence: Moderate | 7 | // Confidence: Moderate |
| 9 | // Copyright: (C) 2010-2012 Nicolas Palix. GPLv2. | 8 | // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. |
| 10 | // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. GPLv2. | 9 | // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. |
| 11 | // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. GPLv2. | 10 | // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. |
| 12 | // URL: http://coccinelle.lip6.fr/ | 11 | // URL: http://coccinelle.lip6.fr/ |
| 13 | // Comments: | 12 | // Comments: |
| 14 | // Options: -no_includes -include_headers | 13 | // Options: -no_includes -include_headers |
| 15 | 14 | ||
| 16 | virtual patch | 15 | virtual patch |
| 17 | virtual context | ||
| 18 | virtual org | ||
| 19 | virtual report | ||
| 20 | 16 | ||
| 21 | @depends on patch@ | 17 | @@ |
| 22 | iterator I; | 18 | iterator I; |
| 23 | expression x,E,E1,E2; | 19 | expression x,E,E1,E2; |
| 24 | statement S,S1,S2; | 20 | statement S,S1,S2; |
| @@ -59,36 +55,4 @@ I(x,...) { <... | |||
| 59 | x != NULL | 55 | x != NULL |
| 60 | + ) | 56 | + ) |
| 61 | ) | 57 | ) |
| 62 | ...> } | 58 | ...> } \ No newline at end of file |
| 63 | |||
| 64 | @r depends on !patch exists@ | ||
| 65 | iterator I; | ||
| 66 | expression x,E; | ||
| 67 | position p1,p2; | ||
| 68 | @@ | ||
| 69 | |||
| 70 | *I@p1(x,...) | ||
| 71 | { ... when != x = E | ||
| 72 | ( | ||
| 73 | * x@p2 == NULL | ||
| 74 | | | ||
| 75 | * x@p2 != NULL | ||
| 76 | ) | ||
| 77 | ... when any | ||
| 78 | } | ||
| 79 | |||
| 80 | @script:python depends on org@ | ||
| 81 | p1 << r.p1; | ||
| 82 | p2 << r.p2; | ||
| 83 | @@ | ||
| 84 | |||
| 85 | cocci.print_main("iterator-bound variable",p1) | ||
| 86 | cocci.print_secs("useless NULL test",p2) | ||
| 87 | |||
| 88 | @script:python depends on report@ | ||
| 89 | p1 << r.p1; | ||
| 90 | p2 << r.p2; | ||
| 91 | @@ | ||
| 92 | |||
| 93 | msg = "ERROR: iterator variable bound on line %s cannot be NULL" % (p1[0].line) | ||
| 94 | coccilib.report.print_report(p2[0], msg) | ||
