aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
Diffstat (limited to 'net')
-rw-r--r--net/bridge/br_multicast.c10
-rw-r--r--net/ipv6/ndisc.c2
-rw-r--r--net/nfc/llcp/sock.c4
3 files changed, 7 insertions, 9 deletions
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 977c3ee02e6..1093c89095d 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -622,7 +622,7 @@ out:
622struct net_bridge_port_group *br_multicast_new_port_group( 622struct net_bridge_port_group *br_multicast_new_port_group(
623 struct net_bridge_port *port, 623 struct net_bridge_port *port,
624 struct br_ip *group, 624 struct br_ip *group,
625 struct net_bridge_port_group *next) 625 struct net_bridge_port_group __rcu *next)
626{ 626{
627 struct net_bridge_port_group *p; 627 struct net_bridge_port_group *p;
628 628
@@ -632,7 +632,7 @@ struct net_bridge_port_group *br_multicast_new_port_group(
632 632
633 p->addr = *group; 633 p->addr = *group;
634 p->port = port; 634 p->port = port;
635 p->next = next; 635 rcu_assign_pointer(p->next, next);
636 hlist_add_head(&p->mglist, &port->mglist); 636 hlist_add_head(&p->mglist, &port->mglist);
637 setup_timer(&p->timer, br_multicast_port_group_expired, 637 setup_timer(&p->timer, br_multicast_port_group_expired,
638 (unsigned long)p); 638 (unsigned long)p);
@@ -1138,7 +1138,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
1138 struct sk_buff *skb) 1138 struct sk_buff *skb)
1139{ 1139{
1140 const struct ipv6hdr *ip6h = ipv6_hdr(skb); 1140 const struct ipv6hdr *ip6h = ipv6_hdr(skb);
1141 struct mld_msg *mld = (struct mld_msg *) icmp6_hdr(skb); 1141 struct mld_msg *mld;
1142 struct net_bridge_mdb_entry *mp; 1142 struct net_bridge_mdb_entry *mp;
1143 struct mld2_query *mld2q; 1143 struct mld2_query *mld2q;
1144 struct net_bridge_port_group *p; 1144 struct net_bridge_port_group *p;
@@ -1165,6 +1165,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
1165 if (max_delay) 1165 if (max_delay)
1166 group = &mld->mld_mca; 1166 group = &mld->mld_mca;
1167 } else if (skb->len >= sizeof(*mld2q)) { 1167 } else if (skb->len >= sizeof(*mld2q)) {
1168 u16 mrc;
1168 if (!pskb_may_pull(skb, sizeof(*mld2q))) { 1169 if (!pskb_may_pull(skb, sizeof(*mld2q))) {
1169 err = -EINVAL; 1170 err = -EINVAL;
1170 goto out; 1171 goto out;
@@ -1172,7 +1173,8 @@ static int br_ip6_multicast_query(struct net_bridge *br,
1172 mld2q = (struct mld2_query *)icmp6_hdr(skb); 1173 mld2q = (struct mld2_query *)icmp6_hdr(skb);
1173 if (!mld2q->mld2q_nsrcs) 1174 if (!mld2q->mld2q_nsrcs)
1174 group = &mld2q->mld2q_mca; 1175 group = &mld2q->mld2q_mca;
1175 max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(mld2q->mld2q_mrc) : 1; 1176 mrc = ntohs(mld2q->mld2q_mrc);
1177 max_delay = mrc ? MLDV2_MRC(mrc) : 1;
1176 } 1178 }
1177 1179
1178 if (!group) 1180 if (!group)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 4c02e6ab96e..f2a007b7bde 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -151,8 +151,8 @@ static inline int ndisc_opt_addr_space(struct net_device *dev)
151static u8 *ndisc_fill_addr_option(u8 *opt, int type, void *data, int data_len, 151static u8 *ndisc_fill_addr_option(u8 *opt, int type, void *data, int data_len,
152 unsigned short addr_type) 152 unsigned short addr_type)
153{ 153{
154 int space = NDISC_OPT_SPACE(data_len);
155 int pad = ndisc_addr_option_pad(addr_type); 154 int pad = ndisc_addr_option_pad(addr_type);
155 int space = NDISC_OPT_SPACE(data_len + pad);
156 156
157 opt[0] = type; 157 opt[0] = type;
158 opt[1] = space>>3; 158 opt[1] = space>>3;
diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 0fa1e92ceac..fea22eb41b8 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -614,10 +614,6 @@ static int llcp_sock_sendmsg(struct kiocb *iocb, struct socket *sock,
614 614
615 if (msg->msg_namelen < sizeof(*addr)) { 615 if (msg->msg_namelen < sizeof(*addr)) {
616 release_sock(sk); 616 release_sock(sk);
617
618 pr_err("Invalid socket address length %d\n",
619 msg->msg_namelen);
620
621 return -EINVAL; 617 return -EINVAL;
622 } 618 }
623 619