13 files changed, 126 insertions, 73 deletions

diff --git a/drivers/media/video/ivtv/Kconfig b/drivers/media/video/ivtv/Kconfig
index 270906fc314..b6171702c4d 100644
--- a/drivers/media/video/ivtv/Kconfig
+++ b/drivers/media/video/ivtv/Kconfig
@@ -10,6 +10,7 @@ config VIDEO_IVTV
         select VIDEO_CX25840
         select VIDEO_MSP3400
         select VIDEO_SAA711X
+        select VIDEO_SAA717X
         select VIDEO_SAA7127
         select VIDEO_TVAUDIO
         select VIDEO_CS53L32A
diff --git a/drivers/media/video/ivtv/ivtv-cards.c b/drivers/media/video/ivtv/ivtv-cards.c
index f23c6b8d691..e908649ea37 100644
--- a/drivers/media/video/ivtv/ivtv-cards.c
+++ b/drivers/media/video/ivtv/ivtv-cards.c
@@ -416,11 +416,10 @@ static const struct ivtv_card ivtv_card_avc2410 = {
            on the country/region setting of the user to decide which tuner
            is available. */
         .tuners = {
-                /* This tuner has been verified for the AVC2410 */
                 { .std = V4L2_STD_625_50, .tuner = TUNER_PHILIPS_FM1216ME_MK3 },
-                /* This is a good guess, but I'm not totally sure this is
-                   the correct tuner for NTSC. */
-                { .std = V4L2_STD_ALL, .tuner = TUNER_PHILIPS_FM1236_MK3 },
+                { .std = V4L2_STD_ALL - V4L2_STD_NTSC_M_JP,
+                        .tuner = TUNER_PHILIPS_FM1236_MK3 },
+                { .std = V4L2_STD_NTSC_M_JP, .tuner = TUNER_PHILIPS_FQ1286 },
         },
         .pci_list = ivtv_pci_avc2410,
         .i2c = &ivtv_i2c_std,
diff --git a/drivers/media/video/ivtv/ivtv-cards.h b/drivers/media/video/ivtv/ivtv-cards.h
index 191aafdd996..9186fa2ee5f 100644
--- a/drivers/media/video/ivtv/ivtv-cards.h
+++ b/drivers/media/video/ivtv/ivtv-cards.h
@@ -119,7 +119,7 @@
 
 #define IVTV_CARD_MAX_VIDEO_INPUTS 6
 #define IVTV_CARD_MAX_AUDIO_INPUTS 3
-#define IVTV_CARD_MAX_TUNERS       2
+#define IVTV_CARD_MAX_TUNERS       3
 
 /* SAA71XX HW inputs */
 #define IVTV_SAA71XX_COMPOSITE0 0
diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c
index 948ca35e7ee..065df53f80f 100644
--- a/drivers/media/video/ivtv/ivtv-driver.c
+++ b/drivers/media/video/ivtv/ivtv-driver.c
@@ -101,7 +101,7 @@ static int radio[IVTV_MAX_CARDS] = { -1, -1, -1, -1, -1, -1, -1, -1,
 static unsigned int cardtype_c = 1;
 static unsigned int tuner_c = 1;
 static unsigned int radio_c = 1;
-static char pal[] = "--";
+static char pal[] = "---";
 static char secam[] = "--";
 static char ntsc[] = "-";
 
@@ -126,12 +126,13 @@ static int dec_mpg_buffers = IVTV_DEFAULT_DEC_MPG_BUFFERS;
 static int dec_yuv_buffers = IVTV_DEFAULT_DEC_YUV_BUFFERS;
 static int dec_vbi_buffers = IVTV_DEFAULT_DEC_VBI_BUFFERS;
 
-static int ivtv_yuv_mode = 0;
-static int ivtv_yuv_threshold=-1;
+static int ivtv_yuv_mode;
+static int ivtv_yuv_threshold = -1;
 static int ivtv_pci_latency = 1;
 
-int ivtv_debug = 0;
+int ivtv_debug;
 
+static int tunertype = -1;
 static int newi2c = -1;
 
 module_param_array(tuner, int, &tuner_c, 0644);
@@ -154,6 +155,7 @@ module_param(dec_mpg_buffers, int, 0644);
 module_param(dec_yuv_buffers, int, 0644);
 module_param(dec_vbi_buffers, int, 0644);
 
+module_param(tunertype, int, 0644);
 module_param(newi2c, int, 0644);
 
 MODULE_PARM_DESC(tuner, "Tuner type selection,\n"
@@ -190,9 +192,14 @@ MODULE_PARM_DESC(cardtype,
                  "\t\t\t24 = AverMedia EZMaker PCI Deluxe\n"
                  "\t\t\t 0 = Autodetect (default)\n"
                  "\t\t\t-1 = Ignore this card\n\t\t");
-MODULE_PARM_DESC(pal, "Set PAL standard: B, G, H, D, K, I, M, N, Nc, 60");
-MODULE_PARM_DESC(secam, "Set SECAM standard: B, G, H, D, K, L, LC");
-MODULE_PARM_DESC(ntsc, "Set NTSC standard: M, J, K");
+MODULE_PARM_DESC(pal, "Set PAL standard: BGH, DK, I, M, N, Nc, 60");
+MODULE_PARM_DESC(secam, "Set SECAM standard: BGH, DK, L, LC");
+MODULE_PARM_DESC(ntsc, "Set NTSC standard: M, J (Japan), K (South Korea)");
+MODULE_PARM_DESC(tunertype,
+                "Specify tuner type:\n"
+                "\t\t\t 0 = tuner for PAL-B/G/H/D/K/I, SECAM-B/G/H/D/K/L/Lc\n"
+                "\t\t\t 1 = tuner for NTSC-M/J/K, PAL-M/N/Nc\n"
+                "\t\t\t-1 = Autodetect (default)\n");
 MODULE_PARM_DESC(debug,
                  "Debug level (bitmask). Default: 0\n"
                  "\t\t\t   1/0x0001: warning\n"
@@ -490,30 +497,35 @@ static v4l2_std_id ivtv_parse_std(struct ivtv *itv)
 {
         switch (pal[0]) {
                 case '6':
+                        tunertype = 0;
                         return V4L2_STD_PAL_60;
                 case 'b':
                 case 'B':
                 case 'g':
                 case 'G':
-                        return V4L2_STD_PAL_BG;
                 case 'h':
                 case 'H':
-                        return V4L2_STD_PAL_H;
+                        tunertype = 0;
+                        return V4L2_STD_PAL_BG | V4L2_STD_PAL_H;
                 case 'n':
                 case 'N':
+                        tunertype = 1;
                         if (pal[1] == 'c' || pal[1] == 'C')
                                 return V4L2_STD_PAL_Nc;
                         return V4L2_STD_PAL_N;
                 case 'i':
                 case 'I':
+                        tunertype = 0;
                         return V4L2_STD_PAL_I;
                 case 'd':
                 case 'D':
                 case 'k':
                 case 'K':
+                        tunertype = 0;
                         return V4L2_STD_PAL_DK;
                 case 'M':
                 case 'm':
+                        tunertype = 1;
                         return V4L2_STD_PAL_M;
                 case '-':
                         break;
@@ -529,14 +541,17 @@ static v4l2_std_id ivtv_parse_std(struct ivtv *itv)
                 case 'G':
                 case 'h':
                 case 'H':
+                        tunertype = 0;
                         return V4L2_STD_SECAM_B | V4L2_STD_SECAM_G | V4L2_STD_SECAM_H;
                 case 'd':
                 case 'D':
                 case 'k':
                 case 'K':
+                        tunertype = 0;
                         return V4L2_STD_SECAM_DK;
                 case 'l':
                 case 'L':
+                        tunertype = 0;
                         if (secam[1] == 'C' || secam[1] == 'c')
                                 return V4L2_STD_SECAM_LC;
                         return V4L2_STD_SECAM_L;
@@ -550,12 +565,15 @@ static v4l2_std_id ivtv_parse_std(struct ivtv *itv)
         switch (ntsc[0]) {
                 case 'm':
                 case 'M':
+                        tunertype = 1;
                         return V4L2_STD_NTSC_M;
                 case 'j':
                 case 'J':
+                        tunertype = 1;
                         return V4L2_STD_NTSC_M_JP;
                 case 'k':
                 case 'K':
+                        tunertype = 1;
                         return V4L2_STD_NTSC_M_KR;
                 case '-':
                         break;
@@ -584,8 +602,13 @@ static void ivtv_process_options(struct ivtv *itv)
         itv->options.tuner = tuner[itv->num];
         itv->options.radio = radio[itv->num];
         itv->options.newi2c = newi2c;
-
+        if (tunertype < -1 || tunertype > 1) {
+                IVTV_WARN("Invalid tunertype argument, will autodetect instead\n");
+                tunertype = -1;
+        }
         itv->std = ivtv_parse_std(itv);
+        if (itv->std == 0 && tunertype >= 0)
+                itv->std = tunertype ? V4L2_STD_MN : (V4L2_STD_ALL & ~V4L2_STD_MN);
         itv->has_cx23415 = (itv->dev->device == PCI_DEVICE_ID_IVTV15);
         chipname = itv->has_cx23415 ? "cx23415" : "cx23416";
         if (itv->options.cardtype == -1) {
@@ -711,6 +734,7 @@ static int __devinit ivtv_init_struct1(struct ivtv *itv)
         itv->yuv_info.lace_mode = ivtv_yuv_mode;
         itv->yuv_info.lace_threshold = ivtv_yuv_threshold;
         itv->yuv_info.max_frames_buffered = 3;
+        itv->yuv_info.track_osd = 1;
         return 0;
 }
 
@@ -859,7 +883,9 @@ static void ivtv_load_and_init_modules(struct ivtv *itv)
 #ifndef CONFIG_VIDEO_SAA7127
         hw = ivtv_request_module(itv, hw, "saa7127", IVTV_HW_SAA7127);
 #endif
+#ifndef CONFIG_VIDEO_SAA717X
         hw = ivtv_request_module(itv, hw, "saa717x", IVTV_HW_SAA717X);
+#endif
 #ifndef CONFIG_VIDEO_UPD64031A
         hw = ivtv_request_module(itv, hw, "upd64031a", IVTV_HW_UPD64031A);
 #endif
diff --git a/drivers/media/video/ivtv/ivtv-driver.h b/drivers/media/video/ivtv/ivtv-driver.h
index 536140f0c19..ba06e813c58 100644
--- a/drivers/media/video/ivtv/ivtv-driver.h
+++ b/drivers/media/video/ivtv/ivtv-driver.h
@@ -456,6 +456,8 @@ struct yuv_playback_info
         int v_filter_2;
         int h_filter;
 
+        u8 track_osd; /* Should yuv output track the OSD size & position */
+
         u32 osd_x_offset;
         u32 osd_y_offset;
 
diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/drivers/media/video/ivtv/ivtv-fileops.c
index 6fb96f19a86..a7640c49f1d 100644
--- a/drivers/media/video/ivtv/ivtv-fileops.c
+++ b/drivers/media/video/ivtv/ivtv-fileops.c
@@ -219,7 +219,9 @@ static struct ivtv_buffer *ivtv_get_buffer(struct ivtv_stream *s, int non_block,
                         /* Process pending program info updates and pending VBI data */
                         ivtv_update_pgm_info(itv);
 
-                        if (jiffies - itv->dualwatch_jiffies > msecs_to_jiffies(1000)) {
+                        if (time_after(jiffies,
+                                       itv->dualwatch_jiffies +
+                                       msecs_to_jiffies(1000))) {
                                 itv->dualwatch_jiffies = jiffies;
                                 ivtv_dualwatch(itv);
                         }
@@ -753,7 +755,7 @@ unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table * wait)
         IVTV_DEBUG_HI_FILE("Encoder poll\n");
         poll_wait(filp, &s->waitq, wait);
 
-        if (eof || s->q_full.length)
+        if (eof || s->q_full.length || s->q_io.length)
                 return POLLIN | POLLRDNORM;
         return 0;
 }
diff --git a/drivers/media/video/ivtv/ivtv-i2c.c b/drivers/media/video/ivtv/ivtv-i2c.c
index fa5ab1eb180..9824eafee02 100644
--- a/drivers/media/video/ivtv/ivtv-i2c.c
+++ b/drivers/media/video/ivtv/ivtv-i2c.c
@@ -177,10 +177,16 @@ int ivtv_i2c_register(struct ivtv *itv, unsigned idx)
         }
 
         if (id != I2C_DRIVERID_TUNER) {
-                c = i2c_new_device(&itv->i2c_adap, &info);
-                if (c->driver == NULL)
+                if (id == I2C_DRIVERID_UPD64031A ||
+                    id == I2C_DRIVERID_UPD64083) {
+                        unsigned short addrs[2] = { info.addr, I2C_CLIENT_END };
+
+                        c = i2c_new_probed_device(&itv->i2c_adap, &info, addrs);
+                } else
+                        c = i2c_new_device(&itv->i2c_adap, &info);
+                if (c && c->driver == NULL)
                         i2c_unregister_device(c);
-                else
+                else if (c)
                         itv->i2c_clients[i] = c;
                 return itv->i2c_clients[i] ? 0 : -ENODEV;
         }
diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media/video/ivtv/ivtv-ioctl.c
index edef2a57961..15cac181212 100644
--- a/drivers/media/video/ivtv/ivtv-ioctl.c
+++ b/drivers/media/video/ivtv/ivtv-ioctl.c
@@ -712,6 +712,7 @@ static int ivtv_debug_ioctls(struct file *filp, unsigned int cmd, void *arg)
 int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void *arg)
 {
         struct ivtv_open_id *id = NULL;
+        struct yuv_playback_info *yi = &itv->yuv_info;
         u32 data[CX2341X_MBOX_MAX_DATA];
         int streamtype = 0;
 
@@ -741,7 +742,8 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
 
                 memset(vcap, 0, sizeof(*vcap));
                 strcpy(vcap->driver, IVTV_DRIVER_NAME);     /* driver name */
-                strcpy(vcap->card, itv->card_name);         /* card type */
+                strncpy(vcap->card, itv->card_name,
+                                sizeof(vcap->card)-1);      /* card type */
                 strcpy(vcap->bus_info, pci_name(itv->dev)); /* bus info... */
                 vcap->version = IVTV_DRIVER_VERSION;        /* version */
                 vcap->capabilities = itv->v4l2_cap;         /* capabilities */
@@ -827,8 +829,7 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
         case VIDIOC_CROPCAP: {
                 struct v4l2_cropcap *cropcap = arg;
 
-                if (cropcap->type != V4L2_BUF_TYPE_VIDEO_CAPTURE &&
-                    cropcap->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
+                if (cropcap->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
                         return -EINVAL;
                 cropcap->bounds.top = cropcap->bounds.left = 0;
                 cropcap->bounds.width = 720;
@@ -837,8 +838,14 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                         cropcap->pixelaspect.numerator = itv->is_50hz ? 59 : 10;
                         cropcap->pixelaspect.denominator = itv->is_50hz ? 54 : 11;
                 } else if (streamtype == IVTV_DEC_STREAM_TYPE_YUV) {
-                        cropcap->bounds.width = itv->yuv_info.osd_full_w;
-                        cropcap->bounds.height = itv->yuv_info.osd_full_h;
+                        if (yi->track_osd) {
+                                cropcap->bounds.width = yi->osd_full_w;
+                                cropcap->bounds.height = yi->osd_full_h;
+                        } else {
+                                cropcap->bounds.width = 720;
+                                cropcap->bounds.height =
+                                                itv->is_out_50hz ? 576 : 480;
+                        }
                         cropcap->pixelaspect.numerator = itv->is_out_50hz ? 59 : 10;
                         cropcap->pixelaspect.denominator = itv->is_out_50hz ? 54 : 11;
                 } else {
@@ -856,7 +863,7 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                 if (crop->type == V4L2_BUF_TYPE_VIDEO_OUTPUT &&
                     (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
                         if (streamtype == IVTV_DEC_STREAM_TYPE_YUV) {
-                                itv->yuv_info.main_rect = crop->c;
+                                yi->main_rect = crop->c;
                                 return 0;
                         } else {
                                 if (!ivtv_vapi(itv, CX2341X_OSD_SET_FRAMEBUFFER_WINDOW, 4,
@@ -867,9 +874,7 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                         }
                         return -EINVAL;
                 }
-                if (crop->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-                        return -EINVAL;
-                return itv->video_dec_func(itv, VIDIOC_S_CROP, arg);
+                return -EINVAL;
         }
 
         case VIDIOC_G_CROP: {
@@ -878,14 +883,12 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                 if (crop->type == V4L2_BUF_TYPE_VIDEO_OUTPUT &&
                     (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
                         if (streamtype == IVTV_DEC_STREAM_TYPE_YUV)
-                                crop->c = itv->yuv_info.main_rect;
+                                crop->c = yi->main_rect;
                         else
                                 crop->c = itv->main_rect;
                         return 0;
                 }
-                if (crop->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
-                        return -EINVAL;
-                return itv->video_dec_func(itv, VIDIOC_G_CROP, arg);
+                return -EINVAL;
         }
 
         case VIDIOC_ENUM_FMT: {
@@ -1070,11 +1073,10 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                         itv->main_rect.height = itv->params.height;
                         ivtv_vapi(itv, CX2341X_OSD_SET_FRAMEBUFFER_WINDOW, 4,
                                 720, itv->main_rect.height, 0, 0);
-                        itv->yuv_info.main_rect = itv->main_rect;
+                        yi->main_rect = itv->main_rect;
                         if (!itv->osd_info) {
-                                itv->yuv_info.osd_full_w = 720;
-                                itv->yuv_info.osd_full_h =
-                                                itv->is_out_50hz ? 576 : 480;
+                                yi->osd_full_w = 720;
+                                yi->osd_full_h = itv->is_out_50hz ? 576 : 480;
                         }
                 }
                 break;
@@ -1272,6 +1274,8 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                         else
                                 fb->flags |= V4L2_FBUF_FLAG_LOCAL_ALPHA;
                 }
+                if (yi->track_osd)
+                        fb->flags |= V4L2_FBUF_FLAG_OVERLAY;
                 break;
         }
 
@@ -1285,6 +1289,7 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void
                         (fb->flags & (V4L2_FBUF_FLAG_LOCAL_ALPHA|V4L2_FBUF_FLAG_LOCAL_INV_ALPHA)) != 0;
                 itv->osd_chroma_key_state = (fb->flags & V4L2_FBUF_FLAG_CHROMAKEY) != 0;
                 ivtv_set_osd_alpha(itv);
+                yi->track_osd = (fb->flags & V4L2_FBUF_FLAG_OVERLAY) != 0;
                 break;
         }
 
@@ -1628,6 +1633,7 @@ static int ivtv_v4l2_do_ioctl(struct inode *inode, struct file *filp,
                 if (ivtv_debug & IVTV_DBGFLG_IOCTL) {
                         printk(KERN_INFO "ivtv%d ioctl: ", itv->num);
                         v4l_printk_ioctl(cmd);
+                        printk("\n");
                 }
                 return ivtv_debug_ioctls(filp, cmd, arg);
 
@@ -1671,6 +1677,7 @@ static int ivtv_v4l2_do_ioctl(struct inode *inode, struct file *filp,
                 if (ivtv_debug & IVTV_DBGFLG_IOCTL) {
                         printk(KERN_INFO "ivtv%d ioctl: ", itv->num);
                         v4l_printk_ioctl(cmd);
+                        printk("\n");
                 }
                 return ivtv_v4l2_ioctls(itv, filp, cmd, arg);
 
@@ -1684,6 +1691,7 @@ static int ivtv_v4l2_do_ioctl(struct inode *inode, struct file *filp,
                 if (ivtv_debug & IVTV_DBGFLG_IOCTL) {
                         printk(KERN_INFO "ivtv%d ioctl: ", itv->num);
                         v4l_printk_ioctl(cmd);
+                        printk("\n");
                 }
                 return ivtv_control_ioctls(itv, cmd, arg);
 
diff --git a/drivers/media/video/ivtv/ivtv-irq.c b/drivers/media/video/ivtv/ivtv-irq.c
index 65604dde972..a329c4689db 100644
--- a/drivers/media/video/ivtv/ivtv-irq.c
+++ b/drivers/media/video/ivtv/ivtv-irq.c
@@ -384,6 +384,8 @@ static void ivtv_dma_enc_start_xfer(struct ivtv_stream *s)
         ivtv_stream_sync_for_device(s);
         write_reg(s->sg_handle, IVTV_REG_ENCDMAADDR);
         write_reg_sync(read_reg(IVTV_REG_DMAXFER) | 0x02, IVTV_REG_DMAXFER);
+        itv->dma_timer.expires = jiffies + msecs_to_jiffies(100);
+        add_timer(&itv->dma_timer);
 }
 
 static void ivtv_dma_dec_start_xfer(struct ivtv_stream *s)
@@ -398,6 +400,8 @@ static void ivtv_dma_dec_start_xfer(struct ivtv_stream *s)
         ivtv_stream_sync_for_device(s);
         write_reg(s->sg_handle, IVTV_REG_DECDMAADDR);
         write_reg_sync(read_reg(IVTV_REG_DMAXFER) | 0x01, IVTV_REG_DMAXFER);
+        itv->dma_timer.expires = jiffies + msecs_to_jiffies(100);
+        add_timer(&itv->dma_timer);
 }
 
 /* start the encoder DMA */
@@ -459,8 +463,6 @@ static void ivtv_dma_enc_start(struct ivtv_stream *s)
                 ivtv_dma_enc_start_xfer(s);
                 set_bit(IVTV_F_I_DMA, &itv->i_flags);
                 itv->cur_dma_stream = s->type;
-                itv->dma_timer.expires = jiffies + msecs_to_jiffies(100);
-                add_timer(&itv->dma_timer);
         }
 }
 
@@ -481,8 +483,6 @@ static void ivtv_dma_dec_start(struct ivtv_stream *s)
         ivtv_dma_dec_start_xfer(s);
         set_bit(IVTV_F_I_DMA, &itv->i_flags);
         itv->cur_dma_stream = s->type;
-        itv->dma_timer.expires = jiffies + msecs_to_jiffies(100);
-        add_timer(&itv->dma_timer);
 }
 
 static void ivtv_irq_dma_read(struct ivtv *itv)
@@ -492,10 +492,11 @@ static void ivtv_irq_dma_read(struct ivtv *itv)
         int hw_stream_type = 0;
 
         IVTV_DEBUG_HI_IRQ("DEC DMA READ\n");
-        if (!test_bit(IVTV_F_I_UDMA, &itv->i_flags) && itv->cur_dma_stream < 0) {
-                del_timer(&itv->dma_timer);
+
+        del_timer(&itv->dma_timer);
+
+        if (!test_bit(IVTV_F_I_UDMA, &itv->i_flags) && itv->cur_dma_stream < 0)
                 return;
-        }
 
         if (!test_bit(IVTV_F_I_UDMA, &itv->i_flags)) {
                 s = &itv->streams[itv->cur_dma_stream];
@@ -543,7 +544,6 @@ static void ivtv_irq_dma_read(struct ivtv *itv)
                 }
                 wake_up(&s->waitq);
         }
-        del_timer(&itv->dma_timer);
         clear_bit(IVTV_F_I_UDMA, &itv->i_flags);
         clear_bit(IVTV_F_I_DMA, &itv->i_flags);
         itv->cur_dma_stream = -1;
@@ -557,10 +557,12 @@ static void ivtv_irq_enc_dma_complete(struct ivtv *itv)
 
         ivtv_api_get_data(&itv->enc_mbox, IVTV_MBOX_DMA_END, data);
         IVTV_DEBUG_HI_IRQ("ENC DMA COMPLETE %x %d (%d)\n", data[0], data[1], itv->cur_dma_stream);
-        if (itv->cur_dma_stream < 0) {
-                del_timer(&itv->dma_timer);
+
+        del_timer(&itv->dma_timer);
+
+        if (itv->cur_dma_stream < 0)
                 return;
-        }
+
         s = &itv->streams[itv->cur_dma_stream];
         ivtv_stream_sync_for_cpu(s);
 
@@ -585,7 +587,6 @@ static void ivtv_irq_enc_dma_complete(struct ivtv *itv)
                 ivtv_dma_enc_start_xfer(s);
                 return;
         }
-        del_timer(&itv->dma_timer);
         clear_bit(IVTV_F_I_DMA, &itv->i_flags);
         itv->cur_dma_stream = -1;
         dma_post(s);
diff --git a/drivers/media/video/ivtv/ivtv-mailbox.c b/drivers/media/video/ivtv/ivtv-mailbox.c
index 13a6c374d2d..1b5c0ac09a8 100644
--- a/drivers/media/video/ivtv/ivtv-mailbox.c
+++ b/drivers/media/video/ivtv/ivtv-mailbox.c
@@ -177,7 +177,8 @@ static int get_mailbox(struct ivtv *itv, struct ivtv_mailbox_data *mbdata, int f
 
                 /* Sleep before a retry, if not atomic */
                 if (!(flags & API_NO_WAIT_MB)) {
-                        if (jiffies - then > msecs_to_jiffies(10*retries))
+                        if (time_after(jiffies,
+                                       then + msecs_to_jiffies(10*retries)))
                                break;
                         ivtv_msleep_timeout(10, 0);
                 }
@@ -244,7 +245,9 @@ static int ivtv_api_call(struct ivtv *itv, int cmd, int args, u32 data[])
            data, then just return 0 as there is no need to issue this command again.
            Just an optimization to prevent unnecessary use of mailboxes. */
         if (itv->api_cache[cmd].last_jiffies &&
-            jiffies - itv->api_cache[cmd].last_jiffies < msecs_to_jiffies(1800000) &&
+            time_before(jiffies,
+                        itv->api_cache[cmd].last_jiffies +
+                        msecs_to_jiffies(1800000)) &&
             !memcmp(data, itv->api_cache[cmd].data, sizeof(itv->api_cache[cmd].data))) {
                 itv->api_cache[cmd].last_jiffies = jiffies;
                 return 0;
@@ -299,7 +302,7 @@ static int ivtv_api_call(struct ivtv *itv, int cmd, int args, u32 data[])
                 }
         }
         while (!(readl(&mbox->flags) & IVTV_MBOX_FIRMWARE_DONE)) {
-                if (jiffies - then > api_timeout) {
+                if (time_after(jiffies, then + api_timeout)) {
                         IVTV_DEBUG_WARN("Could not get result (%s)\n", api_info[cmd].name);
                         /* reset the mailbox, but it is likely too late already */
                         write_sync(0, &mbox->flags);
@@ -311,7 +314,7 @@ static int ivtv_api_call(struct ivtv *itv, int cmd, int args, u32 data[])
                 else
                         ivtv_msleep_timeout(1, 0);
         }
-        if (jiffies - then > msecs_to_jiffies(100))
+        if (time_after(jiffies, then + msecs_to_jiffies(100)))
                 IVTV_DEBUG_WARN("%s took %u jiffies\n",
                                 api_info[cmd].name,
                                 jiffies_to_msecs(jiffies - then));
diff --git a/drivers/media/video/ivtv/ivtv-queue.c b/drivers/media/video/ivtv/ivtv-queue.c
index 39a21671324..3e1deec67a5 100644
--- a/drivers/media/video/ivtv/ivtv-queue.c
+++ b/drivers/media/video/ivtv/ivtv-queue.c
@@ -51,7 +51,7 @@ void ivtv_queue_init(struct ivtv_queue *q)
 
 void ivtv_enqueue(struct ivtv_stream *s, struct ivtv_buffer *buf, struct ivtv_queue *q)
 {
-        unsigned long flags = 0;
+        unsigned long flags;
 
         /* clear the buffer if it is going to be enqueued to the free queue */
         if (q == &s->q_free) {
@@ -71,7 +71,7 @@ void ivtv_enqueue(struct ivtv_stream *s, struct ivtv_buffer *buf, struct ivtv_qu
 struct ivtv_buffer *ivtv_dequeue(struct ivtv_stream *s, struct ivtv_queue *q)
 {
         struct ivtv_buffer *buf = NULL;
-        unsigned long flags = 0;
+        unsigned long flags;
 
         spin_lock_irqsave(&s->qlock, flags);
         if (!list_empty(&q->list)) {
diff --git a/drivers/media/video/ivtv/ivtv-streams.c b/drivers/media/video/ivtv/ivtv-streams.c
index 24d98ecf35a..4ab8d36831b 100644
--- a/drivers/media/video/ivtv/ivtv-streams.c
+++ b/drivers/media/video/ivtv/ivtv-streams.c
@@ -768,7 +768,8 @@ int ivtv_stop_v4l2_encode_stream(struct ivtv_stream *s, int gop_end)
 
                         /* wait 2s for EOS interrupt */
                         while (!test_bit(IVTV_F_I_EOS, &itv->i_flags) &&
-                                jiffies < then + msecs_to_jiffies (2000)) {
+                                time_before(jiffies,
+                                            then + msecs_to_jiffies(2000))) {
                                 schedule_timeout(msecs_to_jiffies(10));
                         }
 
diff --git a/drivers/media/video/ivtv/ivtv-yuv.c b/drivers/media/video/ivtv/ivtv-yuv.c
index 85183480a22..393d917cd67 100644
--- a/drivers/media/video/ivtv/ivtv-yuv.c
+++ b/drivers/media/video/ivtv/ivtv-yuv.c
@@ -718,9 +718,11 @@ static u32 ivtv_yuv_window_setup(struct ivtv *itv, struct yuv_frame_info *f)
                 f->src_w -= (osd_scale * osd_crop) >> 16;
         }
 
-        /* The OSD can be moved. Track to it */
-        f->dst_x += itv->yuv_info.osd_x_offset;
-        f->dst_y += itv->yuv_info.osd_y_offset;
+        if (itv->yuv_info.track_osd) {
+                /* The OSD can be moved. Track to it */
+                f->dst_x += itv->yuv_info.osd_x_offset;
+                f->dst_y += itv->yuv_info.osd_y_offset;
+        }
 
         /* Width & height for both src & dst must be even.
            Same for coordinates. */
@@ -792,11 +794,19 @@ void ivtv_yuv_work_handler(struct ivtv *itv)
         IVTV_DEBUG_YUV("Update yuv registers for frame %d\n", frame);
         f = yi->new_frame_info[frame];
 
-        /* Update the osd pan info */
-        f.pan_x = yi->osd_x_pan;
-        f.pan_y = yi->osd_y_pan;
-        f.vis_w = yi->osd_vis_w;
-        f.vis_h = yi->osd_vis_h;
+        if (yi->track_osd) {
+                /* Snapshot the osd pan info */
+                f.pan_x = yi->osd_x_pan;
+                f.pan_y = yi->osd_y_pan;
+                f.vis_w = yi->osd_vis_w;
+                f.vis_h = yi->osd_vis_h;
+        } else {
+                /* Not tracking the osd, so assume full screen */
+                f.pan_x = 0;
+                f.pan_y = 0;
+                f.vis_w = 720;
+                f.vis_h = yi->decode_height;
+        }
 
         /* Calculate the display window coordinates. Exit if nothing left */
         if (!(yuv_update = ivtv_yuv_window_setup(itv, &f)))
@@ -914,7 +924,7 @@ static void ivtv_yuv_init(struct ivtv *itv)
 }
 
 /* Get next available yuv buffer on PVR350 */
-void ivtv_yuv_next_free(struct ivtv *itv)
+static void ivtv_yuv_next_free(struct ivtv *itv)
 {
         int draw, display;
         struct yuv_playback_info *yi = &itv->yuv_info;
@@ -937,7 +947,7 @@ void ivtv_yuv_next_free(struct ivtv *itv)
 }
 
 /* Set up frame according to ivtv_dma_frame parameters */
-void ivtv_yuv_setup_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
+static void ivtv_yuv_setup_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
 {
         struct yuv_playback_info *yi = &itv->yuv_info;
         u8 frame = yi->draw_frame;
@@ -965,12 +975,6 @@ void ivtv_yuv_setup_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
         /* Are we going to offset the Y plane */
         nf->offset_y = (nf->tru_h + nf->src_x < 512 - 16) ? 1 : 0;
 
-        /* Snapshot the osd pan info */
-        nf->pan_x = yi->osd_x_pan;
-        nf->pan_y = yi->osd_y_pan;
-        nf->vis_w = yi->osd_vis_w;
-        nf->vis_h = yi->osd_vis_h;
-
         nf->update = 0;
         nf->interlaced_y = 0;
         nf->interlaced_uv = 0;
@@ -1042,7 +1046,7 @@ void ivtv_yuv_frame_complete(struct ivtv *itv)
                         (itv->yuv_info.draw_frame + 1) % IVTV_YUV_BUFFERS);
 }
 
-int ivtv_yuv_udma_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
+static int ivtv_yuv_udma_frame(struct ivtv *itv, struct ivtv_dma_frame *args)
 {
         DEFINE_WAIT(wait);
         int rc = 0;