2 files changed, 29 insertions, 32 deletions

diff --git a/arch/powerpc/platforms/cell/spu_syscalls.c b/arch/powerpc/platforms/cell/spu_syscalls.c
index 714bbfc3162..db4e638cf40 100644
--- a/arch/powerpc/platforms/cell/spu_syscalls.c
+++ b/arch/powerpc/platforms/cell/spu_syscalls.c
@@ -69,8 +69,6 @@ SYSCALL_DEFINE4(spu_create, const char __user *, name, unsigned int, flags,
         umode_t, mode, int, neighbor_fd)
 {
         long ret;
-        struct file *neighbor;
-        int fput_needed;
         struct spufs_calls *calls;
 
         calls = spufs_calls_get();
@@ -78,11 +76,11 @@ SYSCALL_DEFINE4(spu_create, const char __user *, name, unsigned int, flags,
                 return -ENOSYS;
 
         if (flags & SPU_CREATE_AFFINITY_SPU) {
+                struct fd neighbor = fdget(neighbor_fd);
                 ret = -EBADF;
-                neighbor = fget_light(neighbor_fd, &fput_needed);
-                if (neighbor) {
-                        ret = calls->create_thread(name, flags, mode, neighbor);
-                        fput_light(neighbor, fput_needed);
+                if (neighbor.file) {
+                        ret = calls->create_thread(name, flags, mode, neighbor.file);
+                        fdput(neighbor);
                 }
         } else
                 ret = calls->create_thread(name, flags, mode, NULL);
@@ -94,8 +92,7 @@ SYSCALL_DEFINE4(spu_create, const char __user *, name, unsigned int, flags,
 asmlinkage long sys_spu_run(int fd, __u32 __user *unpc, __u32 __user *ustatus)
 {
         long ret;
-        struct file *filp;
-        int fput_needed;
+        struct fd arg;
         struct spufs_calls *calls;
 
         calls = spufs_calls_get();
@@ -103,10 +100,10 @@ asmlinkage long sys_spu_run(int fd, __u32 __user *unpc, __u32 __user *ustatus)
                 return -ENOSYS;
 
         ret = -EBADF;
-        filp = fget_light(fd, &fput_needed);
-        if (filp) {
-                ret = calls->spu_run(filp, unpc, ustatus);
-                fput_light(filp, fput_needed);
+        arg = fdget(fd);
+        if (arg.file) {
+                ret = calls->spu_run(arg.file, unpc, ustatus);
+                fdput(arg);
         }
 
         spufs_calls_put(calls);
diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index c2c5b078ba8..657e3f233a6 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c
@@ -106,6 +106,17 @@ static int spufs_ctx_note_size(struct spu_context *ctx, int dfd)
         return total;
 }
 
+static int match_context(const void *v, struct file *file, unsigned fd)
+{
+        struct spu_context *ctx;
+        if (file->f_op != &spufs_context_fops)
+                return 0;
+        ctx = SPUFS_I(file->f_dentry->d_inode)->i_ctx;
+        if (ctx->flags & SPU_CREATE_NOSCHED)
+                return 0;
+        return fd + 1;
+}
+
 /*
  * The additional architecture-specific notes for Cell are various
  * context files in the spu context.
@@ -115,29 +126,18 @@ static int spufs_ctx_note_size(struct spu_context *ctx, int dfd)
  * internal functionality to dump them without needing to actually
  * open the files.
  */
+/*
+ * descriptor table is not shared, so files can't change or go away.
+ */
 static struct spu_context *coredump_next_context(int *fd)
 {
-        struct fdtable *fdt = files_fdtable(current->files);
         struct file *file;
-        struct spu_context *ctx = NULL;
-
-        for (; *fd < fdt->max_fds; (*fd)++) {
-                if (!fd_is_open(*fd, fdt))
-                        continue;
-
-                file = fcheck(*fd);
-
-                if (!file || file->f_op != &spufs_context_fops)
-                        continue;
-
-                ctx = SPUFS_I(file->f_dentry->d_inode)->i_ctx;
-                if (ctx->flags & SPU_CREATE_NOSCHED)
-                        continue;
-
-                break;
-        }
-
-        return ctx;
+        int n = iterate_fd(current->files, *fd, match_context, NULL);
+        if (!n)
+                return NULL;
+        *fd = n - 1;
+        file = fcheck(*fd);
+        return SPUFS_I(file->f_dentry->d_inode)->i_ctx;
 }
 
 int spufs_coredump_extra_notes_size(void)