diff options
50 files changed, 284 insertions, 716 deletions
| @@ -536,7 +536,7 @@ KBUILD_CFLAGS += -g | |||
| 536 | KBUILD_AFLAGS += -gdwarf-2 | 536 | KBUILD_AFLAGS += -gdwarf-2 |
| 537 | endif | 537 | endif |
| 538 | 538 | ||
| 539 | ifdef CONFIG_FTRACE | 539 | ifdef CONFIG_FUNCTION_TRACER |
| 540 | KBUILD_CFLAGS += -pg | 540 | KBUILD_CFLAGS += -pg |
| 541 | endif | 541 | endif |
| 542 | 542 | ||
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 5021db2217e..9722f8bb506 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig | |||
| @@ -16,8 +16,7 @@ config ARM | |||
| 16 | select HAVE_ARCH_KGDB | 16 | select HAVE_ARCH_KGDB |
| 17 | select HAVE_KPROBES if (!XIP_KERNEL) | 17 | select HAVE_KPROBES if (!XIP_KERNEL) |
| 18 | select HAVE_KRETPROBES if (HAVE_KPROBES) | 18 | select HAVE_KRETPROBES if (HAVE_KPROBES) |
| 19 | select HAVE_FTRACE if (!XIP_KERNEL) | 19 | select HAVE_FUNCTION_TRACER if (!XIP_KERNEL) |
| 20 | select HAVE_DYNAMIC_FTRACE if (HAVE_FTRACE) | ||
| 21 | select HAVE_GENERIC_DMA_COHERENT | 20 | select HAVE_GENERIC_DMA_COHERENT |
| 22 | help | 21 | help |
| 23 | The ARM series is a line of low-power-consumption RISC chip designs | 22 | The ARM series is a line of low-power-consumption RISC chip designs |
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index 7a03f200788..c47f2a3f8f8 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile | |||
| @@ -70,7 +70,7 @@ SEDFLAGS = s/TEXT_START/$(ZTEXTADDR)/;s/BSS_START/$(ZBSSADDR)/ | |||
| 70 | targets := vmlinux vmlinux.lds piggy.gz piggy.o font.o font.c \ | 70 | targets := vmlinux vmlinux.lds piggy.gz piggy.o font.o font.c \ |
| 71 | head.o misc.o $(OBJS) | 71 | head.o misc.o $(OBJS) |
| 72 | 72 | ||
| 73 | ifeq ($(CONFIG_FTRACE),y) | 73 | ifeq ($(CONFIG_FUNCTION_TRACER),y) |
| 74 | ORIG_CFLAGS := $(KBUILD_CFLAGS) | 74 | ORIG_CFLAGS := $(KBUILD_CFLAGS) |
| 75 | KBUILD_CFLAGS = $(subst -pg, , $(ORIG_CFLAGS)) | 75 | KBUILD_CFLAGS = $(subst -pg, , $(ORIG_CFLAGS)) |
| 76 | endif | 76 | endif |
diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h index 584ef9a8e5a..39c8bc1a006 100644 --- a/arch/arm/include/asm/ftrace.h +++ b/arch/arm/include/asm/ftrace.h | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | #ifndef _ASM_ARM_FTRACE | 1 | #ifndef _ASM_ARM_FTRACE |
| 2 | #define _ASM_ARM_FTRACE | 2 | #define _ASM_ARM_FTRACE |
| 3 | 3 | ||
| 4 | #ifdef CONFIG_FTRACE | 4 | #ifdef CONFIG_FUNCTION_TRACER |
| 5 | #define MCOUNT_ADDR ((long)(mcount)) | 5 | #define MCOUNT_ADDR ((long)(mcount)) |
| 6 | #define MCOUNT_INSN_SIZE 4 /* sizeof mcount call */ | 6 | #define MCOUNT_INSN_SIZE 4 /* sizeof mcount call */ |
| 7 | 7 | ||
diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c index 2357b1cf1cf..c74f766ffc1 100644 --- a/arch/arm/kernel/armksyms.c +++ b/arch/arm/kernel/armksyms.c | |||
| @@ -183,6 +183,6 @@ EXPORT_SYMBOL(_find_next_bit_be); | |||
| 183 | 183 | ||
| 184 | EXPORT_SYMBOL(copy_page); | 184 | EXPORT_SYMBOL(copy_page); |
| 185 | 185 | ||
| 186 | #ifdef CONFIG_FTRACE | 186 | #ifdef CONFIG_FUNCTION_TRACER |
| 187 | EXPORT_SYMBOL(mcount); | 187 | EXPORT_SYMBOL(mcount); |
| 188 | #endif | 188 | #endif |
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S index 3aa14dcc5ba..06269ea375c 100644 --- a/arch/arm/kernel/entry-common.S +++ b/arch/arm/kernel/entry-common.S | |||
| @@ -101,7 +101,7 @@ ENDPROC(ret_from_fork) | |||
| 101 | #undef CALL | 101 | #undef CALL |
| 102 | #define CALL(x) .long x | 102 | #define CALL(x) .long x |
| 103 | 103 | ||
| 104 | #ifdef CONFIG_FTRACE | 104 | #ifdef CONFIG_FUNCTION_TRACER |
| 105 | #ifdef CONFIG_DYNAMIC_FTRACE | 105 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 106 | ENTRY(mcount) | 106 | ENTRY(mcount) |
| 107 | stmdb sp!, {r0-r3, lr} | 107 | stmdb sp!, {r0-r3, lr} |
| @@ -149,7 +149,7 @@ trace: | |||
| 149 | ftrace_stub: | 149 | ftrace_stub: |
| 150 | mov pc, lr | 150 | mov pc, lr |
| 151 | 151 | ||
| 152 | #endif /* CONFIG_FTRACE */ | 152 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 153 | 153 | ||
| 154 | /*============================================================================= | 154 | /*============================================================================= |
| 155 | * SWI handler | 155 | * SWI handler |
diff --git a/arch/arm/kernel/ftrace.c b/arch/arm/kernel/ftrace.c index 76d50e6091b..6c90479e897 100644 --- a/arch/arm/kernel/ftrace.c +++ b/arch/arm/kernel/ftrace.c | |||
| @@ -95,19 +95,6 @@ int ftrace_update_ftrace_func(ftrace_func_t func) | |||
| 95 | return ret; | 95 | return ret; |
| 96 | } | 96 | } |
| 97 | 97 | ||
| 98 | int ftrace_mcount_set(unsigned long *data) | ||
| 99 | { | ||
| 100 | unsigned long pc, old; | ||
| 101 | unsigned long *addr = data; | ||
| 102 | unsigned char *new; | ||
| 103 | |||
| 104 | pc = (unsigned long)&mcount_call; | ||
| 105 | memcpy(&old, &mcount_call, MCOUNT_INSN_SIZE); | ||
| 106 | new = ftrace_call_replace(pc, *addr); | ||
| 107 | *addr = ftrace_modify_code(pc, (unsigned char *)&old, new); | ||
| 108 | return 0; | ||
| 109 | } | ||
| 110 | |||
| 111 | /* run from kstop_machine */ | 98 | /* run from kstop_machine */ |
| 112 | int __init ftrace_dyn_arch_init(void *data) | 99 | int __init ftrace_dyn_arch_init(void *data) |
| 113 | { | 100 | { |
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 5b1527883fc..525c13a4de9 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig | |||
| @@ -108,8 +108,7 @@ config ARCH_NO_VIRT_TO_BUS | |||
| 108 | config PPC | 108 | config PPC |
| 109 | bool | 109 | bool |
| 110 | default y | 110 | default y |
| 111 | select HAVE_DYNAMIC_FTRACE | 111 | select HAVE_FUNCTION_TRACER |
| 112 | select HAVE_FTRACE | ||
| 113 | select ARCH_WANT_OPTIONAL_GPIOLIB | 112 | select ARCH_WANT_OPTIONAL_GPIOLIB |
| 114 | select HAVE_IDE | 113 | select HAVE_IDE |
| 115 | select HAVE_IOREMAP_PROT | 114 | select HAVE_IOREMAP_PROT |
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 24dd1a37f8f..1f066706994 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile | |||
| @@ -122,7 +122,7 @@ KBUILD_CFLAGS += -mcpu=powerpc | |||
| 122 | endif | 122 | endif |
| 123 | 123 | ||
| 124 | # Work around a gcc code-gen bug with -fno-omit-frame-pointer. | 124 | # Work around a gcc code-gen bug with -fno-omit-frame-pointer. |
| 125 | ifeq ($(CONFIG_FTRACE),y) | 125 | ifeq ($(CONFIG_FUNCTION_TRACER),y) |
| 126 | KBUILD_CFLAGS += -mno-sched-epilog | 126 | KBUILD_CFLAGS += -mno-sched-epilog |
| 127 | endif | 127 | endif |
| 128 | 128 | ||
diff --git a/arch/powerpc/include/asm/ftrace.h b/arch/powerpc/include/asm/ftrace.h index de921326cca..b298f7a631e 100644 --- a/arch/powerpc/include/asm/ftrace.h +++ b/arch/powerpc/include/asm/ftrace.h | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | #ifndef _ASM_POWERPC_FTRACE | 1 | #ifndef _ASM_POWERPC_FTRACE |
| 2 | #define _ASM_POWERPC_FTRACE | 2 | #define _ASM_POWERPC_FTRACE |
| 3 | 3 | ||
| 4 | #ifdef CONFIG_FTRACE | 4 | #ifdef CONFIG_FUNCTION_TRACER |
| 5 | #define MCOUNT_ADDR ((long)(_mcount)) | 5 | #define MCOUNT_ADDR ((long)(_mcount)) |
| 6 | #define MCOUNT_INSN_SIZE 4 /* sizeof mcount call */ | 6 | #define MCOUNT_INSN_SIZE 4 /* sizeof mcount call */ |
| 7 | 7 | ||
diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile index fdb58253fa5..92673b43858 100644 --- a/arch/powerpc/kernel/Makefile +++ b/arch/powerpc/kernel/Makefile | |||
| @@ -12,7 +12,7 @@ CFLAGS_prom_init.o += -fPIC | |||
| 12 | CFLAGS_btext.o += -fPIC | 12 | CFLAGS_btext.o += -fPIC |
| 13 | endif | 13 | endif |
| 14 | 14 | ||
| 15 | ifdef CONFIG_FTRACE | 15 | ifdef CONFIG_FUNCTION_TRACER |
| 16 | # Do not trace early boot code | 16 | # Do not trace early boot code |
| 17 | CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog | 17 | CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog |
| 18 | CFLAGS_REMOVE_prom_init.o = -pg -mno-sched-epilog | 18 | CFLAGS_REMOVE_prom_init.o = -pg -mno-sched-epilog |
diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S index 1cbbf703364..7ecc0d1855c 100644 --- a/arch/powerpc/kernel/entry_32.S +++ b/arch/powerpc/kernel/entry_32.S | |||
| @@ -1158,7 +1158,7 @@ machine_check_in_rtas: | |||
| 1158 | 1158 | ||
| 1159 | #endif /* CONFIG_PPC_RTAS */ | 1159 | #endif /* CONFIG_PPC_RTAS */ |
| 1160 | 1160 | ||
| 1161 | #ifdef CONFIG_FTRACE | 1161 | #ifdef CONFIG_FUNCTION_TRACER |
| 1162 | #ifdef CONFIG_DYNAMIC_FTRACE | 1162 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 1163 | _GLOBAL(mcount) | 1163 | _GLOBAL(mcount) |
| 1164 | _GLOBAL(_mcount) | 1164 | _GLOBAL(_mcount) |
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index fd8b4bae9b0..e6d52845854 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S | |||
| @@ -884,7 +884,7 @@ _GLOBAL(enter_prom) | |||
| 884 | mtlr r0 | 884 | mtlr r0 |
| 885 | blr | 885 | blr |
| 886 | 886 | ||
| 887 | #ifdef CONFIG_FTRACE | 887 | #ifdef CONFIG_FUNCTION_TRACER |
| 888 | #ifdef CONFIG_DYNAMIC_FTRACE | 888 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 889 | _GLOBAL(mcount) | 889 | _GLOBAL(mcount) |
| 890 | _GLOBAL(_mcount) | 890 | _GLOBAL(_mcount) |
diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 3855ceb937b..f4b006ed0ab 100644 --- a/arch/powerpc/kernel/ftrace.c +++ b/arch/powerpc/kernel/ftrace.c | |||
| @@ -28,17 +28,17 @@ static unsigned int ftrace_nop = 0x60000000; | |||
| 28 | #endif | 28 | #endif |
| 29 | 29 | ||
| 30 | 30 | ||
| 31 | static unsigned int notrace ftrace_calc_offset(long ip, long addr) | 31 | static unsigned int ftrace_calc_offset(long ip, long addr) |
| 32 | { | 32 | { |
| 33 | return (int)(addr - ip); | 33 | return (int)(addr - ip); |
| 34 | } | 34 | } |
| 35 | 35 | ||
| 36 | notrace unsigned char *ftrace_nop_replace(void) | 36 | unsigned char *ftrace_nop_replace(void) |
| 37 | { | 37 | { |
| 38 | return (char *)&ftrace_nop; | 38 | return (char *)&ftrace_nop; |
| 39 | } | 39 | } |
| 40 | 40 | ||
| 41 | notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | 41 | unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) |
| 42 | { | 42 | { |
| 43 | static unsigned int op; | 43 | static unsigned int op; |
| 44 | 44 | ||
| @@ -68,7 +68,7 @@ notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | |||
| 68 | # define _ASM_PTR " .long " | 68 | # define _ASM_PTR " .long " |
| 69 | #endif | 69 | #endif |
| 70 | 70 | ||
| 71 | notrace int | 71 | int |
| 72 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, | 72 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, |
| 73 | unsigned char *new_code) | 73 | unsigned char *new_code) |
| 74 | { | 74 | { |
| @@ -113,7 +113,7 @@ ftrace_modify_code(unsigned long ip, unsigned char *old_code, | |||
| 113 | return faulted; | 113 | return faulted; |
| 114 | } | 114 | } |
| 115 | 115 | ||
| 116 | notrace int ftrace_update_ftrace_func(ftrace_func_t func) | 116 | int ftrace_update_ftrace_func(ftrace_func_t func) |
| 117 | { | 117 | { |
| 118 | unsigned long ip = (unsigned long)(&ftrace_call); | 118 | unsigned long ip = (unsigned long)(&ftrace_call); |
| 119 | unsigned char old[MCOUNT_INSN_SIZE], *new; | 119 | unsigned char old[MCOUNT_INSN_SIZE], *new; |
| @@ -126,23 +126,6 @@ notrace int ftrace_update_ftrace_func(ftrace_func_t func) | |||
| 126 | return ret; | 126 | return ret; |
| 127 | } | 127 | } |
| 128 | 128 | ||
| 129 | notrace int ftrace_mcount_set(unsigned long *data) | ||
| 130 | { | ||
| 131 | unsigned long ip = (long)(&mcount_call); | ||
| 132 | unsigned long *addr = data; | ||
| 133 | unsigned char old[MCOUNT_INSN_SIZE], *new; | ||
| 134 | |||
| 135 | /* | ||
| 136 | * Replace the mcount stub with a pointer to the | ||
| 137 | * ip recorder function. | ||
| 138 | */ | ||
| 139 | memcpy(old, &mcount_call, MCOUNT_INSN_SIZE); | ||
| 140 | new = ftrace_call_replace(ip, *addr); | ||
| 141 | *addr = ftrace_modify_code(ip, old, new); | ||
| 142 | |||
| 143 | return 0; | ||
| 144 | } | ||
| 145 | |||
| 146 | int __init ftrace_dyn_arch_init(void *data) | 129 | int __init ftrace_dyn_arch_init(void *data) |
| 147 | { | 130 | { |
| 148 | /* This is running in kstop_machine */ | 131 | /* This is running in kstop_machine */ |
diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c index 8edc2359c41..260089dccfb 100644 --- a/arch/powerpc/kernel/ppc_ksyms.c +++ b/arch/powerpc/kernel/ppc_ksyms.c | |||
| @@ -68,7 +68,7 @@ EXPORT_SYMBOL(single_step_exception); | |||
| 68 | EXPORT_SYMBOL(sys_sigreturn); | 68 | EXPORT_SYMBOL(sys_sigreturn); |
| 69 | #endif | 69 | #endif |
| 70 | 70 | ||
| 71 | #ifdef CONFIG_FTRACE | 71 | #ifdef CONFIG_FUNCTION_TRACER |
| 72 | EXPORT_SYMBOL(_mcount); | 72 | EXPORT_SYMBOL(_mcount); |
| 73 | #endif | 73 | #endif |
| 74 | 74 | ||
diff --git a/arch/powerpc/platforms/powermac/Makefile b/arch/powerpc/platforms/powermac/Makefile index be60d64be7a..50f16939255 100644 --- a/arch/powerpc/platforms/powermac/Makefile +++ b/arch/powerpc/platforms/powermac/Makefile | |||
| @@ -1,6 +1,6 @@ | |||
| 1 | CFLAGS_bootx_init.o += -fPIC | 1 | CFLAGS_bootx_init.o += -fPIC |
| 2 | 2 | ||
| 3 | ifdef CONFIG_FTRACE | 3 | ifdef CONFIG_FUNCTION_TRACER |
| 4 | # Do not trace early boot code | 4 | # Do not trace early boot code |
| 5 | CFLAGS_REMOVE_bootx_init.o = -pg -mno-sched-epilog | 5 | CFLAGS_REMOVE_bootx_init.o = -pg -mno-sched-epilog |
| 6 | endif | 6 | endif |
diff --git a/arch/sparc64/Kconfig b/arch/sparc64/Kconfig index 035b15af90d..3b96e70b467 100644 --- a/arch/sparc64/Kconfig +++ b/arch/sparc64/Kconfig | |||
| @@ -11,8 +11,7 @@ config SPARC | |||
| 11 | config SPARC64 | 11 | config SPARC64 |
| 12 | bool | 12 | bool |
| 13 | default y | 13 | default y |
| 14 | select HAVE_DYNAMIC_FTRACE | 14 | select HAVE_FUNCTION_TRACER |
| 15 | select HAVE_FTRACE | ||
| 16 | select HAVE_IDE | 15 | select HAVE_IDE |
| 17 | select HAVE_LMB | 16 | select HAVE_LMB |
| 18 | select HAVE_ARCH_KGDB | 17 | select HAVE_ARCH_KGDB |
diff --git a/arch/sparc64/Kconfig.debug b/arch/sparc64/Kconfig.debug index d6d32d178fc..c40515c0669 100644 --- a/arch/sparc64/Kconfig.debug +++ b/arch/sparc64/Kconfig.debug | |||
| @@ -33,7 +33,7 @@ config DEBUG_PAGEALLOC | |||
| 33 | 33 | ||
| 34 | config MCOUNT | 34 | config MCOUNT |
| 35 | bool | 35 | bool |
| 36 | depends on STACK_DEBUG || FTRACE | 36 | depends on STACK_DEBUG || FUNCTION_TRACER |
| 37 | default y | 37 | default y |
| 38 | 38 | ||
| 39 | config FRAME_POINTER | 39 | config FRAME_POINTER |
diff --git a/arch/sparc64/kernel/Makefile b/arch/sparc64/kernel/Makefile index c0b8009ab19..b3e0b986bef 100644 --- a/arch/sparc64/kernel/Makefile +++ b/arch/sparc64/kernel/Makefile | |||
| @@ -5,6 +5,8 @@ | |||
| 5 | EXTRA_AFLAGS := -ansi | 5 | EXTRA_AFLAGS := -ansi |
| 6 | EXTRA_CFLAGS := -Werror | 6 | EXTRA_CFLAGS := -Werror |
| 7 | 7 | ||
| 8 | CFLAGS_REMOVE_ftrace.o = -pg | ||
| 9 | |||
| 8 | extra-y := head.o init_task.o vmlinux.lds | 10 | extra-y := head.o init_task.o vmlinux.lds |
| 9 | 11 | ||
| 10 | obj-y := process.o setup.o cpu.o idprom.o reboot.o \ | 12 | obj-y := process.o setup.o cpu.o idprom.o reboot.o \ |
diff --git a/arch/sparc64/kernel/ftrace.c b/arch/sparc64/kernel/ftrace.c index 4298d0aee71..d0218e73f98 100644 --- a/arch/sparc64/kernel/ftrace.c +++ b/arch/sparc64/kernel/ftrace.c | |||
| @@ -9,12 +9,12 @@ | |||
| 9 | 9 | ||
| 10 | static const u32 ftrace_nop = 0x01000000; | 10 | static const u32 ftrace_nop = 0x01000000; |
| 11 | 11 | ||
| 12 | notrace unsigned char *ftrace_nop_replace(void) | 12 | unsigned char *ftrace_nop_replace(void) |
| 13 | { | 13 | { |
| 14 | return (char *)&ftrace_nop; | 14 | return (char *)&ftrace_nop; |
| 15 | } | 15 | } |
| 16 | 16 | ||
| 17 | notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | 17 | unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) |
| 18 | { | 18 | { |
| 19 | static u32 call; | 19 | static u32 call; |
| 20 | s32 off; | 20 | s32 off; |
| @@ -25,7 +25,7 @@ notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | |||
| 25 | return (unsigned char *) &call; | 25 | return (unsigned char *) &call; |
| 26 | } | 26 | } |
| 27 | 27 | ||
| 28 | notrace int | 28 | int |
| 29 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, | 29 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, |
| 30 | unsigned char *new_code) | 30 | unsigned char *new_code) |
| 31 | { | 31 | { |
| @@ -59,7 +59,7 @@ ftrace_modify_code(unsigned long ip, unsigned char *old_code, | |||
| 59 | return faulted; | 59 | return faulted; |
| 60 | } | 60 | } |
| 61 | 61 | ||
| 62 | notrace int ftrace_update_ftrace_func(ftrace_func_t func) | 62 | int ftrace_update_ftrace_func(ftrace_func_t func) |
| 63 | { | 63 | { |
| 64 | unsigned long ip = (unsigned long)(&ftrace_call); | 64 | unsigned long ip = (unsigned long)(&ftrace_call); |
| 65 | unsigned char old[MCOUNT_INSN_SIZE], *new; | 65 | unsigned char old[MCOUNT_INSN_SIZE], *new; |
| @@ -69,24 +69,6 @@ notrace int ftrace_update_ftrace_func(ftrace_func_t func) | |||
| 69 | return ftrace_modify_code(ip, old, new); | 69 | return ftrace_modify_code(ip, old, new); |
| 70 | } | 70 | } |
| 71 | 71 | ||
| 72 | notrace int ftrace_mcount_set(unsigned long *data) | ||
| 73 | { | ||
| 74 | unsigned long ip = (long)(&mcount_call); | ||
| 75 | unsigned long *addr = data; | ||
| 76 | unsigned char old[MCOUNT_INSN_SIZE], *new; | ||
| 77 | |||
| 78 | /* | ||
| 79 | * Replace the mcount stub with a pointer to the | ||
| 80 | * ip recorder function. | ||
| 81 | */ | ||
| 82 | memcpy(old, &mcount_call, MCOUNT_INSN_SIZE); | ||
| 83 | new = ftrace_call_replace(ip, *addr); | ||
| 84 | *addr = ftrace_modify_code(ip, old, new); | ||
| 85 | |||
| 86 | return 0; | ||
| 87 | } | ||
| 88 | |||
| 89 | |||
| 90 | int __init ftrace_dyn_arch_init(void *data) | 72 | int __init ftrace_dyn_arch_init(void *data) |
| 91 | { | 73 | { |
| 92 | ftrace_mcount_set(data); | 74 | ftrace_mcount_set(data); |
diff --git a/arch/sparc64/lib/mcount.S b/arch/sparc64/lib/mcount.S index fad90ddb3a2..7ce9c65f359 100644 --- a/arch/sparc64/lib/mcount.S +++ b/arch/sparc64/lib/mcount.S | |||
| @@ -93,7 +93,7 @@ mcount: | |||
| 93 | nop | 93 | nop |
| 94 | 1: | 94 | 1: |
| 95 | #endif | 95 | #endif |
| 96 | #ifdef CONFIG_FTRACE | 96 | #ifdef CONFIG_FUNCTION_TRACER |
| 97 | #ifdef CONFIG_DYNAMIC_FTRACE | 97 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 98 | mov %o7, %o0 | 98 | mov %o7, %o0 |
| 99 | .globl mcount_call | 99 | .globl mcount_call |
| @@ -119,7 +119,7 @@ mcount_call: | |||
| 119 | .size _mcount,.-_mcount | 119 | .size _mcount,.-_mcount |
| 120 | .size mcount,.-mcount | 120 | .size mcount,.-mcount |
| 121 | 121 | ||
| 122 | #ifdef CONFIG_FTRACE | 122 | #ifdef CONFIG_FUNCTION_TRACER |
| 123 | .globl ftrace_stub | 123 | .globl ftrace_stub |
| 124 | .type ftrace_stub,#function | 124 | .type ftrace_stub,#function |
| 125 | ftrace_stub: | 125 | ftrace_stub: |
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 350bee1d54d..d11d7b51319 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig | |||
| @@ -28,7 +28,7 @@ config X86 | |||
| 28 | select HAVE_KRETPROBES | 28 | select HAVE_KRETPROBES |
| 29 | select HAVE_FTRACE_MCOUNT_RECORD | 29 | select HAVE_FTRACE_MCOUNT_RECORD |
| 30 | select HAVE_DYNAMIC_FTRACE | 30 | select HAVE_DYNAMIC_FTRACE |
| 31 | select HAVE_FTRACE | 31 | select HAVE_FUNCTION_TRACER |
| 32 | select HAVE_KVM if ((X86_32 && !X86_VOYAGER && !X86_VISWS && !X86_NUMAQ) || X86_64) | 32 | select HAVE_KVM if ((X86_32 && !X86_VOYAGER && !X86_VISWS && !X86_NUMAQ) || X86_64) |
| 33 | select HAVE_ARCH_KGDB if !X86_VOYAGER | 33 | select HAVE_ARCH_KGDB if !X86_VOYAGER |
| 34 | select HAVE_ARCH_TRACEHOOK | 34 | select HAVE_ARCH_TRACEHOOK |
diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h index 47f7e65e6c1..9e8bc29b8b1 100644 --- a/arch/x86/include/asm/ftrace.h +++ b/arch/x86/include/asm/ftrace.h | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | #ifndef _ASM_X86_FTRACE_H | 1 | #ifndef _ASM_X86_FTRACE_H |
| 2 | #define _ASM_X86_FTRACE_H | 2 | #define _ASM_X86_FTRACE_H |
| 3 | 3 | ||
| 4 | #ifdef CONFIG_FTRACE | 4 | #ifdef CONFIG_FUNCTION_TRACER |
| 5 | #define MCOUNT_ADDR ((long)(mcount)) | 5 | #define MCOUNT_ADDR ((long)(mcount)) |
| 6 | #define MCOUNT_INSN_SIZE 5 /* sizeof mcount call */ | 6 | #define MCOUNT_INSN_SIZE 5 /* sizeof mcount call */ |
| 7 | 7 | ||
| @@ -19,6 +19,6 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr) | |||
| 19 | } | 19 | } |
| 20 | #endif | 20 | #endif |
| 21 | 21 | ||
| 22 | #endif /* CONFIG_FTRACE */ | 22 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 23 | 23 | ||
| 24 | #endif /* _ASM_X86_FTRACE_H */ | 24 | #endif /* _ASM_X86_FTRACE_H */ |
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index d7e5a58ee22..e489ff9cb3e 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile | |||
| @@ -6,11 +6,12 @@ extra-y := head_$(BITS).o head$(BITS).o head.o init_task.o vmlinu | |||
| 6 | 6 | ||
| 7 | CPPFLAGS_vmlinux.lds += -U$(UTS_MACHINE) | 7 | CPPFLAGS_vmlinux.lds += -U$(UTS_MACHINE) |
| 8 | 8 | ||
| 9 | ifdef CONFIG_FTRACE | 9 | ifdef CONFIG_FUNCTION_TRACER |
| 10 | # Do not profile debug and lowlevel utilities | 10 | # Do not profile debug and lowlevel utilities |
| 11 | CFLAGS_REMOVE_tsc.o = -pg | 11 | CFLAGS_REMOVE_tsc.o = -pg |
| 12 | CFLAGS_REMOVE_rtc.o = -pg | 12 | CFLAGS_REMOVE_rtc.o = -pg |
| 13 | CFLAGS_REMOVE_paravirt-spinlocks.o = -pg | 13 | CFLAGS_REMOVE_paravirt-spinlocks.o = -pg |
| 14 | CFLAGS_REMOVE_ftrace.o = -pg | ||
| 14 | endif | 15 | endif |
| 15 | 16 | ||
| 16 | # | 17 | # |
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index dd65143941a..28b597ef9ca 100644 --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel/entry_32.S | |||
| @@ -1149,7 +1149,7 @@ ENDPROC(xen_failsafe_callback) | |||
| 1149 | 1149 | ||
| 1150 | #endif /* CONFIG_XEN */ | 1150 | #endif /* CONFIG_XEN */ |
| 1151 | 1151 | ||
| 1152 | #ifdef CONFIG_FTRACE | 1152 | #ifdef CONFIG_FUNCTION_TRACER |
| 1153 | #ifdef CONFIG_DYNAMIC_FTRACE | 1153 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 1154 | 1154 | ||
| 1155 | ENTRY(mcount) | 1155 | ENTRY(mcount) |
| @@ -1204,7 +1204,7 @@ trace: | |||
| 1204 | jmp ftrace_stub | 1204 | jmp ftrace_stub |
| 1205 | END(mcount) | 1205 | END(mcount) |
| 1206 | #endif /* CONFIG_DYNAMIC_FTRACE */ | 1206 | #endif /* CONFIG_DYNAMIC_FTRACE */ |
| 1207 | #endif /* CONFIG_FTRACE */ | 1207 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 1208 | 1208 | ||
| 1209 | .section .rodata,"a" | 1209 | .section .rodata,"a" |
| 1210 | #include "syscall_table_32.S" | 1210 | #include "syscall_table_32.S" |
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index 09e7145484c..b86f332c96a 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86/kernel/entry_64.S | |||
| @@ -61,7 +61,7 @@ | |||
| 61 | 61 | ||
| 62 | .code64 | 62 | .code64 |
| 63 | 63 | ||
| 64 | #ifdef CONFIG_FTRACE | 64 | #ifdef CONFIG_FUNCTION_TRACER |
| 65 | #ifdef CONFIG_DYNAMIC_FTRACE | 65 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 66 | ENTRY(mcount) | 66 | ENTRY(mcount) |
| 67 | retq | 67 | retq |
| @@ -138,7 +138,7 @@ trace: | |||
| 138 | jmp ftrace_stub | 138 | jmp ftrace_stub |
| 139 | END(mcount) | 139 | END(mcount) |
| 140 | #endif /* CONFIG_DYNAMIC_FTRACE */ | 140 | #endif /* CONFIG_DYNAMIC_FTRACE */ |
| 141 | #endif /* CONFIG_FTRACE */ | 141 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 142 | 142 | ||
| 143 | #ifndef CONFIG_PREEMPT | 143 | #ifndef CONFIG_PREEMPT |
| 144 | #define retint_kernel retint_restore_args | 144 | #define retint_kernel retint_restore_args |
diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index d073d981a73..50ea0ac8c9b 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c | |||
| @@ -21,8 +21,7 @@ | |||
| 21 | #include <asm/nops.h> | 21 | #include <asm/nops.h> |
| 22 | 22 | ||
| 23 | 23 | ||
| 24 | /* Long is fine, even if it is only 4 bytes ;-) */ | 24 | static unsigned char ftrace_nop[MCOUNT_INSN_SIZE]; |
| 25 | static unsigned long *ftrace_nop; | ||
| 26 | 25 | ||
| 27 | union ftrace_code_union { | 26 | union ftrace_code_union { |
| 28 | char code[MCOUNT_INSN_SIZE]; | 27 | char code[MCOUNT_INSN_SIZE]; |
| @@ -33,17 +32,17 @@ union ftrace_code_union { | |||
| 33 | }; | 32 | }; |
| 34 | 33 | ||
| 35 | 34 | ||
| 36 | static int notrace ftrace_calc_offset(long ip, long addr) | 35 | static int ftrace_calc_offset(long ip, long addr) |
| 37 | { | 36 | { |
| 38 | return (int)(addr - ip); | 37 | return (int)(addr - ip); |
| 39 | } | 38 | } |
| 40 | 39 | ||
| 41 | notrace unsigned char *ftrace_nop_replace(void) | 40 | unsigned char *ftrace_nop_replace(void) |
| 42 | { | 41 | { |
| 43 | return (char *)ftrace_nop; | 42 | return ftrace_nop; |
| 44 | } | 43 | } |
| 45 | 44 | ||
| 46 | notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | 45 | unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) |
| 47 | { | 46 | { |
| 48 | static union ftrace_code_union calc; | 47 | static union ftrace_code_union calc; |
| 49 | 48 | ||
| @@ -57,7 +56,7 @@ notrace unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr) | |||
| 57 | return calc.code; | 56 | return calc.code; |
| 58 | } | 57 | } |
| 59 | 58 | ||
| 60 | notrace int | 59 | int |
| 61 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, | 60 | ftrace_modify_code(unsigned long ip, unsigned char *old_code, |
| 62 | unsigned char *new_code) | 61 | unsigned char *new_code) |
| 63 | { | 62 | { |
| @@ -66,26 +65,31 @@ ftrace_modify_code(unsigned long ip, unsigned char *old_code, | |||
| 66 | /* | 65 | /* |
| 67 | * Note: Due to modules and __init, code can | 66 | * Note: Due to modules and __init, code can |
| 68 | * disappear and change, we need to protect against faulting | 67 | * disappear and change, we need to protect against faulting |
| 69 | * as well as code changing. | 68 | * as well as code changing. We do this by using the |
| 69 | * probe_kernel_* functions. | ||
| 70 | * | 70 | * |
| 71 | * No real locking needed, this code is run through | 71 | * No real locking needed, this code is run through |
| 72 | * kstop_machine, or before SMP starts. | 72 | * kstop_machine, or before SMP starts. |
| 73 | */ | 73 | */ |
| 74 | if (__copy_from_user_inatomic(replaced, (char __user *)ip, MCOUNT_INSN_SIZE)) | ||
| 75 | return 1; | ||
| 76 | 74 | ||
| 75 | /* read the text we want to modify */ | ||
| 76 | if (probe_kernel_read(replaced, (void *)ip, MCOUNT_INSN_SIZE)) | ||
| 77 | return -EFAULT; | ||
| 78 | |||
| 79 | /* Make sure it is what we expect it to be */ | ||
| 77 | if (memcmp(replaced, old_code, MCOUNT_INSN_SIZE) != 0) | 80 | if (memcmp(replaced, old_code, MCOUNT_INSN_SIZE) != 0) |
| 78 | return 2; | 81 | return -EINVAL; |
| 79 | 82 | ||
| 80 | WARN_ON_ONCE(__copy_to_user_inatomic((char __user *)ip, new_code, | 83 | /* replace the text with the new text */ |
| 81 | MCOUNT_INSN_SIZE)); | 84 | if (probe_kernel_write((void *)ip, new_code, MCOUNT_INSN_SIZE)) |
| 85 | return -EPERM; | ||
| 82 | 86 | ||
| 83 | sync_core(); | 87 | sync_core(); |
| 84 | 88 | ||
| 85 | return 0; | 89 | return 0; |
| 86 | } | 90 | } |
| 87 | 91 | ||
| 88 | notrace int ftrace_update_ftrace_func(ftrace_func_t func) | 92 | int ftrace_update_ftrace_func(ftrace_func_t func) |
| 89 | { | 93 | { |
| 90 | unsigned long ip = (unsigned long)(&ftrace_call); | 94 | unsigned long ip = (unsigned long)(&ftrace_call); |
| 91 | unsigned char old[MCOUNT_INSN_SIZE], *new; | 95 | unsigned char old[MCOUNT_INSN_SIZE], *new; |
| @@ -98,13 +102,6 @@ notrace int ftrace_update_ftrace_func(ftrace_func_t func) | |||
| 98 | return ret; | 102 | return ret; |
| 99 | } | 103 | } |
| 100 | 104 | ||
| 101 | notrace int ftrace_mcount_set(unsigned long *data) | ||
| 102 | { | ||
| 103 | /* mcount is initialized as a nop */ | ||
| 104 | *data = 0; | ||
| 105 | return 0; | ||
| 106 | } | ||
| 107 | |||
| 108 | int __init ftrace_dyn_arch_init(void *data) | 105 | int __init ftrace_dyn_arch_init(void *data) |
| 109 | { | 106 | { |
| 110 | extern const unsigned char ftrace_test_p6nop[]; | 107 | extern const unsigned char ftrace_test_p6nop[]; |
| @@ -127,9 +124,6 @@ int __init ftrace_dyn_arch_init(void *data) | |||
| 127 | * TODO: check the cpuid to determine the best nop. | 124 | * TODO: check the cpuid to determine the best nop. |
| 128 | */ | 125 | */ |
| 129 | asm volatile ( | 126 | asm volatile ( |
| 130 | "jmp ftrace_test_jmp\n" | ||
| 131 | /* This code needs to stay around */ | ||
| 132 | ".section .text, \"ax\"\n" | ||
| 133 | "ftrace_test_jmp:" | 127 | "ftrace_test_jmp:" |
| 134 | "jmp ftrace_test_p6nop\n" | 128 | "jmp ftrace_test_p6nop\n" |
| 135 | "nop\n" | 129 | "nop\n" |
| @@ -140,8 +134,6 @@ int __init ftrace_dyn_arch_init(void *data) | |||
| 140 | "jmp 1f\n" | 134 | "jmp 1f\n" |
| 141 | "ftrace_test_nop5:" | 135 | "ftrace_test_nop5:" |
| 142 | ".byte 0x66,0x66,0x66,0x66,0x90\n" | 136 | ".byte 0x66,0x66,0x66,0x66,0x90\n" |
| 143 | "jmp 1f\n" | ||
| 144 | ".previous\n" | ||
| 145 | "1:" | 137 | "1:" |
| 146 | ".section .fixup, \"ax\"\n" | 138 | ".section .fixup, \"ax\"\n" |
| 147 | "2: movl $1, %0\n" | 139 | "2: movl $1, %0\n" |
| @@ -156,15 +148,15 @@ int __init ftrace_dyn_arch_init(void *data) | |||
| 156 | switch (faulted) { | 148 | switch (faulted) { |
| 157 | case 0: | 149 | case 0: |
| 158 | pr_info("ftrace: converting mcount calls to 0f 1f 44 00 00\n"); | 150 | pr_info("ftrace: converting mcount calls to 0f 1f 44 00 00\n"); |
| 159 | ftrace_nop = (unsigned long *)ftrace_test_p6nop; | 151 | memcpy(ftrace_nop, ftrace_test_p6nop, MCOUNT_INSN_SIZE); |
| 160 | break; | 152 | break; |
| 161 | case 1: | 153 | case 1: |
| 162 | pr_info("ftrace: converting mcount calls to 66 66 66 66 90\n"); | 154 | pr_info("ftrace: converting mcount calls to 66 66 66 66 90\n"); |
| 163 | ftrace_nop = (unsigned long *)ftrace_test_nop5; | 155 | memcpy(ftrace_nop, ftrace_test_nop5, MCOUNT_INSN_SIZE); |
| 164 | break; | 156 | break; |
| 165 | case 2: | 157 | case 2: |
| 166 | pr_info("ftrace: converting mcount calls to jmp . + 5\n"); | 158 | pr_info("ftrace: converting mcount calls to jmp . + 5\n"); |
| 167 | ftrace_nop = (unsigned long *)ftrace_test_jmp; | 159 | memcpy(ftrace_nop, ftrace_test_jmp, MCOUNT_INSN_SIZE); |
| 168 | break; | 160 | break; |
| 169 | } | 161 | } |
| 170 | 162 | ||
diff --git a/arch/x86/kernel/i386_ksyms_32.c b/arch/x86/kernel/i386_ksyms_32.c index dd7ebee446a..43cec6bdda6 100644 --- a/arch/x86/kernel/i386_ksyms_32.c +++ b/arch/x86/kernel/i386_ksyms_32.c | |||
| @@ -5,7 +5,7 @@ | |||
| 5 | #include <asm/desc.h> | 5 | #include <asm/desc.h> |
| 6 | #include <asm/ftrace.h> | 6 | #include <asm/ftrace.h> |
| 7 | 7 | ||
| 8 | #ifdef CONFIG_FTRACE | 8 | #ifdef CONFIG_FUNCTION_TRACER |
| 9 | /* mcount is defined in assembly */ | 9 | /* mcount is defined in assembly */ |
| 10 | EXPORT_SYMBOL(mcount); | 10 | EXPORT_SYMBOL(mcount); |
| 11 | #endif | 11 | #endif |
diff --git a/arch/x86/kernel/x8664_ksyms_64.c b/arch/x86/kernel/x8664_ksyms_64.c index b545f371b5f..695e426aa35 100644 --- a/arch/x86/kernel/x8664_ksyms_64.c +++ b/arch/x86/kernel/x8664_ksyms_64.c | |||
| @@ -12,7 +12,7 @@ | |||
| 12 | #include <asm/desc.h> | 12 | #include <asm/desc.h> |
| 13 | #include <asm/ftrace.h> | 13 | #include <asm/ftrace.h> |
| 14 | 14 | ||
| 15 | #ifdef CONFIG_FTRACE | 15 | #ifdef CONFIG_FUNCTION_TRACER |
| 16 | /* mcount is defined in assembly */ | 16 | /* mcount is defined in assembly */ |
| 17 | EXPORT_SYMBOL(mcount); | 17 | EXPORT_SYMBOL(mcount); |
| 18 | #endif | 18 | #endif |
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 313947940a1..6dcefba7836 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | ifdef CONFIG_FTRACE | 1 | ifdef CONFIG_FUNCTION_TRACER |
| 2 | # Do not profile debug and lowlevel utilities | 2 | # Do not profile debug and lowlevel utilities |
| 3 | CFLAGS_REMOVE_spinlock.o = -pg | 3 | CFLAGS_REMOVE_spinlock.o = -pg |
| 4 | CFLAGS_REMOVE_time.o = -pg | 4 | CFLAGS_REMOVE_time.o = -pg |
diff --git a/include/asm-generic/kdebug.h b/include/asm-generic/kdebug.h index 2b799c90b2d..11e57b6a85f 100644 --- a/include/asm-generic/kdebug.h +++ b/include/asm-generic/kdebug.h | |||
| @@ -3,6 +3,7 @@ | |||
| 3 | 3 | ||
| 4 | enum die_val { | 4 | enum die_val { |
| 5 | DIE_UNUSED, | 5 | DIE_UNUSED, |
| 6 | DIE_OOPS=1 | ||
| 6 | }; | 7 | }; |
| 7 | 8 | ||
| 8 | #endif /* _ASM_GENERIC_KDEBUG_H */ | 9 | #endif /* _ASM_GENERIC_KDEBUG_H */ |
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index a3d46151be1..703eb53cfa2 100644 --- a/include/linux/ftrace.h +++ b/include/linux/ftrace.h | |||
| @@ -8,7 +8,7 @@ | |||
| 8 | #include <linux/types.h> | 8 | #include <linux/types.h> |
| 9 | #include <linux/kallsyms.h> | 9 | #include <linux/kallsyms.h> |
| 10 | 10 | ||
| 11 | #ifdef CONFIG_FTRACE | 11 | #ifdef CONFIG_FUNCTION_TRACER |
| 12 | 12 | ||
| 13 | extern int ftrace_enabled; | 13 | extern int ftrace_enabled; |
| 14 | extern int | 14 | extern int |
| @@ -36,16 +36,14 @@ void clear_ftrace_function(void); | |||
| 36 | 36 | ||
| 37 | extern void ftrace_stub(unsigned long a0, unsigned long a1); | 37 | extern void ftrace_stub(unsigned long a0, unsigned long a1); |
| 38 | 38 | ||
| 39 | #else /* !CONFIG_FTRACE */ | 39 | #else /* !CONFIG_FUNCTION_TRACER */ |
| 40 | # define register_ftrace_function(ops) do { } while (0) | 40 | # define register_ftrace_function(ops) do { } while (0) |
| 41 | # define unregister_ftrace_function(ops) do { } while (0) | 41 | # define unregister_ftrace_function(ops) do { } while (0) |
| 42 | # define clear_ftrace_function(ops) do { } while (0) | 42 | # define clear_ftrace_function(ops) do { } while (0) |
| 43 | static inline void ftrace_kill_atomic(void) { } | 43 | static inline void ftrace_kill(void) { } |
| 44 | #endif /* CONFIG_FTRACE */ | 44 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 45 | 45 | ||
| 46 | #ifdef CONFIG_DYNAMIC_FTRACE | 46 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 47 | # define FTRACE_HASHBITS 10 | ||
| 48 | # define FTRACE_HASHSIZE (1<<FTRACE_HASHBITS) | ||
| 49 | 47 | ||
| 50 | enum { | 48 | enum { |
| 51 | FTRACE_FL_FREE = (1 << 0), | 49 | FTRACE_FL_FREE = (1 << 0), |
| @@ -58,9 +56,9 @@ enum { | |||
| 58 | }; | 56 | }; |
| 59 | 57 | ||
| 60 | struct dyn_ftrace { | 58 | struct dyn_ftrace { |
| 61 | struct hlist_node node; | 59 | struct list_head list; |
| 62 | unsigned long ip; /* address of mcount call-site */ | 60 | unsigned long ip; /* address of mcount call-site */ |
| 63 | unsigned long flags; | 61 | unsigned long flags; |
| 64 | }; | 62 | }; |
| 65 | 63 | ||
| 66 | int ftrace_force_update(void); | 64 | int ftrace_force_update(void); |
| @@ -71,14 +69,33 @@ extern int ftrace_ip_converted(unsigned long ip); | |||
| 71 | extern unsigned char *ftrace_nop_replace(void); | 69 | extern unsigned char *ftrace_nop_replace(void); |
| 72 | extern unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr); | 70 | extern unsigned char *ftrace_call_replace(unsigned long ip, unsigned long addr); |
| 73 | extern int ftrace_dyn_arch_init(void *data); | 71 | extern int ftrace_dyn_arch_init(void *data); |
| 74 | extern int ftrace_mcount_set(unsigned long *data); | ||
| 75 | extern int ftrace_modify_code(unsigned long ip, unsigned char *old_code, | ||
| 76 | unsigned char *new_code); | ||
| 77 | extern int ftrace_update_ftrace_func(ftrace_func_t func); | 72 | extern int ftrace_update_ftrace_func(ftrace_func_t func); |
| 78 | extern void ftrace_caller(void); | 73 | extern void ftrace_caller(void); |
| 79 | extern void ftrace_call(void); | 74 | extern void ftrace_call(void); |
| 80 | extern void mcount_call(void); | 75 | extern void mcount_call(void); |
| 81 | 76 | ||
| 77 | /** | ||
| 78 | * ftrace_modify_code - modify code segment | ||
| 79 | * @ip: the address of the code segment | ||
| 80 | * @old_code: the contents of what is expected to be there | ||
| 81 | * @new_code: the code to patch in | ||
| 82 | * | ||
| 83 | * This is a very sensitive operation and great care needs | ||
| 84 | * to be taken by the arch. The operation should carefully | ||
| 85 | * read the location, check to see if what is read is indeed | ||
| 86 | * what we expect it to be, and then on success of the compare, | ||
| 87 | * it should write to the location. | ||
| 88 | * | ||
| 89 | * Return must be: | ||
| 90 | * 0 on success | ||
| 91 | * -EFAULT on error reading the location | ||
| 92 | * -EINVAL on a failed compare of the contents | ||
| 93 | * -EPERM on error writing to the location | ||
| 94 | * Any other value will be considered a failure. | ||
| 95 | */ | ||
| 96 | extern int ftrace_modify_code(unsigned long ip, unsigned char *old_code, | ||
| 97 | unsigned char *new_code); | ||
| 98 | |||
| 82 | extern int skip_trace(unsigned long ip); | 99 | extern int skip_trace(unsigned long ip); |
| 83 | 100 | ||
| 84 | extern void ftrace_release(void *start, unsigned long size); | 101 | extern void ftrace_release(void *start, unsigned long size); |
| @@ -97,11 +114,10 @@ static inline void ftrace_release(void *start, unsigned long size) { } | |||
| 97 | 114 | ||
| 98 | /* totally disable ftrace - can not re-enable after this */ | 115 | /* totally disable ftrace - can not re-enable after this */ |
| 99 | void ftrace_kill(void); | 116 | void ftrace_kill(void); |
| 100 | void ftrace_kill_atomic(void); | ||
| 101 | 117 | ||
| 102 | static inline void tracer_disable(void) | 118 | static inline void tracer_disable(void) |
| 103 | { | 119 | { |
| 104 | #ifdef CONFIG_FTRACE | 120 | #ifdef CONFIG_FUNCTION_TRACER |
| 105 | ftrace_enabled = 0; | 121 | ftrace_enabled = 0; |
| 106 | #endif | 122 | #endif |
| 107 | } | 123 | } |
| @@ -113,7 +129,7 @@ static inline void tracer_disable(void) | |||
| 113 | */ | 129 | */ |
| 114 | static inline int __ftrace_enabled_save(void) | 130 | static inline int __ftrace_enabled_save(void) |
| 115 | { | 131 | { |
| 116 | #ifdef CONFIG_FTRACE | 132 | #ifdef CONFIG_FUNCTION_TRACER |
| 117 | int saved_ftrace_enabled = ftrace_enabled; | 133 | int saved_ftrace_enabled = ftrace_enabled; |
| 118 | ftrace_enabled = 0; | 134 | ftrace_enabled = 0; |
| 119 | return saved_ftrace_enabled; | 135 | return saved_ftrace_enabled; |
| @@ -124,7 +140,7 @@ static inline int __ftrace_enabled_save(void) | |||
| 124 | 140 | ||
| 125 | static inline void __ftrace_enabled_restore(int enabled) | 141 | static inline void __ftrace_enabled_restore(int enabled) |
| 126 | { | 142 | { |
| 127 | #ifdef CONFIG_FTRACE | 143 | #ifdef CONFIG_FUNCTION_TRACER |
| 128 | ftrace_enabled = enabled; | 144 | ftrace_enabled = enabled; |
| 129 | #endif | 145 | #endif |
| 130 | } | 146 | } |
diff --git a/kernel/Makefile b/kernel/Makefile index 305f11dbef2..9a3ec66a9d8 100644 --- a/kernel/Makefile +++ b/kernel/Makefile | |||
| @@ -13,7 +13,7 @@ obj-y = sched.o fork.o exec_domain.o panic.o printk.o \ | |||
| 13 | 13 | ||
| 14 | CFLAGS_REMOVE_sched.o = -mno-spe | 14 | CFLAGS_REMOVE_sched.o = -mno-spe |
| 15 | 15 | ||
| 16 | ifdef CONFIG_FTRACE | 16 | ifdef CONFIG_FUNCTION_TRACER |
| 17 | # Do not trace debug files and internal ftrace files | 17 | # Do not trace debug files and internal ftrace files |
| 18 | CFLAGS_REMOVE_lockdep.o = -pg | 18 | CFLAGS_REMOVE_lockdep.o = -pg |
| 19 | CFLAGS_REMOVE_lockdep_proc.o = -pg | 19 | CFLAGS_REMOVE_lockdep_proc.o = -pg |
| @@ -88,7 +88,7 @@ obj-$(CONFIG_MARKERS) += marker.o | |||
| 88 | obj-$(CONFIG_TRACEPOINTS) += tracepoint.o | 88 | obj-$(CONFIG_TRACEPOINTS) += tracepoint.o |
| 89 | obj-$(CONFIG_LATENCYTOP) += latencytop.o | 89 | obj-$(CONFIG_LATENCYTOP) += latencytop.o |
| 90 | obj-$(CONFIG_HAVE_GENERIC_DMA_COHERENT) += dma-coherent.o | 90 | obj-$(CONFIG_HAVE_GENERIC_DMA_COHERENT) += dma-coherent.o |
| 91 | obj-$(CONFIG_FTRACE) += trace/ | 91 | obj-$(CONFIG_FUNCTION_TRACER) += trace/ |
| 92 | obj-$(CONFIG_TRACING) += trace/ | 92 | obj-$(CONFIG_TRACING) += trace/ |
| 93 | obj-$(CONFIG_SMP) += sched_cpupri.o | 93 | obj-$(CONFIG_SMP) += sched_cpupri.o |
| 94 | 94 | ||
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index a13bd4dfaeb..9d048fa2d90 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c | |||
| @@ -474,7 +474,7 @@ static struct ctl_table kern_table[] = { | |||
| 474 | .mode = 0644, | 474 | .mode = 0644, |
| 475 | .proc_handler = &proc_dointvec, | 475 | .proc_handler = &proc_dointvec, |
| 476 | }, | 476 | }, |
| 477 | #ifdef CONFIG_FTRACE | 477 | #ifdef CONFIG_FUNCTION_TRACER |
| 478 | { | 478 | { |
| 479 | .ctl_name = CTL_UNNUMBERED, | 479 | .ctl_name = CTL_UNNUMBERED, |
| 480 | .procname = "ftrace_enabled", | 480 | .procname = "ftrace_enabled", |
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 1cb3e1f616a..e0cea282e0c 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig | |||
| @@ -1,11 +1,12 @@ | |||
| 1 | # | 1 | # |
| 2 | # Architectures that offer an FTRACE implementation should select HAVE_FTRACE: | 2 | # Architectures that offer an FUNCTION_TRACER implementation should |
| 3 | # select HAVE_FUNCTION_TRACER: | ||
| 3 | # | 4 | # |
| 4 | 5 | ||
| 5 | config NOP_TRACER | 6 | config NOP_TRACER |
| 6 | bool | 7 | bool |
| 7 | 8 | ||
| 8 | config HAVE_FTRACE | 9 | config HAVE_FUNCTION_TRACER |
| 9 | bool | 10 | bool |
| 10 | select NOP_TRACER | 11 | select NOP_TRACER |
| 11 | 12 | ||
| @@ -28,9 +29,11 @@ config TRACING | |||
| 28 | select STACKTRACE | 29 | select STACKTRACE |
| 29 | select TRACEPOINTS | 30 | select TRACEPOINTS |
| 30 | 31 | ||
| 31 | config FTRACE | 32 | menu "Tracers" |
| 33 | |||
| 34 | config FUNCTION_TRACER | ||
| 32 | bool "Kernel Function Tracer" | 35 | bool "Kernel Function Tracer" |
| 33 | depends on HAVE_FTRACE | 36 | depends on HAVE_FUNCTION_TRACER |
| 34 | depends on DEBUG_KERNEL | 37 | depends on DEBUG_KERNEL |
| 35 | select FRAME_POINTER | 38 | select FRAME_POINTER |
| 36 | select TRACING | 39 | select TRACING |
| @@ -49,7 +52,6 @@ config IRQSOFF_TRACER | |||
| 49 | default n | 52 | default n |
| 50 | depends on TRACE_IRQFLAGS_SUPPORT | 53 | depends on TRACE_IRQFLAGS_SUPPORT |
| 51 | depends on GENERIC_TIME | 54 | depends on GENERIC_TIME |
| 52 | depends on HAVE_FTRACE | ||
| 53 | depends on DEBUG_KERNEL | 55 | depends on DEBUG_KERNEL |
| 54 | select TRACE_IRQFLAGS | 56 | select TRACE_IRQFLAGS |
| 55 | select TRACING | 57 | select TRACING |
| @@ -73,7 +75,6 @@ config PREEMPT_TRACER | |||
| 73 | default n | 75 | default n |
| 74 | depends on GENERIC_TIME | 76 | depends on GENERIC_TIME |
| 75 | depends on PREEMPT | 77 | depends on PREEMPT |
| 76 | depends on HAVE_FTRACE | ||
| 77 | depends on DEBUG_KERNEL | 78 | depends on DEBUG_KERNEL |
| 78 | select TRACING | 79 | select TRACING |
| 79 | select TRACER_MAX_TRACE | 80 | select TRACER_MAX_TRACE |
| @@ -101,7 +102,6 @@ config SYSPROF_TRACER | |||
| 101 | 102 | ||
| 102 | config SCHED_TRACER | 103 | config SCHED_TRACER |
| 103 | bool "Scheduling Latency Tracer" | 104 | bool "Scheduling Latency Tracer" |
| 104 | depends on HAVE_FTRACE | ||
| 105 | depends on DEBUG_KERNEL | 105 | depends on DEBUG_KERNEL |
| 106 | select TRACING | 106 | select TRACING |
| 107 | select CONTEXT_SWITCH_TRACER | 107 | select CONTEXT_SWITCH_TRACER |
| @@ -112,7 +112,6 @@ config SCHED_TRACER | |||
| 112 | 112 | ||
| 113 | config CONTEXT_SWITCH_TRACER | 113 | config CONTEXT_SWITCH_TRACER |
| 114 | bool "Trace process context switches" | 114 | bool "Trace process context switches" |
| 115 | depends on HAVE_FTRACE | ||
| 116 | depends on DEBUG_KERNEL | 115 | depends on DEBUG_KERNEL |
| 117 | select TRACING | 116 | select TRACING |
| 118 | select MARKERS | 117 | select MARKERS |
| @@ -122,9 +121,9 @@ config CONTEXT_SWITCH_TRACER | |||
| 122 | 121 | ||
| 123 | config BOOT_TRACER | 122 | config BOOT_TRACER |
| 124 | bool "Trace boot initcalls" | 123 | bool "Trace boot initcalls" |
| 125 | depends on HAVE_FTRACE | ||
| 126 | depends on DEBUG_KERNEL | 124 | depends on DEBUG_KERNEL |
| 127 | select TRACING | 125 | select TRACING |
| 126 | select CONTEXT_SWITCH_TRACER | ||
| 128 | help | 127 | help |
| 129 | This tracer helps developers to optimize boot times: it records | 128 | This tracer helps developers to optimize boot times: it records |
| 130 | the timings of the initcalls and traces key events and the identity | 129 | the timings of the initcalls and traces key events and the identity |
| @@ -141,9 +140,9 @@ config BOOT_TRACER | |||
| 141 | 140 | ||
| 142 | config STACK_TRACER | 141 | config STACK_TRACER |
| 143 | bool "Trace max stack" | 142 | bool "Trace max stack" |
| 144 | depends on HAVE_FTRACE | 143 | depends on HAVE_FUNCTION_TRACER |
| 145 | depends on DEBUG_KERNEL | 144 | depends on DEBUG_KERNEL |
| 146 | select FTRACE | 145 | select FUNCTION_TRACER |
| 147 | select STACKTRACE | 146 | select STACKTRACE |
| 148 | help | 147 | help |
| 149 | This special tracer records the maximum stack footprint of the | 148 | This special tracer records the maximum stack footprint of the |
| @@ -160,7 +159,7 @@ config STACK_TRACER | |||
| 160 | 159 | ||
| 161 | config DYNAMIC_FTRACE | 160 | config DYNAMIC_FTRACE |
| 162 | bool "enable/disable ftrace tracepoints dynamically" | 161 | bool "enable/disable ftrace tracepoints dynamically" |
| 163 | depends on FTRACE | 162 | depends on FUNCTION_TRACER |
| 164 | depends on HAVE_DYNAMIC_FTRACE | 163 | depends on HAVE_DYNAMIC_FTRACE |
| 165 | depends on DEBUG_KERNEL | 164 | depends on DEBUG_KERNEL |
| 166 | default y | 165 | default y |
| @@ -170,7 +169,7 @@ config DYNAMIC_FTRACE | |||
| 170 | with a No-Op instruction) as they are called. A table is | 169 | with a No-Op instruction) as they are called. A table is |
| 171 | created to dynamically enable them again. | 170 | created to dynamically enable them again. |
| 172 | 171 | ||
| 173 | This way a CONFIG_FTRACE kernel is slightly larger, but otherwise | 172 | This way a CONFIG_FUNCTION_TRACER kernel is slightly larger, but otherwise |
| 174 | has native performance as long as no tracing is active. | 173 | has native performance as long as no tracing is active. |
| 175 | 174 | ||
| 176 | The changes to the code are done by a kernel thread that | 175 | The changes to the code are done by a kernel thread that |
| @@ -195,3 +194,5 @@ config FTRACE_STARTUP_TEST | |||
| 195 | a series of tests are made to verify that the tracer is | 194 | a series of tests are made to verify that the tracer is |
| 196 | functioning properly. It will do tests on all the configured | 195 | functioning properly. It will do tests on all the configured |
| 197 | tracers of ftrace. | 196 | tracers of ftrace. |
| 197 | |||
| 198 | endmenu | ||
diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile index a85dfba88ba..c8228b1a49e 100644 --- a/kernel/trace/Makefile +++ b/kernel/trace/Makefile | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | 1 | ||
| 2 | # Do not instrument the tracer itself: | 2 | # Do not instrument the tracer itself: |
| 3 | 3 | ||
| 4 | ifdef CONFIG_FTRACE | 4 | ifdef CONFIG_FUNCTION_TRACER |
| 5 | ORIG_CFLAGS := $(KBUILD_CFLAGS) | 5 | ORIG_CFLAGS := $(KBUILD_CFLAGS) |
| 6 | KBUILD_CFLAGS = $(subst -pg,,$(ORIG_CFLAGS)) | 6 | KBUILD_CFLAGS = $(subst -pg,,$(ORIG_CFLAGS)) |
| 7 | 7 | ||
| @@ -10,13 +10,13 @@ CFLAGS_trace_selftest_dynamic.o = -pg | |||
| 10 | obj-y += trace_selftest_dynamic.o | 10 | obj-y += trace_selftest_dynamic.o |
| 11 | endif | 11 | endif |
| 12 | 12 | ||
| 13 | obj-$(CONFIG_FTRACE) += libftrace.o | 13 | obj-$(CONFIG_FUNCTION_TRACER) += libftrace.o |
| 14 | obj-$(CONFIG_RING_BUFFER) += ring_buffer.o | 14 | obj-$(CONFIG_RING_BUFFER) += ring_buffer.o |
| 15 | 15 | ||
| 16 | obj-$(CONFIG_TRACING) += trace.o | 16 | obj-$(CONFIG_TRACING) += trace.o |
| 17 | obj-$(CONFIG_CONTEXT_SWITCH_TRACER) += trace_sched_switch.o | 17 | obj-$(CONFIG_CONTEXT_SWITCH_TRACER) += trace_sched_switch.o |
| 18 | obj-$(CONFIG_SYSPROF_TRACER) += trace_sysprof.o | 18 | obj-$(CONFIG_SYSPROF_TRACER) += trace_sysprof.o |
| 19 | obj-$(CONFIG_FTRACE) += trace_functions.o | 19 | obj-$(CONFIG_FUNCTION_TRACER) += trace_functions.o |
| 20 | obj-$(CONFIG_IRQSOFF_TRACER) += trace_irqsoff.o | 20 | obj-$(CONFIG_IRQSOFF_TRACER) += trace_irqsoff.o |
| 21 | obj-$(CONFIG_PREEMPT_TRACER) += trace_irqsoff.o | 21 | obj-$(CONFIG_PREEMPT_TRACER) += trace_irqsoff.o |
| 22 | obj-$(CONFIG_SCHED_TRACER) += trace_sched_wakeup.o | 22 | obj-$(CONFIG_SCHED_TRACER) += trace_sched_wakeup.o |
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 4dda4f60a2a..7618c528756 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -25,13 +25,24 @@ | |||
| 25 | #include <linux/ftrace.h> | 25 | #include <linux/ftrace.h> |
| 26 | #include <linux/sysctl.h> | 26 | #include <linux/sysctl.h> |
| 27 | #include <linux/ctype.h> | 27 | #include <linux/ctype.h> |
| 28 | #include <linux/hash.h> | ||
| 29 | #include <linux/list.h> | 28 | #include <linux/list.h> |
| 30 | 29 | ||
| 31 | #include <asm/ftrace.h> | 30 | #include <asm/ftrace.h> |
| 32 | 31 | ||
| 33 | #include "trace.h" | 32 | #include "trace.h" |
| 34 | 33 | ||
| 34 | #define FTRACE_WARN_ON(cond) \ | ||
| 35 | do { \ | ||
| 36 | if (WARN_ON(cond)) \ | ||
| 37 | ftrace_kill(); \ | ||
| 38 | } while (0) | ||
| 39 | |||
| 40 | #define FTRACE_WARN_ON_ONCE(cond) \ | ||
| 41 | do { \ | ||
| 42 | if (WARN_ON_ONCE(cond)) \ | ||
| 43 | ftrace_kill(); \ | ||
| 44 | } while (0) | ||
| 45 | |||
| 35 | /* ftrace_enabled is a method to turn ftrace on or off */ | 46 | /* ftrace_enabled is a method to turn ftrace on or off */ |
| 36 | int ftrace_enabled __read_mostly; | 47 | int ftrace_enabled __read_mostly; |
| 37 | static int last_ftrace_enabled; | 48 | static int last_ftrace_enabled; |
| @@ -153,21 +164,8 @@ static int __unregister_ftrace_function(struct ftrace_ops *ops) | |||
| 153 | } | 164 | } |
| 154 | 165 | ||
| 155 | #ifdef CONFIG_DYNAMIC_FTRACE | 166 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 156 | |||
| 157 | #ifndef CONFIG_FTRACE_MCOUNT_RECORD | 167 | #ifndef CONFIG_FTRACE_MCOUNT_RECORD |
| 158 | /* | 168 | # error Dynamic ftrace depends on MCOUNT_RECORD |
| 159 | * The hash lock is only needed when the recording of the mcount | ||
| 160 | * callers are dynamic. That is, by the caller themselves and | ||
| 161 | * not recorded via the compilation. | ||
| 162 | */ | ||
| 163 | static DEFINE_SPINLOCK(ftrace_hash_lock); | ||
| 164 | #define ftrace_hash_lock(flags) spin_lock_irqsave(&ftrace_hash_lock, flags) | ||
| 165 | #define ftrace_hash_unlock(flags) \ | ||
| 166 | spin_unlock_irqrestore(&ftrace_hash_lock, flags) | ||
| 167 | #else | ||
| 168 | /* This is protected via the ftrace_lock with MCOUNT_RECORD. */ | ||
| 169 | #define ftrace_hash_lock(flags) do { (void)(flags); } while (0) | ||
| 170 | #define ftrace_hash_unlock(flags) do { } while(0) | ||
| 171 | #endif | 169 | #endif |
| 172 | 170 | ||
| 173 | /* | 171 | /* |
| @@ -178,8 +176,6 @@ static DEFINE_SPINLOCK(ftrace_hash_lock); | |||
| 178 | */ | 176 | */ |
| 179 | static unsigned long mcount_addr = MCOUNT_ADDR; | 177 | static unsigned long mcount_addr = MCOUNT_ADDR; |
| 180 | 178 | ||
| 181 | static struct task_struct *ftraced_task; | ||
| 182 | |||
| 183 | enum { | 179 | enum { |
| 184 | FTRACE_ENABLE_CALLS = (1 << 0), | 180 | FTRACE_ENABLE_CALLS = (1 << 0), |
| 185 | FTRACE_DISABLE_CALLS = (1 << 1), | 181 | FTRACE_DISABLE_CALLS = (1 << 1), |
| @@ -190,13 +186,9 @@ enum { | |||
| 190 | 186 | ||
| 191 | static int ftrace_filtered; | 187 | static int ftrace_filtered; |
| 192 | static int tracing_on; | 188 | static int tracing_on; |
| 193 | static int frozen_record_count; | ||
| 194 | 189 | ||
| 195 | static struct hlist_head ftrace_hash[FTRACE_HASHSIZE]; | 190 | static LIST_HEAD(ftrace_new_addrs); |
| 196 | 191 | ||
| 197 | static DEFINE_PER_CPU(int, ftrace_shutdown_disable_cpu); | ||
| 198 | |||
| 199 | static DEFINE_MUTEX(ftraced_lock); | ||
| 200 | static DEFINE_MUTEX(ftrace_regex_lock); | 192 | static DEFINE_MUTEX(ftrace_regex_lock); |
| 201 | 193 | ||
| 202 | struct ftrace_page { | 194 | struct ftrace_page { |
| @@ -214,16 +206,13 @@ struct ftrace_page { | |||
| 214 | static struct ftrace_page *ftrace_pages_start; | 206 | static struct ftrace_page *ftrace_pages_start; |
| 215 | static struct ftrace_page *ftrace_pages; | 207 | static struct ftrace_page *ftrace_pages; |
| 216 | 208 | ||
| 217 | static int ftraced_trigger; | ||
| 218 | static int ftraced_suspend; | ||
| 219 | static int ftraced_stop; | ||
| 220 | |||
| 221 | static int ftrace_record_suspend; | ||
| 222 | |||
| 223 | static struct dyn_ftrace *ftrace_free_records; | 209 | static struct dyn_ftrace *ftrace_free_records; |
| 224 | 210 | ||
| 225 | 211 | ||
| 226 | #ifdef CONFIG_KPROBES | 212 | #ifdef CONFIG_KPROBES |
| 213 | |||
| 214 | static int frozen_record_count; | ||
| 215 | |||
| 227 | static inline void freeze_record(struct dyn_ftrace *rec) | 216 | static inline void freeze_record(struct dyn_ftrace *rec) |
| 228 | { | 217 | { |
| 229 | if (!(rec->flags & FTRACE_FL_FROZEN)) { | 218 | if (!(rec->flags & FTRACE_FL_FROZEN)) { |
| @@ -250,72 +239,6 @@ static inline int record_frozen(struct dyn_ftrace *rec) | |||
| 250 | # define record_frozen(rec) ({ 0; }) | 239 | # define record_frozen(rec) ({ 0; }) |
| 251 | #endif /* CONFIG_KPROBES */ | 240 | #endif /* CONFIG_KPROBES */ |
| 252 | 241 | ||
| 253 | int skip_trace(unsigned long ip) | ||
| 254 | { | ||
| 255 | unsigned long fl; | ||
| 256 | struct dyn_ftrace *rec; | ||
| 257 | struct hlist_node *t; | ||
| 258 | struct hlist_head *head; | ||
| 259 | |||
| 260 | if (frozen_record_count == 0) | ||
| 261 | return 0; | ||
| 262 | |||
| 263 | head = &ftrace_hash[hash_long(ip, FTRACE_HASHBITS)]; | ||
| 264 | hlist_for_each_entry_rcu(rec, t, head, node) { | ||
| 265 | if (rec->ip == ip) { | ||
| 266 | if (record_frozen(rec)) { | ||
| 267 | if (rec->flags & FTRACE_FL_FAILED) | ||
| 268 | return 1; | ||
| 269 | |||
| 270 | if (!(rec->flags & FTRACE_FL_CONVERTED)) | ||
| 271 | return 1; | ||
| 272 | |||
| 273 | if (!tracing_on || !ftrace_enabled) | ||
| 274 | return 1; | ||
| 275 | |||
| 276 | if (ftrace_filtered) { | ||
| 277 | fl = rec->flags & (FTRACE_FL_FILTER | | ||
| 278 | FTRACE_FL_NOTRACE); | ||
| 279 | if (!fl || (fl & FTRACE_FL_NOTRACE)) | ||
| 280 | return 1; | ||
| 281 | } | ||
| 282 | } | ||
| 283 | break; | ||
| 284 | } | ||
| 285 | } | ||
| 286 | |||
| 287 | return 0; | ||
| 288 | } | ||
| 289 | |||
| 290 | static inline int | ||
| 291 | ftrace_ip_in_hash(unsigned long ip, unsigned long key) | ||
| 292 | { | ||
| 293 | struct dyn_ftrace *p; | ||
| 294 | struct hlist_node *t; | ||
| 295 | int found = 0; | ||
| 296 | |||
| 297 | hlist_for_each_entry_rcu(p, t, &ftrace_hash[key], node) { | ||
| 298 | if (p->ip == ip) { | ||
| 299 | found = 1; | ||
| 300 | break; | ||
| 301 | } | ||
| 302 | } | ||
| 303 | |||
| 304 | return found; | ||
| 305 | } | ||
| 306 | |||
| 307 | static inline void | ||
| 308 | ftrace_add_hash(struct dyn_ftrace *node, unsigned long key) | ||
| 309 | { | ||
| 310 | hlist_add_head_rcu(&node->node, &ftrace_hash[key]); | ||
| 311 | } | ||
| 312 | |||
| 313 | /* called from kstop_machine */ | ||
| 314 | static inline void ftrace_del_hash(struct dyn_ftrace *node) | ||
| 315 | { | ||
| 316 | hlist_del(&node->node); | ||
| 317 | } | ||
| 318 | |||
| 319 | static void ftrace_free_rec(struct dyn_ftrace *rec) | 242 | static void ftrace_free_rec(struct dyn_ftrace *rec) |
| 320 | { | 243 | { |
| 321 | rec->ip = (unsigned long)ftrace_free_records; | 244 | rec->ip = (unsigned long)ftrace_free_records; |
| @@ -346,7 +269,6 @@ void ftrace_release(void *start, unsigned long size) | |||
| 346 | } | 269 | } |
| 347 | } | 270 | } |
| 348 | spin_unlock(&ftrace_lock); | 271 | spin_unlock(&ftrace_lock); |
| 349 | |||
| 350 | } | 272 | } |
| 351 | 273 | ||
| 352 | static struct dyn_ftrace *ftrace_alloc_dyn_node(unsigned long ip) | 274 | static struct dyn_ftrace *ftrace_alloc_dyn_node(unsigned long ip) |
| @@ -358,10 +280,8 @@ static struct dyn_ftrace *ftrace_alloc_dyn_node(unsigned long ip) | |||
| 358 | rec = ftrace_free_records; | 280 | rec = ftrace_free_records; |
| 359 | 281 | ||
| 360 | if (unlikely(!(rec->flags & FTRACE_FL_FREE))) { | 282 | if (unlikely(!(rec->flags & FTRACE_FL_FREE))) { |
| 361 | WARN_ON_ONCE(1); | 283 | FTRACE_WARN_ON_ONCE(1); |
| 362 | ftrace_free_records = NULL; | 284 | ftrace_free_records = NULL; |
| 363 | ftrace_disabled = 1; | ||
| 364 | ftrace_enabled = 0; | ||
| 365 | return NULL; | 285 | return NULL; |
| 366 | } | 286 | } |
| 367 | 287 | ||
| @@ -371,76 +291,36 @@ static struct dyn_ftrace *ftrace_alloc_dyn_node(unsigned long ip) | |||
| 371 | } | 291 | } |
| 372 | 292 | ||
| 373 | if (ftrace_pages->index == ENTRIES_PER_PAGE) { | 293 | if (ftrace_pages->index == ENTRIES_PER_PAGE) { |
| 374 | if (!ftrace_pages->next) | 294 | if (!ftrace_pages->next) { |
| 375 | return NULL; | 295 | /* allocate another page */ |
| 296 | ftrace_pages->next = | ||
| 297 | (void *)get_zeroed_page(GFP_KERNEL); | ||
| 298 | if (!ftrace_pages->next) | ||
| 299 | return NULL; | ||
| 300 | } | ||
| 376 | ftrace_pages = ftrace_pages->next; | 301 | ftrace_pages = ftrace_pages->next; |
| 377 | } | 302 | } |
| 378 | 303 | ||
| 379 | return &ftrace_pages->records[ftrace_pages->index++]; | 304 | return &ftrace_pages->records[ftrace_pages->index++]; |
| 380 | } | 305 | } |
| 381 | 306 | ||
| 382 | static void | 307 | static struct dyn_ftrace * |
| 383 | ftrace_record_ip(unsigned long ip) | 308 | ftrace_record_ip(unsigned long ip) |
| 384 | { | 309 | { |
| 385 | struct dyn_ftrace *node; | 310 | struct dyn_ftrace *rec; |
| 386 | unsigned long flags; | ||
| 387 | unsigned long key; | ||
| 388 | int resched; | ||
| 389 | int cpu; | ||
| 390 | 311 | ||
| 391 | if (!ftrace_enabled || ftrace_disabled) | 312 | if (!ftrace_enabled || ftrace_disabled) |
| 392 | return; | 313 | return NULL; |
| 393 | |||
| 394 | resched = need_resched(); | ||
| 395 | preempt_disable_notrace(); | ||
| 396 | |||
| 397 | /* | ||
| 398 | * We simply need to protect against recursion. | ||
| 399 | * Use the the raw version of smp_processor_id and not | ||
| 400 | * __get_cpu_var which can call debug hooks that can | ||
| 401 | * cause a recursive crash here. | ||
| 402 | */ | ||
| 403 | cpu = raw_smp_processor_id(); | ||
| 404 | per_cpu(ftrace_shutdown_disable_cpu, cpu)++; | ||
| 405 | if (per_cpu(ftrace_shutdown_disable_cpu, cpu) != 1) | ||
| 406 | goto out; | ||
| 407 | 314 | ||
| 408 | if (unlikely(ftrace_record_suspend)) | 315 | rec = ftrace_alloc_dyn_node(ip); |
| 409 | goto out; | 316 | if (!rec) |
| 410 | 317 | return NULL; | |
| 411 | key = hash_long(ip, FTRACE_HASHBITS); | ||
| 412 | |||
| 413 | WARN_ON_ONCE(key >= FTRACE_HASHSIZE); | ||
| 414 | |||
| 415 | if (ftrace_ip_in_hash(ip, key)) | ||
| 416 | goto out; | ||
| 417 | |||
| 418 | ftrace_hash_lock(flags); | ||
| 419 | |||
| 420 | /* This ip may have hit the hash before the lock */ | ||
| 421 | if (ftrace_ip_in_hash(ip, key)) | ||
| 422 | goto out_unlock; | ||
| 423 | |||
| 424 | node = ftrace_alloc_dyn_node(ip); | ||
| 425 | if (!node) | ||
| 426 | goto out_unlock; | ||
| 427 | |||
| 428 | node->ip = ip; | ||
| 429 | 318 | ||
| 430 | ftrace_add_hash(node, key); | 319 | rec->ip = ip; |
| 431 | 320 | ||
| 432 | ftraced_trigger = 1; | 321 | list_add(&rec->list, &ftrace_new_addrs); |
| 433 | 322 | ||
| 434 | out_unlock: | 323 | return rec; |
| 435 | ftrace_hash_unlock(flags); | ||
| 436 | out: | ||
| 437 | per_cpu(ftrace_shutdown_disable_cpu, cpu)--; | ||
| 438 | |||
| 439 | /* prevent recursion with scheduler */ | ||
| 440 | if (resched) | ||
| 441 | preempt_enable_no_resched_notrace(); | ||
| 442 | else | ||
| 443 | preempt_enable_notrace(); | ||
| 444 | } | 324 | } |
| 445 | 325 | ||
| 446 | #define FTRACE_ADDR ((long)(ftrace_caller)) | 326 | #define FTRACE_ADDR ((long)(ftrace_caller)) |
| @@ -559,7 +439,6 @@ static void ftrace_replace_code(int enable) | |||
| 559 | rec->flags |= FTRACE_FL_FAILED; | 439 | rec->flags |= FTRACE_FL_FAILED; |
| 560 | if ((system_state == SYSTEM_BOOTING) || | 440 | if ((system_state == SYSTEM_BOOTING) || |
| 561 | !core_kernel_text(rec->ip)) { | 441 | !core_kernel_text(rec->ip)) { |
| 562 | ftrace_del_hash(rec); | ||
| 563 | ftrace_free_rec(rec); | 442 | ftrace_free_rec(rec); |
| 564 | } | 443 | } |
| 565 | } | 444 | } |
| @@ -567,15 +446,6 @@ static void ftrace_replace_code(int enable) | |||
| 567 | } | 446 | } |
| 568 | } | 447 | } |
| 569 | 448 | ||
| 570 | static void ftrace_shutdown_replenish(void) | ||
| 571 | { | ||
| 572 | if (ftrace_pages->next) | ||
| 573 | return; | ||
| 574 | |||
| 575 | /* allocate another page */ | ||
| 576 | ftrace_pages->next = (void *)get_zeroed_page(GFP_KERNEL); | ||
| 577 | } | ||
| 578 | |||
| 579 | static void print_ip_ins(const char *fmt, unsigned char *p) | 449 | static void print_ip_ins(const char *fmt, unsigned char *p) |
| 580 | { | 450 | { |
| 581 | int i; | 451 | int i; |
| @@ -591,23 +461,23 @@ ftrace_code_disable(struct dyn_ftrace *rec) | |||
| 591 | { | 461 | { |
| 592 | unsigned long ip; | 462 | unsigned long ip; |
| 593 | unsigned char *nop, *call; | 463 | unsigned char *nop, *call; |
| 594 | int failed; | 464 | int ret; |
| 595 | 465 | ||
| 596 | ip = rec->ip; | 466 | ip = rec->ip; |
| 597 | 467 | ||
| 598 | nop = ftrace_nop_replace(); | 468 | nop = ftrace_nop_replace(); |
| 599 | call = ftrace_call_replace(ip, mcount_addr); | 469 | call = ftrace_call_replace(ip, mcount_addr); |
| 600 | 470 | ||
| 601 | failed = ftrace_modify_code(ip, call, nop); | 471 | ret = ftrace_modify_code(ip, call, nop); |
| 602 | if (failed) { | 472 | if (ret) { |
| 603 | switch (failed) { | 473 | switch (ret) { |
| 604 | case 1: | 474 | case -EFAULT: |
| 605 | WARN_ON_ONCE(1); | 475 | FTRACE_WARN_ON_ONCE(1); |
| 606 | pr_info("ftrace faulted on modifying "); | 476 | pr_info("ftrace faulted on modifying "); |
| 607 | print_ip_sym(ip); | 477 | print_ip_sym(ip); |
| 608 | break; | 478 | break; |
| 609 | case 2: | 479 | case -EINVAL: |
| 610 | WARN_ON_ONCE(1); | 480 | FTRACE_WARN_ON_ONCE(1); |
| 611 | pr_info("ftrace failed to modify "); | 481 | pr_info("ftrace failed to modify "); |
| 612 | print_ip_sym(ip); | 482 | print_ip_sym(ip); |
| 613 | print_ip_ins(" expected: ", call); | 483 | print_ip_ins(" expected: ", call); |
| @@ -615,6 +485,15 @@ ftrace_code_disable(struct dyn_ftrace *rec) | |||
| 615 | print_ip_ins(" replace: ", nop); | 485 | print_ip_ins(" replace: ", nop); |
| 616 | printk(KERN_CONT "\n"); | 486 | printk(KERN_CONT "\n"); |
| 617 | break; | 487 | break; |
| 488 | case -EPERM: | ||
| 489 | FTRACE_WARN_ON_ONCE(1); | ||
| 490 | pr_info("ftrace faulted on writing "); | ||
| 491 | print_ip_sym(ip); | ||
| 492 | break; | ||
| 493 | default: | ||
| 494 | FTRACE_WARN_ON_ONCE(1); | ||
| 495 | pr_info("ftrace faulted on unknown error "); | ||
| 496 | print_ip_sym(ip); | ||
| 618 | } | 497 | } |
| 619 | 498 | ||
| 620 | rec->flags |= FTRACE_FL_FAILED; | 499 | rec->flags |= FTRACE_FL_FAILED; |
| @@ -623,19 +502,11 @@ ftrace_code_disable(struct dyn_ftrace *rec) | |||
| 623 | return 1; | 502 | return 1; |
| 624 | } | 503 | } |
| 625 | 504 | ||
| 626 | static int __ftrace_update_code(void *ignore); | ||
| 627 | |||
| 628 | static int __ftrace_modify_code(void *data) | 505 | static int __ftrace_modify_code(void *data) |
| 629 | { | 506 | { |
| 630 | unsigned long addr; | ||
| 631 | int *command = data; | 507 | int *command = data; |
| 632 | 508 | ||
| 633 | if (*command & FTRACE_ENABLE_CALLS) { | 509 | if (*command & FTRACE_ENABLE_CALLS) { |
| 634 | /* | ||
| 635 | * Update any recorded ips now that we have the | ||
| 636 | * machine stopped | ||
| 637 | */ | ||
| 638 | __ftrace_update_code(NULL); | ||
| 639 | ftrace_replace_code(1); | 510 | ftrace_replace_code(1); |
| 640 | tracing_on = 1; | 511 | tracing_on = 1; |
| 641 | } else if (*command & FTRACE_DISABLE_CALLS) { | 512 | } else if (*command & FTRACE_DISABLE_CALLS) { |
| @@ -646,14 +517,6 @@ static int __ftrace_modify_code(void *data) | |||
| 646 | if (*command & FTRACE_UPDATE_TRACE_FUNC) | 517 | if (*command & FTRACE_UPDATE_TRACE_FUNC) |
| 647 | ftrace_update_ftrace_func(ftrace_trace_function); | 518 | ftrace_update_ftrace_func(ftrace_trace_function); |
| 648 | 519 | ||
| 649 | if (*command & FTRACE_ENABLE_MCOUNT) { | ||
| 650 | addr = (unsigned long)ftrace_record_ip; | ||
| 651 | ftrace_mcount_set(&addr); | ||
| 652 | } else if (*command & FTRACE_DISABLE_MCOUNT) { | ||
| 653 | addr = (unsigned long)ftrace_stub; | ||
| 654 | ftrace_mcount_set(&addr); | ||
| 655 | } | ||
| 656 | |||
| 657 | return 0; | 520 | return 0; |
| 658 | } | 521 | } |
| 659 | 522 | ||
| @@ -662,26 +525,9 @@ static void ftrace_run_update_code(int command) | |||
| 662 | stop_machine(__ftrace_modify_code, &command, NULL); | 525 | stop_machine(__ftrace_modify_code, &command, NULL); |
| 663 | } | 526 | } |
| 664 | 527 | ||
| 665 | void ftrace_disable_daemon(void) | ||
| 666 | { | ||
| 667 | /* Stop the daemon from calling kstop_machine */ | ||
| 668 | mutex_lock(&ftraced_lock); | ||
| 669 | ftraced_stop = 1; | ||
| 670 | mutex_unlock(&ftraced_lock); | ||
| 671 | |||
| 672 | ftrace_force_update(); | ||
| 673 | } | ||
| 674 | |||
| 675 | void ftrace_enable_daemon(void) | ||
| 676 | { | ||
| 677 | mutex_lock(&ftraced_lock); | ||
| 678 | ftraced_stop = 0; | ||
| 679 | mutex_unlock(&ftraced_lock); | ||
| 680 | |||
| 681 | ftrace_force_update(); | ||
| 682 | } | ||
| 683 | |||
| 684 | static ftrace_func_t saved_ftrace_func; | 528 | static ftrace_func_t saved_ftrace_func; |
| 529 | static int ftrace_start; | ||
| 530 | static DEFINE_MUTEX(ftrace_start_lock); | ||
| 685 | 531 | ||
| 686 | static void ftrace_startup(void) | 532 | static void ftrace_startup(void) |
| 687 | { | 533 | { |
| @@ -690,9 +536,9 @@ static void ftrace_startup(void) | |||
| 690 | if (unlikely(ftrace_disabled)) | 536 | if (unlikely(ftrace_disabled)) |
| 691 | return; | 537 | return; |
| 692 | 538 | ||
| 693 | mutex_lock(&ftraced_lock); | 539 | mutex_lock(&ftrace_start_lock); |
| 694 | ftraced_suspend++; | 540 | ftrace_start++; |
| 695 | if (ftraced_suspend == 1) | 541 | if (ftrace_start == 1) |
| 696 | command |= FTRACE_ENABLE_CALLS; | 542 | command |= FTRACE_ENABLE_CALLS; |
| 697 | 543 | ||
| 698 | if (saved_ftrace_func != ftrace_trace_function) { | 544 | if (saved_ftrace_func != ftrace_trace_function) { |
| @@ -705,7 +551,7 @@ static void ftrace_startup(void) | |||
| 705 | 551 | ||
| 706 | ftrace_run_update_code(command); | 552 | ftrace_run_update_code(command); |
| 707 | out: | 553 | out: |
| 708 | mutex_unlock(&ftraced_lock); | 554 | mutex_unlock(&ftrace_start_lock); |
| 709 | } | 555 | } |
| 710 | 556 | ||
| 711 | static void ftrace_shutdown(void) | 557 | static void ftrace_shutdown(void) |
| @@ -715,9 +561,9 @@ static void ftrace_shutdown(void) | |||
| 715 | if (unlikely(ftrace_disabled)) | 561 | if (unlikely(ftrace_disabled)) |
| 716 | return; | 562 | return; |
| 717 | 563 | ||
| 718 | mutex_lock(&ftraced_lock); | 564 | mutex_lock(&ftrace_start_lock); |
| 719 | ftraced_suspend--; | 565 | ftrace_start--; |
| 720 | if (!ftraced_suspend) | 566 | if (!ftrace_start) |
| 721 | command |= FTRACE_DISABLE_CALLS; | 567 | command |= FTRACE_DISABLE_CALLS; |
| 722 | 568 | ||
| 723 | if (saved_ftrace_func != ftrace_trace_function) { | 569 | if (saved_ftrace_func != ftrace_trace_function) { |
| @@ -730,7 +576,7 @@ static void ftrace_shutdown(void) | |||
| 730 | 576 | ||
| 731 | ftrace_run_update_code(command); | 577 | ftrace_run_update_code(command); |
| 732 | out: | 578 | out: |
| 733 | mutex_unlock(&ftraced_lock); | 579 | mutex_unlock(&ftrace_start_lock); |
| 734 | } | 580 | } |
| 735 | 581 | ||
| 736 | static void ftrace_startup_sysctl(void) | 582 | static void ftrace_startup_sysctl(void) |
| @@ -740,15 +586,15 @@ static void ftrace_startup_sysctl(void) | |||
| 740 | if (unlikely(ftrace_disabled)) | 586 | if (unlikely(ftrace_disabled)) |
| 741 | return; | 587 | return; |
| 742 | 588 | ||
| 743 | mutex_lock(&ftraced_lock); | 589 | mutex_lock(&ftrace_start_lock); |
| 744 | /* Force update next time */ | 590 | /* Force update next time */ |
| 745 | saved_ftrace_func = NULL; | 591 | saved_ftrace_func = NULL; |
| 746 | /* ftraced_suspend is true if we want ftrace running */ | 592 | /* ftrace_start is true if we want ftrace running */ |
| 747 | if (ftraced_suspend) | 593 | if (ftrace_start) |
| 748 | command |= FTRACE_ENABLE_CALLS; | 594 | command |= FTRACE_ENABLE_CALLS; |
| 749 | 595 | ||
| 750 | ftrace_run_update_code(command); | 596 | ftrace_run_update_code(command); |
| 751 | mutex_unlock(&ftraced_lock); | 597 | mutex_unlock(&ftrace_start_lock); |
| 752 | } | 598 | } |
| 753 | 599 | ||
| 754 | static void ftrace_shutdown_sysctl(void) | 600 | static void ftrace_shutdown_sysctl(void) |
| @@ -758,112 +604,50 @@ static void ftrace_shutdown_sysctl(void) | |||
| 758 | if (unlikely(ftrace_disabled)) | 604 | if (unlikely(ftrace_disabled)) |
| 759 | return; | 605 | return; |
| 760 | 606 | ||
| 761 | mutex_lock(&ftraced_lock); | 607 | mutex_lock(&ftrace_start_lock); |
| 762 | /* ftraced_suspend is true if ftrace is running */ | 608 | /* ftrace_start is true if ftrace is running */ |
| 763 | if (ftraced_suspend) | 609 | if (ftrace_start) |
| 764 | command |= FTRACE_DISABLE_CALLS; | 610 | command |= FTRACE_DISABLE_CALLS; |
| 765 | 611 | ||
| 766 | ftrace_run_update_code(command); | 612 | ftrace_run_update_code(command); |
| 767 | mutex_unlock(&ftraced_lock); | 613 | mutex_unlock(&ftrace_start_lock); |
| 768 | } | 614 | } |
| 769 | 615 | ||
| 770 | static cycle_t ftrace_update_time; | 616 | static cycle_t ftrace_update_time; |
| 771 | static unsigned long ftrace_update_cnt; | 617 | static unsigned long ftrace_update_cnt; |
| 772 | unsigned long ftrace_update_tot_cnt; | 618 | unsigned long ftrace_update_tot_cnt; |
| 773 | 619 | ||
| 774 | static int __ftrace_update_code(void *ignore) | 620 | static int ftrace_update_code(void) |
| 775 | { | 621 | { |
| 776 | int i, save_ftrace_enabled; | 622 | struct dyn_ftrace *p, *t; |
| 777 | cycle_t start, stop; | 623 | cycle_t start, stop; |
| 778 | struct dyn_ftrace *p; | ||
| 779 | struct hlist_node *t, *n; | ||
| 780 | struct hlist_head *head, temp_list; | ||
| 781 | |||
| 782 | /* Don't be recording funcs now */ | ||
| 783 | ftrace_record_suspend++; | ||
| 784 | save_ftrace_enabled = ftrace_enabled; | ||
| 785 | ftrace_enabled = 0; | ||
| 786 | 624 | ||
| 787 | start = ftrace_now(raw_smp_processor_id()); | 625 | start = ftrace_now(raw_smp_processor_id()); |
| 788 | ftrace_update_cnt = 0; | 626 | ftrace_update_cnt = 0; |
| 789 | 627 | ||
| 790 | /* No locks needed, the machine is stopped! */ | 628 | list_for_each_entry_safe(p, t, &ftrace_new_addrs, list) { |
| 791 | for (i = 0; i < FTRACE_HASHSIZE; i++) { | ||
| 792 | INIT_HLIST_HEAD(&temp_list); | ||
| 793 | head = &ftrace_hash[i]; | ||
| 794 | |||
| 795 | /* all CPUS are stopped, we are safe to modify code */ | ||
| 796 | hlist_for_each_entry_safe(p, t, n, head, node) { | ||
| 797 | /* Skip over failed records which have not been | ||
| 798 | * freed. */ | ||
| 799 | if (p->flags & FTRACE_FL_FAILED) | ||
| 800 | continue; | ||
| 801 | |||
| 802 | /* Unconverted records are always at the head of the | ||
| 803 | * hash bucket. Once we encounter a converted record, | ||
| 804 | * simply skip over to the next bucket. Saves ftraced | ||
| 805 | * some processor cycles (ftrace does its bid for | ||
| 806 | * global warming :-p ). */ | ||
| 807 | if (p->flags & (FTRACE_FL_CONVERTED)) | ||
| 808 | break; | ||
| 809 | 629 | ||
| 810 | /* Ignore updates to this record's mcount site. | 630 | /* If something went wrong, bail without enabling anything */ |
| 811 | * Reintroduce this record at the head of this | 631 | if (unlikely(ftrace_disabled)) |
| 812 | * bucket to attempt to "convert" it again if | 632 | return -1; |
| 813 | * the kprobe on it is unregistered before the | ||
| 814 | * next run. */ | ||
| 815 | if (get_kprobe((void *)p->ip)) { | ||
| 816 | ftrace_del_hash(p); | ||
| 817 | INIT_HLIST_NODE(&p->node); | ||
| 818 | hlist_add_head(&p->node, &temp_list); | ||
| 819 | freeze_record(p); | ||
| 820 | continue; | ||
| 821 | } else { | ||
| 822 | unfreeze_record(p); | ||
| 823 | } | ||
| 824 | 633 | ||
| 825 | /* convert record (i.e, patch mcount-call with NOP) */ | 634 | list_del_init(&p->list); |
| 826 | if (ftrace_code_disable(p)) { | ||
| 827 | p->flags |= FTRACE_FL_CONVERTED; | ||
| 828 | ftrace_update_cnt++; | ||
| 829 | } else { | ||
| 830 | if ((system_state == SYSTEM_BOOTING) || | ||
| 831 | !core_kernel_text(p->ip)) { | ||
| 832 | ftrace_del_hash(p); | ||
| 833 | ftrace_free_rec(p); | ||
| 834 | } | ||
| 835 | } | ||
| 836 | } | ||
| 837 | 635 | ||
| 838 | hlist_for_each_entry_safe(p, t, n, &temp_list, node) { | 636 | /* convert record (i.e, patch mcount-call with NOP) */ |
| 839 | hlist_del(&p->node); | 637 | if (ftrace_code_disable(p)) { |
| 840 | INIT_HLIST_NODE(&p->node); | 638 | p->flags |= FTRACE_FL_CONVERTED; |
| 841 | hlist_add_head(&p->node, head); | 639 | ftrace_update_cnt++; |
| 842 | } | 640 | } else |
| 641 | ftrace_free_rec(p); | ||
| 843 | } | 642 | } |
| 844 | 643 | ||
| 845 | stop = ftrace_now(raw_smp_processor_id()); | 644 | stop = ftrace_now(raw_smp_processor_id()); |
| 846 | ftrace_update_time = stop - start; | 645 | ftrace_update_time = stop - start; |
| 847 | ftrace_update_tot_cnt += ftrace_update_cnt; | 646 | ftrace_update_tot_cnt += ftrace_update_cnt; |
| 848 | ftraced_trigger = 0; | ||
| 849 | |||
| 850 | ftrace_enabled = save_ftrace_enabled; | ||
| 851 | ftrace_record_suspend--; | ||
| 852 | 647 | ||
| 853 | return 0; | 648 | return 0; |
| 854 | } | 649 | } |
| 855 | 650 | ||
| 856 | static int ftrace_update_code(void) | ||
| 857 | { | ||
| 858 | if (unlikely(ftrace_disabled) || | ||
| 859 | !ftrace_enabled || !ftraced_trigger) | ||
| 860 | return 0; | ||
| 861 | |||
| 862 | stop_machine(__ftrace_update_code, NULL, NULL); | ||
| 863 | |||
| 864 | return 1; | ||
| 865 | } | ||
| 866 | |||
| 867 | static int __init ftrace_dyn_table_alloc(unsigned long num_to_init) | 651 | static int __init ftrace_dyn_table_alloc(unsigned long num_to_init) |
| 868 | { | 652 | { |
| 869 | struct ftrace_page *pg; | 653 | struct ftrace_page *pg; |
| @@ -892,7 +676,7 @@ static int __init ftrace_dyn_table_alloc(unsigned long num_to_init) | |||
| 892 | pg = ftrace_pages = ftrace_pages_start; | 676 | pg = ftrace_pages = ftrace_pages_start; |
| 893 | 677 | ||
| 894 | cnt = num_to_init / ENTRIES_PER_PAGE; | 678 | cnt = num_to_init / ENTRIES_PER_PAGE; |
| 895 | pr_info("ftrace: allocating %ld hash entries in %d pages\n", | 679 | pr_info("ftrace: allocating %ld entries in %d pages\n", |
| 896 | num_to_init, cnt); | 680 | num_to_init, cnt); |
| 897 | 681 | ||
| 898 | for (i = 0; i < cnt; i++) { | 682 | for (i = 0; i < cnt; i++) { |
| @@ -1401,10 +1185,10 @@ ftrace_regex_release(struct inode *inode, struct file *file, int enable) | |||
| 1401 | } | 1185 | } |
| 1402 | 1186 | ||
| 1403 | mutex_lock(&ftrace_sysctl_lock); | 1187 | mutex_lock(&ftrace_sysctl_lock); |
| 1404 | mutex_lock(&ftraced_lock); | 1188 | mutex_lock(&ftrace_start_lock); |
| 1405 | if (iter->filtered && ftraced_suspend && ftrace_enabled) | 1189 | if (iter->filtered && ftrace_start && ftrace_enabled) |
| 1406 | ftrace_run_update_code(FTRACE_ENABLE_CALLS); | 1190 | ftrace_run_update_code(FTRACE_ENABLE_CALLS); |
| 1407 | mutex_unlock(&ftraced_lock); | 1191 | mutex_unlock(&ftrace_start_lock); |
| 1408 | mutex_unlock(&ftrace_sysctl_lock); | 1192 | mutex_unlock(&ftrace_sysctl_lock); |
| 1409 | 1193 | ||
| 1410 | kfree(iter); | 1194 | kfree(iter); |
| @@ -1424,55 +1208,6 @@ ftrace_notrace_release(struct inode *inode, struct file *file) | |||
| 1424 | return ftrace_regex_release(inode, file, 0); | 1208 | return ftrace_regex_release(inode, file, 0); |
| 1425 | } | 1209 | } |
| 1426 | 1210 | ||
| 1427 | static ssize_t | ||
| 1428 | ftraced_read(struct file *filp, char __user *ubuf, | ||
| 1429 | size_t cnt, loff_t *ppos) | ||
| 1430 | { | ||
| 1431 | /* don't worry about races */ | ||
| 1432 | char *buf = ftraced_stop ? "disabled\n" : "enabled\n"; | ||
| 1433 | int r = strlen(buf); | ||
| 1434 | |||
| 1435 | return simple_read_from_buffer(ubuf, cnt, ppos, buf, r); | ||
| 1436 | } | ||
| 1437 | |||
| 1438 | static ssize_t | ||
| 1439 | ftraced_write(struct file *filp, const char __user *ubuf, | ||
| 1440 | size_t cnt, loff_t *ppos) | ||
| 1441 | { | ||
| 1442 | char buf[64]; | ||
| 1443 | long val; | ||
| 1444 | int ret; | ||
| 1445 | |||
| 1446 | if (cnt >= sizeof(buf)) | ||
| 1447 | return -EINVAL; | ||
| 1448 | |||
| 1449 | if (copy_from_user(&buf, ubuf, cnt)) | ||
| 1450 | return -EFAULT; | ||
| 1451 | |||
| 1452 | if (strncmp(buf, "enable", 6) == 0) | ||
| 1453 | val = 1; | ||
| 1454 | else if (strncmp(buf, "disable", 7) == 0) | ||
| 1455 | val = 0; | ||
| 1456 | else { | ||
| 1457 | buf[cnt] = 0; | ||
| 1458 | |||
| 1459 | ret = strict_strtoul(buf, 10, &val); | ||
| 1460 | if (ret < 0) | ||
| 1461 | return ret; | ||
| 1462 | |||
| 1463 | val = !!val; | ||
| 1464 | } | ||
| 1465 | |||
| 1466 | if (val) | ||
| 1467 | ftrace_enable_daemon(); | ||
| 1468 | else | ||
| 1469 | ftrace_disable_daemon(); | ||
| 1470 | |||
| 1471 | filp->f_pos += cnt; | ||
| 1472 | |||
| 1473 | return cnt; | ||
| 1474 | } | ||
| 1475 | |||
| 1476 | static struct file_operations ftrace_avail_fops = { | 1211 | static struct file_operations ftrace_avail_fops = { |
| 1477 | .open = ftrace_avail_open, | 1212 | .open = ftrace_avail_open, |
| 1478 | .read = seq_read, | 1213 | .read = seq_read, |
| @@ -1503,54 +1238,6 @@ static struct file_operations ftrace_notrace_fops = { | |||
| 1503 | .release = ftrace_notrace_release, | 1238 | .release = ftrace_notrace_release, |
| 1504 | }; | 1239 | }; |
| 1505 | 1240 | ||
| 1506 | static struct file_operations ftraced_fops = { | ||
| 1507 | .open = tracing_open_generic, | ||
| 1508 | .read = ftraced_read, | ||
| 1509 | .write = ftraced_write, | ||
| 1510 | }; | ||
| 1511 | |||
| 1512 | /** | ||
| 1513 | * ftrace_force_update - force an update to all recording ftrace functions | ||
| 1514 | */ | ||
| 1515 | int ftrace_force_update(void) | ||
| 1516 | { | ||
| 1517 | int ret = 0; | ||
| 1518 | |||
| 1519 | if (unlikely(ftrace_disabled)) | ||
| 1520 | return -ENODEV; | ||
| 1521 | |||
| 1522 | mutex_lock(&ftrace_sysctl_lock); | ||
| 1523 | mutex_lock(&ftraced_lock); | ||
| 1524 | |||
| 1525 | /* | ||
| 1526 | * If ftraced_trigger is not set, then there is nothing | ||
| 1527 | * to update. | ||
| 1528 | */ | ||
| 1529 | if (ftraced_trigger && !ftrace_update_code()) | ||
| 1530 | ret = -EBUSY; | ||
| 1531 | |||
| 1532 | mutex_unlock(&ftraced_lock); | ||
| 1533 | mutex_unlock(&ftrace_sysctl_lock); | ||
| 1534 | |||
| 1535 | return ret; | ||
| 1536 | } | ||
| 1537 | |||
| 1538 | static void ftrace_force_shutdown(void) | ||
| 1539 | { | ||
| 1540 | struct task_struct *task; | ||
| 1541 | int command = FTRACE_DISABLE_CALLS | FTRACE_UPDATE_TRACE_FUNC; | ||
| 1542 | |||
| 1543 | mutex_lock(&ftraced_lock); | ||
| 1544 | task = ftraced_task; | ||
| 1545 | ftraced_task = NULL; | ||
| 1546 | ftraced_suspend = -1; | ||
| 1547 | ftrace_run_update_code(command); | ||
| 1548 | mutex_unlock(&ftraced_lock); | ||
| 1549 | |||
| 1550 | if (task) | ||
| 1551 | kthread_stop(task); | ||
| 1552 | } | ||
| 1553 | |||
| 1554 | static __init int ftrace_init_debugfs(void) | 1241 | static __init int ftrace_init_debugfs(void) |
| 1555 | { | 1242 | { |
| 1556 | struct dentry *d_tracer; | 1243 | struct dentry *d_tracer; |
| @@ -1581,17 +1268,11 @@ static __init int ftrace_init_debugfs(void) | |||
| 1581 | pr_warning("Could not create debugfs " | 1268 | pr_warning("Could not create debugfs " |
| 1582 | "'set_ftrace_notrace' entry\n"); | 1269 | "'set_ftrace_notrace' entry\n"); |
| 1583 | 1270 | ||
| 1584 | entry = debugfs_create_file("ftraced_enabled", 0644, d_tracer, | ||
| 1585 | NULL, &ftraced_fops); | ||
| 1586 | if (!entry) | ||
| 1587 | pr_warning("Could not create debugfs " | ||
| 1588 | "'ftraced_enabled' entry\n"); | ||
| 1589 | return 0; | 1271 | return 0; |
| 1590 | } | 1272 | } |
| 1591 | 1273 | ||
| 1592 | fs_initcall(ftrace_init_debugfs); | 1274 | fs_initcall(ftrace_init_debugfs); |
| 1593 | 1275 | ||
| 1594 | #ifdef CONFIG_FTRACE_MCOUNT_RECORD | ||
| 1595 | static int ftrace_convert_nops(unsigned long *start, | 1276 | static int ftrace_convert_nops(unsigned long *start, |
| 1596 | unsigned long *end) | 1277 | unsigned long *end) |
| 1597 | { | 1278 | { |
| @@ -1599,20 +1280,18 @@ static int ftrace_convert_nops(unsigned long *start, | |||
| 1599 | unsigned long addr; | 1280 | unsigned long addr; |
| 1600 | unsigned long flags; | 1281 | unsigned long flags; |
| 1601 | 1282 | ||
| 1283 | mutex_lock(&ftrace_start_lock); | ||
| 1602 | p = start; | 1284 | p = start; |
| 1603 | while (p < end) { | 1285 | while (p < end) { |
| 1604 | addr = ftrace_call_adjust(*p++); | 1286 | addr = ftrace_call_adjust(*p++); |
| 1605 | /* should not be called from interrupt context */ | ||
| 1606 | spin_lock(&ftrace_lock); | ||
| 1607 | ftrace_record_ip(addr); | 1287 | ftrace_record_ip(addr); |
| 1608 | spin_unlock(&ftrace_lock); | ||
| 1609 | ftrace_shutdown_replenish(); | ||
| 1610 | } | 1288 | } |
| 1611 | 1289 | ||
| 1612 | /* p is ignored */ | 1290 | /* disable interrupts to prevent kstop machine */ |
| 1613 | local_irq_save(flags); | 1291 | local_irq_save(flags); |
| 1614 | __ftrace_update_code(p); | 1292 | ftrace_update_code(); |
| 1615 | local_irq_restore(flags); | 1293 | local_irq_restore(flags); |
| 1294 | mutex_unlock(&ftrace_start_lock); | ||
| 1616 | 1295 | ||
| 1617 | return 0; | 1296 | return 0; |
| 1618 | } | 1297 | } |
| @@ -1658,130 +1337,26 @@ void __init ftrace_init(void) | |||
| 1658 | failed: | 1337 | failed: |
| 1659 | ftrace_disabled = 1; | 1338 | ftrace_disabled = 1; |
| 1660 | } | 1339 | } |
| 1661 | #else /* CONFIG_FTRACE_MCOUNT_RECORD */ | ||
| 1662 | static int ftraced(void *ignore) | ||
| 1663 | { | ||
| 1664 | unsigned long usecs; | ||
| 1665 | |||
| 1666 | while (!kthread_should_stop()) { | ||
| 1667 | |||
| 1668 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 1669 | |||
| 1670 | /* check once a second */ | ||
| 1671 | schedule_timeout(HZ); | ||
| 1672 | |||
| 1673 | if (unlikely(ftrace_disabled)) | ||
| 1674 | continue; | ||
| 1675 | |||
| 1676 | mutex_lock(&ftrace_sysctl_lock); | ||
| 1677 | mutex_lock(&ftraced_lock); | ||
| 1678 | if (!ftraced_suspend && !ftraced_stop && | ||
| 1679 | ftrace_update_code()) { | ||
| 1680 | usecs = nsecs_to_usecs(ftrace_update_time); | ||
| 1681 | if (ftrace_update_tot_cnt > 100000) { | ||
| 1682 | ftrace_update_tot_cnt = 0; | ||
| 1683 | pr_info("hm, dftrace overflow: %lu change%s" | ||
| 1684 | " (%lu total) in %lu usec%s\n", | ||
| 1685 | ftrace_update_cnt, | ||
| 1686 | ftrace_update_cnt != 1 ? "s" : "", | ||
| 1687 | ftrace_update_tot_cnt, | ||
| 1688 | usecs, usecs != 1 ? "s" : ""); | ||
| 1689 | ftrace_disabled = 1; | ||
| 1690 | WARN_ON_ONCE(1); | ||
| 1691 | } | ||
| 1692 | } | ||
| 1693 | mutex_unlock(&ftraced_lock); | ||
| 1694 | mutex_unlock(&ftrace_sysctl_lock); | ||
| 1695 | |||
| 1696 | ftrace_shutdown_replenish(); | ||
| 1697 | } | ||
| 1698 | __set_current_state(TASK_RUNNING); | ||
| 1699 | return 0; | ||
| 1700 | } | ||
| 1701 | |||
| 1702 | static int __init ftrace_dynamic_init(void) | ||
| 1703 | { | ||
| 1704 | struct task_struct *p; | ||
| 1705 | unsigned long addr; | ||
| 1706 | int ret; | ||
| 1707 | |||
| 1708 | addr = (unsigned long)ftrace_record_ip; | ||
| 1709 | |||
| 1710 | stop_machine(ftrace_dyn_arch_init, &addr, NULL); | ||
| 1711 | |||
| 1712 | /* ftrace_dyn_arch_init places the return code in addr */ | ||
| 1713 | if (addr) { | ||
| 1714 | ret = (int)addr; | ||
| 1715 | goto failed; | ||
| 1716 | } | ||
| 1717 | |||
| 1718 | ret = ftrace_dyn_table_alloc(NR_TO_INIT); | ||
| 1719 | if (ret) | ||
| 1720 | goto failed; | ||
| 1721 | |||
| 1722 | p = kthread_run(ftraced, NULL, "ftraced"); | ||
| 1723 | if (IS_ERR(p)) { | ||
| 1724 | ret = -1; | ||
| 1725 | goto failed; | ||
| 1726 | } | ||
| 1727 | |||
| 1728 | last_ftrace_enabled = ftrace_enabled = 1; | ||
| 1729 | ftraced_task = p; | ||
| 1730 | |||
| 1731 | return 0; | ||
| 1732 | |||
| 1733 | failed: | ||
| 1734 | ftrace_disabled = 1; | ||
| 1735 | return ret; | ||
| 1736 | } | ||
| 1737 | |||
| 1738 | core_initcall(ftrace_dynamic_init); | ||
| 1739 | #endif /* CONFIG_FTRACE_MCOUNT_RECORD */ | ||
| 1740 | 1340 | ||
| 1741 | #else | 1341 | #else |
| 1742 | # define ftrace_startup() do { } while (0) | 1342 | # define ftrace_startup() do { } while (0) |
| 1743 | # define ftrace_shutdown() do { } while (0) | 1343 | # define ftrace_shutdown() do { } while (0) |
| 1744 | # define ftrace_startup_sysctl() do { } while (0) | 1344 | # define ftrace_startup_sysctl() do { } while (0) |
| 1745 | # define ftrace_shutdown_sysctl() do { } while (0) | 1345 | # define ftrace_shutdown_sysctl() do { } while (0) |
| 1746 | # define ftrace_force_shutdown() do { } while (0) | ||
| 1747 | #endif /* CONFIG_DYNAMIC_FTRACE */ | 1346 | #endif /* CONFIG_DYNAMIC_FTRACE */ |
| 1748 | 1347 | ||
| 1749 | /** | 1348 | /** |
| 1750 | * ftrace_kill_atomic - kill ftrace from critical sections | 1349 | * ftrace_kill - kill ftrace |
| 1751 | * | 1350 | * |
| 1752 | * This function should be used by panic code. It stops ftrace | 1351 | * This function should be used by panic code. It stops ftrace |
| 1753 | * but in a not so nice way. If you need to simply kill ftrace | 1352 | * but in a not so nice way. If you need to simply kill ftrace |
| 1754 | * from a non-atomic section, use ftrace_kill. | 1353 | * from a non-atomic section, use ftrace_kill. |
| 1755 | */ | 1354 | */ |
| 1756 | void ftrace_kill_atomic(void) | ||
| 1757 | { | ||
| 1758 | ftrace_disabled = 1; | ||
| 1759 | ftrace_enabled = 0; | ||
| 1760 | #ifdef CONFIG_DYNAMIC_FTRACE | ||
| 1761 | ftraced_suspend = -1; | ||
| 1762 | #endif | ||
| 1763 | clear_ftrace_function(); | ||
| 1764 | } | ||
| 1765 | |||
| 1766 | /** | ||
| 1767 | * ftrace_kill - totally shutdown ftrace | ||
| 1768 | * | ||
| 1769 | * This is a safety measure. If something was detected that seems | ||
| 1770 | * wrong, calling this function will keep ftrace from doing | ||
| 1771 | * any more modifications, and updates. | ||
| 1772 | * used when something went wrong. | ||
| 1773 | */ | ||
| 1774 | void ftrace_kill(void) | 1355 | void ftrace_kill(void) |
| 1775 | { | 1356 | { |
| 1776 | mutex_lock(&ftrace_sysctl_lock); | ||
| 1777 | ftrace_disabled = 1; | 1357 | ftrace_disabled = 1; |
| 1778 | ftrace_enabled = 0; | 1358 | ftrace_enabled = 0; |
| 1779 | |||
| 1780 | clear_ftrace_function(); | 1359 | clear_ftrace_function(); |
| 1781 | mutex_unlock(&ftrace_sysctl_lock); | ||
| 1782 | |||
| 1783 | /* Try to totally disable ftrace */ | ||
| 1784 | ftrace_force_shutdown(); | ||
| 1785 | } | 1360 | } |
| 1786 | 1361 | ||
| 1787 | /** | 1362 | /** |
| @@ -1870,3 +1445,4 @@ ftrace_enable_sysctl(struct ctl_table *table, int write, | |||
| 1870 | mutex_unlock(&ftrace_sysctl_lock); | 1445 | mutex_unlock(&ftrace_sysctl_lock); |
| 1871 | return ret; | 1446 | return ret; |
| 1872 | } | 1447 | } |
| 1448 | |||
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 94af1fe56bb..cedf4e26828 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c | |||
| @@ -130,7 +130,7 @@ struct buffer_page { | |||
| 130 | static inline void free_buffer_page(struct buffer_page *bpage) | 130 | static inline void free_buffer_page(struct buffer_page *bpage) |
| 131 | { | 131 | { |
| 132 | if (bpage->page) | 132 | if (bpage->page) |
| 133 | __free_page(bpage->page); | 133 | free_page((unsigned long)bpage->page); |
| 134 | kfree(bpage); | 134 | kfree(bpage); |
| 135 | } | 135 | } |
| 136 | 136 | ||
| @@ -966,7 +966,9 @@ rb_add_time_stamp(struct ring_buffer_per_cpu *cpu_buffer, | |||
| 966 | if (unlikely(*delta > (1ULL << 59) && !once++)) { | 966 | if (unlikely(*delta > (1ULL << 59) && !once++)) { |
| 967 | printk(KERN_WARNING "Delta way too big! %llu" | 967 | printk(KERN_WARNING "Delta way too big! %llu" |
| 968 | " ts=%llu write stamp = %llu\n", | 968 | " ts=%llu write stamp = %llu\n", |
| 969 | *delta, *ts, cpu_buffer->write_stamp); | 969 | (unsigned long long)*delta, |
| 970 | (unsigned long long)*ts, | ||
| 971 | (unsigned long long)cpu_buffer->write_stamp); | ||
| 970 | WARN_ON(1); | 972 | WARN_ON(1); |
| 971 | } | 973 | } |
| 972 | 974 | ||
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d345d649d07..a610ca77155 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
| @@ -34,6 +34,7 @@ | |||
| 34 | 34 | ||
| 35 | #include <linux/stacktrace.h> | 35 | #include <linux/stacktrace.h> |
| 36 | #include <linux/ring_buffer.h> | 36 | #include <linux/ring_buffer.h> |
| 37 | #include <linux/irqflags.h> | ||
| 37 | 38 | ||
| 38 | #include "trace.h" | 39 | #include "trace.h" |
| 39 | 40 | ||
| @@ -851,7 +852,7 @@ ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) | |||
| 851 | preempt_enable_notrace(); | 852 | preempt_enable_notrace(); |
| 852 | } | 853 | } |
| 853 | 854 | ||
| 854 | #ifdef CONFIG_FTRACE | 855 | #ifdef CONFIG_FUNCTION_TRACER |
| 855 | static void | 856 | static void |
| 856 | function_trace_call(unsigned long ip, unsigned long parent_ip) | 857 | function_trace_call(unsigned long ip, unsigned long parent_ip) |
| 857 | { | 858 | { |
| @@ -865,9 +866,6 @@ function_trace_call(unsigned long ip, unsigned long parent_ip) | |||
| 865 | if (unlikely(!ftrace_function_enabled)) | 866 | if (unlikely(!ftrace_function_enabled)) |
| 866 | return; | 867 | return; |
| 867 | 868 | ||
| 868 | if (skip_trace(ip)) | ||
| 869 | return; | ||
| 870 | |||
| 871 | pc = preempt_count(); | 869 | pc = preempt_count(); |
| 872 | resched = need_resched(); | 870 | resched = need_resched(); |
| 873 | preempt_disable_notrace(); | 871 | preempt_disable_notrace(); |
| @@ -2379,9 +2377,10 @@ tracing_set_trace_write(struct file *filp, const char __user *ubuf, | |||
| 2379 | int i; | 2377 | int i; |
| 2380 | size_t ret; | 2378 | size_t ret; |
| 2381 | 2379 | ||
| 2380 | ret = cnt; | ||
| 2381 | |||
| 2382 | if (cnt > max_tracer_type_len) | 2382 | if (cnt > max_tracer_type_len) |
| 2383 | cnt = max_tracer_type_len; | 2383 | cnt = max_tracer_type_len; |
| 2384 | ret = cnt; | ||
| 2385 | 2384 | ||
| 2386 | if (copy_from_user(&buf, ubuf, cnt)) | 2385 | if (copy_from_user(&buf, ubuf, cnt)) |
| 2387 | return -EFAULT; | 2386 | return -EFAULT; |
| @@ -2414,8 +2413,8 @@ tracing_set_trace_write(struct file *filp, const char __user *ubuf, | |||
| 2414 | out: | 2413 | out: |
| 2415 | mutex_unlock(&trace_types_lock); | 2414 | mutex_unlock(&trace_types_lock); |
| 2416 | 2415 | ||
| 2417 | if (ret == cnt) | 2416 | if (ret > 0) |
| 2418 | filp->f_pos += cnt; | 2417 | filp->f_pos += ret; |
| 2419 | 2418 | ||
| 2420 | return ret; | 2419 | return ret; |
| 2421 | } | 2420 | } |
| @@ -3097,7 +3096,7 @@ void ftrace_dump(void) | |||
| 3097 | dump_ran = 1; | 3096 | dump_ran = 1; |
| 3098 | 3097 | ||
| 3099 | /* No turning back! */ | 3098 | /* No turning back! */ |
| 3100 | ftrace_kill_atomic(); | 3099 | ftrace_kill(); |
| 3101 | 3100 | ||
| 3102 | for_each_tracing_cpu(cpu) { | 3101 | for_each_tracing_cpu(cpu) { |
| 3103 | atomic_inc(&global_trace.data[cpu]->disabled); | 3102 | atomic_inc(&global_trace.data[cpu]->disabled); |
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index f1f99572cde..6889ca48f1f 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h | |||
| @@ -335,7 +335,7 @@ void update_max_tr_single(struct trace_array *tr, | |||
| 335 | 335 | ||
| 336 | extern cycle_t ftrace_now(int cpu); | 336 | extern cycle_t ftrace_now(int cpu); |
| 337 | 337 | ||
| 338 | #ifdef CONFIG_FTRACE | 338 | #ifdef CONFIG_FUNCTION_TRACER |
| 339 | void tracing_start_function_trace(void); | 339 | void tracing_start_function_trace(void); |
| 340 | void tracing_stop_function_trace(void); | 340 | void tracing_stop_function_trace(void); |
| 341 | #else | 341 | #else |
diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c index e90eb0c2c56..0f85a64003d 100644 --- a/kernel/trace/trace_functions.c +++ b/kernel/trace/trace_functions.c | |||
| @@ -64,7 +64,7 @@ static void function_trace_ctrl_update(struct trace_array *tr) | |||
| 64 | 64 | ||
| 65 | static struct tracer function_trace __read_mostly = | 65 | static struct tracer function_trace __read_mostly = |
| 66 | { | 66 | { |
| 67 | .name = "ftrace", | 67 | .name = "function", |
| 68 | .init = function_trace_init, | 68 | .init = function_trace_init, |
| 69 | .reset = function_trace_reset, | 69 | .reset = function_trace_reset, |
| 70 | .ctrl_update = function_trace_ctrl_update, | 70 | .ctrl_update = function_trace_ctrl_update, |
diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c index a7db7f040ae..9c74071c10e 100644 --- a/kernel/trace/trace_irqsoff.c +++ b/kernel/trace/trace_irqsoff.c | |||
| @@ -63,7 +63,7 @@ irq_trace(void) | |||
| 63 | */ | 63 | */ |
| 64 | static __cacheline_aligned_in_smp unsigned long max_sequence; | 64 | static __cacheline_aligned_in_smp unsigned long max_sequence; |
| 65 | 65 | ||
| 66 | #ifdef CONFIG_FTRACE | 66 | #ifdef CONFIG_FUNCTION_TRACER |
| 67 | /* | 67 | /* |
| 68 | * irqsoff uses its own tracer function to keep the overhead down: | 68 | * irqsoff uses its own tracer function to keep the overhead down: |
| 69 | */ | 69 | */ |
| @@ -104,7 +104,7 @@ static struct ftrace_ops trace_ops __read_mostly = | |||
| 104 | { | 104 | { |
| 105 | .func = irqsoff_tracer_call, | 105 | .func = irqsoff_tracer_call, |
| 106 | }; | 106 | }; |
| 107 | #endif /* CONFIG_FTRACE */ | 107 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 108 | 108 | ||
| 109 | /* | 109 | /* |
| 110 | * Should this new latency be reported/recorded? | 110 | * Should this new latency be reported/recorded? |
diff --git a/kernel/trace/trace_sched_wakeup.c b/kernel/trace/trace_sched_wakeup.c index fe4a252c236..3ae93f16b56 100644 --- a/kernel/trace/trace_sched_wakeup.c +++ b/kernel/trace/trace_sched_wakeup.c | |||
| @@ -31,7 +31,7 @@ static raw_spinlock_t wakeup_lock = | |||
| 31 | 31 | ||
| 32 | static void __wakeup_reset(struct trace_array *tr); | 32 | static void __wakeup_reset(struct trace_array *tr); |
| 33 | 33 | ||
| 34 | #ifdef CONFIG_FTRACE | 34 | #ifdef CONFIG_FUNCTION_TRACER |
| 35 | /* | 35 | /* |
| 36 | * irqsoff uses its own tracer function to keep the overhead down: | 36 | * irqsoff uses its own tracer function to keep the overhead down: |
| 37 | */ | 37 | */ |
| @@ -96,7 +96,7 @@ static struct ftrace_ops trace_ops __read_mostly = | |||
| 96 | { | 96 | { |
| 97 | .func = wakeup_tracer_call, | 97 | .func = wakeup_tracer_call, |
| 98 | }; | 98 | }; |
| 99 | #endif /* CONFIG_FTRACE */ | 99 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 100 | 100 | ||
| 101 | /* | 101 | /* |
| 102 | * Should this new latency be reported/recorded? | 102 | * Should this new latency be reported/recorded? |
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index 09cf230d7ec..90bc752a758 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c | |||
| @@ -70,7 +70,7 @@ static int trace_test_buffer(struct trace_array *tr, unsigned long *count) | |||
| 70 | return ret; | 70 | return ret; |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | #ifdef CONFIG_FTRACE | 73 | #ifdef CONFIG_FUNCTION_TRACER |
| 74 | 74 | ||
| 75 | #ifdef CONFIG_DYNAMIC_FTRACE | 75 | #ifdef CONFIG_DYNAMIC_FTRACE |
| 76 | 76 | ||
| @@ -99,13 +99,6 @@ int trace_selftest_startup_dynamic_tracing(struct tracer *trace, | |||
| 99 | /* passed in by parameter to fool gcc from optimizing */ | 99 | /* passed in by parameter to fool gcc from optimizing */ |
| 100 | func(); | 100 | func(); |
| 101 | 101 | ||
| 102 | /* update the records */ | ||
| 103 | ret = ftrace_force_update(); | ||
| 104 | if (ret) { | ||
| 105 | printk(KERN_CONT ".. ftraced failed .. "); | ||
| 106 | return ret; | ||
| 107 | } | ||
| 108 | |||
| 109 | /* | 102 | /* |
| 110 | * Some archs *cough*PowerPC*cough* add charachters to the | 103 | * Some archs *cough*PowerPC*cough* add charachters to the |
| 111 | * start of the function names. We simply put a '*' to | 104 | * start of the function names. We simply put a '*' to |
| @@ -183,13 +176,6 @@ trace_selftest_startup_function(struct tracer *trace, struct trace_array *tr) | |||
| 183 | /* make sure msleep has been recorded */ | 176 | /* make sure msleep has been recorded */ |
| 184 | msleep(1); | 177 | msleep(1); |
| 185 | 178 | ||
| 186 | /* force the recorded functions to be traced */ | ||
| 187 | ret = ftrace_force_update(); | ||
| 188 | if (ret) { | ||
| 189 | printk(KERN_CONT ".. ftraced failed .. "); | ||
| 190 | return ret; | ||
| 191 | } | ||
| 192 | |||
| 193 | /* start the tracing */ | 179 | /* start the tracing */ |
| 194 | ftrace_enabled = 1; | 180 | ftrace_enabled = 1; |
| 195 | tracer_enabled = 1; | 181 | tracer_enabled = 1; |
| @@ -226,7 +212,7 @@ trace_selftest_startup_function(struct tracer *trace, struct trace_array *tr) | |||
| 226 | 212 | ||
| 227 | return ret; | 213 | return ret; |
| 228 | } | 214 | } |
| 229 | #endif /* CONFIG_FTRACE */ | 215 | #endif /* CONFIG_FUNCTION_TRACER */ |
| 230 | 216 | ||
| 231 | #ifdef CONFIG_IRQSOFF_TRACER | 217 | #ifdef CONFIG_IRQSOFF_TRACER |
| 232 | int | 218 | int |
diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c index 74c5d9a3afa..be682b62fe5 100644 --- a/kernel/trace/trace_stack.c +++ b/kernel/trace/trace_stack.c | |||
| @@ -44,6 +44,10 @@ static inline void check_stack(void) | |||
| 44 | if (this_size <= max_stack_size) | 44 | if (this_size <= max_stack_size) |
| 45 | return; | 45 | return; |
| 46 | 46 | ||
| 47 | /* we do not handle interrupt stacks yet */ | ||
| 48 | if (!object_is_on_stack(&this_size)) | ||
| 49 | return; | ||
| 50 | |||
| 47 | raw_local_irq_save(flags); | 51 | raw_local_irq_save(flags); |
| 48 | __raw_spin_lock(&max_stack_lock); | 52 | __raw_spin_lock(&max_stack_lock); |
| 49 | 53 | ||
diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index f2b7c28a470..af8c8566488 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c | |||
| @@ -131,6 +131,9 @@ tracepoint_entry_remove_probe(struct tracepoint_entry *entry, void *probe) | |||
| 131 | 131 | ||
| 132 | old = entry->funcs; | 132 | old = entry->funcs; |
| 133 | 133 | ||
| 134 | if (!old) | ||
| 135 | return NULL; | ||
| 136 | |||
| 134 | debug_print_probes(entry); | 137 | debug_print_probes(entry); |
| 135 | /* (N -> M), (N > 1, M >= 0) probes */ | 138 | /* (N -> M), (N > 1, M >= 0) probes */ |
| 136 | for (nr_probes = 0; old[nr_probes]; nr_probes++) { | 139 | for (nr_probes = 0; old[nr_probes]; nr_probes++) { |
| @@ -388,6 +391,11 @@ int tracepoint_probe_unregister(const char *name, void *probe) | |||
| 388 | if (entry->rcu_pending) | 391 | if (entry->rcu_pending) |
| 389 | rcu_barrier_sched(); | 392 | rcu_barrier_sched(); |
| 390 | old = tracepoint_entry_remove_probe(entry, probe); | 393 | old = tracepoint_entry_remove_probe(entry, probe); |
| 394 | if (!old) { | ||
| 395 | printk(KERN_WARNING "Warning: Trying to unregister a probe" | ||
| 396 | "that doesn't exist\n"); | ||
| 397 | goto end; | ||
| 398 | } | ||
| 391 | mutex_unlock(&tracepoints_mutex); | 399 | mutex_unlock(&tracepoints_mutex); |
| 392 | tracepoint_update_probes(); /* may update entry */ | 400 | tracepoint_update_probes(); /* may update entry */ |
| 393 | mutex_lock(&tracepoints_mutex); | 401 | mutex_lock(&tracepoints_mutex); |
diff --git a/lib/Makefile b/lib/Makefile index 16feaab057b..7cb65d85aeb 100644 --- a/lib/Makefile +++ b/lib/Makefile | |||
| @@ -2,7 +2,7 @@ | |||
| 2 | # Makefile for some libs needed in the kernel. | 2 | # Makefile for some libs needed in the kernel. |
| 3 | # | 3 | # |
| 4 | 4 | ||
| 5 | ifdef CONFIG_FTRACE | 5 | ifdef CONFIG_FUNCTION_TRACER |
| 6 | ORIG_CFLAGS := $(KBUILD_CFLAGS) | 6 | ORIG_CFLAGS := $(KBUILD_CFLAGS) |
| 7 | KBUILD_CFLAGS = $(subst -pg,,$(ORIG_CFLAGS)) | 7 | KBUILD_CFLAGS = $(subst -pg,,$(ORIG_CFLAGS)) |
| 8 | endif | 8 | endif |
diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 5ed4cbf1e0e..468fbc9016c 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build | |||
| @@ -198,10 +198,16 @@ cmd_modversions = \ | |||
| 198 | fi; | 198 | fi; |
| 199 | endif | 199 | endif |
| 200 | 200 | ||
| 201 | ifdef CONFIG_64BIT | ||
| 202 | arch_bits = 64 | ||
| 203 | else | ||
| 204 | arch_bits = 32 | ||
| 205 | endif | ||
| 206 | |||
| 201 | ifdef CONFIG_FTRACE_MCOUNT_RECORD | 207 | ifdef CONFIG_FTRACE_MCOUNT_RECORD |
| 202 | cmd_record_mcount = perl $(srctree)/scripts/recordmcount.pl \ | 208 | cmd_record_mcount = perl $(srctree)/scripts/recordmcount.pl \ |
| 203 | "$(ARCH)" "$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" "$(NM)" "$(RM)" \ | 209 | "$(ARCH)" "$(arch_bits)" "$(OBJDUMP)" "$(OBJCOPY)" "$(CC)" "$(LD)" \ |
| 204 | "$(MV)" "$(@)"; | 210 | "$(NM)" "$(RM)" "$(MV)" "$(@)"; |
| 205 | endif | 211 | endif |
| 206 | 212 | ||
| 207 | define rule_cc_o_c | 213 | define rule_cc_o_c |
diff --git a/scripts/bootgraph.pl b/scripts/bootgraph.pl index 5e7316e5aa3..d2c61efc216 100644 --- a/scripts/bootgraph.pl +++ b/scripts/bootgraph.pl | |||
| @@ -37,7 +37,10 @@ | |||
| 37 | # dmesg | perl scripts/bootgraph.pl > output.svg | 37 | # dmesg | perl scripts/bootgraph.pl > output.svg |
| 38 | # | 38 | # |
| 39 | 39 | ||
| 40 | my %start, %end; | 40 | use strict; |
| 41 | |||
| 42 | my %start; | ||
| 43 | my %end; | ||
| 41 | my $done = 0; | 44 | my $done = 0; |
| 42 | my $maxtime = 0; | 45 | my $maxtime = 0; |
| 43 | my $firsttime = 100; | 46 | my $firsttime = 100; |
| @@ -105,18 +108,20 @@ my $threshold = ($maxtime - $firsttime) / 60.0; | |||
| 105 | my $stylecounter = 0; | 108 | my $stylecounter = 0; |
| 106 | my %rows; | 109 | my %rows; |
| 107 | my $rowscount = 1; | 110 | my $rowscount = 1; |
| 108 | while (($key,$value) = each %start) { | 111 | my @initcalls = sort { $start{$a} <=> $start{$b} } keys(%start); |
| 112 | my $key; | ||
| 113 | foreach $key (@initcalls) { | ||
| 109 | my $duration = $end{$key} - $start{$key}; | 114 | my $duration = $end{$key} - $start{$key}; |
| 110 | 115 | ||
| 111 | if ($duration >= $threshold) { | 116 | if ($duration >= $threshold) { |
| 112 | my $s, $s2, $e, $y; | 117 | my ($s, $s2, $e, $w, $y, $y2, $style); |
| 113 | $pid = $pids{$key}; | 118 | my $pid = $pids{$key}; |
| 114 | 119 | ||
| 115 | if (!defined($rows{$pid})) { | 120 | if (!defined($rows{$pid})) { |
| 116 | $rows{$pid} = $rowscount; | 121 | $rows{$pid} = $rowscount; |
| 117 | $rowscount = $rowscount + 1; | 122 | $rowscount = $rowscount + 1; |
| 118 | } | 123 | } |
| 119 | $s = ($value - $firsttime) * $mult; | 124 | $s = ($start{$key} - $firsttime) * $mult; |
| 120 | $s2 = $s + 6; | 125 | $s2 = $s + 6; |
| 121 | $e = ($end{$key} - $firsttime) * $mult; | 126 | $e = ($end{$key} - $firsttime) * $mult; |
| 122 | $w = $e - $s; | 127 | $w = $e - $s; |
| @@ -140,9 +145,9 @@ while (($key,$value) = each %start) { | |||
| 140 | my $time = $firsttime; | 145 | my $time = $firsttime; |
| 141 | my $step = ($maxtime - $firsttime) / 15; | 146 | my $step = ($maxtime - $firsttime) / 15; |
| 142 | while ($time < $maxtime) { | 147 | while ($time < $maxtime) { |
| 143 | my $s2 = ($time - $firsttime) * $mult; | 148 | my $s3 = ($time - $firsttime) * $mult; |
| 144 | my $tm = int($time * 100) / 100.0; | 149 | my $tm = int($time * 100) / 100.0; |
| 145 | print "<text transform=\"translate($s2,89) rotate(90)\">$tm</text>\n"; | 150 | print "<text transform=\"translate($s3,89) rotate(90)\">$tm</text>\n"; |
| 146 | $time = $time + $step; | 151 | $time = $time + $step; |
| 147 | } | 152 | } |
| 148 | 153 | ||
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index f56d760bd58..6b9fe3eb836 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl | |||
| @@ -106,7 +106,13 @@ if ($#ARGV < 6) { | |||
| 106 | exit(1); | 106 | exit(1); |
| 107 | } | 107 | } |
| 108 | 108 | ||
| 109 | my ($arch, $objdump, $objcopy, $cc, $ld, $nm, $rm, $mv, $inputfile) = @ARGV; | 109 | my ($arch, $bits, $objdump, $objcopy, $cc, |
| 110 | $ld, $nm, $rm, $mv, $inputfile) = @ARGV; | ||
| 111 | |||
| 112 | # Acceptable sections to record. | ||
| 113 | my %text_sections = ( | ||
| 114 | ".text" => 1, | ||
| 115 | ); | ||
| 110 | 116 | ||
| 111 | $objdump = "objdump" if ((length $objdump) == 0); | 117 | $objdump = "objdump" if ((length $objdump) == 0); |
| 112 | $objcopy = "objcopy" if ((length $objcopy) == 0); | 118 | $objcopy = "objcopy" if ((length $objcopy) == 0); |
| @@ -129,8 +135,16 @@ my $function_regex; # Find the name of a function | |||
| 129 | # (return offset and func name) | 135 | # (return offset and func name) |
| 130 | my $mcount_regex; # Find the call site to mcount (return offset) | 136 | my $mcount_regex; # Find the call site to mcount (return offset) |
| 131 | 137 | ||
| 138 | if ($arch eq "x86") { | ||
| 139 | if ($bits == 64) { | ||
| 140 | $arch = "x86_64"; | ||
| 141 | } else { | ||
| 142 | $arch = "i386"; | ||
| 143 | } | ||
| 144 | } | ||
| 145 | |||
| 132 | if ($arch eq "x86_64") { | 146 | if ($arch eq "x86_64") { |
| 133 | $section_regex = "Disassembly of section"; | 147 | $section_regex = "Disassembly of section\\s+(\\S+):"; |
| 134 | $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:"; | 148 | $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:"; |
| 135 | $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount([+-]0x[0-9a-zA-Z]+)?\$"; | 149 | $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount([+-]0x[0-9a-zA-Z]+)?\$"; |
| 136 | $type = ".quad"; | 150 | $type = ".quad"; |
| @@ -142,7 +156,7 @@ if ($arch eq "x86_64") { | |||
| 142 | $cc .= " -m64"; | 156 | $cc .= " -m64"; |
| 143 | 157 | ||
| 144 | } elsif ($arch eq "i386") { | 158 | } elsif ($arch eq "i386") { |
| 145 | $section_regex = "Disassembly of section"; | 159 | $section_regex = "Disassembly of section\\s+(\\S+):"; |
| 146 | $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:"; | 160 | $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:"; |
| 147 | $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount\$"; | 161 | $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount\$"; |
| 148 | $type = ".long"; | 162 | $type = ".long"; |
| @@ -289,7 +303,13 @@ my $text; | |||
| 289 | while (<IN>) { | 303 | while (<IN>) { |
| 290 | # is it a section? | 304 | # is it a section? |
| 291 | if (/$section_regex/) { | 305 | if (/$section_regex/) { |
| 292 | $read_function = 1; | 306 | |
| 307 | # Only record text sections that we know are safe | ||
| 308 | if (defined($text_sections{$1})) { | ||
| 309 | $read_function = 1; | ||
| 310 | } else { | ||
| 311 | $read_function = 0; | ||
| 312 | } | ||
| 293 | # print out any recorded offsets | 313 | # print out any recorded offsets |
| 294 | update_funcs() if ($text_found); | 314 | update_funcs() if ($text_found); |
| 295 | 315 | ||
