4 files changed, 5 insertions, 7 deletions

diff --git a/drivers/infiniband/core/ucm.c b/drivers/infiniband/core/ucm.c
index 08f948df8fa..b8a0b4a7811 100644
--- a/drivers/infiniband/core/ucm.c
+++ b/drivers/infiniband/core/ucm.c
@@ -1122,7 +1122,7 @@ static ssize_t ib_ucm_write(struct file *filp, const char __user *buf,
         if (copy_from_user(&hdr, buf, sizeof(hdr)))
                 return -EFAULT;
 
-        if (hdr.cmd < 0 || hdr.cmd >= ARRAY_SIZE(ucm_cmd_table))
+        if (hdr.cmd >= ARRAY_SIZE(ucm_cmd_table))
                 return -EINVAL;
 
         if (hdr.in + sizeof(hdr) > len)
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 71be5eebd68..b3f3dddd528 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1270,7 +1270,7 @@ static ssize_t ucma_write(struct file *filp, const char __user *buf,
         if (copy_from_user(&hdr, buf, sizeof(hdr)))
                 return -EFAULT;
 
-        if (hdr.cmd < 0 || hdr.cmd >= ARRAY_SIZE(ucma_cmd_table))
+        if (hdr.cmd >= ARRAY_SIZE(ucma_cmd_table))
                 return -EINVAL;
 
         if (hdr.in + sizeof(hdr) > len)
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
index 8d261b6ea5f..07db22997e9 100644
--- a/drivers/infiniband/core/user_mad.c
+++ b/drivers/infiniband/core/user_mad.c
@@ -458,8 +458,7 @@ static ssize_t ib_umad_write(struct file *filp, const char __user *buf,
                 goto err;
         }
 
-        if (packet->mad.hdr.id < 0 ||
-            packet->mad.hdr.id >= IB_UMAD_MAX_AGENTS) {
+        if (packet->mad.hdr.id >= IB_UMAD_MAX_AGENTS) {
                 ret = -EINVAL;
                 goto err;
         }
@@ -703,7 +702,7 @@ static int ib_umad_unreg_agent(struct ib_umad_file *file, u32 __user *arg)
         mutex_lock(&file->port->file_mutex);
         mutex_lock(&file->mutex);
 
-        if (id < 0 || id >= IB_UMAD_MAX_AGENTS || !__get_agent(file, id)) {
+        if (id >= IB_UMAD_MAX_AGENTS || !__get_agent(file, id)) {
                 ret = -EINVAL;
                 goto out;
         }
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c
index 56898b6578a..7c30e1e12c9 100644
--- a/drivers/infiniband/core/uverbs_main.c
+++ b/drivers/infiniband/core/uverbs_main.c
@@ -557,8 +557,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf,
         if (hdr.in_words * 4 != count)
                 return -EINVAL;
 
-        if (hdr.command < 0                             ||
-            hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||
+        if (hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||
             !uverbs_cmd_table[hdr.command])
                 return -EINVAL;