diff options
| -rw-r--r-- | drivers/staging/fwserial/TODO | 3 | ||||
| -rw-r--r-- | drivers/staging/fwserial/fwserial.c | 2 | ||||
| -rw-r--r-- | drivers/staging/fwserial/fwserial.h | 6 |
3 files changed, 4 insertions, 7 deletions
diff --git a/drivers/staging/fwserial/TODO b/drivers/staging/fwserial/TODO index 726900548ea..ffe47d1d8c1 100644 --- a/drivers/staging/fwserial/TODO +++ b/drivers/staging/fwserial/TODO | |||
| @@ -12,9 +12,6 @@ TODOs | |||
| 12 | 1. This driver uses the same unregistered vendor id that the firewire core does | 12 | 1. This driver uses the same unregistered vendor id that the firewire core does |
| 13 | (0xd00d1e). Perhaps this could be exposed as a define in | 13 | (0xd00d1e). Perhaps this could be exposed as a define in |
| 14 | firewire-constants.h? | 14 | firewire-constants.h? |
| 15 | 2. MAX_ASYNC_PAYLOAD needs to be publicly exposed by core/ohci | ||
| 16 | - otherwise how will this driver know the max size of address window to | ||
| 17 | open for one packet write? | ||
| 18 | 3. Maybe device_max_receive() and link_speed_to_max_payload() should be | 15 | 3. Maybe device_max_receive() and link_speed_to_max_payload() should be |
| 19 | taken up by the firewire core? | 16 | taken up by the firewire core? |
| 20 | 4. To avoid dropping rx data while still limiting the maximum buffering, | 17 | 4. To avoid dropping rx data while still limiting the maximum buffering, |
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index 61ee29083b2..d03a7f57e8d 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c | |||
| @@ -179,7 +179,7 @@ static void dump_profile(struct seq_file *m, struct stats *stats) | |||
| 179 | /* Returns the max receive packet size for the given card */ | 179 | /* Returns the max receive packet size for the given card */ |
| 180 | static inline int device_max_receive(struct fw_device *fw_device) | 180 | static inline int device_max_receive(struct fw_device *fw_device) |
| 181 | { | 181 | { |
| 182 | return 1 << (clamp_t(int, fw_device->max_rec, 8U, 13U) + 1); | 182 | return 1 << (clamp_t(int, fw_device->max_rec, 8U, 11U) + 1); |
| 183 | } | 183 | } |
| 184 | 184 | ||
| 185 | static void fwtty_log_tx_error(struct fwtty_port *port, int rcode) | 185 | static void fwtty_log_tx_error(struct fwtty_port *port, int rcode) |
diff --git a/drivers/staging/fwserial/fwserial.h b/drivers/staging/fwserial/fwserial.h index 8b572edf956..caa1c1ea82d 100644 --- a/drivers/staging/fwserial/fwserial.h +++ b/drivers/staging/fwserial/fwserial.h | |||
| @@ -374,10 +374,10 @@ static inline void fwtty_bind_console(struct fwtty_port *port, | |||
| 374 | */ | 374 | */ |
| 375 | static inline int link_speed_to_max_payload(unsigned speed) | 375 | static inline int link_speed_to_max_payload(unsigned speed) |
| 376 | { | 376 | { |
| 377 | static const int max_async[] = { 307, 614, 1229, 2458, 4916, 9832, }; | 377 | static const int max_async[] = { 307, 614, 1229, 2458, }; |
| 378 | BUILD_BUG_ON(ARRAY_SIZE(max_async) - 1 != SCODE_3200); | 378 | BUILD_BUG_ON(ARRAY_SIZE(max_async) - 1 != SCODE_800); |
| 379 | 379 | ||
| 380 | speed = clamp(speed, (unsigned) SCODE_100, (unsigned) SCODE_3200); | 380 | speed = clamp(speed, (unsigned) SCODE_100, (unsigned) SCODE_800); |
| 381 | if (limit_bw) | 381 | if (limit_bw) |
| 382 | return max_async[speed]; | 382 | return max_async[speed]; |
| 383 | else | 383 | else |
