diff options
author | David Ahern <dsahern@gmail.com> | 2012-10-08 13:17:35 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-08 16:14:13 -0400 |
commit | 2aa8eab029b319b2b458b3ba393bbba31961ea96 (patch) | |
tree | 2ce824590e3f11997ddc1989cfe8884961b3d37b /tools/perf | |
parent | ae86912f48b624540b886187e169bcf47a14e42a (diff) |
perf kvm: Only process events for vcpus of interest
Minimizing processing overhead for each sample - which becomes important
for the upcoming live mode when it has to deal with 100+k events per
second.
Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Dong Hao <haodong@linux.vnet.ibm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1349716656-48165-12-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r-- | tools/perf/builtin-kvm.c | 18 |
1 files changed, 16 insertions, 2 deletions
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index 260abc535b5..b98095edf1f 100644 --- a/tools/perf/builtin-kvm.c +++ b/tools/perf/builtin-kvm.c | |||
@@ -416,7 +416,10 @@ static double kvm_event_rel_stddev(int vcpu_id, struct kvm_event *event) | |||
416 | static bool update_kvm_event(struct kvm_event *event, int vcpu_id, | 416 | static bool update_kvm_event(struct kvm_event *event, int vcpu_id, |
417 | u64 time_diff) | 417 | u64 time_diff) |
418 | { | 418 | { |
419 | kvm_update_event_stats(&event->total, time_diff); | 419 | if (vcpu_id == -1) { |
420 | kvm_update_event_stats(&event->total, time_diff); | ||
421 | return true; | ||
422 | } | ||
420 | 423 | ||
421 | if (!kvm_event_expand(event, vcpu_id)) | 424 | if (!kvm_event_expand(event, vcpu_id)) |
422 | return false; | 425 | return false; |
@@ -432,6 +435,12 @@ static bool handle_end_event(struct perf_kvm *kvm, | |||
432 | { | 435 | { |
433 | struct kvm_event *event; | 436 | struct kvm_event *event; |
434 | u64 time_begin, time_diff; | 437 | u64 time_begin, time_diff; |
438 | int vcpu; | ||
439 | |||
440 | if (kvm->trace_vcpu == -1) | ||
441 | vcpu = -1; | ||
442 | else | ||
443 | vcpu = vcpu_record->vcpu_id; | ||
435 | 444 | ||
436 | event = vcpu_record->last_event; | 445 | event = vcpu_record->last_event; |
437 | time_begin = vcpu_record->start_time; | 446 | time_begin = vcpu_record->start_time; |
@@ -461,7 +470,7 @@ static bool handle_end_event(struct perf_kvm *kvm, | |||
461 | BUG_ON(timestamp < time_begin); | 470 | BUG_ON(timestamp < time_begin); |
462 | 471 | ||
463 | time_diff = timestamp - time_begin; | 472 | time_diff = timestamp - time_begin; |
464 | return update_kvm_event(event, vcpu_record->vcpu_id, time_diff); | 473 | return update_kvm_event(event, vcpu, time_diff); |
465 | } | 474 | } |
466 | 475 | ||
467 | static | 476 | static |
@@ -498,6 +507,11 @@ static bool handle_kvm_event(struct perf_kvm *kvm, | |||
498 | if (!vcpu_record) | 507 | if (!vcpu_record) |
499 | return true; | 508 | return true; |
500 | 509 | ||
510 | /* only process events for vcpus user cares about */ | ||
511 | if ((kvm->trace_vcpu != -1) && | ||
512 | (kvm->trace_vcpu != vcpu_record->vcpu_id)) | ||
513 | return true; | ||
514 | |||
501 | if (kvm->events_ops->is_begin_event(evsel, sample, &key)) | 515 | if (kvm->events_ops->is_begin_event(evsel, sample, &key)) |
502 | return handle_begin_event(kvm, vcpu_record, &key, sample->time); | 516 | return handle_begin_event(kvm, vcpu_record, &key, sample->time); |
503 | 517 | ||