diff options
author | Mark Hills <mark@pogo.org.uk> | 2012-05-11 13:31:55 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2012-05-11 15:27:36 -0400 |
commit | 7df4a691fb6645405c9d3dad8d27f8e5e3451e00 (patch) | |
tree | 670a39092dfb19b493611151a62537b6b3294b18 /sound/usb | |
parent | 0910c216f78d1097a4ac6dcc83b38809dea94160 (diff) |
ALSA: usb-audio: Fix comment
Explained by Takashi in <s5hfwbtmz0q.wl%tiwai@suse.de>
> The reason is because get_min_max*() isn't called in the place you
> created these controls, and get_min_max() would be called only for
> integer volumes later even if uninitialized. A short cut for booleans.
Signed-off-by: Mark Hills <mark@pogo.org.uk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb')
-rw-r--r-- | sound/usb/mixer_quirks.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 12125ca7167..41f4b691192 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c | |||
@@ -79,16 +79,8 @@ static int snd_create_std_mono_ctl(struct usb_mixer_interface *mixer, | |||
79 | cval->control = control; | 79 | cval->control = control; |
80 | cval->cmask = cmask; | 80 | cval->cmask = cmask; |
81 | 81 | ||
82 | /* FIXME: Do we need this? | 82 | /* get_min_max() is called only for integer volumes later, |
83 | * The following values are for compatibility with | 83 | * so provide a short-cut for booleans */ |
84 | * Ebox-44 mixer. | ||
85 | * But the corresponding ebox-44 function says: | ||
86 | * "Volume controls will override these values" | ||
87 | * | ||
88 | * These values don't have any effect at all for | ||
89 | * M-Audio FTUs. | ||
90 | * So I think, we can safely omit the range settings here. | ||
91 | */ | ||
92 | cval->min = 0; | 84 | cval->min = 0; |
93 | cval->max = 1; | 85 | cval->max = 1; |
94 | cval->res = 0; | 86 | cval->res = 0; |