aboutsummaryrefslogtreecommitdiffstats
path: root/sound/soc/codecs/ac97.c
diff options
context:
space:
mode:
authorGraham Gower <graham.gower@gmail.com>2010-03-24 20:22:12 -0400
committerMark Brown <broonie@opensource.wolfsonmicro.com>2010-03-29 16:00:37 -0400
commitfb48e3c6a4d8888aff61fbf567aadac7d206e973 (patch)
tree3fba75703831f392034271f62b73484764ffc675 /sound/soc/codecs/ac97.c
parenta8462bde78fdb77c8ede61e1af99617905a78ccf (diff)
ASoC: Fix passing platform_data to ac97 bus users and fix a leak
[The issue is an attempt to write the pdata without the AC97 device allocated when using ac97.c - also added a comment in soc-core.c for the special case for ac97. -- broonie] Signed-off-by: Graham Gower <graham.gower@gmail.com> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound/soc/codecs/ac97.c')
-rw-r--r--sound/soc/codecs/ac97.c15
1 files changed, 9 insertions, 6 deletions
diff --git a/sound/soc/codecs/ac97.c b/sound/soc/codecs/ac97.c
index a1bbe16b7f9..bcfa5327167 100644
--- a/sound/soc/codecs/ac97.c
+++ b/sound/soc/codecs/ac97.c
@@ -80,9 +80,11 @@ static int ac97_write(struct snd_soc_codec *codec, unsigned int reg,
80static int ac97_soc_probe(struct platform_device *pdev) 80static int ac97_soc_probe(struct platform_device *pdev)
81{ 81{
82 struct snd_soc_device *socdev = platform_get_drvdata(pdev); 82 struct snd_soc_device *socdev = platform_get_drvdata(pdev);
83 struct snd_soc_card *card = socdev->card;
83 struct snd_soc_codec *codec; 84 struct snd_soc_codec *codec;
84 struct snd_ac97_bus *ac97_bus; 85 struct snd_ac97_bus *ac97_bus;
85 struct snd_ac97_template ac97_template; 86 struct snd_ac97_template ac97_template;
87 int i;
86 int ret = 0; 88 int ret = 0;
87 89
88 printk(KERN_INFO "AC97 SoC Audio Codec %s\n", AC97_VERSION); 90 printk(KERN_INFO "AC97 SoC Audio Codec %s\n", AC97_VERSION);
@@ -102,12 +104,6 @@ static int ac97_soc_probe(struct platform_device *pdev)
102 INIT_LIST_HEAD(&codec->dapm_widgets); 104 INIT_LIST_HEAD(&codec->dapm_widgets);
103 INIT_LIST_HEAD(&codec->dapm_paths); 105 INIT_LIST_HEAD(&codec->dapm_paths);
104 106
105 ret = snd_soc_new_ac97_codec(codec, &soc_ac97_ops, 0);
106 if (ret < 0) {
107 printk(KERN_ERR "ASoC: failed to init gen ac97 glue\n");
108 goto err;
109 }
110
111 /* register pcms */ 107 /* register pcms */
112 ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1); 108 ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
113 if (ret < 0) 109 if (ret < 0)
@@ -123,6 +119,13 @@ static int ac97_soc_probe(struct platform_device *pdev)
123 if (ret < 0) 119 if (ret < 0)
124 goto bus_err; 120 goto bus_err;
125 121
122 for (i = 0; i < card->num_links; i++) {
123 if (card->dai_link[i].codec_dai->ac97_control) {
124 snd_ac97_dev_add_pdata(codec->ac97,
125 card->dai_link[i].cpu_dai->ac97_pdata);
126 }
127 }
128
126 return 0; 129 return 0;
127 130
128bus_err: 131bus_err: