[ALSA] Unregister device files at disconnection

Orignally proposed by Sam Revitch <sam.revitch@gmail.com>.
Unregister device files at disconnection to avoid the futher accesses.
Also, the dev_unregister callback is removed and replaced with the
combination of disconnect + free.
A new function snd_card_free_when_closed() is introduced, which is
used in USB disconnect callback.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>

1 files changed, 22 insertions, 30 deletions

diff --git a/sound/core/timer.c b/sound/core/timer.c
index 52ecbe1e9ab..7e5e562fe35 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -88,7 +88,7 @@ static DEFINE_MUTEX(register_mutex);
 static int snd_timer_free(struct snd_timer *timer);
 static int snd_timer_dev_free(struct snd_device *device);
 static int snd_timer_dev_register(struct snd_device *device);
-static int snd_timer_dev_unregister(struct snd_device *device);
+static int snd_timer_dev_disconnect(struct snd_device *device);
 
 static void snd_timer_reschedule(struct snd_timer * timer, unsigned long ticks_left);
 
@@ -773,7 +773,7 @@ int snd_timer_new(struct snd_card *card, char *id, struct snd_timer_id *tid,
         static struct snd_device_ops ops = {
                 .dev_free = snd_timer_dev_free,
                 .dev_register = snd_timer_dev_register,
-                .dev_unregister = snd_timer_dev_unregister
+                .dev_disconnect = snd_timer_dev_disconnect,
         };
 
         snd_assert(tid != NULL, return -EINVAL);
@@ -813,6 +813,21 @@ int snd_timer_new(struct snd_card *card, char *id, struct snd_timer_id *tid,
 static int snd_timer_free(struct snd_timer *timer)
 {
         snd_assert(timer != NULL, return -ENXIO);
+
+        mutex_lock(&register_mutex);
+        if (! list_empty(&timer->open_list_head)) {
+                struct list_head *p, *n;
+                struct snd_timer_instance *ti;
+                snd_printk(KERN_WARNING "timer %p is busy?\n", timer);
+                list_for_each_safe(p, n, &timer->open_list_head) {
+                        list_del_init(p);
+                        ti = list_entry(p, struct snd_timer_instance, open_list);
+                        ti->timer = NULL;
+                }
+        }
+        list_del(&timer->device_list);
+        mutex_unlock(&register_mutex);
+
         if (timer->private_free)
                 timer->private_free(timer);
         kfree(timer);
@@ -867,30 +882,13 @@ static int snd_timer_dev_register(struct snd_device *dev)
         return 0;
 }
 
-static int snd_timer_unregister(struct snd_timer *timer)
+static int snd_timer_dev_disconnect(struct snd_device *device)
 {
-        struct list_head *p, *n;
-        struct snd_timer_instance *ti;
-
-        snd_assert(timer != NULL, return -ENXIO);
+        struct snd_timer *timer = device->device_data;
         mutex_lock(&register_mutex);
-        if (! list_empty(&timer->open_list_head)) {
-                snd_printk(KERN_WARNING "timer 0x%lx is busy?\n", (long)timer);
-                list_for_each_safe(p, n, &timer->open_list_head) {
-                        list_del_init(p);
-                        ti = list_entry(p, struct snd_timer_instance, open_list);
-                        ti->timer = NULL;
-                }
-        }
-        list_del(&timer->device_list);
+        list_del_init(&timer->device_list);
         mutex_unlock(&register_mutex);
-        return snd_timer_free(timer);
-}
-
-static int snd_timer_dev_unregister(struct snd_device *device)
-{
-        struct snd_timer *timer = device->device_data;
-        return snd_timer_unregister(timer);
+        return 0;
 }
 
 void snd_timer_notify(struct snd_timer *timer, int event, struct timespec *tstamp)
@@ -955,11 +953,6 @@ int snd_timer_global_register(struct snd_timer *timer)
         return snd_timer_dev_register(&dev);
 }
 
-int snd_timer_global_unregister(struct snd_timer *timer)
-{
-        return snd_timer_unregister(timer);
-}
-
 /*
  *  System timer
  */
@@ -1982,7 +1975,7 @@ static void __exit alsa_timer_exit(void)
         /* unregister the system timer */
         list_for_each_safe(p, n, &snd_timer_list) {
                 struct snd_timer *timer = list_entry(p, struct snd_timer, device_list);
-                snd_timer_unregister(timer);
+                snd_timer_free(timer);
         }
         snd_timer_proc_done();
 #ifdef SNDRV_OSS_INFO_DEV_TIMERS
@@ -2005,5 +1998,4 @@ EXPORT_SYMBOL(snd_timer_notify);
 EXPORT_SYMBOL(snd_timer_global_new);
 EXPORT_SYMBOL(snd_timer_global_free);
 EXPORT_SYMBOL(snd_timer_global_register);
-EXPORT_SYMBOL(snd_timer_global_unregister);
 EXPORT_SYMBOL(snd_timer_interrupt);