diff options
author | Andy Whitcroft <apw@canonical.com> | 2012-03-23 18:02:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-03-23 19:58:36 -0400 |
commit | e45bab8ebfee65ba89b228c1e7c64a6cb0812124 (patch) | |
tree | fe61be22fa4438d5bd132712e730daca9cbf341b /scripts | |
parent | b9df76ac76da351cd4f6ba52369e9a64e9ab686d (diff) |
checkpatch: handle string concatenation in simple #defines
Adjacent strings indicate concatentation, therefore look at identifiers
directly adjacent to literal strings as strings too. This allows us to
better detect the form below and accept it as a simple constant:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 95ba30a24dc..01a65988a05 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -2894,6 +2894,12 @@ sub process { | |||
2894 | { | 2894 | { |
2895 | } | 2895 | } |
2896 | 2896 | ||
2897 | # Flatten any obvious string concatentation. | ||
2898 | while ($dstat =~ s/("X*")\s*$Ident/$1/ || | ||
2899 | $dstat =~ s/$Ident\s*("X*")/$1/) | ||
2900 | { | ||
2901 | } | ||
2902 | |||
2897 | my $exceptions = qr{ | 2903 | my $exceptions = qr{ |
2898 | $Declare| | 2904 | $Declare| |
2899 | module_param_named| | 2905 | module_param_named| |