diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-31 21:10:18 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-31 21:10:18 -0400 |
| commit | 08615d7d85e5aa02c05bf6c4dde87d940e7f85f6 (patch) | |
| tree | 18906149d313d25914160aca21cedf54b3a7e818 /scripts/checkpatch.pl | |
| parent | 9fdadb2cbaf4b482dfd6086e8bd3d2db071a1702 (diff) | |
| parent | 0a4dd35c67b144d8ef9432120105f1aab9293ee9 (diff) | |
Merge branch 'akpm' (Andrew's patch-bomb)
Merge misc patches from Andrew Morton:
- the "misc" tree - stuff from all over the map
- checkpatch updates
- fatfs
- kmod changes
- procfs
- cpumask
- UML
- kexec
- mqueue
- rapidio
- pidns
- some checkpoint-restore feature work. Reluctantly. Most of it
delayed a release. I'm still rather worried that we don't have a
clear roadmap to completion for this work.
* emailed from Andrew Morton <akpm@linux-foundation.org>: (78 patches)
kconfig: update compression algorithm info
c/r: prctl: add ability to set new mm_struct::exe_file
c/r: prctl: extend PR_SET_MM to set up more mm_struct entries
c/r: procfs: add arg_start/end, env_start/end and exit_code members to /proc/$pid/stat
syscalls, x86: add __NR_kcmp syscall
fs, proc: introduce /proc/<pid>/task/<tid>/children entry
sysctl: make kernel.ns_last_pid control dependent on CHECKPOINT_RESTORE
aio/vfs: cleanup of rw_copy_check_uvector() and compat_rw_copy_check_uvector()
eventfd: change int to __u64 in eventfd_signal()
fs/nls: add Apple NLS
pidns: make killed children autoreap
pidns: use task_active_pid_ns in do_notify_parent
rapidio/tsi721: add DMA engine support
rapidio: add DMA engine support for RIO data transfers
ipc/mqueue: add rbtree node caching support
tools/selftests: add mq_perf_tests
ipc/mqueue: strengthen checks on mqueue creation
ipc/mqueue: correct mq_attr_ok test
ipc/mqueue: improve performance of send/recv
selftests: add mq_open_tests
...
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index faea0ec612b..e5bd60ff48e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -2382,6 +2382,19 @@ sub process { | |||
| 2382 | } | 2382 | } |
| 2383 | } | 2383 | } |
| 2384 | 2384 | ||
| 2385 | if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) { | ||
| 2386 | my $orig = $1; | ||
| 2387 | my $level = lc($orig); | ||
| 2388 | $level = "warn" if ($level eq "warning"); | ||
| 2389 | WARN("PREFER_PR_LEVEL", | ||
| 2390 | "Prefer pr_$level(... to printk(KERN_$1, ...\n" . $herecurr); | ||
| 2391 | } | ||
| 2392 | |||
| 2393 | if ($line =~ /\bpr_warning\s*\(/) { | ||
| 2394 | WARN("PREFER_PR_LEVEL", | ||
| 2395 | "Prefer pr_warn(... to pr_warning(...\n" . $herecurr); | ||
| 2396 | } | ||
| 2397 | |||
| 2385 | # function brace can't be on same line, except for #defines of do while, | 2398 | # function brace can't be on same line, except for #defines of do while, |
| 2386 | # or if closed on same line | 2399 | # or if closed on same line |
| 2387 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and | 2400 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and |
| @@ -2448,6 +2461,13 @@ sub process { | |||
| 2448 | "space prohibited between function name and open parenthesis '('\n" . $herecurr); | 2461 | "space prohibited between function name and open parenthesis '('\n" . $herecurr); |
| 2449 | } | 2462 | } |
| 2450 | } | 2463 | } |
| 2464 | |||
| 2465 | # check for whitespace before a non-naked semicolon | ||
| 2466 | if ($line =~ /^\+.*\S\s+;/) { | ||
| 2467 | CHK("SPACING", | ||
| 2468 | "space prohibited before semicolon\n" . $herecurr); | ||
| 2469 | } | ||
| 2470 | |||
| 2451 | # Check operator spacing. | 2471 | # Check operator spacing. |
| 2452 | if (!($line=~/\#\s*include/)) { | 2472 | if (!($line=~/\#\s*include/)) { |
| 2453 | my $ops = qr{ | 2473 | my $ops = qr{ |
