diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2012-11-15 22:03:01 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-11-18 20:32:45 -0500 |
commit | cff109768b2d9c03095848f4cd4b0754117262aa (patch) | |
tree | 353b3a45a3520d12171182862ecc328958be3c5e /net/sysctl_net.c | |
parent | dfc47ef8639facd77210e74be831943c2fdd9c74 (diff) |
net: Update the per network namespace sysctls to be available to the network namespace owner
- Allow anyone with CAP_NET_ADMIN rights in the user namespace of the
the netowrk namespace to change sysctls.
- Allow anyone the uid of the user namespace root the same
permissions over the network namespace sysctls as the global root.
- Allow anyone with gid of the user namespace root group the same
permissions over the network namespace sysctl as the global root group.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sysctl_net.c')
-rw-r--r-- | net/sysctl_net.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/net/sysctl_net.c b/net/sysctl_net.c index e98f3932bdf..6410436aa49 100644 --- a/net/sysctl_net.c +++ b/net/sysctl_net.c | |||
@@ -41,11 +41,21 @@ static int is_seen(struct ctl_table_set *set) | |||
41 | static int net_ctl_permissions(struct ctl_table_header *head, | 41 | static int net_ctl_permissions(struct ctl_table_header *head, |
42 | struct ctl_table *table) | 42 | struct ctl_table *table) |
43 | { | 43 | { |
44 | struct net *net = container_of(head->set, struct net, sysctls); | ||
45 | kuid_t root_uid = make_kuid(net->user_ns, 0); | ||
46 | kgid_t root_gid = make_kgid(net->user_ns, 0); | ||
47 | |||
44 | /* Allow network administrator to have same access as root. */ | 48 | /* Allow network administrator to have same access as root. */ |
45 | if (capable(CAP_NET_ADMIN)) { | 49 | if (ns_capable(net->user_ns, CAP_NET_ADMIN) || |
50 | uid_eq(root_uid, current_uid())) { | ||
46 | int mode = (table->mode >> 6) & 7; | 51 | int mode = (table->mode >> 6) & 7; |
47 | return (mode << 6) | (mode << 3) | mode; | 52 | return (mode << 6) | (mode << 3) | mode; |
48 | } | 53 | } |
54 | /* Allow netns root group to have the same assess as the root group */ | ||
55 | if (gid_eq(root_gid, current_gid())) { | ||
56 | int mode = (table->mode >> 3) & 7; | ||
57 | return (mode << 3) | (mode << 3) | mode; | ||
58 | } | ||
49 | return table->mode; | 59 | return table->mode; |
50 | } | 60 | } |
51 | 61 | ||