diff options
author | Lennert Buytenhek <buytenh@wantstofly.org> | 2009-03-20 05:52:09 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-21 22:06:54 -0400 |
commit | e84665c9cb4db963393fafad6fefe5efdd7e4a09 (patch) | |
tree | 545c4a2a63a77b853e3f34609d86b346fe61baf4 /net/dsa/tag_trailer.c | |
parent | 076d3e10a54caa2c148de5732c126c7a31381d48 (diff) |
dsa: add switch chip cascading support
The initial version of the DSA driver only supported a single switch
chip per network interface, while DSA-capable switch chips can be
interconnected to form a tree of switch chips. This patch adds support
for multiple switch chips on a network interface.
An example topology for a 16-port device with an embedded CPU is as
follows:
+-----+ +--------+ +--------+
| |eth0 10| switch |9 10| switch |
| CPU +----------+ +-------+ |
| | | chip 0 | | chip 1 |
+-----+ +---++---+ +---++---+
|| ||
|| ||
||1000baseT ||1000baseT
||ports 1-8 ||ports 9-16
This requires a couple of interdependent changes in the DSA layer:
- The dsa platform driver data needs to be extended: there is still
only one netdevice per DSA driver instance (eth0 in the example
above), but each of the switch chips in the tree needs its own
mii_bus device pointer, MII management bus address, and port name
array. (include/net/dsa.h) The existing in-tree dsa users need
some small changes to deal with this. (arch/arm)
- The DSA and Ethertype DSA tagging modules need to be extended to
use the DSA device ID field on receive and demultiplex the packet
accordingly, and fill in the DSA device ID field on transmit
according to which switch chip the packet is heading to.
(net/dsa/tag_{dsa,edsa}.c)
- The concept of "CPU port", which is the switch chip port that the
CPU is connected to (port 10 on switch chip 0 in the example), needs
to be extended with the concept of "upstream port", which is the
port on the switch chip that will bring us one hop closer to the CPU
(port 10 for both switch chips in the example above).
- The dsa platform data needs to specify which ports on which switch
chips are links to other switch chips, so that we can enable DSA
tagging mode on them. (For inter-switch links, we always use
non-EtherType DSA tagging, since it has lower overhead. The CPU
link uses dsa or edsa tagging depending on what the 'root' switch
chip supports.) This is done by specifying "dsa" for the given
port in the port array.
- The dsa platform data needs to be extended with information on via
which port to reach any given switch chip from any given switch chip.
This info is specified via the per-switch chip data struct ->rtable[]
array, which gives the nexthop ports for each of the other switches
in the tree.
For the example topology above, the dsa platform data would look
something like this:
static struct dsa_chip_data sw[2] = {
{
.mii_bus = &foo,
.sw_addr = 1,
.port_names[0] = "p1",
.port_names[1] = "p2",
.port_names[2] = "p3",
.port_names[3] = "p4",
.port_names[4] = "p5",
.port_names[5] = "p6",
.port_names[6] = "p7",
.port_names[7] = "p8",
.port_names[9] = "dsa",
.port_names[10] = "cpu",
.rtable = (s8 []){ -1, 9, },
}, {
.mii_bus = &foo,
.sw_addr = 2,
.port_names[0] = "p9",
.port_names[1] = "p10",
.port_names[2] = "p11",
.port_names[3] = "p12",
.port_names[4] = "p13",
.port_names[5] = "p14",
.port_names[6] = "p15",
.port_names[7] = "p16",
.port_names[10] = "dsa",
.rtable = (s8 []){ 10, -1, },
},
},
static struct dsa_platform_data pd = {
.netdev = &foo,
.nr_switches = 2,
.sw = sw,
};
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Tested-by: Gary Thomas <gary@mlbassoc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_trailer.c')
-rw-r--r-- | net/dsa/tag_trailer.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/net/dsa/tag_trailer.c b/net/dsa/tag_trailer.c index a6d959da678..1c3e30c38b8 100644 --- a/net/dsa/tag_trailer.c +++ b/net/dsa/tag_trailer.c | |||
@@ -1,6 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * net/dsa/tag_trailer.c - Trailer tag format handling | 2 | * net/dsa/tag_trailer.c - Trailer tag format handling |
3 | * Copyright (c) 2008 Marvell Semiconductor | 3 | * Copyright (c) 2008-2009 Marvell Semiconductor |
4 | * | 4 | * |
5 | * This program is free software; you can redistribute it and/or modify | 5 | * This program is free software; you can redistribute it and/or modify |
6 | * it under the terms of the GNU General Public License as published by | 6 | * it under the terms of the GNU General Public License as published by |
@@ -59,7 +59,7 @@ int trailer_xmit(struct sk_buff *skb, struct net_device *dev) | |||
59 | 59 | ||
60 | nskb->protocol = htons(ETH_P_TRAILER); | 60 | nskb->protocol = htons(ETH_P_TRAILER); |
61 | 61 | ||
62 | nskb->dev = p->parent->master_netdev; | 62 | nskb->dev = p->parent->dst->master_netdev; |
63 | dev_queue_xmit(nskb); | 63 | dev_queue_xmit(nskb); |
64 | 64 | ||
65 | return NETDEV_TX_OK; | 65 | return NETDEV_TX_OK; |
@@ -68,12 +68,14 @@ int trailer_xmit(struct sk_buff *skb, struct net_device *dev) | |||
68 | static int trailer_rcv(struct sk_buff *skb, struct net_device *dev, | 68 | static int trailer_rcv(struct sk_buff *skb, struct net_device *dev, |
69 | struct packet_type *pt, struct net_device *orig_dev) | 69 | struct packet_type *pt, struct net_device *orig_dev) |
70 | { | 70 | { |
71 | struct dsa_switch *ds = dev->dsa_ptr; | 71 | struct dsa_switch_tree *dst = dev->dsa_ptr; |
72 | struct dsa_switch *ds; | ||
72 | u8 *trailer; | 73 | u8 *trailer; |
73 | int source_port; | 74 | int source_port; |
74 | 75 | ||
75 | if (unlikely(ds == NULL)) | 76 | if (unlikely(dst == NULL)) |
76 | goto out_drop; | 77 | goto out_drop; |
78 | ds = dst->ds[0]; | ||
77 | 79 | ||
78 | skb = skb_unshare(skb, GFP_ATOMIC); | 80 | skb = skb_unshare(skb, GFP_ATOMIC); |
79 | if (skb == NULL) | 81 | if (skb == NULL) |