diff options
author | Konstantin Khlebnikov <khlebnikov@openvz.org> | 2012-10-08 19:28:46 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-09 03:22:17 -0400 |
commit | 0b173bc4daa8f8ec03a85abf5e47b23502ff80af (patch) | |
tree | 173d0523555e02a077e0af4563bd4cadea46cb23 /mm | |
parent | 4b6e1e37026ec7dae9b23d78ffcebdd5ddb1bfa1 (diff) |
mm: kill vma flag VM_CAN_NONLINEAR
Move actual pte filling for non-linear file mappings into the new special
vma operation: ->remap_pages().
Filesystems must implement this method to get non-linear mapping support,
if it uses filemap_fault() then generic_file_remap_pages() can be used.
Now device drivers can implement this method and obtain nonlinear vma support.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Carsten Otte <cotte@de.ibm.com>
Cc: Chris Metcalf <cmetcalf@tilera.com> #arch/tile
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Eric Paris <eparis@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Morris <james.l.morris@oracle.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Matt Helsley <matthltc@us.ibm.com>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Robert Richter <robert.richter@amd.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Venkatesh Pallipadi <venki@google.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/filemap.c | 2 | ||||
-rw-r--r-- | mm/filemap_xip.c | 3 | ||||
-rw-r--r-- | mm/fremap.c | 14 | ||||
-rw-r--r-- | mm/mmap.c | 3 | ||||
-rw-r--r-- | mm/nommu.c | 8 | ||||
-rw-r--r-- | mm/shmem.c | 3 |
6 files changed, 21 insertions, 12 deletions
diff --git a/mm/filemap.c b/mm/filemap.c index 384344575c3..a9827b42556 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
@@ -1737,6 +1737,7 @@ EXPORT_SYMBOL(filemap_page_mkwrite); | |||
1737 | const struct vm_operations_struct generic_file_vm_ops = { | 1737 | const struct vm_operations_struct generic_file_vm_ops = { |
1738 | .fault = filemap_fault, | 1738 | .fault = filemap_fault, |
1739 | .page_mkwrite = filemap_page_mkwrite, | 1739 | .page_mkwrite = filemap_page_mkwrite, |
1740 | .remap_pages = generic_file_remap_pages, | ||
1740 | }; | 1741 | }; |
1741 | 1742 | ||
1742 | /* This is used for a general mmap of a disk file */ | 1743 | /* This is used for a general mmap of a disk file */ |
@@ -1749,7 +1750,6 @@ int generic_file_mmap(struct file * file, struct vm_area_struct * vma) | |||
1749 | return -ENOEXEC; | 1750 | return -ENOEXEC; |
1750 | file_accessed(file); | 1751 | file_accessed(file); |
1751 | vma->vm_ops = &generic_file_vm_ops; | 1752 | vma->vm_ops = &generic_file_vm_ops; |
1752 | vma->vm_flags |= VM_CAN_NONLINEAR; | ||
1753 | return 0; | 1753 | return 0; |
1754 | } | 1754 | } |
1755 | 1755 | ||
diff --git a/mm/filemap_xip.c b/mm/filemap_xip.c index 13e013b1270..91750227a19 100644 --- a/mm/filemap_xip.c +++ b/mm/filemap_xip.c | |||
@@ -305,6 +305,7 @@ out: | |||
305 | static const struct vm_operations_struct xip_file_vm_ops = { | 305 | static const struct vm_operations_struct xip_file_vm_ops = { |
306 | .fault = xip_file_fault, | 306 | .fault = xip_file_fault, |
307 | .page_mkwrite = filemap_page_mkwrite, | 307 | .page_mkwrite = filemap_page_mkwrite, |
308 | .remap_pages = generic_file_remap_pages, | ||
308 | }; | 309 | }; |
309 | 310 | ||
310 | int xip_file_mmap(struct file * file, struct vm_area_struct * vma) | 311 | int xip_file_mmap(struct file * file, struct vm_area_struct * vma) |
@@ -313,7 +314,7 @@ int xip_file_mmap(struct file * file, struct vm_area_struct * vma) | |||
313 | 314 | ||
314 | file_accessed(file); | 315 | file_accessed(file); |
315 | vma->vm_ops = &xip_file_vm_ops; | 316 | vma->vm_ops = &xip_file_vm_ops; |
316 | vma->vm_flags |= VM_CAN_NONLINEAR | VM_MIXEDMAP; | 317 | vma->vm_flags |= VM_MIXEDMAP; |
317 | return 0; | 318 | return 0; |
318 | } | 319 | } |
319 | EXPORT_SYMBOL_GPL(xip_file_mmap); | 320 | EXPORT_SYMBOL_GPL(xip_file_mmap); |
diff --git a/mm/fremap.c b/mm/fremap.c index 048659c0c03..3d731a49878 100644 --- a/mm/fremap.c +++ b/mm/fremap.c | |||
@@ -5,6 +5,7 @@ | |||
5 | * | 5 | * |
6 | * started by Ingo Molnar, Copyright (C) 2002, 2003 | 6 | * started by Ingo Molnar, Copyright (C) 2002, 2003 |
7 | */ | 7 | */ |
8 | #include <linux/export.h> | ||
8 | #include <linux/backing-dev.h> | 9 | #include <linux/backing-dev.h> |
9 | #include <linux/mm.h> | 10 | #include <linux/mm.h> |
10 | #include <linux/swap.h> | 11 | #include <linux/swap.h> |
@@ -80,9 +81,10 @@ out: | |||
80 | return err; | 81 | return err; |
81 | } | 82 | } |
82 | 83 | ||
83 | static int populate_range(struct mm_struct *mm, struct vm_area_struct *vma, | 84 | int generic_file_remap_pages(struct vm_area_struct *vma, unsigned long addr, |
84 | unsigned long addr, unsigned long size, pgoff_t pgoff) | 85 | unsigned long size, pgoff_t pgoff) |
85 | { | 86 | { |
87 | struct mm_struct *mm = vma->vm_mm; | ||
86 | int err; | 88 | int err; |
87 | 89 | ||
88 | do { | 90 | do { |
@@ -95,9 +97,9 @@ static int populate_range(struct mm_struct *mm, struct vm_area_struct *vma, | |||
95 | pgoff++; | 97 | pgoff++; |
96 | } while (size); | 98 | } while (size); |
97 | 99 | ||
98 | return 0; | 100 | return 0; |
99 | |||
100 | } | 101 | } |
102 | EXPORT_SYMBOL(generic_file_remap_pages); | ||
101 | 103 | ||
102 | /** | 104 | /** |
103 | * sys_remap_file_pages - remap arbitrary pages of an existing VM_SHARED vma | 105 | * sys_remap_file_pages - remap arbitrary pages of an existing VM_SHARED vma |
@@ -167,7 +169,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, | |||
167 | if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR)) | 169 | if (vma->vm_private_data && !(vma->vm_flags & VM_NONLINEAR)) |
168 | goto out; | 170 | goto out; |
169 | 171 | ||
170 | if (!(vma->vm_flags & VM_CAN_NONLINEAR)) | 172 | if (!vma->vm_ops->remap_pages) |
171 | goto out; | 173 | goto out; |
172 | 174 | ||
173 | if (start < vma->vm_start || start + size > vma->vm_end) | 175 | if (start < vma->vm_start || start + size > vma->vm_end) |
@@ -228,7 +230,7 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, | |||
228 | } | 230 | } |
229 | 231 | ||
230 | mmu_notifier_invalidate_range_start(mm, start, start + size); | 232 | mmu_notifier_invalidate_range_start(mm, start, start + size); |
231 | err = populate_range(mm, vma, start, size, pgoff); | 233 | err = vma->vm_ops->remap_pages(vma, start, size, pgoff); |
232 | mmu_notifier_invalidate_range_end(mm, start, start + size); | 234 | mmu_notifier_invalidate_range_end(mm, start, start + size); |
233 | if (!err && !(flags & MAP_NONBLOCK)) { | 235 | if (!err && !(flags & MAP_NONBLOCK)) { |
234 | if (vma->vm_flags & VM_LOCKED) { | 236 | if (vma->vm_flags & VM_LOCKED) { |
@@ -669,8 +669,7 @@ again: remove_next = 1 + (end > next->vm_end); | |||
669 | static inline int is_mergeable_vma(struct vm_area_struct *vma, | 669 | static inline int is_mergeable_vma(struct vm_area_struct *vma, |
670 | struct file *file, unsigned long vm_flags) | 670 | struct file *file, unsigned long vm_flags) |
671 | { | 671 | { |
672 | /* VM_CAN_NONLINEAR may get set later by f_op->mmap() */ | 672 | if (vma->vm_flags ^ vm_flags) |
673 | if ((vma->vm_flags ^ vm_flags) & ~VM_CAN_NONLINEAR) | ||
674 | return 0; | 673 | return 0; |
675 | if (vma->vm_file != file) | 674 | if (vma->vm_file != file) |
676 | return 0; | 675 | return 0; |
diff --git a/mm/nommu.c b/mm/nommu.c index dee2ff89fd5..98318dcff74 100644 --- a/mm/nommu.c +++ b/mm/nommu.c | |||
@@ -1961,6 +1961,14 @@ int filemap_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
1961 | } | 1961 | } |
1962 | EXPORT_SYMBOL(filemap_fault); | 1962 | EXPORT_SYMBOL(filemap_fault); |
1963 | 1963 | ||
1964 | int generic_file_remap_pages(struct vm_area_struct *vma, unsigned long addr, | ||
1965 | unsigned long size, pgoff_t pgoff) | ||
1966 | { | ||
1967 | BUG(); | ||
1968 | return 0; | ||
1969 | } | ||
1970 | EXPORT_SYMBOL(generic_file_remap_pages); | ||
1971 | |||
1964 | static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm, | 1972 | static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm, |
1965 | unsigned long addr, void *buf, int len, int write) | 1973 | unsigned long addr, void *buf, int len, int write) |
1966 | { | 1974 | { |
diff --git a/mm/shmem.c b/mm/shmem.c index d3752110c8c..cc12072f878 100644 --- a/mm/shmem.c +++ b/mm/shmem.c | |||
@@ -1339,7 +1339,6 @@ static int shmem_mmap(struct file *file, struct vm_area_struct *vma) | |||
1339 | { | 1339 | { |
1340 | file_accessed(file); | 1340 | file_accessed(file); |
1341 | vma->vm_ops = &shmem_vm_ops; | 1341 | vma->vm_ops = &shmem_vm_ops; |
1342 | vma->vm_flags |= VM_CAN_NONLINEAR; | ||
1343 | return 0; | 1342 | return 0; |
1344 | } | 1343 | } |
1345 | 1344 | ||
@@ -2643,6 +2642,7 @@ static const struct vm_operations_struct shmem_vm_ops = { | |||
2643 | .set_policy = shmem_set_policy, | 2642 | .set_policy = shmem_set_policy, |
2644 | .get_policy = shmem_get_policy, | 2643 | .get_policy = shmem_get_policy, |
2645 | #endif | 2644 | #endif |
2645 | .remap_pages = generic_file_remap_pages, | ||
2646 | }; | 2646 | }; |
2647 | 2647 | ||
2648 | static struct dentry *shmem_mount(struct file_system_type *fs_type, | 2648 | static struct dentry *shmem_mount(struct file_system_type *fs_type, |
@@ -2836,7 +2836,6 @@ int shmem_zero_setup(struct vm_area_struct *vma) | |||
2836 | fput(vma->vm_file); | 2836 | fput(vma->vm_file); |
2837 | vma->vm_file = file; | 2837 | vma->vm_file = file; |
2838 | vma->vm_ops = &shmem_vm_ops; | 2838 | vma->vm_ops = &shmem_vm_ops; |
2839 | vma->vm_flags |= VM_CAN_NONLINEAR; | ||
2840 | return 0; | 2839 | return 0; |
2841 | } | 2840 | } |
2842 | 2841 | ||